mirrors/gecko-dev
1
0
Fork 1
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-10-28 23:15:54 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Bug 1969980 - part 1 - remove password saved and username updated snackbars r=android-reviewers,twhite,android-l10n-reviewers,delphine

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D252232
This commit is contained in:
gela 2025-07-08 20:19:27 +00:00 committed by gmalekpour@mozilla.com
parent 032153cfa1
commit 00b10518da
6 changed files with 2 additions and 33 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
mobile/android/android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/PromptFeature.kt
View file

@ -953,7 +953,6 @@ class PromptFeature private constructor(
// For v1, we only handle a single login and drop all others on the floor
entry = promptRequest.logins[0],
icon = session.content.icon,
onShowSnackbarAfterLoginChange = onSaveLogin,
)
}

6
mobile/android/android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/dialog/SaveLoginDialogFragment.kt
View file

@ -90,7 +90,6 @@ internal class SaveLoginDialogFragment : PromptDialogFragment() {
private var loginValid = false
private var validateStateUpdate: Job? = null
private var onShowSnackbarAfterLoginChange: (Boolean) -> Unit = { _ -> }
private var isUpdate = false
override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
@ -184,8 +183,6 @@ internal class SaveLoginDialogFragment : PromptDialogFragment() {
)
emitSaveFact()
dismiss()
onShowSnackbarAfterLoginChange.invoke(isUpdate)
}
@VisibleForTesting
@ -404,7 +401,6 @@ internal class SaveLoginDialogFragment : PromptDialogFragment() {
* @param hint a value that helps to determine the appropriate prompting behavior.
* @param entry represents login information on a given domain.
* @param icon represents the icon to be displayed on the dialog.
* @param onShowSnackbarAfterLoginChange callback to display a snackbar after save/update.
* */
fun newInstance(
sessionId: String,
@ -413,7 +409,6 @@ internal class SaveLoginDialogFragment : PromptDialogFragment() {
hint: Int,
entry: LoginEntry,
icon: Bitmap? = null,
onShowSnackbarAfterLoginChange: (Boolean) -> Unit,
): SaveLoginDialogFragment {
val fragment = SaveLoginDialogFragment()
val arguments = fragment.arguments ?: Bundle()
@ -432,7 +427,6 @@ internal class SaveLoginDialogFragment : PromptDialogFragment() {
}
fragment.arguments = arguments
fragment.onShowSnackbarAfterLoginChange = onShowSnackbarAfterLoginChange
return fragment
}
}

4
mobile/android/android-components/components/feature/prompts/src/main/res/values/strings.xml
View file

@ -114,11 +114,11 @@
<!-- Pressing this will dismiss the suggested strong password dialog -->
<string name="mozac_feature_prompts_suggest_strong_password_dismiss">Not now</string>
<!-- Title for showing the suggest strong password saved confirmation snackbar -->
<string name="mozac_feature_prompts_suggest_strong_password_saved_snackbar_title">Password saved</string>
<string name="mozac_feature_prompts_suggest_strong_password_saved_snackbar_title" tools:ignore="UnusedResources" moz:removedIn="142">Password saved</string>
<!-- Title for showing the suggest strong password updated confirmation snackbar -->
<string name="mozac_feature_prompts_suggest_strong_password_updated_snackbar_title">Password updated</string>
<!-- Title for showing the username updated confirmation snackbar -->
<string name="mozac_feature_prompt_login_snackbar_username_updated">Username updated</string>
<string name="mozac_feature_prompt_login_snackbar_username_updated" tools:ignore="UnusedResources" moz:removedIn="142">Username updated</string>
<!-- Strings shown in a dialog that appear when users try to refresh a certain kind of webpages -->
<string name="mozac_feature_prompt_repost_title">Resend data to this site?</string>

1
mobile/android/android-components/components/feature/prompts/src/test/java/mozilla/components/feature/prompts/PromptFeatureTest.kt
View file

@ -2819,7 +2819,6 @@ class PromptFeatureTest {
username = "username",
password = "password",
),
onShowSnackbarAfterLoginChange = { _ -> },
),
)
feature.activePrompt = WeakReference(fragment)

2
mobile/android/android-components/components/feature/prompts/src/test/java/mozilla/components/feature/prompts/dialog/SaveLoginDialogFragmentTest.kt
View file

@ -49,7 +49,6 @@ class SaveLoginDialogFragmentTest : TestCase() {
hint = hint,
entry = entry,
icon = icon,
onShowSnackbarAfterLoginChange = { _ -> },
),
)
doReturn(appCompatContext).`when`(fragment).requireContext()
@ -96,7 +95,6 @@ class SaveLoginDialogFragmentTest : TestCase() {
hint = hint,
entry = entry,
icon = icon,
onShowSnackbarAfterLoginChange = { _ -> },
),
)
val defaultIconResource = iconsR.drawable.mozac_ic_globe_24

21
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt
View file

@ -1038,11 +1038,6 @@ abstract class BaseBrowserFragment :
password = password,
)
},
onSaveLogin = { isUpdate ->
showSnackbarAfterLoginChange(
isUpdate,
)
},
passwordGeneratorColorsProvider = passwordGeneratorColorsProvider,
hideUpdateFragmentAfterSavingGeneratedPassword = { username, password ->
hideUpdateFragmentAfterSavingGeneratedPassword(
@ -1437,22 +1432,6 @@ abstract class BaseBrowserFragment :
}
}
/**
* Show a [Snackbar] when credentials are saved or updated.
*/
private fun showSnackbarAfterLoginChange(isUpdate: Boolean) {
val snackbarText = if (isUpdate) {
R.string.mozac_feature_prompt_login_snackbar_username_updated
} else {
R.string.mozac_feature_prompts_suggest_strong_password_saved_snackbar_title
}
ContextMenuSnackbarDelegate().show(
snackBarParentView = binding.dynamicSnackbarContainer,
text = snackbarText,
duration = LENGTH_LONG,
)
}
/**
* Shows a biometric prompt and fallback to prompting for the password.
*/