mirrors/gecko-dev
1
0
Fork 1
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-11-10 05:08:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Bug 1813487 - Add barriers on ExportNameVector type r=sfink

Browse source 
This makes it so you can just call trace() on it. The barriers should not end
up being triggered anyway.

Differential Revision: https://phabricator.services.mozilla.com/D168227
This commit is contained in:
Jon Coppeard 2023-02-01 09:06:13 +00:00
parent a0e9013302
commit 11822099b1
2 changed files with 3 additions and 8 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

5
js/src/builtin/ModuleObject.cpp
View file

@ -594,10 +594,7 @@ void ModuleNamespaceObject::ProxyHandler::trace(JSTracer* trc,
auto& self = proxy->as<ModuleNamespaceObject>(); auto& self = proxy->as<ModuleNamespaceObject>();
if (self.hasExports()) { if (self.hasExports()) {
for (JSAtom*& name : self.mutableExports()) { self.mutableExports().trace(trc);
TraceManuallyBarrieredEdge(trc, &name,
"ModuleNamespaceObject export name");
}
} }
if (self.hasBindings()) { if (self.hasBindings()) {

6
js/src/builtin/ModuleObject.h
View file

@ -188,10 +188,8 @@ class IndirectBindingMap {
// Vector of atoms representing the names exported from a module namespace. // Vector of atoms representing the names exported from a module namespace.
// //
// Barriers are not required because this is either used as a root, or a // This is used both on the stack and in the heap.
// non-mutable field of ModuleNamespaceObject. Don't change this without adding using ExportNameVector = GCVector<HeapPtr<JSAtom*>, 0, SystemAllocPolicy>;
// barriers.
using ExportNameVector = GCVector<JSAtom*, 0, SystemAllocPolicy>;
class ModuleNamespaceObject : public ProxyObject { class ModuleNamespaceObject : public ProxyObject {
public: public: