mirrors/gecko-dev
1
0
Fork 1
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-11-03 17:58:55 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Bug 1954751: SelectionManager::SelectionRangeChanged: Fail gracefully if the range's closest common ancestor is null. r=eeejay

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D242113
This commit is contained in:
James Teh 2025-03-24 22:30:25 +00:00
parent b999769951
commit 213a09599f
1 changed files with 5 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

5
accessible/base/SelectionManager.cpp
View file

@ -219,6 +219,11 @@ bool SelectionManager::SelectionRangeChanged(SelectionType aType,
dom::Document* doc = start->OwnerDoc(); dom::Document* doc = start->OwnerDoc();
MOZ_ASSERT(doc); MOZ_ASSERT(doc);
nsINode* node = aRange.GetClosestCommonInclusiveAncestor(); nsINode* node = aRange.GetClosestCommonInclusiveAncestor();
if (!node) {
// Bug 1954751: This can happen when a Selection is being garbage collected,
// but it's unclear exactly what other circumstances are involved.
return false;
}
HyperTextAccessible* acc = nsAccUtils::GetTextContainer(node); HyperTextAccessible* acc = nsAccUtils::GetTextContainer(node);
if (!acc) { if (!acc) {
return true; return true;