Commit graph

106 commits

Author SHA1 Message Date
Paolo Amadini
68c4637db8 Bug 1362207 - Remove the dropdown menu from the footer of the Downloads Panel. r=mak
MozReview-Commit-ID: CFrHklbB7TK

--HG--
extra : rebase_source : 307502b673bd06e8beb57866a69661ca1784d4f6
2017-05-05 15:37:00 +01:00
Yiren Wang
5f88f7294a Bug 1264206 - Enable ESLint for browser/components/downloads and fix the existing issues. r=Standard8
MozReview-Commit-ID: HDjTxdFCnRp
2017-04-03 10:25:05 +01:00
David Rajchenbach-Teller
4e3f201503 Bug 1087255 - Convert Download JS clients of RemovePage(s) to History.remove;r=paolo
MozReview-Commit-ID: KpXAh74W12E
2014-10-31 12:39:28 +01:00
Sean Lee
f72579d769 Bug 1282662 - Part 2: Implement the detail description in hover button case.; r=Paolo
MozReview-Commit-ID: G3L0sULmRLD

--HG--
extra : rebase_source : adcc3455504ec506482d74f51032a6f123ebd2d2
2016-12-21 22:50:07 +08:00
George Pîrlea
34e7abc036 Bug 991965 - Inhibit item selection and update commands when the DownloadsBlockedSubview is open. r=paolo
MozReview-Commit-ID: Akly0NenY8Z

--HG--
extra : rebase_source : 0a02a747ec86e17a3218fdb00ed3ba018adc0a99
2017-01-21 17:42:36 +00:00
George Pîrlea
9647092161 Bug 991965 - Use event.target and inhibit item selection if the context menu is open. r=paolo
1) In the Downloads Panel, hovering over an item would sometimes not trigger an
actual selection, due to an error in how 'onDownloadMouseOver()' events were
processed - 'aEvent.orginalTarget' doesn't take retargets into account. Fixed
by using 'aEvent.target' instead of 'aEvent.originalTarget'.

2) In the Downloads Panel, right-clicking an item opens a context menu that
lets you act on the selected item. However, if you unintentionally hover over a
different item when the context menu is open, the selection changes. You may,
for example, 'Remove From History' a different, unintended item. Fixed by
inhibiting item selection when a context menu is open for a download item.

MozReview-Commit-ID: DLIAFNcs33N

--HG--
extra : rebase_source : c4021fc7634836a0b7739f8cf0c9524d732b18b9
2017-01-21 12:21:51 +00:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Rex Lee
daf6e74a28 Bug 1269957 - Unify height of download items and allow maximum 5 items to show in downloads panel. r=Paolo
MozReview-Commit-ID: 1EoBfLXyDVN

--HG--
extra : rebase_source : 2a44c65eff7122f0c6f2096e6e9dba0be05a778f
2016-12-01 20:42:05 +08:00
Sean Lee
15f00ba1a2 Bug 1282664 - Redesign the right-menu on a download item in Downloads Panel.; r=Paolo
MozReview-Commit-ID: DyTisE3dX1A

--HG--
extra : rebase_source : d87b91cb9a8b7875eddc42c4e2bad6234f433af7
2016-10-14 14:07:00 +08:00
Paolo Amadini
4c9c5a6db6 Bug 1300556 - Adjust the height of the Downloads Panel if downloads are removed while the panel is hidden. r=jaws
MozReview-Commit-ID: JpW9G6MAGwM

--HG--
extra : rebase_source : ad1cd03928d959757151fd46e25a8412c13b2511
2016-09-07 15:00:46 +01:00
Sean Lee
51322da3c0 Bug 1298276 - Change the hover behavior in summary section with downloading files. r=paolo
MozReview-Commit-ID: 1hKBRXOBH6c

--HG--
extra : transplant_source : %21%1E%80%E6%D5%A2%C52%E6%9B%D1%A4%1D%D3%27%8C%C7Q%F9%A1
2016-08-18 14:45:57 +08:00
Drew Willcoxon
d14c6b15aa Bug 1292345 - Downloads panel didn't shrink to the fit height after all items are downloaded. r=me
MozReview-Commit-ID: AV0S8GM0ztj

--HG--
extra : rebase_source : e8d01256b994368b72c73344232f64cb26d6a357
2016-08-26 16:36:56 -07:00
Drew Willcoxon
d07b49ff57 Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel. r=Paolo
MozReview-Commit-ID: 3jiqzlzLuWM

--HG--
extra : rebase_source : 46560a17b66d8ddff04795422a7c9a1a3bf6471a
2016-08-26 09:59:11 -07:00
Drew Willcoxon
1a22b3ba23 Bug 1292566 - The "open" button in the subview for uncommon and potentially unwanted downloads should not ask for confirmation. r=Paolo
MozReview-Commit-ID: AVDyaQSbriX

--HG--
extra : rebase_source : 1e151511068dc708e27f60216b6b055a90d72ef9
2016-08-24 17:56:44 -07:00
Sean Lee
ab824e0228 Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel., r=Paolo
MozReview-Commit-ID: ArmPPgLABtA

--HG--
extra : rebase_source : 8a15572df32954306b8484dbe3bf7be0c077b88e
2016-08-22 18:44:24 +08:00
Sean Lee
9b70990ee3 Bug 1269962 - Implement a popup menu for showing a submenu in Downloads Panel Footer., r=Paolo
MozReview-Commit-ID: 7K1W15039W8

--HG--
extra : rebase_source : 01b66909876cb22ea8442d037ebd8b8f3f5748ec
2016-07-13 13:39:00 +08:00
Drew Willcoxon
a21a61d78d Bug 1287914 - Buttons in sliding panel overlay are not clickable. r=jaws
MozReview-Commit-ID: 91yoPxiMIy8
2016-07-28 11:51:53 -07:00
Drew Willcoxon
01dbcb42ca Bug 1280709 - Downloads panel's "Show All Downloads" menu item is no longer clickable below its text label. r=gijs
MozReview-Commit-ID: HgTiDObq2JU

--HG--
extra : rebase_source : 546203ad5f899d66eab70dd7b86cd2a90c124978
2016-07-25 12:25:52 -07:00
Drew Willcoxon
05d0f2d0ee Bug 1252509 - Use a sliding panel overlay from the downloads panel to display the available actions. r=jaws
MozReview-Commit-ID: FhRlxcPeWu3
2016-06-10 22:08:59 -07:00
Paolo Amadini
f13e54ad79 Bug 1265387 - The default action for uncommon downloads should open the file directly. r=past
MozReview-Commit-ID: GrZev8J5MRN

--HG--
extra : rebase_source : 4f30d59be56c51801f42f9222a35dc86def9c819
2016-04-20 15:44:38 +01:00
Paolo Amadini
e0a1fb4878 Bug 1198181 - Part 5 - Change the unblock dialog actions based on the verdict. r=past
MozReview-Commit-ID: 3NkvpI9EqpB

--HG--
extra : rebase_source : 029bde9cc35128aea9c2fd61ab1d42b27ad78822
2016-04-20 11:16:00 +01:00
Paolo Amadini
916f990002 Bug 1198181 - Part 2 - Unify the code that updates the state of download items. r=jaws
MozReview-Commit-ID: KptYcAGbMG2

--HG--
extra : rebase_source : dadc1863d877de730107b12ff063c8695cf8c90d
2016-04-15 15:37:22 +01:00
Paolo Amadini
44ddde4b6e Bug 1254100 - Part 2 - Downloads blocked by Application Reputation should provide information about the verdict. r=mak
MozReview-Commit-ID: FYH5Tdtbzn

--HG--
extra : rebase_source : a59e79ac247d5f6d039d25f6ee6aea6cf2b5dbe6
2016-03-16 14:29:23 +00:00
Paolo Amadini
0fec3e127c Bug 1117145 - Part 5 - Share the implementation of some of the download item commands. r=jaws
MozReview-Commit-ID: La6km3izidY

--HG--
extra : rebase_source : 6cbd26296b0943e347fd71b263ce2a4dacb9115c
2016-02-14 17:28:12 +00:00
Paolo Amadini
f5f432c4df Bug 1117145 - Part 4 - Unify how commands are handled in the Downloads Panel and the Library. r=jaws
MozReview-Commit-ID: 2Irgwu5YI72

--HG--
extra : rebase_source : d1da32b41a36f383cc76039934ae022742a29840
2016-02-29 15:50:57 +00:00
Paolo Amadini
42971bb248 Bug 1117145 - Part 2 - Unify DownloadsViewItem and DownloadsViewItemController. r=jaws
MozReview-Commit-ID: 8qcV5Y7t1hM

--HG--
extra : rebase_source : a49dff2db7f5c89f1fa2851416cf122b1fb484c0
2016-02-10 14:54:24 +00:00
Dave Townsend
2438882fb4 Bug 1229224: Fix linting for some browser files that tests depend on. r=felipe
--HG--
extra : commitid : 63xJ7CuQ3vP
extra : rebase_source : 5bb977edee31a299d13ef82acdebb9fe6808f8fa
2015-12-17 15:19:00 -08:00
Carsten "Tomcat" Book
08997000eb Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Sebastian Hengst
cdcff6d0a7 Backed out changeset c6b267589d0d (bug 1202902) for Mulet Reftest, W3C Platform Test and other failures. r=backout a=backout on a CLOSED TREE 2015-10-07 13:36:26 +02:00
Shu-yu Guo
52e365bb7b Bug 1202902 - Fix the world. (r=ato for marionette, rs=Mossop for rest) 2015-10-06 14:00:30 -07:00
Tooru Fujisawa
e3e8c7540e Bug 1207491 - Part 6: Remove use of expression closure from browser/components/downloads/. r=Gijs
--HG--
extra : commitid : 8BIIBSCXIf9
extra : rebase_source : cca677e0c83e99cca719f5b6f794060fa0144205
2015-09-23 18:36:20 +09:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Nazim Can Altinova
5483bf7f34 Bug 1198235 - abuse of bind(this) with add/removeEventListener in downloads.js. r=mak 2015-08-31 14:04:00 +02:00
Birunthan Mohanathas
3ffa8d565d Bug 1166840 - Remove unused document argument in uses of nsIClipboardHelper.copyString. r=ehsan 2015-05-21 21:49:30 +01:00
Bill McCloskey
2cbf53b22f Bug 1145394 - Remove exec bit on js files (r=fabrice,gavin) 2015-03-20 11:57:38 -07:00
Jared Wein
2d7032360c Bug 1137909 - part 2: context menuitem to unblock downloads and an X button to confirm the blocked download. r=paolo
--HG--
extra : rebase_source : 5c72469031f9d452c9fc4b579c8e4cb2a7099f88
2015-03-05 12:25:45 -05:00
Paolo Amadini
7de2b29a33 Bug 1137996 - Can't drag items from downloads panel. r=mak 2015-03-03 10:23:12 +00:00
Marco Bonardo
448c1ef44d Bug 1135348 - Fix about:downloads by adding missing XPCOMUtils imports. r=paolo 2015-02-26 19:06:15 +01:00
Paolo Amadini
cd4b3c7397 Bug 1129896 - Part 2 of 2 - Convert the shared front-end code to a JavaScript code module. r=mak
--HG--
rename : browser/components/downloads/content/downloadsViewCommon.js => browser/components/downloads/DownloadsViewUI.jsm
2015-02-16 18:49:56 +00:00
Paolo Amadini
6e91f09568 Bug 1127867 - Use the new back-end property to get the size of downloads asynchronously. r=mak 2015-02-16 18:49:52 +00:00
Paolo Amadini
69d94e3fbd Bug 1117141 - Part 2 of 2 - Refactor notifications and remove the DownloadsDataItem object. r=mak 2015-02-16 18:49:51 +00:00
Paolo Amadini
797528c9fe Bug 1117141 - Part 1 of 2 - Bypass all the DownloadsDataItem properties. r=mak 2015-02-16 18:49:49 +00:00
Paolo Amadini
91501caee2 Bug 1117139 - Move code controlling the "download.xml" binding to a common place. r=mak 2015-02-16 18:49:47 +00:00
Paolo Amadini
1f1b323a7d Bug 1116176 - Create DownloadsHistoryDataItem and HistoryDownload objects. r=mak 2015-02-16 18:49:46 +00:00
Paolo Amadini
63cb33d173 Bug 1115983 - Keep only minimal state information in the DataItem. r=mak 2015-02-16 18:49:44 +00:00
Paolo Amadini
a541c7a926 Bug 1115379 - Streamline DownloadsViewItemController construction and remove now unneeded identifiers. r=mak 2015-01-14 17:30:27 +00:00
Paolo Amadini
d5519cad10 Bug 1115369 - Use notifications instead of getViewItem for DownloadsView. r=mak 2015-01-14 17:30:27 +00:00
Paolo Amadini
d4c5c8ca0b Bug 1115364 - Downloads Panel code style refresh. r=jaws 2014-12-29 12:35:27 +00:00
Ed Morley
18a50dd690 Bug 577266 - Correct another handful of incorrect spellings 2014-08-13 09:04:36 +01:00
Jim Blandy
7e20285e70 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00