Commit graph

146 commits

Author SHA1 Message Date
Nicholas Nethercote
bab6d17ebf Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj.
This patch makes the following changes on many in-class methods.

- NS_IMETHODIMP F() override;      --> NS_IMETHOD F() override;
- NS_IMETHODIMP F() override {...} --> NS_IMETHOD F() override {...}
- NS_IMETHODIMP F() final;         --> NS_IMETHOD F() final;
- NS_IMETHODIMP F() final {...}    --> NS_IMETHOD F() final {...}

Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.

--HG--
extra : rebase_source : 386ee4e4ea2ecd8d5001efabc3ac87b4d6c0659f
2016-08-08 10:54:47 +10:00
Nicholas Nethercote
e7f10a07fd Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.

As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.

--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
Wei-Cheng Pan
fd87664d8e Bug 1264566 - Part 2: Refactor all usage of FileDescriptor. r=valentin
Callers should use a UniquePtr to hold the platform handle.

MozReview-Commit-ID: 6BWnyAf4b3a

--HG--
extra : transplant_source : %26%CA%0D%28%08%9BT%97Z%A1%3Dq%CD%21%A1_%EFE%83%0E
extra : histedit_source : 77f8ed3d0fdec6cce0c95469130ade0fb547bb91
2016-05-27 16:12:51 +08:00
Chris Peterson
b175c9fdd5 Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo 2016-07-20 22:03:25 -07:00
Jonathan Watt
b15368cfcb Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky 2016-06-07 21:10:18 +01:00
Alexandre Lissy
20b739aeda Bug 1273520 - NS_NewRunnable* renaming and include task.h r=fabrice
MozReview-Commit-ID: BcAboKGMr3a

--HG--
extra : rebase_source : 6c5050527d8dffbce4a5e867bd48254a1041e657
2016-05-18 18:25:35 +02:00
Kyle Huey
c73656947b Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00
Sotaro Ikeda
3b81e9dd7d Bug 1262278 - Rename PlanarYCbCrImage::SetData and PlanarYCbCrImage::SetDataNoCopy r=nical 2016-04-18 20:12:41 -07:00
Birunthan Mohanathas
d7371d07d0 Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-02-02 17:36:30 +02:00
Nathan Froyd
ddc23df5df Bug 1222475 - use UniquePtr<T[]> instead of nsAutoArrayPtr<T> in dom/; r=baku,bz,terrence 2015-11-03 13:29:19 -05:00
Phil Ringnalda
d381b4bca6 Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
CLOSED TREE

Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
Birunthan Mohanathas
373593275e Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-01-31 17:12:12 +02:00
Nicholas Nethercote
0f6b051df6 Bug 1186808 - Replace nsBaseHashtable::EnumerateRead() calls in dom/camera/ with iterators. r=mikeh.
--HG--
extra : rebase_source : f332c1005449f2988936ad82cbfce1c3f65bcd7a
2015-11-22 14:39:01 -08:00
David Anderson
8e086a182c Remove Gonk usage of ImageContainer::CreateImage. (bug 1222910, r=sotaro) 2015-11-17 00:09:01 -08:00
Andrew Osmond
18286d98bd Bug 1222122 - Add picture size to verified parameters when reconfiguring the camera. r=dhylands 2015-11-05 16:00:57 -05:00
Andrew Osmond
6fc8938032 Bug 1179726 - Prefer lower resolutions than 4kuhd as the default video recording profile. r=dhylands 2015-10-29 16:06:46 -04:00
Makoto Kato
1929f6c7c4 Bug 1218315 - Replace NS_LITERAL_STRING(...).get() with MOZ_UTF16(...) on dom. r=nfroyd 2015-10-28 14:29:57 +09:00
Andrew Osmond
ba769d465a Bug 1215372 - Filter empty camera face detected events at gonk layer. r=dhylands 2015-10-21 01:51:39 -04:00
Nathan Froyd
01583602a9 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi

--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
Andrew Osmond
ae6281faf8 Bug 1196330 - Do not restart preview if configuration is unchanged. r=dhylands 2015-08-20 12:44:25 -04:00
Andrew Osmond
ea52042e5f Backed out changeset 19eb382364a9 (bug 1194476) 2015-08-20 12:18:49 -04:00
Andrew Osmond
f5deed75f0 Bug 1194476 - Do not restart preview if configuration is unchanged. r=dhylands 2015-08-20 12:12:45 -04:00
Andrew Osmond
b100eebfc1 Bug 1187364 - Part 1. Add ability for camera to pause/resume recording. r=dhylands,bz 2015-08-17 15:20:28 -04:00
Andrew Osmond
d74af6faf3 Bug 1175656 - Implement generation of recording posters in Gecko. r=dhylands,bz 2015-06-16 20:35:00 -04:00
Roger Yang
11ba368e2a Bug 1124338 - Fix possible camera cached parameters invalidation from underlying driver modification. r=aosmond 2015-05-24 11:36:00 -04:00
Eric Rahm
34f99e4b4c Bug 1163201 - Part 1: Remove instances of #ifdef PR_LOGGING in dom/. r=froydnj
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
2015-05-14 10:13:23 -07:00
Roger Yang
0cffd42719 Bug 1129051 - Fix double free in Camera Control Listener. Fix webrtc memory leak. r=aosmond 2015-04-28 16:08:40 -04:00
Andrew Osmond
5a7c3f4749 Bug 1144211 - Improve code coverage of camera mochitests. r=mikeh
--HG--
rename : dom/camera/test/test_camera_hardware_auto_focus_moving_cb.html => dom/camera/test/test_camera_auto_focus.html
rename : dom/camera/test/test_camera_bad_initial_config.html => dom/camera/test/test_camera_configuration.html
rename : dom/camera/test/test_camera_hardware_face_detection.html => dom/camera/test/test_camera_face_detection.html
rename : dom/camera/test/test_bug975472.html => dom/camera/test/test_camera_release.html
rename : dom/camera/test/test_camera_hardware_failures.html => dom/camera/test/test_camera_take_picture.html
extra : amend_source : edb877b83a258230767eca02fa3d0500ab865a0e
2015-03-17 13:01:24 -04:00
Andrew Osmond
b35bb25eaf Bug 1152260 - Generate focused event for drivers that do not notify us when using continuous auto focus. r=mikeh 2015-04-14 09:38:40 -04:00
Ehsan Akhgari
883849ee32 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Andrew Osmond
ce39ae083d Bug 1139027 - Permit running of camera mochitests on B2G desktop. r=mikeh 2015-03-10 19:39:49 -04:00
Mike Habicher
70496aa353 Bug 1121769 - push picture size to the camera driver, even in video mode, r=aosmond 2015-01-22 12:25:49 -05:00
Vincent Liu
9a52c3c7eb Bug 1107300 - (gonk-L-Camera) [meta] Camera Android L Porting. r=Sotaro 2014-12-22 14:17:22 +08:00
Alfredo Yang
833002460c Bug 938034 - Enable gonk camera recording callback. r=roc 2014-12-18 01:00:00 -05:00
Andrew Osmond
6a9e14e1fb Bug 1104913 - Update selection algorithms for preview, picture and video sizes to have sane defaults. r=mikeh, r=bz 2014-12-12 19:51:29 -08:00
Andrew Osmond
3842a0845a Bug 1111752 - Initialize metering mode to correct value. r=mikeh 2014-12-15 11:53:49 -08:00
Mike Habicher
4e25b1e2d9 Bug 1052821 - expose exposure metering modes to JS, r=aosmond,bz 2014-12-12 21:42:13 -05:00
Mike Habicher
cb12b55b35 Bug 1104055 - fix CameraControl memory leak, r=aosmond 2014-12-12 21:18:03 -05:00
Mike Habicher
34426c6b7a Bug 1099390 - add reason to onClosed event, r=aosmond,bz 2014-11-25 14:45:00 -05:00
Mike Habicher
a2a53064df Bug 1098660 - fix the (complex) requirements for video mode preview size, r=aosmond 2014-11-14 20:56:59 -05:00
Mike Habicher
cb66942d32 Bug 1079543 - handle camera hardware busy when prelaunching, r=aosmond 2014-11-12 13:54:48 -05:00
Andrew Osmond
8b6050a745 Bug 1093663 - Load recorder profiles when setting the video configuration if not already. r=mikeh 2014-11-04 11:34:00 -05:00
Mike Habicher
88e39aed0e Bug 1020368 - remove direct JS_*() calls from CameraRecorderProfiles, r=aosmond,bz 2014-10-31 13:19:06 -04:00
Ryan VanderMeulen
64db9b1b38 Backed out changeset 3fde6fc99b0a (bug 1020368) for non-unified bustage. 2014-10-31 18:51:23 -04:00
Mike Habicher
1b9a3ffc9e Bug 1020368 - remove direct JS_*() calls from CameraRecorderProfiles, r=aosmond,bz 2014-10-31 13:19:06 -04:00
Mike Habicher
9fb0ea849f Bug 1014877 - uncouple preview and video-recording frame sizes, r=aosmond 2014-09-16 15:36:48 -04:00
Mike Habicher
85a40223c1 Bug 1054803 - improve size-matching algorithm, r=aosmond 2014-09-10 11:48:55 -04:00
Mike Habicher
a973fb71ad Bug 981318 - expose compressed image quality setting, r=dhylands,khuey 2014-08-25 15:12:49 -04:00
Mike Habicher
2f751308dd Bug 1037322 - change CameraConfiguration default mode to 'unspecified' r=dhylands,khuey 2014-08-05 13:20:31 -04:00
Andrew Osmond
6cb6557d3f Bug 1030007 - Throttle updating the preview window when CPU low and/or encoder falls behind. r=mikeh, r=cpearce 2014-07-02 19:55:00 -04:00