Commit graph

61 commits

Author SHA1 Message Date
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Alphan Chen
e12a23998d Bug 1554512 - Add a handing for scroll position in copyFromCache() r=mikedeboer
Need to update the scroll position if it is deleted in the TabStateCachae.

Differential Revision: https://phabricator.services.mozilla.com/D32803

--HG--
extra : moz-landing-system : lando
2019-05-29 10:20:57 +00:00
Nika Layzell
947aaf1432 Bug 1522637 - Part 3: Send history index when resuming redirected loads, r=qdot
Depends on D18603

Differential Revision: https://phabricator.services.mozilla.com/D18604

--HG--
extra : moz-landing-system : lando
2019-02-15 19:49:11 +00:00
Razvan Maries
d93d94cbc9 Backed out 9 changesets (bug 1522637) for causing bug 1528188. a=backout
Backed out changeset e4ca191d62a5 (bug 1522637)
Backed out changeset 540e5f318768 (bug 1522637)
Backed out changeset 0886a317a108 (bug 1522637)
Backed out changeset 4c7c512a262d (bug 1522637)
Backed out changeset d7eb272688be (bug 1522637)
Backed out changeset 67e838f49f4b (bug 1522637)
Backed out changeset 7e38890c72fa (bug 1522637)
Backed out changeset e6ca9ad18d15 (bug 1522637)
Backed out changeset 0f759e91eca8 (bug 1522637)
2019-02-15 18:21:36 +02:00
Nika Layzell
6ded246a08 Bug 1522637 - Part 3: Send history index when resuming redirected loads, r=qdot
Depends on D18603

Differential Revision: https://phabricator.services.mozilla.com/D18604

--HG--
extra : source : 6b4d010964ec9e2175e7ba02991d083fab128c49
2019-02-14 15:36:02 +00:00
Bogdan Tara
c732fccb1e Backed out 8 changesets (bug 1522637) for browser_all_files_referenced.js failures CLOSED TREE
Backed out changeset f7ab0e6e739b (bug 1522637)
Backed out changeset 3d24e8e81c02 (bug 1522637)
Backed out changeset 41ca0b87537e (bug 1522637)
Backed out changeset 6e0d4b6b1c93 (bug 1522637)
Backed out changeset 8f494271ec06 (bug 1522637)
Backed out changeset 6b4d010964ec (bug 1522637)
Backed out changeset 5eeda2ba8e79 (bug 1522637)
Backed out changeset 5988b8e7d17c (bug 1522637)
2019-02-14 19:20:58 +02:00
Nika Layzell
438cbbeca1 Bug 1522637 - Part 3: Send history index when resuming redirected loads, r=qdot
Depends on D18603

Differential Revision: https://phabricator.services.mozilla.com/D18604

--HG--
extra : moz-landing-system : lando
2019-02-14 15:36:02 +00:00
shindli
6b820cdfea Backed out 6 changesets (bug 1522637) for en-US failures in testing/firefox-ui/tests/functional/safebrowsing/test_notification.py TestSafeBrowsingNotificationBar.test_notification_bar CLOSED TREE
Backed out changeset 18a809d53298 (bug 1522637)
Backed out changeset 9e9fd362dd8f (bug 1522637)
Backed out changeset f1191be4243a (bug 1522637)
Backed out changeset 5a8067fd848c (bug 1522637)
Backed out changeset 5f49cd87b1bd (bug 1522637)
Backed out changeset f82ba91f5ea2 (bug 1522637)
2019-02-09 03:12:53 +02:00
Nika Layzell
d6280f72ab Bug 1522637 - Part 3: Send history index when resuming redirected loads, r=qdot
Depends on D18603

Differential Revision: https://phabricator.services.mozilla.com/D18604

--HG--
extra : moz-landing-system : lando
2019-02-08 17:36:02 +00:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Dave Townsend
79bc1ca39f Bug 1472476: Allow restoring sessions from before favicons were only allowed to be local schemes. r=adw
Re-introduces support for setting remote icons provided a loading principal is
passed. Removes some now defunkt code from sessionstore.

Differential Revision: https://phabricator.services.mozilla.com/D3123

--HG--
extra : rebase_source : f039f34d13aa43c52af880d8f59962f6450791be
extra : amend_source : e60b5d7fb22538728837d5196b866ecf2284bc64
2018-08-20 12:32:27 -07:00
Mark Banner
6feaa5a9c3 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 1e31ff288280d09ae226cdc698331263ba969205
2018-07-25 09:10:07 +01:00
Narcis Beleuzu
d47c829065 Backed out 4 changesets (bug 1478308) for ESlint failure on AttributionCode.jsm. CLOSED TREE
Backed out changeset a809b45ff49b (bug 1478308)
Backed out changeset c68131530742 (bug 1478308)
Backed out changeset 0e4ba7a6dc1a (bug 1478308)
Backed out changeset 32a27f317a77 (bug 1478308)
2018-07-26 11:13:28 +03:00
Mark Banner
180233c593 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM

--HG--
extra : rebase_source : 67dc15c0cdff0234d3274f1a8978d1f2a5b3f411
2018-07-25 09:10:07 +01:00
Chris Pearce
55364ffa5c Bug 1458383 - Don't session restore browser.mediaBlocked. r=mikedeboer
This is a backout of Bug 1347791 part 4; 49b533231388.

49b533231388 took the mediaBlocked attribute and stored it in session store,
and caused us to call browser.resumeMedia() or blockMedia() as appropriate
upon restore. We don't want to session restore whether tabs have had delay
playback start unblocked anymore, so remove the code that session stores
that attribute.

MozReview-Commit-ID: AkRVlufrUAK

--HG--
extra : rebase_source : 613619e2ec587b546cede7795b76b049258df9dd
2018-05-04 16:22:16 +12:00
Jan Henning
2b764766f6 Bug 1456391 - Part 7: Move PrivacyFilter to Toolkit. r=mikedeboer
Since we want to start collecting all form data through mapFrameTree on Fennec,
too, we need to change our filtering strategy for form data.
We can no longer bail out directly during the data collection loop and instead
have to filter the data after having collected all of it.

The easiest way to do that is to start using PrivacyFilter.filterFormData() on
Android as well.

MozReview-Commit-ID: GBos4Zn3l2U

--HG--
rename : browser/components/sessionstore/PrivacyFilter.jsm => toolkit/modules/sessionstore/PrivacyFilter.jsm
extra : rebase_source : 1c5dfce28716c82e3a237f6d559449cb904ae13a
2018-04-25 22:33:50 +02:00
Mike de Boer
781f548ab2 Bug 1034036 - Part 4: move away from keeping state on the living objects, like windows, tabs and browsers, but keep it truly privately stored in WeakMaps. r=dao
NOTE: The '__SSi' and '__SS_lastSessionWindowID' properties on windows are kept,
      because they are expected to stick around longer during application shutdown.

The benefits is are:
1. Cleaner code - Sessionstore implementation details are not leaked outside its
   module.
2. Observing the lifetime of objects becomes unnecessary, because the WeakMaps are
   cleaned up when objects are GC'd, making leakage of their references impossible
   and Sessionstore can't hold objects hostage anymore.
3. Simplification - all state is now maintained in SessionStore.jsm, which allows
   for additional refactoring later on to simplify the implementation further.

MozReview-Commit-ID: C1II8qHkQ6F

--HG--
extra : rebase_source : e5fc6984558bd455a33e275f7060d42c93c21720
2018-04-11 12:06:06 +02:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Alastor Wu
b58f62a199 Bug 1347791 - part4 : keep tab's block state consistent after session restore. r=dao,mikedeboer
If the tab was resumed before, it could start playing any autoplay media without user's
permission after session restore.

MozReview-Commit-ID: C3DHIIsLtJA

--HG--
extra : rebase_source : d415d26d9ddcc9cb2949eb3215aee74f4c85912c
2017-06-29 05:46:28 -07:00
Carsten "Tomcat" Book
c60f5362f4 Backed out changeset 888dc371081a (bug 1347791) 2017-05-17 08:11:05 +02:00
Alastor Wu
a483732a11 Bug 1347791 - part4 : keep tab's block state consistent after session restore. r=mikedeboer
If the tab was resumed before, it could start playing any autoplay media without user's
permission after session restore.

MozReview-Commit-ID: C3DHIIsLtJA

--HG--
extra : rebase_source : 9517525aa242bff3150a902070544cf64c5ba6c1
2017-05-17 11:56:10 +08:00
Tim Huang
8f6d9f30c3 Bug 1351084 - Making the TabState.jsm collecting 'iconLoadingPrincipal' from browser.mIconLoadingPrincipal. r=mikedeboer
The browser.contentPrincpal will report a null prinicpal instead of the actual
content principal if the tab is not loaded. So the SessionStore will collect a
wrong principal for the 'iconLoadingPrincipal', and it will use this wrong
principal to load favicon when session restoring.

To fix this problem, this patch makes the TabState.jsm to collect
'iconLoadingPrincipal' from browser.mIconLoadingPrincipal which will be the
correct principal for loading favicon.

MozReview-Commit-ID: AYUbHFKaG8v

--HG--
extra : rebase_source : 3e2333f18c221d415bd0e26bc416a841344cef2c
2017-03-29 10:46:01 +08:00
Carsten "Tomcat" Book
8fd069a1f2 Merge mozilla-central to autoland 2017-03-14 14:27:38 +01:00
Mark Banner
c26710ebe4 Bug 1311347 - Enable eslint of browser/components/sessionstore/. Manual fixes. r=jaws
MozReview-Commit-ID: AupJNLZJ2Ye

--HG--
extra : rebase_source : b9113d1ca913d399ca4e831f3c381e8fa45847bd
2017-03-13 10:32:03 +00:00
Mark Banner
4acba13973 Bug 1311347 - Enable eslint of browser/components/sessionstore/. Autofix changes. r=jaws
MozReview-Commit-ID: 5LKHbcmjSy

--HG--
extra : rebase_source : d7e4571dae5c5770c7908579d7634419382d78e2
2017-03-10 19:51:20 +00:00
Michael Layzell
f083c8ec83 Bug 1345857 - Clone TabData entries when restoring tabs, r=mikedeboer
MozReview-Commit-ID: BhAbhSHgXWt
2017-03-13 18:57:07 -04:00
Sebastian Hengst
5a87040be3 Backed out changeset 5e4c135cb424 (bug 1345857) for failing at least marionette (test_refresh_firefox.py TestFirefoxRefresh.testReset), functional-ui and browser-chrome. r=backout on a CLOSED TREE 2017-03-13 19:21:03 +01:00
Michael Layzell
f838a81893 Bug 1345857 - Clone TabData entries when restoring tabs, r=mikedeboer
MozReview-Commit-ID: BhAbhSHgXWt
2017-03-13 13:25:01 -04:00
Geoff Brown
ef3f1323fa Bug 1313397 - Move browser/components/sessionstore/Utils.jsm to toolkit/modules; r=mikedeboer
--HG--
rename : browser/components/sessionstore/Utils.jsm => toolkit/modules/sessionstore/Utils.jsm
2016-11-02 10:56:20 -06:00
Steven Englehardt
84249d0d06 Bug 1294866 - Part 2: Storing the loadingPrincipal used to load favicons in SessionStore. r=mikedeboer
--HG--
extra : rebase_source : 4465315e3fea27598a4e0fd30c3acabc39a0fe14
2016-09-13 21:18:37 +08:00
Pushpankar
c6670d980f Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao
--HG--
extra : rebase_source : 72d50e73baf595840a2aade57ae782e4c40d4c27
2016-07-16 10:20:04 +02:00
Mike de Boer
037ad62636 Bug 1276884 - fix nits in TabAttributes.jsm and TabState.jsm. r=ttaubert 2016-06-01 14:48:18 +02:00
Gijs Kruitbosch
b77685214e Bug 1241085 - part 2: rip out userTypedClear and replace it with more self-documenting stuff, r=mconley
userTypedClear was used for two cases:
1) to keep track of whether we were in the middle of a loadURI call. This use is replaced by inLoadURI, which is
more sane when using e10s (though it's hard to be precise there because we're sending all web navigation calls to
the content process and this introduces a degree of asynchronousness that we just have to live with...).
2) to keep track of whether we were between a network start and a corresponding network stop, and whether the user
typed since the load properly started. This is now tracked on a small object on the browser binding, which has
appropriately named method so we're not just incrementing some magic number but actually understand what
we're saying, and so the information we get out (did the user type since this load started or not?) makes sense.

Note that we're keeping userTypedClear in session store information in order to remain backwards compatible.
It becomes a simple boolean-stored-as-int (1 or 0) that indicates whether we quit/crashed/stopped while a load
was pending, or not.

MozReview-Commit-ID: 5NbmVueocC7

--HG--
extra : rebase_source : 55cd9f3513c0a985580957a5157d47853a8822bf
extra : source : 386b9c750bd2ed458112acd29eb72e4e1371af9d
2016-04-28 19:51:36 +01:00
Gijs Kruitbosch
3dc1902afe Backed out changesets b386e97721cf, 386b9c750bd2, 3c86861912bb (bug 1241085) because the about:newtab URI is now kept across sessions, a=backout-with-approval-from-ryanvm
MozReview-Commit-ID: EVv6M6x9F44

--HG--
extra : source : de5ab3fd7c7e5772cc323a6d998a3a94143c23b1
extra : amend_source : cf7abadb9a7dbb97aaa9665a3df5981ae3459bff
2016-05-05 17:45:58 +01:00
Gijs Kruitbosch
2f63110f3f Bug 1241085 - part 2: rip out userTypedClear and replace it with more self-documenting stuff, r=mconley
userTypedClear was used for two cases:
1) to keep track of whether we were in the middle of a loadURI call. This use is replaced by inLoadURI, which is
more sane when using e10s (though it's hard to be precise there because we're sending all web navigation calls to
the content process and this introduces a degree of asynchronousness that we just have to live with...).
2) to keep track of whether we were between a network start and a corresponding network stop, and whether the user
typed since the load properly started. This is now tracked on a small object on the browser binding, which has
appropriately named method so we're not just incrementing some magic number but actually understand what
we're saying, and so the information we get out (did the user type since this load started or not?) makes sense.

Note that we're keeping userTypedClear in session store information in order to remain backwards compatible.
It becomes a simple boolean-stored-as-int (1 or 0) that indicates whether we quit/crashed/stopped while a load
was pending, or not.

MozReview-Commit-ID: 5NbmVueocC7

--HG--
extra : rebase_source : f87199c77094c24c132e6c88f751a5b5d5aa62f9
2016-04-28 19:51:36 +01:00
Mike Conley
044d8bca6b Bug 1195295 - Remove SessionStore's SyncHandler since all tab and window flushing is now async. r=ttaubert
MozReview-Commit-ID: 5UrQj1UUKDE

--HG--
extra : rebase_source : 0b2f5ebb954603bfe6a800ff0d6100be5a2dfbb2
2015-12-01 14:34:25 -05:00
Kris Maglione
3543ac46b0 Bug 1238311: Part 2 - Persist tab mutedInfo in sessionstore. r=ehsan
--HG--
extra : commitid : HX9K6Rabf3v
extra : rebase_source : 0cada35053441177863b89753e3c9a8968dc1908
extra : histedit_source : 07331d5b938d79c59dfd8789bb581e65f6a29d26
2016-01-26 17:05:42 -08:00
Bill McCloskey
9858860734 Bug 1235379 - Eliminate deferred session storage mode (r=ttaubert) 2016-01-05 21:59:46 -08:00
Andrea Marchesini
cb358b3a57 Bug 1193854 - Restoring userContextIds with the browser session - part 1 - store the userContextId in sessionStore, r=smaug, r=ttaubert 2016-01-05 21:00:33 +00:00
Andrea Marchesini
5e1308efcc Bug 1236827 - Remove non-useful 'delete' in TabStore.jsm, r=ttaubert 2016-01-05 17:22:36 +00:00
Andrew McCreight
0f12a580d4 Backed out changeset 18eec0849a1f (Bug 1195295) for leaking.
This changeset is causing shutdown leaks (bug 1234697 and bug 1220517).
2015-12-23 15:59:15 -05:00
Mike Conley
f2127e9ebb Bug 1195295 - Remove SessionStore's SyncHandler since all tab and window flushing is now async. r=ttaubert
--HG--
extra : commitid : 20kUFlNpMz6
extra : rebase_source : 89f89eea235b8a68f6c76e3324909be7d7da0ede
2015-12-01 14:34:25 -05:00
Alexandre Poirot
89cb263b54 Bug 1204812 - Keep Console.jsm in toolkit/modules/ r=jryans,Mossop
--HG--
rename : devtools/shared/Console.jsm => toolkit/modules/Console.jsm
2015-10-15 03:45:22 -07:00
Ehsan Akhgari
bf33ea16ea Bug 1211314 - Use tab.toggleMuteAudio() from sessionstore instead of setting the muted attribute manually on the tab; r=jaws 2015-10-14 17:21:05 -04:00