Commit graph

759 commits

Author SHA1 Message Date
Simon Giesecke
79f1249dc9 Bug 1623278 - Use MovingNotNull in ActorsParent. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73033
2020-05-14 09:14:17 +00:00
Simon Giesecke
a892bc01f6 Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 09:14:04 +00:00
Bogdan Tara
078debe589 Backed out 2 changesets (bug 1623278, bug 1633719) for assertion failure on NotNull.h CLOSED TREE
Backed out changeset 8a21ea441fc7 (bug 1623278)
Backed out changeset ab6a041c0d57 (bug 1633719)
2020-05-14 11:34:50 +03:00
Simon Giesecke
e0aafb232f Bug 1623278 - Use MovingNotNull in ActorsParent. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73033
2020-05-13 10:44:52 +00:00
Simon Giesecke
98b9d42815 Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73025
2020-05-14 07:47:46 +00:00
Simon Giesecke
e5e444b9cc Bug 1636316 - Disable defective optimization in DeserializeIndexValueHelper::DispatchAndWait. r=asuth,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D75046
2020-05-13 15:49:46 +00:00
ssengupta
cf852bbfb9 Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D73868
2020-05-12 19:02:05 +00:00
Simon Giesecke
9d5e7505f9 Bug 1623278 - Make Factory derive from SafeRefCounted. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D69398
2020-05-06 12:20:14 +00:00
Simon Giesecke
f5ecb7c004 Bug 1623278 - Use SafeRefCounted in ActorsParent. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D69351
2020-05-06 11:35:20 +00:00
Simon Giesecke
6d8be8c785 Bug 1623278 - Make transaction actors refcounted. r=dom-workers-and-storage-reviewers,nika,janv
Differential Revision: https://phabricator.services.mozilla.com/D71933
2020-05-06 12:20:32 +00:00
Simon Giesecke
ea023a9d8e Bug 1626570 - Improve handling of copying arrays in dom/indexedDB/. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D73650
2020-05-05 14:13:46 +00:00
Sylvestre Ledru
34acbb653a Bug 1619165 - Reformat recent changes to the Google coding style r=andi
First reformat with clang-format 10

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D68802
2020-04-25 09:40:08 +00:00
Simon Giesecke
2d8c4390b7 Bug 1628715 - Part 15: Replace MOZ_NONNULL_RETURN by returning NotNull<elem_type*>. r=xpcom-reviewers,necko-reviewers,dragana,nika
Differential Revision: https://phabricator.services.mozilla.com/D71300
2020-04-24 13:35:27 +00:00
Chris Peterson
843c954b43 Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-23 01:49:16 +00:00
Simon Giesecke
2b4a61a0b6 Bug 1628716 - Use range-based for and STL algorithms with hashtables. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D70378
2020-04-22 13:52:52 +00:00
Simon Giesecke
1dd70d203d Bug 1618542 - Add further uses of new transformation algorithms with nsTHashtable. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D70377
2020-04-22 13:51:43 +00:00
Dorel Luca
41c3ea3ee8 acked out changeset 6bbecc3020b7 (bug 1631684) for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE 2020-04-22 08:41:47 +03:00
Chris Peterson
0aeb2db4f6 Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-22 05:22:44 +00:00
Bogdan Tara
76b2fc7b60 Bug 1618542 - Fixed whitespace on ActorsParent.cpp CLOSED TREE 2020-04-21 20:19:50 +03:00
Simon Giesecke
410c229065 Bug 1618542 - Add further uses of new transformation algorithms. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D69041
2020-04-21 14:56:20 +00:00
Simon Giesecke
48fc4a573b Bug 1618542 - Make OpenDatabaseOp::MetadataToSpec fallible. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D69040
2020-04-21 14:34:26 +00:00
Simon Giesecke
2fd18d4675 Bug 1618542 - Made possibly large memory allocations fallible. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D69038
2020-04-21 14:34:19 +00:00
Simon Giesecke
09fa9d86d9 Bug 1618542 - Add further uses of new transformation algorithms. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D69037
2020-04-21 14:54:41 +00:00
Simon Giesecke
931e494dba Bug 1618542 - Remove uses of FallibleTArray in ActorsParent.cpp. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D69036
2020-04-21 14:37:51 +00:00
Simon Giesecke
ef41d753b5 Bug 1623278 - Eliminate output and raw pointer input parameters on some ActorsParent functions. r=dom-workers-and-storage-reviewers,ttung
Differential Revision: https://phabricator.services.mozilla.com/D68338
2020-04-21 14:40:00 +00:00
Simon Giesecke
4968855eb7 Bug 1623278 - Eliminate output parameters on GetOrCreateConnection. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D68337
2020-04-21 14:33:06 +00:00
Simon Giesecke
8644241bec Bug 1628723 - Simplify ConnectionPool::Cleanup and add assertion. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D70379
2020-04-21 13:58:57 +00:00
Jan Varga
882077ccb1 Bug 1619965 - Simplify clearing of mWaitingFactoryOp; r=sg,dom-workers-and-storage-reviewers
mWaitingFactoryOp is now always cleared when the last maybe blocked database is
removed in FactoryOp::NoteDatabaseClosed.

Differential Revision: https://phabricator.services.mozilla.com/D70201

--HG--
extra : moz-landing-system : lando
2020-04-09 08:53:21 +00:00
Simon Giesecke
0f359d3fdb Bug 1619965 - Remove duplication between NoteDatabaseClosed methods. r=janv,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65334

--HG--
extra : moz-landing-system : lando
2020-04-09 09:23:39 +00:00
Bogdan Tara
9120151ddb Backed out 2 changesets (bug 1619965) for bustages complaining about ActorsParent.cpp CLOSED TREE
Backed out changeset efa2dcf4f69e (bug 1619965)
Backed out changeset da983a0216c8 (bug 1619965)
2020-04-09 11:36:54 +03:00
Jan Varga
61a77769f7 Bug 1619965 - Simplify clearing of mWaitingFactoryOp; r=sg,dom-workers-and-storage-reviewers
mWaitingFactoryOp is now always cleared when the last maybe blocked database is
removed in FactoryOp::NoteDatabaseClosed.

Differential Revision: https://phabricator.services.mozilla.com/D70201

--HG--
extra : moz-landing-system : lando
2020-04-09 08:10:10 +00:00
Simon Giesecke
15d16a9d16 Bug 1619965 - Remove duplication between NoteDatabaseClosed methods. r=janv,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65334

--HG--
extra : moz-landing-system : lando
2020-04-08 17:44:20 +00:00
Andreas Farre
36eaf82163 Bug 1620594 - Part 2: Use SchedulerGroup::Dispatch instead of SystemGroup::Dispatch. r=nika
Depends on D67631

Differential Revision: https://phabricator.services.mozilla.com/D67632

--HG--
extra : moz-landing-system : lando
2020-04-07 15:16:33 +00:00
Tom Tung
94e4123950 Bug 1536796 - P3 - Use QM_NewLocalFile in QM and its clients; r=janv,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D67875

--HG--
extra : moz-landing-system : lando
2020-04-01 07:26:27 +00:00
Simon Giesecke
a8c2236b19 Bug 1623278 - Replace GetStorageConnection by HasStorageConnection and MutableStorageConnection accessors. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D67286

--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:56 +00:00
Simon Giesecke
e614684d09 Bug 1623278 - Use SafeRefPtr for TransactionBase and its subclasses. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D65711

--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:52 +00:00
Simon Giesecke
02753c9665 Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D65710

--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:39 +00:00
Simon Giesecke
64d6929415 Bug 1623278 - Use SafeRefPtr for Database. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D65568

--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:16 +00:00
Simon Giesecke
88b93c652a Bug 1623278 - Use SafeRefPtr for FileInfo. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D65550

--HG--
extra : moz-landing-system : lando
2020-04-01 09:53:01 +00:00
Simon Giesecke
86efbc2cef Bug 1623278 - Use SafeRefPtr for FileManager. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D65549

--HG--
extra : moz-landing-system : lando
2020-04-01 09:52:54 +00:00
Simon Giesecke
3d2232e5e2 Bug 1623278 - Use SafeRefPtr for FullDatabaseMetadata. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D65548

--HG--
extra : moz-landing-system : lando
2020-04-01 09:54:24 +00:00
Simon Giesecke
bd9cd54c52 Bug 1623278 - Workaround to make gcc 8.3.0 happy. r=jstutte
Depends on D65547

Differential Revision: https://phabricator.services.mozilla.com/D69170

--HG--
extra : moz-landing-system : lando
2020-04-01 09:56:58 +00:00
Simon Giesecke
4b23573552 Bug 1620917 - Ensure a failure of StartTransactionOp is correctly handled on the resulting CommitOp. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D67667

--HG--
extra : moz-landing-system : lando
2020-03-23 10:38:47 +00:00
Simon Giesecke
a98c358c43 Bug 1620632 - Revert workaround for nsTArray move construction in indexedDB ActorsParent.cpp. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D66247

--HG--
extra : moz-landing-system : lando
2020-03-20 17:06:52 +00:00
Simon Giesecke
58d0171406 Bug 1620632 - Ensure nsTArray_Impl only declares a copy-constructor/assignment operator if E is copy-constructible. r=froydnj
To correctly implement this, it must be known on instantiation whether E is
copy-constructible, which is not the case if only a forward declaration is
available. This can be resolved either by making sure a full definition of E is
available, which is preferable. But in cases where this is not (easily) possible,
the information can be explicitly provided by the MOZ_DECLARE_COPY_CONSTRUCTIBLE
and MOZ_DECLARE_NON_COPY_CONSTRUCTIBLE macros. In particular, declarations for
IPDL-declared types are added to nsTArray.h itself, like it was already done
for MOZ_DECLARE_RELOCATE_USING_MOVE_CONSTRUCTOR.

Differential Revision: https://phabricator.services.mozilla.com/D66244

--HG--
extra : moz-landing-system : lando
2020-03-20 17:13:51 +00:00
Simon Giesecke
acddf5bae9 Bug 1617170 - Remove duplication around deleting files. r=janv,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65306

--HG--
extra : moz-landing-system : lando
2020-03-19 14:40:04 +00:00
Simon Giesecke
393a8cb4a2 Bug 1617170 - Split StructuredCloneFile into parent- and child-specific classes. r=janv,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65167

--HG--
extra : moz-landing-system : lando
2020-03-19 11:35:03 +00:00
Simon Giesecke
6257967779 Bug 1617170 - Deserialize Blob only when it is used in AllocPBackgroundIDBDatabaseFileParent. r=janv
Differential Revision: https://phabricator.services.mozilla.com/D65948

--HG--
extra : moz-landing-system : lando
2020-03-19 11:34:58 +00:00
Simon Giesecke
253bdd830f Bug 1617170 - Reduce statefulness of FileHelper. r=janv,dom-workers-and-storage-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65305

--HG--
extra : moz-landing-system : lando
2020-03-19 11:35:00 +00:00
Mihai Alexandru Michis
2922453b6e Backed out 10 changesets (bug 1623278, bug 1617170, bug 1620273, bug 1597954) for causing bustages.
CLOSED TREE

Backed out changeset 50c0e58dd654 (bug 1623278)
Backed out changeset b31ddbcdd2f2 (bug 1597954)
Backed out changeset 8b03993a9234 (bug 1623278)
Backed out changeset ad7b08acadd6 (bug 1623278)
Backed out changeset bb094a6084b3 (bug 1623278)
Backed out changeset 7fdf38a403bb (bug 1623278)
Backed out changeset d69cf5fcb571 (bug 1620273)
Backed out changeset 5abef9862e60 (bug 1617170)
Backed out changeset 11d9ccb4ddd8 (bug 1617170)
Backed out changeset 6df7028b41d0 (bug 1617170)
2020-03-19 13:30:26 +02:00