Simon Giesecke
9aedc5ab75
Bug 1626570 - Improve handling of copying arrays in dom/plugins/. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D73656
2020-05-06 11:16:12 +00:00
Sylvestre Ledru
734f79b541
Bug 1624237 - Run misc-unused-using-decls - Remove useless declarations r=andi
...
$ ./mach static-analysis check --checks="-*, misc-unused-using-decls" --fix <path>
Differential Revision: https://phabricator.services.mozilla.com/D67811
--HG--
extra : moz-landing-system : lando
2020-03-23 13:15:33 +00:00
Andrew Osmond
91b071ed14
Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel
...
gfx::Color is currently misused in many places. The DrawTargets expect
the color space to be in device space, e.g. what we are actually going
to draw using. Everything sitting above generally deals with sRGB, as
specified in CSS. Sometimes we missed the conversion from sRGB to device
space when issuing draw calls, and similarly sometimes we converted the
color to device space twice.
This patch splits the type in two. sRGBColor and DeviceColor now
represent sRGB and device color spaces respectively. DrawTarget only
accepts DeviceColor, and one can get a DeviceColor from an sRGBColor via
the ToDeviceColor helper API. The reftests now pass with color
management enabled for everything (e.g. CSS) instead of just tagged
raster images.
There will be a follow up patch to enable color management everywhere by
default on all supported platforms.
Differential Revision: https://phabricator.services.mozilla.com/D64771
--HG--
extra : moz-landing-system : lando
2020-03-09 14:16:17 +00:00
Eric Rahm
05033fda2a
Bug 1618735 - Remove nsAutoPtr usage from dom/plugins. r=handyman
...
Differential Revision: https://phabricator.services.mozilla.com/D64693
--HG--
extra : moz-landing-system : lando
2020-02-29 02:10:12 +00:00
Narcis Beleuzu
dbd979419a
Backed out 2 changesets (bug 1618735, bug 1618753) for bustages on nsZipArchive.h . CLOSED TREE
...
Backed out changeset 5eae5c3e54bf (bug 1618753)
Backed out changeset e58f6c24816c (bug 1618735)
2020-02-29 04:06:12 +02:00
Eric Rahm
487e572e35
Bug 1618735 - Remove nsAutoPtr usage from dom/plugins. r=handyman
...
Differential Revision: https://phabricator.services.mozilla.com/D64693
--HG--
extra : moz-landing-system : lando
2020-02-28 20:31:44 +00:00
Simon Giesecke
aaf6cb4e75
Bug 1617628 - Hide nsBaseHashtable Put overloads in nsRefPtrHashtable subclass. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D63899
--HG--
extra : moz-landing-system : lando
2020-02-25 17:03:36 +00:00
Emilio Cobos Álvarez
b2fe832c7b
Bug 1603313 - Remove some silly patterns. r=bzbarsky
...
foo ? true : false
or:
foo ? false : true
Have always a nicer way to be written.
Differential Revision: https://phabricator.services.mozilla.com/D56842
--HG--
extra : moz-landing-system : lando
2019-12-14 05:05:01 +00:00
Sylvestre Ledru
8d2f0d1b1f
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D54686
--HG--
extra : moz-landing-system : lando
2019-11-26 14:35:02 +00:00
David Parks
b5f917254e
Bug 1449736: Properly detect failure in receiving plugin NPObjects r=jmathies
...
Properly handles NPError reporting and makes sure that, in the case of failure, it does not return junk for the NPObject.
Differential Revision: https://phabricator.services.mozilla.com/D48474
--HG--
extra : moz-landing-system : lando
2019-10-12 17:05:35 +00:00
David Parks
33f854d97a
Bug 1384260: Part 3 - Remove GetKeyState from Windows content proc plugin code r=jmathies
...
As part of sandboxing the content process for Windows, we want to remove these calls from it. These instances of GetKeyState should not be in actual use since plugin mouse events are handled through different means. When they come to nsPluginInstanceOwner::ProcessEvent, they come with a pre-filled-in mPluginEvent, and this code is conditional on that not happening. Despite that, I am preserving the existing behavior by moving the GetKeyState calls to the plugin process (where they are brokered to the parent process). This fix is more robust to change than just removing the code would be.
Differential Revision: https://phabricator.services.mozilla.com/D47937
--HG--
extra : moz-landing-system : lando
2019-10-16 21:21:57 +00:00
Eric Rahm
1fc1deae7d
Bug 1577936 - Remove using namespace std from dom/plugins r=handyman
...
Differential Revision: https://phabricator.services.mozilla.com/D44292
--HG--
extra : moz-landing-system : lando
2019-09-03 16:31:23 +00:00
Barret Rennie
6d98deeeab
Bug 1289211 - Rename InfallibleTArray to nsTArray in dom/plugins/ r=jmathies
...
Differential Revision: https://phabricator.services.mozilla.com/D36948
--HG--
extra : moz-landing-system : lando
2019-07-10 03:27:43 +00:00
Kyle Machulis
971f298ed0
Bug 1525583 - Add more null checks for NPN_RetainObject; r=jmathies
...
Don't try to change refcount on null pointer if one is passed.
Differential Revision: https://phabricator.services.mozilla.com/D25982
--HG--
extra : moz-landing-system : lando
2019-04-03 19:52:40 +00:00
Mats Palmgren
f46136021c
Bug 288704 part 1 - [css-lists] Add an inherited internal UA sheet property (-moz-list-reversed:true|false) to propagate <ol reversed> to its relevant decendants. r=emilio
2019-03-24 23:13:52 +01:00
Alex Gaynor
38a2064d1e
Bug 1441651 - Part 2 - pass Shmem and ByteBuf by rvalref to Send* IPC methods; r=nika,jrmuizel
...
Differential Revision: https://phabricator.services.mozilla.com/D19954
--HG--
extra : moz-landing-system : lando
2019-03-04 16:35:30 +00:00
Kyle Machulis
ba73781dd1
Bug 1525583 - Add null checks for before retaining NPAPI objects; r=jmathies
...
Remove assertion and add actual checks to make sure we're retaining
live objects, not nullptrs. Return error if retain doesn't work.
Differential Revision: https://phabricator.services.mozilla.com/D20538
--HG--
extra : moz-landing-system : lando
2019-02-25 19:28:51 +00:00
Ehsan Akhgari
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Daniel Varga
10fe290de6
Backed out changeset 49be7aaa199c (bug 1449736) for mochitest failure at layout/generic/test/test_plugin_focus.html on a CLOSED TREE
2019-01-10 22:56:40 +02:00
David Parks
4ff2f5dfa4
Bug 1449736: Properly detect failure in receiving plugin NPObjects (r=jmathies)
...
We need to recognize IPDL errors in order to return the proper error status when the right PluginScriptableObject could not be found.
Differential Revision: https://phabricator.services.mozilla.com/D15469
--HG--
extra : moz-landing-system : lando
2019-01-09 16:36:59 +00:00
Tooru Fujisawa
7983faeb5d
Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp
2018-12-01 04:52:05 +09:00
Benjamin Bouvier
a7f1d173a0
Bug 1511383: Update vim modelines after clang-format; r=sylvestre
...
- modify line wrap up to 80 chars; (tw=80)
- modify size of tab to 2 chars everywhere; (sts=2, sw=2)
--HG--
extra : rebase_source : 7eedce0311b340c9a5a1265dc42d3121cc0f32a0
extra : amend_source : 9cb4ffdd5005f5c4c14172390dd00b04b2066cd7
2018-11-30 16:39:55 +01:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Jean-Yves Avenard
aace4e2e6a
Bug 1496758 - Fix few compilation warnings in ipc code. r=handyman,Jamie
...
Differential Revision: https://phabricator.services.mozilla.com/D7918
--HG--
extra : moz-landing-system : lando
2018-10-10 04:31:35 +00:00
Aaron Klotz
23646bdf45
Bug 1460022: Part 7 - Update plugin code to work with revised DLL interceptor interface; r=handyman
2018-06-27 11:50:50 -06:00
shindli
dd50d1646e
Backed out 13 changesets (bug 1460022) for bustages in :/build/build/src/mozglue/tests/interceptor/TestDllInterceptor.cpp(113) on a CLOSED TREE
...
Backed out changeset b798c3689bbf (bug 1460022)
Backed out changeset c3b3b854affd (bug 1460022)
Backed out changeset ecb1b6fd3134 (bug 1460022)
Backed out changeset 91fed649dd5a (bug 1460022)
Backed out changeset be7032cddad2 (bug 1460022)
Backed out changeset d4a036b976e6 (bug 1460022)
Backed out changeset 5f3dfde41e38 (bug 1460022)
Backed out changeset a16486a6f685 (bug 1460022)
Backed out changeset 69eacc5c3ab8 (bug 1460022)
Backed out changeset 34aa7c29b31e (bug 1460022)
Backed out changeset 00b20c0a7637 (bug 1460022)
Backed out changeset b8e8aea4a01f (bug 1460022)
Backed out changeset 15822d9848d8 (bug 1460022)
2018-07-04 03:37:11 +03:00
Aaron Klotz
0f899ac198
Bug 1460022: Part 7 - Update plugin code to work with revised DLL interceptor interface; r=handyman
2018-06-27 11:50:50 -06:00
shindli
dcc88f33f9
Backed out 13 changesets (bug 1460022) for bustages in builds/worker/workspace/build/src/dom/plugins/ipc/FunctionHook.h 💯 24 on a CLOSED TREE
...
Backed out changeset 0734142a3f35 (bug 1460022)
Backed out changeset 18fbfa7ca685 (bug 1460022)
Backed out changeset 2df129bd5692 (bug 1460022)
Backed out changeset 02a7ed68933f (bug 1460022)
Backed out changeset 221137d1c2de (bug 1460022)
Backed out changeset 9cb0b7a15402 (bug 1460022)
Backed out changeset 18f8f85c0307 (bug 1460022)
Backed out changeset 867a1351efff (bug 1460022)
Backed out changeset 933e0b698f8e (bug 1460022)
Backed out changeset 09da660071e1 (bug 1460022)
Backed out changeset 8bb5142d3f53 (bug 1460022)
Backed out changeset 0ddf581bdaac (bug 1460022)
Backed out changeset 1cd5f9b4a6af (bug 1460022)
2018-07-04 02:49:24 +03:00
Aaron Klotz
cc80cb14e0
Bug 1460022: Part 7 - Update plugin code to work with revised DLL interceptor interface; r=handyman
...
--HG--
extra : rebase_source : 277e237e80b513b055b55ef7fb5cace7f240ea95
2018-06-27 11:50:50 -06:00
David Parks
6a029ee77d
Bug 1449388 - Send NPNVaudioDeviceStateChanged to plugins when any Windows audio device changes state. r=jimm
...
This message allows plugins to detect when any audio devices change state, even when running inside of our plugin sandbox.
2018-06-13 13:12:54 -07:00
Chris Peterson
2afd829d0f
Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
...
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.
MozReview-Commit-ID: 5UQVHElSpCr
--HG--
extra : rebase_source : 4c1b2fc32b269342f07639266b64941e2270e9c4
extra : source : 907543f6eae716f23a6de52b1ffb1c82908d158a
2018-06-17 22:43:11 -07:00
Andi-Bogdan Postelnicu
16e7cff712
Bug 1453795 - Dom/Plugins - Initialize member fields in classes/ structures. r=jmathies
2018-06-14 08:38:21 +03:00
Jim Mathies
5bb082d6a1
Bug 1460007 - Only call PluginInstanceChild's HookSetWindowLongPtr once. r=aklotz
2018-05-16 13:29:43 -05:00
Jim Mathies
ba6f25a6f4
Bug 1460006 - Only call PluginInstanceChild's InitPopupMenuHook once. r=aklotz
2018-05-16 13:23:43 -05:00
Makoto Kato
fb3fb140eb
Bug 1456294 - Hook ImmAssociateContextEx. r=masayuki
2018-05-17 14:47:55 +09:00
Sebastian Hengst
0819f35e51
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
Makoto Kato
897ea8c314
Bug 1438955 - Remove ImmReleaseContext hook. r=masayuki
...
--HG--
extra : rebase_source : 78eeb24aa1b89c634cb9da089b43c01bdd390906
2018-03-07 11:01:30 +09:00
Dorel Luca
f41b03eca9
Backed out changeset 38577c007450 (bug 1424371) for Marionett test failure on testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py. CLOSED TREE
2018-02-19 22:15:23 +02:00
Milan Sreckovic
7571df7e7c
Bug 1424371: Use BaseRect access methods instead of member variables in dom/ r=qdot
...
MozReview-Commit-ID: HXWhggOMIEK
--HG--
extra : rebase_source : 9c9eacf80d2b7f78faa82a1549170b98d12cdaa8
2018-02-19 12:56:10 -05:00
Chris Peterson
1df202b177
Bug 1412048 - Replace NS_RUNTIMEABORT("...") with MOZ_CRASH("..."). r=froydnj
...
And remove unreachable code after MOZ_CRASH().
MozReview-Commit-ID: 6ShBtPRKYlF
--HG--
extra : rebase_source : 0fe45a59411bda663828336e2686707b550144ae
extra : source : 8473fd7333d2abe1ea1cc176510c292a5b34df45
2017-10-24 23:30:31 -07:00
Sylvestre Ledru
d60d69e2cb
Bug 1411001 - Remove the +x permissions on cpp & h files r=froydnj
...
MozReview-Commit-ID: DjDkL20wRg0
--HG--
extra : rebase_source : a343d83d1f4e97e4ba56d0f57fec93079df0b5ea
2017-10-23 20:59:55 +02:00
Tom Ritter
09e9d30178
Bug 1409258 Adjust the definition of NPEvent and resolve uint -> int narrowing in dom/plugins r=jimm
...
lParam is a long int (signed) while wparam is unsigned. Correct lParam to be an intptr
MozReview-Commit-ID: BeWJUM798O5
--HG--
extra : rebase_source : 901e0ebf4eaa9622b45a6e60de1a11bc6cf606fc
2017-10-17 12:04:51 -05:00
Nicholas Nethercote
78f521a734
Bug 1352573 (part 2) - Remove NPN_PluginThreadAsyncCall() and related machinery. r=bsmedberg.
...
* * *
[mq]: rm-checkGCRace
--HG--
extra : rebase_source : 4b9316ee05c1f62e80b20c7f9ab03bd8f33d4658
2017-08-03 22:12:51 +10:00
Tom Ritter
ae930caa79
Bug 1393535 Fix unused variable warnings in dom/ r=cpearce
...
MozReview-Commit-ID: 1Ql20AHx1Jz
--HG--
extra : rebase_source : 21105b4fc70953ecdccd4c1e7fe9c9d5564795c4
2017-08-24 11:52:36 -05:00
Jan Beich
434eece1c8
Bug 1391993 - plugins: Fix -Wunreachable-code-return in PluginInstanceChild.cpp for non-OSX. r=kats
...
MozReview-Commit-ID: 9qIndwc8G0N
--HG--
extra : rebase_source : e58c1f2d2980f2fd6a29e5e053dcf0ec2130c3ca
2017-08-19 18:05:42 +00:00
Nicholas Nethercote
2a1feb9d19
Bug 1352573 (part 1) - Convert FlashThrottleAsyncMsg from a ChildAsyncCall to a CancelableRunnable. r=bsmedberg.
...
This requires adding mPendingFlashThrottleMsgs to PluginInstanceChild. It also
requires adding FlashThrottleMsg::mInstance, and a FlashThrottleMsg::Cancel()
function that nulls mInstance.
--HG--
extra : rebase_source : 87e5732ddf2ad57d4f3ff078ab66143797eac49f
2017-07-19 17:22:05 +10:00
dan1bh
de45c53ef7
Bug 1352559 - Remove support for plugin-provided streams; NPN_NewStream, PPluginStream and other supporting machinery, r=bsmedberg
...
Removed API List:
* NPN_NewStream
* NPN_Write
* NPN_DestroyStream
* nsNPAPIStreamWrapper
* nsPluginStreamToFile
* PPluginStream.ipdl
MozReview-Commit-ID: 61dKGct3qGW
--HG--
extra : source : 999aa7b6683d7f0cf481f8dd0e8a9ba3dade4a05
extra : intermediate-source : cb1548354e0cf582dca6b0ab0d27712d01a4c819
2017-07-11 14:27:25 -04:00
Nicholas Nethercote
7f215371c0
Backed out changeset cb1548354e0c (bug 1352559, part 3) for causing *many* crashes in Nightly. r=backout
2017-07-17 09:41:29 +10:00
dan1bh
b62787e960
Bug 1352559 - Remove support for plugin-provided streams; NPN_NewStream, PPluginStream and other supporting machinery, r=bsmedberg
...
Removed API List:
* NPN_NewStream
* NPN_Write
* NPN_DestroyStream
* nsNPAPIStreamWrapper
* nsPluginStreamToFile
* PPluginStream.ipdl
MozReview-Commit-ID: 61dKGct3qGW
--HG--
extra : rebase_source : 1567d89d0735ca23c964a0c6691f9a117305641f
extra : source : 999aa7b6683d7f0cf481f8dd0e8a9ba3dade4a05
2017-07-11 14:27:25 -04:00