Commit graph

59 commits

Author SHA1 Message Date
Tom Tung
6dfa60337a Bug 1628240 - Do not clear all origins that match the pattern for QuotaCleaner.deleteByHost; r=dom-workers-and-storage-reviewers,janv
We do clearStoragsForPrincipal based on the result from listOrigin, so it's fine
to not clear all stroages that match the prefix here. Also, since the passing
principals can contain origin attributes which is not allowed to be used with
aClearAll.

Differential Revision: https://phabricator.services.mozilla.com/D73417
2020-05-13 13:57:28 +00:00
Tom Tung
81b5f914d9 Bug 1628240 - A temporary fix to remove the same origins for the same host for all quota clients in ClearSiteDataFromHost; r=johannh,dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D71716
2020-05-01 06:09:44 +00:00
Dana Keeler
e8ebc73d50 Bug 1630038 - remove HPKP entirely r=kjacobs,bbeurdouche
This removes processing of HTTP Public Key Pinning headers, remotely modifying
pinning information, and using cached pinning information, all of which was
already disabled in bug 1412438. Static pins that ship with the browser are
still enforced.

Differential Revision: https://phabricator.services.mozilla.com/D73352
2020-05-06 22:57:50 +00:00
Noemi Erli
d44894bde2 .Backed out 3 changesets (bug 1628240) for causing geckoview failures CLOSED TREE
Backed out changeset 6fc159a53fab (bug 1628240)
Backed out changeset 6f0ed8b711fd (bug 1628240)
Backed out changeset 4c685e21c33d (bug 1628240)
2020-04-28 19:55:08 +03:00
Tom Tung
cc5bfdd963 Bug 1628240 - A temporary fix to remove the same origins for the same host for all quota clients in ClearSiteDataFromHost; r=johannh,dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D71716
2020-04-28 15:56:53 +00:00
Jan Varga
0e36a593fa Bug 1615998 - QM: Remove nsIQuotaOriginsResult interface; r=ttung,dom-workers-and-storage-reviewers,sg
Differential Revision: https://phabricator.services.mozilla.com/D63051

--HG--
extra : moz-landing-system : lando
2020-02-22 01:03:26 +00:00
Ehsan Akhgari
1ca91dd7ab Bug 1603969 - Part 1: Remove the concept of granted origins from the anti-tracking backend; r=baku
Granted origins cause a third-party tracker browsing context to not get
full first-party storage access after successfully calling the storage
access API or a heuristic granting ephemeral access.

For example, after https://tracker.example calls the storage access API
successfully in the third-party context, they embed
https://other-tracker.example, and that load fails because of ETP
restrictions.  Here what happens is that https://other-tracker.example
is mistakenly considered the granted origin, and because such a
permission doesn't exist, access is denied.

Differential Revision: https://phabricator.services.mozilla.com/D57493

--HG--
extra : moz-landing-system : lando
2019-12-19 02:56:52 +00:00
Gurzau Raul
bed8b9f116 Backed out 4 changesets (bug 1603969) for failing at /browser_startup_mainthreadio.js on a CLOSED TREE.
Backed out changeset c4d79087eef1 (bug 1603969)
Backed out changeset 2c0198f3506c (bug 1603969)
Backed out changeset c5ad252c525b (bug 1603969)
Backed out changeset a334451b95eb (bug 1603969)
2019-12-19 02:08:09 +02:00
Ehsan Akhgari
1676da33c8 Bug 1603969 - Part 1: Remove the concept of granted origins from the anti-tracking backend; r=baku
Granted origins cause a third-party tracker browsing context to not get
full first-party storage access after successfully calling the storage
access API or a heuristic granting ephemeral access.

For example, after https://tracker.example calls the storage access API
successfully in the third-party context, they embed
https://other-tracker.example, and that load fails because of ETP
restrictions.  Here what happens is that https://other-tracker.example
is mistakenly considered the granted origin, and because such a
permission doesn't exist, access is denied.

Differential Revision: https://phabricator.services.mozilla.com/D57493

--HG--
extra : moz-landing-system : lando
2019-12-18 19:14:53 +00:00
Gurzau Raul
e92fa08412 Backed out 4 changesets (bug 1603969) for failing at /browser_startup_mainthreadio.js on a CLOSED TREE.
Backed out changeset 959f12e42db9 (bug 1603969)
Backed out changeset 18bf461b9630 (bug 1603969)
Backed out changeset 8c3bb23a048b (bug 1603969)
Backed out changeset 450eec13d73e (bug 1603969)
2019-12-18 20:53:13 +02:00
Ehsan Akhgari
9852e6494c Bug 1603969 - Part 1: Remove the concept of granted origins from the anti-tracking backend; r=baku
Granted origins cause a third-party tracker browsing context to not get
full first-party storage access after successfully calling the storage
access API or a heuristic granting ephemeral access.

For example, after https://tracker.example calls the storage access API
successfully in the third-party context, they embed
https://other-tracker.example, and that load fails because of ETP
restrictions.  Here what happens is that https://other-tracker.example
is mistakenly considered the granted origin, and because such a
permission doesn't exist, access is denied.

Differential Revision: https://phabricator.services.mozilla.com/D57493

--HG--
extra : moz-landing-system : lando
2019-12-18 15:48:29 +00:00
Tom Tung
21f3d11a5b Bug 1474608 - P3 - Add a argument (aCallback) to deleteDataFromOriginAttributesPattern and add a browser test to verify the behavior on quota storage; r=asuth,baku
Differential Revision: https://phabricator.services.mozilla.com/D34325

--HG--
extra : moz-landing-system : lando
2019-12-10 10:03:34 +00:00
Tom Tung
dcf0aeb0a2 Bug 1474608 - P2 - Clear origin attributes data directly on cache2; r=asuth,michal,baku
Differential Revision: https://phabricator.services.mozilla.com/D34324

--HG--
extra : moz-landing-system : lando
2019-12-02 19:47:05 +00:00
Tom Tung
83eb41d14a Bug 1474608 - P1 - Clear origin attributes directly for deleteDataFromOriginAttributesPattern if it's possible; r=asuth,baku
The idea of this patch is to try to not use oberver mechanism as possible. To
achieve that, it introduces deleteByOriginAttributes() to cleaners. Different
from other methods, it would only be executed if it's implemented from a
cleaner.

It doesn't remove oberver mechanism entirely since some cleaners are still using
that for other deleteByXXX() functions. So, it only applies removing stuff to
PushService, QuotaManagerService, ServiceWorkerManager, nsPermissionManager,
nsApplicationCacheService, and nsCookieService.

Since the original issue is related to QuotaManagerService, it adds xpcshell
test under the dom/quota/test/unit/ to ensure the behavior won't be changed
accidentally in the future.

Differential Revision: https://phabricator.services.mozilla.com/D33758

--HG--
extra : moz-landing-system : lando
2019-12-02 19:47:13 +00:00
Matthew Noorenberghe
60e3f6a6e1 Bug 1596660 - Replace pwmgr storage-mozStorage with a stub storage-geckoview. r=sfoster
* storage-mozStorage was used by Fenenc but that is no longer built from m-c.
* Existing Android tests need to be disabled since they rely on being able to manipulate storage but this commit only stubs searching for logins.
* A later commit will actually filter the logins returned by a GV delegate.

Differential Revision: https://phabricator.services.mozilla.com/D54139

--HG--
rename : toolkit/components/passwordmgr/storage-json.js => toolkit/components/passwordmgr/storage-geckoview.js
extra : moz-landing-system : lando
2019-12-11 05:22:43 +00:00
Ehsan Akhgari
6216893099 Bug 1599237 - Add a cookie manager API for deleting cookies by a time range, and use it in the clear data service; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D54646

--HG--
extra : moz-landing-system : lando
2019-11-27 11:01:45 +00:00
Daniel Varga
f12c40c242 Backed out changeset afe80b4ff889 (bug 1595934) Requested by ehsan to see if it fixex bug 1597915. On a CLOSED TREE 2019-11-22 02:01:51 +02:00
Ehsan Akhgari
30cf316b38 Bug 1595934 - Make nsICookieManager cookie enumerators return Array<nsICookie> instead of nsISimpleEnumerator; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D52761

--HG--
extra : moz-landing-system : lando
2019-11-17 07:21:14 +00:00
Ehsan Akhgari
a8a01884db Bug 1591803 - Part 2: Rename nsIPermissionManager.enumerator to all and turn it into an Array; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D50753

--HG--
extra : moz-landing-system : lando
2019-10-29 01:56:25 +00:00
Arthur Iakab
9c93bb3a7a Backed out 2 changesets (bug 1591803) for causing build bustages on XULAlerts.cpp CLOSED TREE
Backed out changeset 7eff50262110 (bug 1591803)
Backed out changeset c0b6f37d24d2 (bug 1591803)
2019-10-29 03:37:07 +02:00
Ehsan Akhgari
8c1d9bf15d Bug 1591803 - Part 2: Rename nsIPermissionManager.enumerator to all and turn it into an Array; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D50753

--HG--
extra : moz-landing-system : lando
2019-10-28 20:26:21 +00:00
Arthur Iakab
470c5a07f1 Backed out 2 changesets (bug 1591803) for causing build busatges on PermissionManager.idl. CLOSED TREE
Backed out changeset 060f159fa43d (bug 1591803)
Backed out changeset b53a3d8c408d (bug 1591803)
2019-10-28 22:12:01 +02:00
Ehsan Akhgari
f7eef9ebc5 Bug 1591803 - Part 2: Rename nsIPermissionManager.enumerator to all and turn it into an Array; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D50753

--HG--
extra : moz-landing-system : lando
2019-10-28 13:55:56 +00:00
Gijs Kruitbosch
d579352ba8 Bug 1565998 - display a descriptive text for local file: related data, and allow removing it, r=johannh,fluent-reviewers,flod,baku
Differential Revision: https://phabricator.services.mozilla.com/D44832

--HG--
extra : moz-landing-system : lando
2019-10-02 11:42:53 +00:00
Tom Tung
c0f0ba97a7 Bug 1584986 - P2 - Rename listInitializedOrigins to listOrigins; r=asuth,johannh
Differential Revision: https://phabricator.services.mozilla.com/D47741

--HG--
rename : dom/quota/test/unit/test_listInitializedOrigins.js => dom/quota/test/unit/test_listOrigins.js
extra : moz-landing-system : lando
2019-10-02 07:57:52 +00:00
Oana Pop Rus
cb6253f70e Backed out 3 changesets (bug 1584986) for xpcshell failures in dom/quota/test/unit/test_listOrigins.js on a CLOSED TREE
Backed out changeset 8fc63769342e (bug 1584986)
Backed out changeset ec44603ce08a (bug 1584986)
Backed out changeset 0fc3d50b822e (bug 1584986)

--HG--
rename : dom/quota/test/unit/test_listOrigins.js => dom/quota/test/unit/test_listInitializedOrigins.js
2019-10-02 07:50:10 +03:00
Tom Tung
a9e251b07f Bug 1584986 - P2 - Rename listInitializedOrigins to listOrigins; r=asuth,johannh
Depends on D47740

Differential Revision: https://phabricator.services.mozilla.com/D47741

--HG--
rename : dom/quota/test/unit/test_listInitializedOrigins.js => dom/quota/test/unit/test_listOrigins.js
extra : moz-landing-system : lando
2019-10-01 13:29:52 +00:00
Sebastian Streich
2fbc46096e Bug 1580782 - Remove JS Callsites for Principal->GetURI->Schemeis r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D45685

--HG--
extra : moz-landing-system : lando
2019-09-26 10:47:33 +00:00
Paul Zuehlcke
a20be9ee64 Bug 1574469 - Removed block param from nsICookieManager::Remove. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D45848

--HG--
extra : moz-landing-system : lando
2019-09-24 17:13:43 +00:00
Oana Pop Rus
3144f81e55 Backed out changeset cb1b6afa9f33 (bug 1574469) for multiple failures in nsICookieManager.remove on a CLOSED TREE 2019-09-24 13:10:07 +03:00
Paul Zuehlcke
b7de7aec93 Bug 1574469 - Removed block param from nsICookieManager::Remove. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D45848

--HG--
extra : moz-landing-system : lando
2019-09-19 17:10:58 +00:00
Johann Hofmann
a95351130d Bug 1571234 - Change RemoveCookiesFromRootDomain to RemoveCookiesFromExactHost. r=baku
This will change RemoveCookiesFromRootDomain to not remove cookies from all sub-domains but instead
only remove the single host that is passed. This is necessary to support removing all sub-domain
cookie data in ForgetAboutSite without compromising on the cookie permissions that are supported by
Sanitizer.jsm

As a side effect, this also fixes the issues described in https://bugzilla.mozilla.org/show_bug.cgi?id=1515913#c24
(which were caused by deleting sub-domains without checking their permission).

Sanitizer.jsm should retain its functionality even with this change, because it already collects
all the principals we have to delete individually and tries to delete them (so it would consider
mozilla.org and support.mozilla.org separately).

Differential Revision: https://phabricator.services.mozilla.com/D45012

--HG--
extra : moz-landing-system : lando
2019-09-09 13:58:06 +00:00
Andrea Marchesini
16b47a442d Bug 1541344 - Delete plugin-data only for the sites with data,r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D40644

--HG--
extra : moz-landing-system : lando
2019-08-14 22:11:09 +00:00
Dana Keeler
18e9f3ba80 bug 1564481 - reset HSTS/HPKP state to factory settings rather than storing knockout entries for preloaded sites r=jcj r=KevinJacobs
As originally implemented, nsISiteSecurityService.removeState allowed direct
access to remove HSTS state. It also provided the implementation for when the
browser encountered an HSTS header with "max-age=0". In bug 775370, it was
updated to store an entry that would override preloaded information when
processing such headers. However, this meant that the semantics of the direct
access API had changed. Preloaded information could be overridden if a user
invoked the "forget about this site" feature. This change fixes the public API
(and renames it to "resetState") so it actually behaves as its consumers expect.

Reviewers: jcj!, KevinJacobs!

Tags: #secure-revision

Bug #: 1564481

Differential Revision: https://phabricator.services.mozilla.com/D38108

--HG--
extra : rebase_source : 8dd5460d3fd3c0ce92746cc83fae220d6e2a83cf
extra : amend_source : 171ebb015e9f9ae775f0caa22e161d41970f3d51
2019-07-11 13:48:28 -07:00
Jonathan Kingston
31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Victor Porof
4a06c925ac Bug 1561435 - Format toolkit/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36052

--HG--
extra : source : b5be5b4f4b47c256e28a29f665dc754f6407ee7f
2019-07-05 11:14:05 +02:00
Erica Wright
2c4d0c79fb Bug 1549830 - Create content blocking database. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D33716

--HG--
extra : moz-landing-system : lando
2019-06-21 22:45:47 +00:00
Nihanth Subramanya
c706261f70 Bug 1547015 - ClearDataService: Implement CertCleaner.deleteAll. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D32916

--HG--
extra : moz-landing-system : lando
2019-06-03 21:30:32 +00:00
Eugen Sawin
52bea1fda2 Bug 1553454 - [1.1] Only enable handling of CLEAR_HISTORY when Places is supported. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D32473

--HG--
extra : moz-landing-system : lando
2019-05-27 11:09:50 +00:00
Carolina
0a89a5c5a4 Bug 1541450 - Add a Certs cleaner and defines that object in FLAGS_MAP. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D27193

--HG--
extra : moz-landing-system : lando
2019-05-16 18:45:48 +00:00
Tom Tung
5a873324c6 Bug 1535298 - Capture and ignore the exception for not having a host from a principal URI; r=janv,johannh
Protocols, likes about:, moz-extension, ... etc, don't have a host. Thus, an
exception will be returned if they are accessed. To avoid from that, this patch
catches this bug a try-catch.

Differential Revision: https://phabricator.services.mozilla.com/D29821

--HG--
extra : moz-landing-system : lando
2019-05-14 16:49:03 +00:00
Johann Hofmann
8aaf3c05e3 Bug 1546296 - Correctly clear Service Workers by hostname. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30455

--HG--
extra : moz-landing-system : lando
2019-05-13 21:32:53 +00:00
Brindusan Cristian
cab8f31085 Backed out changeset dd551956b332 (bug 1546296) for bc failures at browser_serviceworkers.js. CLOSED TREE 2019-05-10 00:38:56 +03:00
Johann Hofmann
6a824f6608 Bug 1546296 - Correctly clear Service Workers by hostname. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30455

--HG--
extra : moz-landing-system : lando
2019-05-09 20:09:04 +00:00
Cosmin Sabou
8602101987 Backed out changeset 6abefa3e063b (bug 1541450) for xpcshell failures on test_certs.js. CLOSED TREE 2019-05-06 02:15:56 +03:00
Carolina Jimenez Gomez
f34fc8b3b1 Bug 1541450 - Add a Certs cleaner and defines that object in FLAGS_MAP. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D27193

--HG--
extra : moz-landing-system : lando
2019-05-05 20:12:24 +00:00
Dorel Luca
41e7361f98 Backed out changeset c5d2d999a8ab (bug 1541450) for XPCShell failures in toolkit/components/cleardata/tests/unit/test_certs.js 2019-04-26 05:22:24 +03:00
Carolina Jimenez Gomez
e219a42b30 Bug 1541450 - Add a Certs cleaner and defines that object in FLAGS_MAP. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D27193

--HG--
extra : moz-landing-system : lando
2019-04-25 17:03:50 +00:00
Andrea Marchesini
6f470dae23 Bug 1515913 - Implement nsICookieService.removeCookiesFromRootDomain, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D27289

--HG--
extra : moz-landing-system : lando
2019-04-12 20:27:21 +00:00
Johann Hofmann
cdc128ccbe Bug 1532203 - Implement deleteByHost for NetworkCacheCleaner and ImageCacheCleaner. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D23491

--HG--
extra : moz-landing-system : lando
2019-04-05 09:57:34 +00:00