Commit graph

509 commits

Author SHA1 Message Date
Zack Weinberg
1628ea1551 Bug 266236 part 9: Move nsBoundingMetrics to its own header and prune inclusions of nsRenderingContext.h.
--HG--
rename : gfx/src/nsThebesRenderingContext.cpp => gfx/src/nsRenderingContext.cpp
rename : gfx/src/nsThebesRenderingContext.h => gfx/src/nsRenderingContext.h
extra : rebase_source : 92660748436f03475e011184e2828f1db0ad63e0
2011-04-07 18:04:40 -07:00
Jan Küchler
c510bc3046 Bug 266236 part 3: Mechanical rename of nsIRenderingContext and nsThebesRenderingContext to nsRenderingContext. Mechanical substitution of nsRefPtr<nsRenderingContext> for nsCOMPtr<nsRenderingContext>.
--HG--
rename : gfx/src/nsThebesRenderingContext.cpp => gfx/src/nsRenderingContext.cpp
extra : rebase_source : 34884bfcafd885feaf73300bc7246cd192062a48
2011-04-07 18:04:40 -07:00
Josh Aas
daa6dd469a Bug 556873: Fix bugs in our secure input implementation for Mac OS X. More reliably enable and disable secure input mode. r=masayuki a=jst 2011-02-09 14:00:58 -05:00
Ehsan Akhgari
352289000d Bug 629878 - Followup to fix build bustage; a=bustage 2011-02-09 14:34:56 -05:00
Ehsan Akhgari
15bb64e5e7 Bug 629878 - Part 2: Do not scroll the selection into view when restoring the selection offsets for a text control after a reframe; r=roc a=blocking-final+
Previously, we used to scroll the text control's selection into view after a
reframe.  This had two problems: it was not precise (in case the selection was
modified by the mouse, for example), and it lead to problems such as bug 629878
if the control's frame was reconstructed because of the control being moved
inside the DOM.

This patch disables that behavior by wrapping the selection scroll function
into nsITextControlFrame::ScrollSelectionIntoView, so that APIs such as
setSelectionRange on the text control's content node can still call it
explicitly (since they actually need this behavior), but other callers of
nsITextControlFrame::SetSelectionRange (such as the nsTextEditorState
object's selection offset restoring mechanism) don't get this behavior as
an undesired side-effect.
2011-02-04 19:29:29 -05:00
Ehsan Akhgari
cb4cdacce5 Bug 629878 - Part 1: Save the scroll state for text controls the standard way; r=roc a=blocking-final+ 2011-02-04 18:28:38 -05:00
Mounir Lamouri
8b64a94dfa Bug 595310 - Drag and drop of text into an input field does not remove placeholder. r=ehsan,roc a=jst 2011-01-28 02:19:04 +01:00
Alexander Surkov
5029052452 Bug 628922 - layout should use cached nsIAccessibilityService, r=davidb, sr=roc, a=roc 2011-01-28 12:38:14 +08:00
Mats Palmgren
57bbf4a4e3 Bug 626014 - Deal with the frame being destroyed as a result of the flush in AddRange. r=ehsan a=blocking2.0:final 2011-01-18 18:40:38 +01:00
Ehsan Akhgari
71b50d62bf Bug 620936 followup - Switch to NS_MIN; r=joe a=DONTBUILD
--HG--
extra : rebase_source : 7594f27208efd71dd1ee290d2074fc224119b715
2011-01-11 12:10:47 -05:00
Ehsan Akhgari
aed6683683 Bug 620936 - setSelectionRange should not fail with offsets larger than the value of the editable field; r=roc a=blocking-betaN+ 2011-01-05 20:55:31 -05:00
Ehsan Akhgari
5dece71b0e Bug 527935 - Fire the input event for text controls with the correct trusted-ness status; r=roc a=blocking-final+ 2010-12-07 01:30:05 -05:00
Mounir Lamouri
d0c28d9134 Bug 615833 - Change event should not be cancelable. r=smaug a=sicking
--HG--
extra : rebase_source : a067989d8ce1297a9ed9869f931b64f33f2fed9f
2010-12-17 09:45:46 -08:00
Ehsan Akhgari
36cdf253ea Bug 612271 - Cursor jumps back to the end of the previous line after pressing enter at the end of a textarea managed by the jQuery autoResize plugin; r=roc a=blocking-betaN+ 2010-12-07 01:30:05 -05:00
Ehsan Akhgari
b20c5f8510 Bug 611189 - Parchment IF Reader Misbehaves; r=bzbarsky a=blocking-final+
This patch makes sure that we don't try to read the value from the editor if we haven't started to initialize the editor yet.
This ensures that the UpdateValueDisplay calls before we start to initialize the editor will always end up reading the value from the content node, and do not rely on the data returned by the editor, which might be stale.

--HG--
extra : rebase_source : e31be0ce21585f0f18eca3aa2d8e43d3646348e2
2010-11-22 03:12:56 -05:00
Ehsan Akhgari
7883671dc5 Bug 605138 - Scripts from topix.net apparently causing page to scroll down when opening; r=roc a=blocking-final+ 2010-10-21 16:56:20 -04:00
Ehsan Akhgari
115bd55a00 Bug 595337 - Crash [@ nsTextEditorState::InitializeKeyboardEventListeners] on print preview close with iframe, position:fixed and input; r=roc a=blocking-final+ 2010-09-24 15:09:25 -04:00
Mounir Lamouri
e457aa01ce Bug 553097 - Do not create a frame and DOM node for placeholder if not needed. r=ehsan,roc a=blocking 2010-10-19 15:11:07 +02:00
Alexander Surkov
7ca32694f5 Bug 604386 - Prune placeholder from text children, r=davidb, sr=bz, a=blocking 2010-10-16 00:34:35 +09:00
Ehsan Akhgari
f4d2ceae73 Bug 572649 - Attempting to scroll a textarea with a horizontal scrollbar using the mouse jumps to its bottom right (focusing a textarea with the mouse scrolls the selection into view); r=roc a=blocking-betaN+
--HG--
rename : layout/forms/test/test_bug353539.html => layout/forms/test/test_bug572649.html
2010-09-20 19:30:07 -04:00
Siddharth Agarwal
48afe97055 Back out bug 588712 and bug 595337 due to leaks and test failures. a=orange 2010-09-14 23:04:50 +05:30
Ehsan Akhgari
a0c782c046 Bug 595337 - Crash [@ nsTextEditorState::InitializeKeyboardEventListeners] on print preview close with iframe, position:fixed and input r,a=roc 2010-09-13 16:36:43 -04:00
Ehsan Akhgari
64b2f04816 Bug 240933 - Part 9: Simplify text control frame's DOM point to offset conversion code; r=roc a=dbaron
--HG--
extra : rebase_source : 1ed8187ad31ca40bd0b4d5a5a3c7494aacfee495
2010-07-20 08:47:28 -04:00
Ehsan Akhgari
d84bc18024 Back out bug 240933 and bug 590554 because of reftest failure on Win7 and also bug 593211 2010-09-02 19:54:23 -04:00
Ehsan Akhgari
58248ee66a Bug 240933 - Part 9: Simplify text control frame's DOM point to offset conversion code; r=roc a=dbaron
--HG--
extra : rebase_source : 134895e08a57c7aeb39f25266d8925cde4595159
2010-07-20 08:47:28 -04:00
Ehsan Akhgari
193ba9958c Bug 590302 - Crash [@ nsTextControlFrame::CalcIntrinsicSize] on print preview with textarea, position:fixed; r=roc a=blocking2.0:final+ 2010-08-25 01:44:18 -04:00
Mounir Lamouri
8473f691f3 Bug 568441 - Explicitely show the caret in nsTextControlFrame when the content is no longer disabled and focused. r=roc a2.0=blocking+ 2010-08-15 11:19:34 -04:00
David Zbarsky
170437618c Remove unneeded nsIDOMNSHTMLInputElement interface by merging it into nsIDOMHTMLInputElement. (Bug 582303) r=jst 2010-08-04 22:40:18 -04:00
Ehsan Akhgari
6ddaf2e6c3 Bug 578604 - Crash [@ nsTextControlFrame::SetInitialChildList(nsIAtom*, nsFrameList&) ] when print preview; r=roc a=blocking2.0+ 2010-08-04 22:13:57 -04:00
Ehsan Akhgari
48b4d58926 Bug 569397 - Eagerly initialize the input controls with spellcheck="true"; r=roc ui-r=faaborg approval2.0=benjamin 2010-06-02 22:39:29 -04:00
Mounir Lamouri
d55a633ca1 Bug 549475: Implement HTML5-specified value sanitization algorithm for HTMLInputElement. r=sicking,ehsan,bsmedberg sr=jst
--HG--
rename : layout/reftests/editor/newline-1.html => layout/reftests/editor/newline-4.html
2010-07-21 02:11:19 +02:00
Timothy Nikkel
1259443af7 Bug 563878. Part 5. Rename nsIFrame::GetWindow(Offset) to GetNearestWidget. r=mats 2010-07-02 14:11:04 -05:00
Ehsan Akhgari
6a92641501 Bug 574898 - "ASSERTION: called nsGenericElement::SetText" with spellcheck; r=roc 2010-06-28 14:04:37 -04:00
Alexander Surkov
65c355c8a7 Bug 573706 - make frame based accessible creation more pellucid, r=davidb, sr=roc 2010-06-28 21:02:03 +09:00
Ehsan Akhgari
d3e9d7a250 Bug 570624 - "ASSERTION: called nsGenericElement::SetText"; r=roc
--HG--
extra : rebase_source : 24d41a8eccef1c6d8b3adc6a04ca1a20912263ef
2010-06-09 14:14:42 -04:00
Ehsan Akhgari
6139ffb2b9 Bug 534785 - Move the ownership of editor and selection controller from the text frame to the content node; r=roc,jst sr=roc
(transplanted from 2437636244f39bbdc7d20b062e2c978b9d85c239)

--HG--
rename : layout/reftests/forms/placeholder/placeholder-14.html => layout/reftests/forms/placeholder/placeholder-18.html
extra : transplant_source : %247cbD%F3%9B%BD%C7%D2%0B%06.%2C%97%8B%9D%85%C29
2010-04-21 16:17:41 -04:00
Ehsan Akhgari
c9c8c3c5b3 Bug 336104 - "ASSERTION: no frame, see bug #188946"; r=roc,dbaron 2010-05-21 16:36:42 -04:00
Ehsan Akhgari
db9d404619 Bug 560647 - add startup timeline instrumentation; r=vlad 2010-05-19 19:22:19 -04:00
Mounir Lamouri
34bd1fda86 Bug 557620 - Implement <input type="tel">. r=smaug,dolske,dao sr=sicking 2010-05-12 09:17:07 +02:00
Ehsan Akhgari
30acd8031f Bug 564115 - activating the browser window scrolls the document (to show the focused text control); r=roc 2010-05-06 19:19:35 -04:00
Ehsan Akhgari
3f646139ab Bug 562447 - when navigating in gmail sometimes get a screen full of white; r=roc 2010-05-06 18:12:21 -04:00
Boris Zbarsky
8ccd3c1fea Bug 564574. Pass the first appended node to ContentAppended. r=jst, sr=sicking 2010-05-10 21:12:34 -04:00
Jonas Sicking
5d052b35df Bug 429175: Make sure to only set aNotify to true when we should. r=peterv 2010-05-03 06:23:36 -07:00
Ehsan Akhgari
c21291195b Bug 559710 - Don't add a br node under text controls when the editor is not initialized for them yet; r=roc,davidb a=1hr 2010-04-15 21:25:40 -04:00
Daniel Holbert
889648bb23 Bug 560271: Reorder nsTextControlFrame constructor init list to fix build warning. r=ehsan 2010-04-19 12:00:45 -07:00
Ehsan Akhgari
6533b66978 Bug 558954 - Don't show/hide placeholder if we're about to initialize the editor; r=roc 2010-04-12 20:32:29 -04:00
Ehsan Akhgari
18d931eb33 Bug 557689 - Mochitest-3 (debug) crash after running test_bug366682.html or test_selection_move_commands.xul as a result of bug 542919 [@ nsCOMPtr<nsIMutationObserver>::assign_with_AddRef] (underlying issue will be fixed in bug 534785); r=jrmuizel 2010-04-12 02:13:17 -04:00
Ehsan Akhgari
f3d9f778f5 Bug 221820 - Part 7: Wrap the calls to nsTextControlFrame::EnsureEditorInitialized in a weak frame check; r=roc 2010-04-06 16:44:46 -04:00
Ehsan Akhgari
d42f42731a Bug 221820 - Part 5: Make lazy editor initialization compatible with placeholder values; r=bzbarsky 2010-04-06 16:43:39 -04:00
Ehsan Akhgari
82c0a0f238 Bug 221820 - Part 4: Fix the newline handling for text fields without an editor; r=bzbarsky 2010-02-22 16:15:56 -08:00
Ehsan Akhgari
a7d5edaacc Bug 221820 - Part 3: Debug-only assertion for reentrancy detection; r=bzbarsky 2010-02-09 20:29:11 -05:00
Ehsan Akhgari
48c789f12e Bug 221820 - Part 2: Make the editor initialization lazy (initialize only when needed); r=bzbarsky 2010-02-02 10:49:55 -05:00
Ehsan Akhgari
347a6506d3 Bug 221820 - Part 1: Call EnsureEditorInitialized from all places where editor needs to exist; r=bzbarsky 2010-02-01 23:00:12 -05:00
Ehsan Akhgari
382ad60d6f Bug 542919 - Maintain the exact same behavior in editor initialization (don't try to set the editor value if the default value is empty) in an attempt to fix the crash of bug 557689 2010-04-11 16:00:36 -04:00
Ehsan Akhgari
0bbd9e77c9 Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc 2010-02-01 23:00:06 -05:00
Ehsan Akhgari
c51a6481a1 Back out the editor lazy inititialization patches (bug 221820) to try to solve the orange in bug 557689 2010-04-06 21:08:58 -04:00
Ehsan Akhgari
b096e7c504 Bug 221820 - Part 7: Wrap the calls to nsTextControlFrame::EnsureEditorInitialized in a weak frame check; r=roc
--HG--
extra : rebase_source : e8ea41dfa8e4b591e21176fb654f968671cc3ba1
2010-04-06 16:44:46 -04:00
Ehsan Akhgari
f4a336fb87 Bug 221820 - Part 5: Make lazy editor initialization compatible with placeholder values; r=bzbarsky
--HG--
extra : rebase_source : f7e1954482d34f5a229307ff7a6bc4fa527171ff
2010-04-06 16:43:39 -04:00
Ehsan Akhgari
380b7b208c Bug 221820 - Part 4: Fix the newline handling for text fields without an editor; r=bzbarsky
--HG--
extra : rebase_source : 92d9e491351a6183f0232604cd989c14d10d5fad
2010-02-22 16:15:56 -08:00
Ehsan Akhgari
a85b9fbf14 Bug 221820 - Part 3: Debug-only assertion for reentrancy detection; r=bzbarsky
--HG--
extra : rebase_source : 0b3e81c649178ebff2b08856f652a37be59d7547
2010-02-09 20:29:11 -05:00
Ehsan Akhgari
a5e3d44e9b Bug 221820 - Part 2: Make the editor initialization lazy (initialize only when needed); r=bzbarsky
--HG--
extra : rebase_source : bf84341934b14c78fadc162607721e9325673fc4
2010-02-02 10:49:55 -05:00
Ehsan Akhgari
64a3144e62 Bug 221820 - Part 1: Call EnsureEditorInitialized from all places where editor needs to exist; r=bzbarsky
--HG--
extra : rebase_source : 91df07eb7a6a52c35d8f4d52212663045450b95a
2010-02-01 23:00:12 -05:00
Ehsan Akhgari
3776d4f9f8 Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc
--HG--
extra : rebase_source : 9c043d3cb30420f061d543e11e3000a1f8e18e27
2010-02-01 23:00:06 -05:00
Craig Topper
c82a6bc194 Bug 253889: DeCOMtaminate nsIPresShell - GetCaret(). r=roc
--HG--
extra : rebase_source : 2a05050d8cbb10dd3bb763d5d5a158cc5f3dd814
2010-03-31 08:39:31 -04:00
Kyle Huey
5278cfe428 Backed out changeset 4b8936ac4a31 2010-03-30 19:56:44 -04:00
Craig Topper
61dba9a452 Bug 253889: More deCOMtamination of nsIPresShell. r=roc 2010-03-28 19:21:11 -04:00
Neil Deakin
3cbbbf8a1e Bug 543563, fix build error due to conflict with bug 544472 2010-03-18 16:45:29 -04:00
Neil Deakin
8f209c1ed5 Bug 543563, textarea in xul textbox doesn't take into account any assigned widths/heights, r=dbaron 2010-03-18 15:58:12 -04:00
Ehsan Akhgari
be4b7eb8dc Bug 353539 - textarea.focus() puts caret at end without scrolling it into view; r=roc
--HG--
extra : rebase_source : 775c2c16cfbb0ef9a9024dd53c42c803ee08e8ae
2010-03-18 12:14:40 -04:00
Ehsan Akhgari
52ec0ae2b2 Bug 231389 - Textarea scrolls to top after changing its .value, regardless of cursor position; r=roc
--HG--
extra : rebase_source : 01f1129bc5289c3b56d15a7965e647002a0b1198
2010-03-18 12:14:08 -04:00
Mounir Lamouri
6d0eda64c3 Bug 549208 - Dragging a text in an input/textarea element doesn't make the placeholder disappear; r=bzbarsky
--HG--
extra : rebase_source : 13dc342d24bef26815bda5ef9958cfcb11a68a10
2010-03-01 10:35:40 -08:00
Mounir Lamouri
4ac915c7e1 Bug 457800 - Implement placeholder attribute for text input fields; r=ehsan,bzbarsky,bolter sr=roc ui-r=faaborg
--HG--
extra : rebase_source : 2e2f3a73553d720b32812603b0ce96c89b9a6261
2010-02-26 10:47:38 -08:00
Alexander Surkov
f64a603fd3 Bug 534527 - Accessibility needs new DOM API part 2, r=smaug, sr=bz 2010-02-20 16:52:50 -08:00
Ehsan Akhgari
c0c8581846 Backed out changeset e6cf06cfcef9 2010-02-18 19:03:28 -05:00
Ehsan Akhgari
c67120ed70 Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc
--HG--
extra : rebase_source : 5c6baa16c4f3c91f8564cfdf394d70c8ea507861
2010-02-01 23:00:06 -05:00
Alexander Surkov
03b1de4b95 Bug 534527 - Accessibility needs new DOM API, r=olli.pettay, sr=roc 2010-02-12 01:34:01 +08:00
Olli Pettay
a229f20863 Bug 518122, improve textarea.value+= performance, r=bz 2010-02-07 21:44:32 +02:00
Robert O'Callahan
6a5cc88a0d Bug 526394. Part 18: Remove nsIScrollableViewProvider and its implementations, now that we've removed all its users. r=mats 2009-09-09 17:40:01 +12:00
Robert O'Callahan
cfa270791d Bug 526394. Part 17: Convert some selection-related code in nsTextControlFrame and nsSelection. r=mats 2009-09-03 17:23:47 +12:00
Robert O'Callahan
93b13a82be Bug 526394. Part 2: Remove pointless code in nsTextControlFrame, nsGfxScrollFrame handles this already. r=mats 2009-07-29 22:07:04 +12:00
fantasai
3027a2127b Bug 508473 part III: Pass destruction root to frame destruction methods r=bz sr=roc 2009-12-24 00:21:15 -05:00
fantasai
b8f6ad289d Bug 508473 Part I: Remove nsIFrame::RemovedAsPrimary r=bz sr=roc 2009-12-24 00:20:20 -05:00
Brad Lassey
0595320f20 bug 530367 - passwords from password manager flash in clear text r=neil 2009-11-25 12:41:23 -05:00
Mats Palmgren
3e79ed11b3 Bug 522787. Always register an editor observer. r=smaug 2009-11-19 12:38:11 +13:00
Boris Zbarsky
7717e0c2f4 Bug 259636. Don't do sync reflow when setting .value on text inputs. r=roc, sr=dbaron 2009-11-11 18:28:16 -05:00
Robert O'Callahan
3c44fac732 Bug 514660. Use classes instead of an explicit 'style' attribute to style the anonymous DIV of a text control, so that the styles are treated as user-agent styles and not removed when author styling is disabled. r=bzbarsky
--HG--
extra : rebase_source : 949e902529b2e0f48539d40141614038dfea0ea2
2009-09-23 23:02:27 +12:00
David Zbarsky
3d96b7b4a7 Bug 488249. Replace IsNodeOfType(eHTML) checks with namespace checks. r+sr=jst 2009-08-24 16:02:07 -04:00
Mats Palmgren
dea07412a1 Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc 2009-09-16 17:01:36 +02:00
Zack Weinberg
d47e0f433b Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc 2009-09-12 17:49:24 +01:00
Boris Zbarsky
8f435d226b Backed out changeset 4aa19414e651 (bug 488249) to fix test orange.
--HG--
extra : rebase_source : ae1c0155ec32b0887eff27ded77c6ba2b37dda64
2009-08-24 20:51:57 -04:00
David Zbarsky
0aa6350041 Bug 488249. Replace IsNodeOfType(eHTML) checks with namespace checks. r+sr=jst 2009-08-24 16:02:07 -04:00
Hashem Masoud
b71a1a1cfa Bug 489502 - Replace NS_ASSERTION(0, ...) by NS_ERROR(...) in mozilla-central; r=benjamin 2009-08-14 16:09:00 +02:00
Boris Zbarsky
1ef12b64a7 Bug 504221 part 12. Switch SetInitialChildList to nsFrameList. r=fantasai, r+sr=roc 2009-07-28 08:53:20 -04:00
Robert O'Callahan
45f0dccac6 Bug 495385. Text inputs should set the white-space style of the anonymous inner div when that div is created, not later when it will trigger a restyle. r+sr=bzbarsky
--HG--
extra : rebase_source : bef3008f365592d754039e74bac0b428a8c84794
2009-06-13 21:16:27 +12:00
Neil Deakin
15df29db77 Bug 178324, refactor focus by moving all focus handling into one place and simplifying it, add many tests, fixes many other bugs too numerous to mention in this small checkin comment, r=josh,smichaud,ere,dbaron,marco,neil,gavin,smaug,sr=smaug (CLOSED TREE) 2009-06-10 14:00:39 -04:00
Boris Zbarsky
b0eecf6115 Bug 492387. Flush out content notifications before initing our editor. r+sr=jst 2009-05-19 10:49:57 -04:00
Karl Tomlinson
3bbadcfb42 b=481751 block-height line-height for text input and strut baseline for textarea r=bz,sr=dbaron
--HG--
extra : rebase_source : 1241360066ea9387d15c71936da9468399240640
2009-05-19 10:13:12 +12:00
Boris Zbarsky
75b1d6d0f1 Bug 478219. Put a script blocker around delayed editor init. r+sr=sicking 2009-03-16 07:50:04 -04:00
Dão Gottwald
b0f2cdc142 Backed out changeset 12e163f4f272 2009-03-16 15:00:57 +01:00
Boris Zbarsky
1863ecc5d2 Bug 478219. Put a script blocker around delayed editor init. r+sr=sicking 2009-03-16 07:50:04 -04:00
Boris Zbarsky
f5a290d916 Bug 477700. Push a null JSContext around editor init, so it'll work no matter what JS is on the stack. r+sr=smaug 2009-02-16 09:11:41 -05:00
Boris Zbarsky
ff8ff59c94 Bug 335615. Don't do editor init inside frame construction. r=mats, sr=roc 2009-01-29 14:46:17 -05:00
Benjamin Smedberg
3498a5f86e Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Robert O'Callahan
1f1a970697 Bug 459613. When we tear down a textcontrol frame, tell its editor that we're blowing away the frame tree so it doesn't try to clear the spellcheck selection, which not only wastes time but does GetPrimaryFrame for during frame destruction which is a no-no. r+sr=mats 2008-12-12 21:34:43 +13:00
Markus Stange
1b2252f6c6 Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc 2008-11-04 15:38:16 +01:00
Benjamin Smedberg
7a0477cfbf Bug 461186 - nsTextControlFrame should not implement nsIPhonetic: there's only one caller, and that caller can use nsITextControlFrame directly. This is one less frame that implements an nsISupports-derived interface. r+sr=roc 2008-10-27 20:27:55 -04:00
Theppitak Karoonboonyanan
88e1b95b7b Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc 2008-10-16 20:44:32 +13:00
Mats Palmgren
0abae51687 Ignore the keypress event if DOMEventToNativeKeyEvent() fails. b=456273 r=Olli.Pettay sr=jonas 2008-10-15 12:50:42 +02:00
Taras Glek
ba02fffe86 bug 455536: s/NS_ERROR_FAILURE/NS_ERROR_OOM/ outparamdelled nsNodeInfoManager::GetNodeInfo r+sr=jsr 2008-09-25 15:46:52 -07:00
Arpad Borsos
87878e68eb Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie) 2008-09-15 17:40:25 +02:00
Taras Glek
74132a5585 bug 450777:deCOMtaminate nsNodeInfoManager::GetNodeInfo r+sr=jst 2008-09-12 15:32:18 -07:00
Mats Palmgren
8534784f1c Bug 446663. Make sure that if the user is typing in a text input its text input listener will get the events (so that undo/redo work and oninput is fired). 2008-07-31 17:34:11 -07:00
Zack Weinberg
a1072e86a3 Delete nsLayoutUtils::GetAbsoluteCoord(); fold logic into callers and simplify. (Bug 437335) r+sr=dbaron 2008-07-17 16:37:12 -07:00
John Daniels
b006229ae6 Bug 419532 – deCOMtaminate nsICaret. r+sr=roc 2008-07-16 12:52:01 +02:00
neil@parkwaycc.co.uk
64491786fd Bug 444466 – Crash [@ nsTextControlFrame::PreDestroy()], r+sr=bz 2008-07-12 11:26:40 +02:00
jst@mozilla.org
4b69a276d4 Landing fix for bug 419716. Make us consistently deal how we're pass param tags to object tags when parsing XHTML. Patch by mrbkap@gmail.com and bent.mozilla@gmail.com, r+sr=jonas@sicking.cc, a=beltzner 2008-04-17 15:30:51 -07:00
dbaron@dbaron.org
4589e85ab3 Backout bug 157546 (making the delete key delete by clusters) to fix blockers bug 419217 and bug 419406. Instead of removing the added test, mark now-failing tests as todo. a=damons 2008-04-14 18:04:18 -07:00
roc+@cs.cmu.edu
0a70ba3e53 Bug 425253. Propagate reflow-depth tracking through XUL box layout. r+sr=dbaron,a=damon 2008-04-09 21:39:41 -07:00
reed@reedloden.com
3ada7e2c40 Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+] 2008-04-08 11:52:48 -07:00
timeless@mozdev.org
b0e4df4591 Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-04-06 05:28:34 -07:00
mats.palmgren@bredband.net
747c16c7c6 Disconnect the frame selection object from the pres shell earlier. b=421083 r+sr=roc a1.9=beltzner 2008-04-02 19:42:20 -07:00
masayuki@d-toybox.com
2a69e80bd1 Bug 424989 Cannot use reconversion of IMEs from system menu at the focus being on textarea r+sr=roc, b1.9=jonas 2008-03-29 12:38:05 -07:00
timeless@mozdev.org
7f880e43ef reverting, wrong patch, missing AMBIGUOUS 2008-03-19 14:55:22 -07:00
timeless@mozdev.org
022712406a Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-03-19 14:19:35 -07:00
masayuki@d-toybox.com
1c98c2e245 Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) (retry) r+sr=roc, a1.9b4=beltzner 2008-02-28 07:28:37 -08:00
masayuki@d-toybox.com
076b8bba8e backing out the previous patch, becaused qm-centos5-01 dep unit test is orange 2008-02-28 05:59:25 -08:00
masayuki@d-toybox.com
600836e7ed Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) r+sr=roc, a1.9b4=beltzner 2008-02-28 03:01:56 -08:00
roc+@cs.cmu.edu
709741beff Bug 157546. 'Delete' key should delete entire cluster. patch by Theppitak Karoonboonyanan, r+sr=roc,a=schrep 2008-02-21 18:24:04 -08:00
reed@reedloden.com
36a557fc04 Back out patch from Theppitak Karoonboonyanan in bug 157546 due to test failures. 2008-02-20 03:10:16 -08:00
reed@reedloden.com
61f93061b0 Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=schrep] 2008-02-20 02:19:31 -08:00
reed@reedloden.com
2eddcd6e28 Back out Theppitak Karoonboonyanan's patch from bug 157546 due to a regression (bug 417745). 2008-02-15 12:20:55 -08:00
reed@reedloden.com
636da4197c Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=beltzner] 2008-02-14 21:30:34 -08:00
neil@parkwaycc.co.uk
b22e83627e Make XUL elements really native anonymous b=410119 r=smaug sr+a=sicking 2008-01-04 03:24:41 -08:00
reed@reedloden.com
58044dcad7 Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart] 2007-12-29 12:43:27 -08:00
reed@reedloden.com
27a55e7707 Back out patch from bug 406047, as it is causing orange on Linux and Tp regression on Mac. 2007-12-14 00:55:08 -08:00
reed@reedloden.com
71fe589716 Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart] 2007-12-13 23:20:32 -08:00
Olli.Pettay@helsinki.fi
a0a74f16e7 Bug 368760, r=mats, sr=roc, a=blocking1.9+ 2007-11-22 12:47:33 -08:00
Olli.Pettay@helsinki.fi
7a162df868 Bug 388558, 'change' event isn't dispatched if user selects input field value from the autocomplete list, r=jst, sr=sicking, a=mconnor 2007-10-02 09:56:07 -07:00
joshmoz@gmail.com
a91716eeae extra measure of security for password textfields on Mac OS X. b=394107 r=smorgan sr=roc 2007-09-27 09:01:32 -07:00
bzbarsky@mit.edu
ee74eef160 Only update the select command for focused text inputs. Bug 394792, r=roc, sr=neil, a=roc 2007-09-14 15:33:40 -07:00
bzbarsky@mit.edu
ddcdc2b80d Make maxlength not affect initial values or scripted sets. Bug 345267, r+sr=mats, a=dbaron 2007-08-21 20:22:21 -07:00
bzbarsky@mit.edu
4a0892e86f Make auto-height abs-pos textfields with top and bottom offsets both set use their intrinsic height, per spec. Bug 385870, r+sr+a=dbaron 2007-08-21 20:07:25 -07:00
bzbarsky@mit.edu
77efa38741 Account for the padding on our anonymous div when sizing. Bug 388086, r+sr+a=dbaron 2007-08-02 15:06:00 -07:00
bzbarsky@mit.edu
bea1e960d8 Avoid doing some work when initializing textfields. Bug 221150, patch by
peterv and a little bit me, r=me, sr=roc
2007-07-24 17:11:22 -07:00
Olli.Pettay@helsinki.fi
076594c97a Bug 355367, textbox onchange doesn't fire if user tabs out and value changed in onkeydown, r=jst, sr=sicking 2007-07-20 16:19:19 -07:00
mrbkap@gmail.com
cf72287e8c Backing out this change to see if it fixes the test failures. 2007-07-09 16:05:44 -07:00
mrbkap@gmail.com
bc4b050f93 Attempt to re-enable async reflow and painting in editor. bug 174823, r+sr=roc 2007-07-09 14:55:18 -07:00
jwalden@mit.edu
6d7584839a Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00