This simply removes the content blocking section when TP is not enabled to avoid overpromising.
We may update this UI to alert the user that TP is off after the UX team comes back with a new design.
Differential Revision: https://phabricator.services.mozilla.com/D10071
--HG--
extra : rebase_source : 6cf70948a142309edf06da3a53874bde2d7372e5
This makes the about:privatebrowsing display "Content Blocking" instead
of "Tracking Protection" and makes the toggle flip the TP setting for PB
mode as well as the CB pref if it's turned off.
Differential Revision: https://phabricator.services.mozilla.com/D4395
--HG--
extra : moz-landing-system : lando
There are 3 issues here:
- the runtime changing of the title causes issues where the content title is
not set. This is fixed by setting it to the private title by default;
there is very little (if any) UI that allows users to even open
about:privatebrowsing in 'normal' windows so we care a lot less about
flicker there. To be able to include this title in the markup, we switched
to a dtd.
- the 'empty tab' title we set on the tab initially is set when the tab is
created. This has been updated to check for private windows, and default to
'Private Browsing' instead. This will obviously also affect other new tabs
in private browsing, but that seems desirable/consistent.
- Likewise, we use this title when updating a tab's title that we don't yet
have a content title for (which can still happen while about:privatebrowsing
is loading because e10s), and so that is updated, too.
MozReview-Commit-ID: nVfXD2M6UZ
--HG--
extra : rebase_source : e5a698da70f215d8c7ccca242fbddc0fcaf9bf6b
There are 3 issues here:
- the runtime changing of the title causes issues where the content title is
not set. This is fixed by setting it to the private title by default;
there is very little (if any) UI that allows users to even open
about:privatebrowsing in 'normal' windows so we care a lot less about
flicker there. To be able to include this title in the markup, we switched
to a dtd.
- the 'empty tab' title we set on the tab initially is set when the tab is
created. This has been updated to check for private windows, and default to
'Private Browsing' instead. This will obviously also affect other new tabs
in private browsing, but that seems desirable/consistent.
- Likewise, we use this title when updating a tab's title that we don't yet
have a content title for (which can still happen while about:privatebrowsing
is loading because e10s), and so that is updated, too.
MozReview-Commit-ID: nVfXD2M6UZ
--HG--
extra : rebase_source : 8bd41f1581213b77e1fabced7fc4021ab4cf4d17
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <