Commit graph

25 commits

Author SHA1 Message Date
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Johann Hofmann
69b829d9b9 Bug 1483440 - Part 2 - Don't use purge-domain-data to clear session history for a domain. r=mikedeboer,baku
Differential Revision: https://phabricator.services.mozilla.com/D16461

--HG--
extra : moz-landing-system : lando
2019-01-17 17:41:23 +00:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Brendan Dahl
8a6f97c45c Bug 1442302 - Remove placesOverlay.xul. r=Gijs,mak,standard8
The overlay was responsible for script loading and defining three elements
(bhTooltip, placesCommands, placesContext). In the majority of places where
the overlay was included only part of it was used. To remove the overlay, the
elements were each split into include files and moved into where they
were used. For the scripts, a JS file was added that defines all the lazy
modules and then this script, globalOverlay.js and utilityOverlay.js were
inlined to everywhere that would have included them from the overlay.

MozReview-Commit-ID: 8T5D46oYWLn

--HG--
rename : browser/components/places/content/placesOverlay.xul => browser/components/places/content/placesCommands.inc.xul
rename : browser/components/places/content/placesOverlay.xul => browser/components/places/content/placesContextMenu.inc.xul
extra : rebase_source : c1071af4ea264a95183cbc65caae98feb23d58e5
2018-03-12 10:43:35 -07:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Mike Conley
e80d1e033b Bug 1351677 - Fix a race in browser_394759_purge.js. r=mikedeboer
MozReview-Commit-ID: J1z8Y5Zbwgz

--HG--
extra : rebase_source : 31cbee03b926e60f914ad2f9914ebd9bd6953c4f
2017-04-04 16:02:06 -04:00
milindl
6109edd9bd Bug 1247201 - yield on tests using removeDataFromDomain,r=mak
This changeset changes tests using ForgetAboutSite.removeDataFromDomain
to yield on it, since now it is a Task

MozReview-Commit-ID: 72OEYoO1avd

--HG--
extra : rebase_source : 9ea8cc06493c3e965d260dc9377461ff29fe572a
2017-03-17 14:29:48 +05:30
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Mark Banner
4acba13973 Bug 1311347 - Enable eslint of browser/components/sessionstore/. Autofix changes. r=jaws
MozReview-Commit-ID: 5LKHbcmjSy

--HG--
extra : rebase_source : d7e4571dae5c5770c7908579d7634419382d78e2
2017-03-10 19:51:20 +00:00
Christoph Kerschbaumer
af33c277b4 Bug 1307736 - Ensure tests performing a history load pass valid triggeringPrincipal. r=bz,mdeboer 2017-01-27 11:19:45 +01:00
Tooru Fujisawa
9d0fd651c5 Bug 1207491 - Part 16: Remove use of expression closure from browser/components/sessionstore/. r=Gijs
--HG--
extra : commitid : E1komPTv4xq
extra : rebase_source : 0111c79e4ae92aa92095659ed3539a6a69a04e31
2015-09-23 18:36:23 +09:00
Felipe Gomes
c555edbfa0 Bug 850210 - Part 1. Update ForgetAboutSite.jsm to use the nsIContentPrefService2 API. r=adw 2013-03-29 23:08:46 -03:00
Ehsan Akhgari
a18f92c2f3 Bug 799126 - Rename ClearRecentHistory to ForgetAboutSite; r=jdm
--HG--
rename : browser/components/privatebrowsing/src/ClearRecentHistory.jsm => browser/components/privatebrowsing/src/ForgetAboutSite.jsm
2012-10-08 11:55:41 -04:00
Ehsan Akhgari
a76261fade Bug 774963 - Remove removeDataFromDomain from nsIPrivateBrowsingService, and put it in its own JS module, ClearRecentHistory; r=jdm 2012-10-03 11:29:10 -04:00
Tim Taubert
94ec7ae1dc Bug 664324 - [session restore cleanup] Remove trailing whitespace; r=zpao 2012-05-25 23:39:22 +02:00
Gervase Markham
82ff7027aa Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Ed Morley
d052ca001a Bug 692625 - Move browser/components/sessionstore/test/browser/ to browser/components/sessionstore/test/; r=gavin
--HG--
rename : browser/components/sessionstore/test/browser/Makefile.in => browser/components/sessionstore/test/Makefile.in
rename : browser/components/sessionstore/test/browser/browser_248970_a.js => browser/components/sessionstore/test/browser_248970_a.js
rename : browser/components/sessionstore/test/browser/browser_248970_b.js => browser/components/sessionstore/test/browser_248970_b.js
rename : browser/components/sessionstore/test/browser/browser_248970_b_sample.html => browser/components/sessionstore/test/browser_248970_b_sample.html
rename : browser/components/sessionstore/test/browser/browser_339445.js => browser/components/sessionstore/test/browser_339445.js
rename : browser/components/sessionstore/test/browser/browser_339445_sample.html => browser/components/sessionstore/test/browser_339445_sample.html
rename : browser/components/sessionstore/test/browser/browser_345898.js => browser/components/sessionstore/test/browser_345898.js
rename : browser/components/sessionstore/test/browser/browser_346337.js => browser/components/sessionstore/test/browser_346337.js
rename : browser/components/sessionstore/test/browser/browser_346337_sample.html => browser/components/sessionstore/test/browser_346337_sample.html
rename : browser/components/sessionstore/test/browser/browser_350525.js => browser/components/sessionstore/test/browser_350525.js
rename : browser/components/sessionstore/test/browser/browser_354894.js => browser/components/sessionstore/test/browser_354894.js
rename : browser/components/sessionstore/test/browser/browser_367052.js => browser/components/sessionstore/test/browser_367052.js
rename : browser/components/sessionstore/test/browser/browser_393716.js => browser/components/sessionstore/test/browser_393716.js
rename : browser/components/sessionstore/test/browser/browser_394759_basic.js => browser/components/sessionstore/test/browser_394759_basic.js
rename : browser/components/sessionstore/test/browser/browser_394759_behavior.js => browser/components/sessionstore/test/browser_394759_behavior.js
rename : browser/components/sessionstore/test/browser/browser_394759_privatebrowsing.js => browser/components/sessionstore/test/browser_394759_privatebrowsing.js
rename : browser/components/sessionstore/test/browser/browser_394759_purge.js => browser/components/sessionstore/test/browser_394759_purge.js
rename : browser/components/sessionstore/test/browser/browser_408470.js => browser/components/sessionstore/test/browser_408470.js
rename : browser/components/sessionstore/test/browser/browser_408470_sample.html => browser/components/sessionstore/test/browser_408470_sample.html
rename : browser/components/sessionstore/test/browser/browser_423132.js => browser/components/sessionstore/test/browser_423132.js
rename : browser/components/sessionstore/test/browser/browser_423132_sample.html => browser/components/sessionstore/test/browser_423132_sample.html
rename : browser/components/sessionstore/test/browser/browser_447951.js => browser/components/sessionstore/test/browser_447951.js
rename : browser/components/sessionstore/test/browser/browser_447951_sample.html => browser/components/sessionstore/test/browser_447951_sample.html
rename : browser/components/sessionstore/test/browser/browser_448741.js => browser/components/sessionstore/test/browser_448741.js
rename : browser/components/sessionstore/test/browser/browser_454908.js => browser/components/sessionstore/test/browser_454908.js
rename : browser/components/sessionstore/test/browser/browser_454908_sample.html => browser/components/sessionstore/test/browser_454908_sample.html
rename : browser/components/sessionstore/test/browser/browser_456342.js => browser/components/sessionstore/test/browser_456342.js
rename : browser/components/sessionstore/test/browser/browser_456342_sample.xhtml => browser/components/sessionstore/test/browser_456342_sample.xhtml
rename : browser/components/sessionstore/test/browser/browser_459906.js => browser/components/sessionstore/test/browser_459906.js
rename : browser/components/sessionstore/test/browser/browser_459906_empty.html => browser/components/sessionstore/test/browser_459906_empty.html
rename : browser/components/sessionstore/test/browser/browser_459906_sample.html => browser/components/sessionstore/test/browser_459906_sample.html
rename : browser/components/sessionstore/test/browser/browser_461634.js => browser/components/sessionstore/test/browser_461634.js
rename : browser/components/sessionstore/test/browser/browser_461743.js => browser/components/sessionstore/test/browser_461743.js
rename : browser/components/sessionstore/test/browser/browser_461743_sample.html => browser/components/sessionstore/test/browser_461743_sample.html
rename : browser/components/sessionstore/test/browser/browser_463205.js => browser/components/sessionstore/test/browser_463205.js
rename : browser/components/sessionstore/test/browser/browser_463205_helper.html => browser/components/sessionstore/test/browser_463205_helper.html
rename : browser/components/sessionstore/test/browser/browser_463205_sample.html => browser/components/sessionstore/test/browser_463205_sample.html
rename : browser/components/sessionstore/test/browser/browser_463206.js => browser/components/sessionstore/test/browser_463206.js
rename : browser/components/sessionstore/test/browser/browser_463206_sample.html => browser/components/sessionstore/test/browser_463206_sample.html
rename : browser/components/sessionstore/test/browser/browser_464199.js => browser/components/sessionstore/test/browser_464199.js
rename : browser/components/sessionstore/test/browser/browser_464620_a.html => browser/components/sessionstore/test/browser_464620_a.html
rename : browser/components/sessionstore/test/browser/browser_464620_a.js => browser/components/sessionstore/test/browser_464620_a.js
rename : browser/components/sessionstore/test/browser/browser_464620_b.html => browser/components/sessionstore/test/browser_464620_b.html
rename : browser/components/sessionstore/test/browser/browser_464620_b.js => browser/components/sessionstore/test/browser_464620_b.js
rename : browser/components/sessionstore/test/browser/browser_464620_xd.html => browser/components/sessionstore/test/browser_464620_xd.html
rename : browser/components/sessionstore/test/browser/browser_465215.js => browser/components/sessionstore/test/browser_465215.js
rename : browser/components/sessionstore/test/browser/browser_465223.js => browser/components/sessionstore/test/browser_465223.js
rename : browser/components/sessionstore/test/browser/browser_466937.js => browser/components/sessionstore/test/browser_466937.js
rename : browser/components/sessionstore/test/browser/browser_466937_sample.html => browser/components/sessionstore/test/browser_466937_sample.html
rename : browser/components/sessionstore/test/browser/browser_467409-backslashplosion.js => browser/components/sessionstore/test/browser_467409-backslashplosion.js
rename : browser/components/sessionstore/test/browser/browser_477657.js => browser/components/sessionstore/test/browser_477657.js
rename : browser/components/sessionstore/test/browser/browser_480148.js => browser/components/sessionstore/test/browser_480148.js
rename : browser/components/sessionstore/test/browser/browser_480893.js => browser/components/sessionstore/test/browser_480893.js
rename : browser/components/sessionstore/test/browser/browser_483330.js => browser/components/sessionstore/test/browser_483330.js
rename : browser/components/sessionstore/test/browser/browser_485482.js => browser/components/sessionstore/test/browser_485482.js
rename : browser/components/sessionstore/test/browser/browser_485482_sample.html => browser/components/sessionstore/test/browser_485482_sample.html
rename : browser/components/sessionstore/test/browser/browser_485563.js => browser/components/sessionstore/test/browser_485563.js
rename : browser/components/sessionstore/test/browser/browser_490040.js => browser/components/sessionstore/test/browser_490040.js
rename : browser/components/sessionstore/test/browser/browser_491168.js => browser/components/sessionstore/test/browser_491168.js
rename : browser/components/sessionstore/test/browser/browser_491577.js => browser/components/sessionstore/test/browser_491577.js
rename : browser/components/sessionstore/test/browser/browser_493467.js => browser/components/sessionstore/test/browser_493467.js
rename : browser/components/sessionstore/test/browser/browser_495495.js => browser/components/sessionstore/test/browser_495495.js
rename : browser/components/sessionstore/test/browser/browser_500328.js => browser/components/sessionstore/test/browser_500328.js
rename : browser/components/sessionstore/test/browser/browser_506482.js => browser/components/sessionstore/test/browser_506482.js
rename : browser/components/sessionstore/test/browser/browser_514751.js => browser/components/sessionstore/test/browser_514751.js
rename : browser/components/sessionstore/test/browser/browser_522375.js => browser/components/sessionstore/test/browser_522375.js
rename : browser/components/sessionstore/test/browser/browser_522545.js => browser/components/sessionstore/test/browser_522545.js
rename : browser/components/sessionstore/test/browser/browser_524745.js => browser/components/sessionstore/test/browser_524745.js
rename : browser/components/sessionstore/test/browser/browser_526613.js => browser/components/sessionstore/test/browser_526613.js
rename : browser/components/sessionstore/test/browser/browser_528776.js => browser/components/sessionstore/test/browser_528776.js
rename : browser/components/sessionstore/test/browser/browser_579868.js => browser/components/sessionstore/test/browser_579868.js
rename : browser/components/sessionstore/test/browser/browser_579879.js => browser/components/sessionstore/test/browser_579879.js
rename : browser/components/sessionstore/test/browser/browser_580512.js => browser/components/sessionstore/test/browser_580512.js
rename : browser/components/sessionstore/test/browser/browser_581593.js => browser/components/sessionstore/test/browser_581593.js
rename : browser/components/sessionstore/test/browser/browser_581937.js => browser/components/sessionstore/test/browser_581937.js
rename : browser/components/sessionstore/test/browser/browser_586068-cascaded_restore.js => browser/components/sessionstore/test/browser_586068-cascaded_restore.js
rename : browser/components/sessionstore/test/browser/browser_586147.js => browser/components/sessionstore/test/browser_586147.js
rename : browser/components/sessionstore/test/browser/browser_588426.js => browser/components/sessionstore/test/browser_588426.js
rename : browser/components/sessionstore/test/browser/browser_589246.js => browser/components/sessionstore/test/browser_589246.js
rename : browser/components/sessionstore/test/browser/browser_590268.js => browser/components/sessionstore/test/browser_590268.js
rename : browser/components/sessionstore/test/browser/browser_590563.js => browser/components/sessionstore/test/browser_590563.js
rename : browser/components/sessionstore/test/browser/browser_595601-restore_hidden.js => browser/components/sessionstore/test/browser_595601-restore_hidden.js
rename : browser/components/sessionstore/test/browser/browser_597071.js => browser/components/sessionstore/test/browser_597071.js
rename : browser/components/sessionstore/test/browser/browser_597315.js => browser/components/sessionstore/test/browser_597315.js
rename : browser/components/sessionstore/test/browser/browser_597315_a.html => browser/components/sessionstore/test/browser_597315_a.html
rename : browser/components/sessionstore/test/browser/browser_597315_b.html => browser/components/sessionstore/test/browser_597315_b.html
rename : browser/components/sessionstore/test/browser/browser_597315_c.html => browser/components/sessionstore/test/browser_597315_c.html
rename : browser/components/sessionstore/test/browser/browser_597315_c1.html => browser/components/sessionstore/test/browser_597315_c1.html
rename : browser/components/sessionstore/test/browser/browser_597315_c2.html => browser/components/sessionstore/test/browser_597315_c2.html
rename : browser/components/sessionstore/test/browser/browser_597315_index.html => browser/components/sessionstore/test/browser_597315_index.html
rename : browser/components/sessionstore/test/browser/browser_599909.js => browser/components/sessionstore/test/browser_599909.js
rename : browser/components/sessionstore/test/browser/browser_600545.js => browser/components/sessionstore/test/browser_600545.js
rename : browser/components/sessionstore/test/browser/browser_601955.js => browser/components/sessionstore/test/browser_601955.js
rename : browser/components/sessionstore/test/browser/browser_607016.js => browser/components/sessionstore/test/browser_607016.js
rename : browser/components/sessionstore/test/browser/browser_615394-SSWindowState_events.js => browser/components/sessionstore/test/browser_615394-SSWindowState_events.js
rename : browser/components/sessionstore/test/browser/browser_618151.js => browser/components/sessionstore/test/browser_618151.js
rename : browser/components/sessionstore/test/browser/browser_623779.js => browser/components/sessionstore/test/browser_623779.js
rename : browser/components/sessionstore/test/browser/browser_624727.js => browser/components/sessionstore/test/browser_624727.js
rename : browser/components/sessionstore/test/browser/browser_625016.js => browser/components/sessionstore/test/browser_625016.js
rename : browser/components/sessionstore/test/browser/browser_625257.js => browser/components/sessionstore/test/browser_625257.js
rename : browser/components/sessionstore/test/browser/browser_628270.js => browser/components/sessionstore/test/browser_628270.js
rename : browser/components/sessionstore/test/browser/browser_635418.js => browser/components/sessionstore/test/browser_635418.js
rename : browser/components/sessionstore/test/browser/browser_636279.js => browser/components/sessionstore/test/browser_636279.js
rename : browser/components/sessionstore/test/browser/browser_644409-scratchpads.js => browser/components/sessionstore/test/browser_644409-scratchpads.js
rename : browser/components/sessionstore/test/browser/browser_645428.js => browser/components/sessionstore/test/browser_645428.js
rename : browser/components/sessionstore/test/browser/browser_659591.js => browser/components/sessionstore/test/browser_659591.js
rename : browser/components/sessionstore/test/browser/browser_662812.js => browser/components/sessionstore/test/browser_662812.js
rename : browser/components/sessionstore/test/browser/browser_665702-state_session.js => browser/components/sessionstore/test/browser_665702-state_session.js
rename : browser/components/sessionstore/test/browser/browser_682507.js => browser/components/sessionstore/test/browser_682507.js
rename : browser/components/sessionstore/test/browser/browser_687710.js => browser/components/sessionstore/test/browser_687710.js
rename : browser/components/sessionstore/test/browser/browser_687710_2.js => browser/components/sessionstore/test/browser_687710_2.js
rename : browser/components/sessionstore/test/browser/browser_694378.js => browser/components/sessionstore/test/browser_694378.js
rename : browser/components/sessionstore/test/browser/browser_705597.js => browser/components/sessionstore/test/browser_705597.js
rename : browser/components/sessionstore/test/browser/browser_form_restore_events.js => browser/components/sessionstore/test/browser_form_restore_events.js
rename : browser/components/sessionstore/test/browser/browser_form_restore_events_sample.html => browser/components/sessionstore/test/browser_form_restore_events_sample.html
rename : browser/components/sessionstore/test/browser/head.js => browser/components/sessionstore/test/head.js
2011-12-16 09:11:21 +00:00
Renamed from browser/components/sessionstore/test/browser/browser_394759_purge.js (Browse further)