Commit graph

44 commits

Author SHA1 Message Date
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Carol Ng
0f895bd54e Bug 1417577 - Support locale direction changes in sync sidebar r=eoger,gandalf
MozReview-Commit-ID: 2pHSjoOhW9o

--HG--
extra : rebase_source : bf6c483413994c279fbcb762c3305f4dcf8f703a
2018-05-30 14:12:24 -04:00
Brindusan Cristian
fc99ada428 Backed out changeset 3cb69bac2eac (bug 1417577) at eoger's request. 2018-05-30 01:39:37 +03:00
Carol Ng
ad9f7a1fa4 Bug 1417577 - Support intl.uidirection pref in sync sidebar r=eoger
MozReview-Commit-ID: HumZg9nGZtW

--HG--
extra : rebase_source : e325b0b2ae1472676898d9425cfb1c0432580d18
2018-05-29 15:24:30 -04:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Edouard Oger
0bbfe533cc Bug 1439194 - Implement a separate state for login failed in the sidebar. r=markh
MozReview-Commit-ID: B9hY8mpPEMw

--HG--
extra : rebase_source : 57f888e59506d3e88655fd0b30fe66b13a633291
2018-02-20 09:58:05 +08:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Edouard Oger
7fabe73930 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : c2b534461715f8db1e6cb8bc7910311cc4ff6611
2017-11-30 16:01:40 -05:00
Edouard Oger
6c2f09959a Bug 1421905 - Listen to service start notification in Synced Tabs sidebar. r=markh
MozReview-Commit-ID: JE1U1ZFFq99

--HG--
extra : rebase_source : 02dcf490fdb49725c6bdb4ceae76f3844ee34ef1
2017-11-30 11:29:18 -05:00
Dorel Luca
171c255f60 Backed out changeset 1ca98c1618a6 (bug 1422106) for failing browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE 2017-12-02 02:37:38 +02:00
Edouard Oger
afb8b81041 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : 747637f3746356e3da208acc41a3629bd2597e2e
2017-11-30 16:01:40 -05:00
Dorel Luca
e07748b33c Backed out changeset 3aff028846c0 (bug 1422106) for failing syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js and browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE
--HG--
extra : rebase_source : ec98a160ef77f13abc4b067f8836e290e3b11e21
2017-12-02 00:33:41 +02:00
Edouard Oger
2a41681065 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : b1471e1ef0163b2d3b137852d285146f5a23f1fa
2017-11-30 16:01:40 -05:00
Edouard Oger
ae62aef149 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
MozReview-Commit-ID: 5vBKH9NejVV

--HG--
extra : rebase_source : c160a5a1d7753d41c7afec3a822aefa9461684e6
2017-11-17 16:48:17 -05:00
Noemi Erli
e5e82c8496 Backed out changeset 932a77d8fbae (bug 1418466) for ES failures in /builds/worker/checkouts/gecko/browser/base/content/browser-sync.js r=backout on a CLOSED TREE 2017-11-30 18:44:16 +02:00
Edouard Oger
016b5734e5 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
MozReview-Commit-ID: 5vBKH9NejVV

--HG--
extra : rebase_source : e8628aba338b19142dc63add9bb380042096053f
2017-11-17 16:48:17 -05:00
Edouard Oger
c5d46f4966 Bug 1417520 p1 - Show message to unverified users in synced tabs sidebar. r=markh
MozReview-Commit-ID: KYlbWLg2Kj0

--HG--
extra : rebase_source : efff1dfda3a0e4134e08501848bc66f674aa292d
2017-11-16 15:29:23 -05:00
Edouard Oger
b3b3ff9cc5 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : dcba087df94d06b15c9f073ff2df3324fd646c57
2017-04-18 14:15:43 -04:00
Sebastian Hengst
18253e3fa2 Backed out changeset 0a0138825fb5 (bug 1353571)
--HG--
rename : browser/base/content/test/sync/accounts_testRemoteCommands.html => browser/base/content/test/general/accounts_testRemoteCommands.html
rename : browser/base/content/test/sync/browser_fxa_web_channel.html => browser/base/content/test/general/browser_fxa_web_channel.html
rename : browser/base/content/test/sync/content_aboutAccounts.js => browser/base/content/test/general/content_aboutAccounts.js
2017-05-03 21:56:44 +02:00
Edouard Oger
c11e66021d Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : aa6cb209d312c6ef3f45589b0fd8fa8a39c612e3
2017-04-18 14:15:43 -04:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Edouard Oger
f5eb6dc494 Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh
MozReview-Commit-ID: LK9akz4chd1
2017-01-27 13:31:57 -05:00
Wes Kocher
c3cc3b6407 Backed out 13 changesets (bug 1296767) for xpcshell failures a=backout CLOSED TREE
Backed out changeset 41ed77788333 (bug 1296767)
Backed out changeset 1c0c9289b532 (bug 1296767)
Backed out changeset 50294db1d871 (bug 1296767)
Backed out changeset 26c065f79c54 (bug 1296767)
Backed out changeset 0362a78d6978 (bug 1296767)
Backed out changeset 4e71cf94e4ee (bug 1296767)
Backed out changeset f6f59447d22a (bug 1296767)
Backed out changeset 6c9b792cc296 (bug 1296767)
Backed out changeset 46a52b10a868 (bug 1296767)
Backed out changeset 5d70d87d2a8f (bug 1296767)
Backed out changeset 8219686be6a2 (bug 1296767)
Backed out changeset 0a989b0cea67 (bug 1296767)
Backed out changeset 9f59a0b75c1f (bug 1296767)

MozReview-Commit-ID: 2XBNsd8JrZL

--HG--
extra : amend_source : 1afafaa8127fcebac31ce1d7743dc16872fa0522
2017-01-26 11:16:12 -08:00
Edouard Oger
b41402ea7b Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh
MozReview-Commit-ID: LK9akz4chd1

--HG--
extra : rebase_source : b7113c37a486f88ae1138c54e314bb0ff07ef1af
2017-01-18 17:39:11 -05:00
Edouard Oger
d2b4472abe Bug 1298011 - Update the Synced Tabs sidebar UI when account password changed. r=markh
MozReview-Commit-ID: 2cJK8ZAQH5R

--HG--
extra : rebase_source : 7ea9455093467e34b4daec0da2bcc08b40f17de6
2017-01-05 16:54:12 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Kit Cambridge
f97b3eef3b Bug 1322408 - Use gBrowser.loadTabs to open all tabs when middle-clicking a client in Synced Tabs. r=markh
MozReview-Commit-ID: 6phgHjAAXUs

--HG--
extra : rebase_source : 44260c7a8f407c1efa869912e6407e81e68fb2eb
2016-12-07 11:46:36 -10:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Kit Cambridge
81cb8e12e4 Bug 1246156 - Show additional link options in the synced tabs sidebar context menu. r=markh
MozReview-Commit-ID: 44KlEasJiLc

--HG--
extra : rebase_source : ccd6b124d5d8159d47ad8918710ad7060e63b750
2016-03-10 15:56:25 -08:00
Sebastian Hengst
db9bc3593c Bug 1245377 - Avoid use of Object.values in SyncedTabs sidebar as it only exists on nightly: eslint fix followup. r=eslint-fix 2016-02-06 00:00:50 +01:00
Mark Hammond
e15ca4d406 Bug 1245377 - Avoid use of Object.values in SyncedTabs sidebar as it only exists on nightly. r=zaach 2016-02-04 17:43:00 -05:00
Dave Townsend
e496a11771 Bug 1245649: Turn on no-extra-semi. r=markh
--HG--
extra : commitid : HReQFPDOA6x
extra : rebase_source : 303a92f511c3c9dd2d26135975d4dc7c85e823b3
2016-02-03 17:27:36 -08:00
Zachary Carter
f70ec7f297 Bug 1210586 - add entrypoint when opening Sync setup from tabs sidebar r=markh 2016-01-27 14:55:02 -08:00
Zachary Carter
4937ef326e Bug 1210586 - Create a Synced tabs sidebar r=markh 2016-01-27 14:40:30 -08:00