Commit graph

16 commits

Author SHA1 Message Date
Brian Birtles
075271a248 Bug 1518403 - Make IsCurrent return false for animations with playback rate == 0 that are in before/active phase; r=hiro
As per following spec update:

  0c369c0806

Depends on D16001

Differential Revision: https://phabricator.services.mozilla.com/D16131

--HG--
extra : moz-landing-system : lando
2019-01-10 01:03:24 +00:00
Brian Birtles
1ec94901a9 Bug 1518403 - Make "is current" depend on the direction of the associated animation's playback rate; r=hiro
As per the following spec change:

  4ec1deb76a

Spec issue:

  https://github.com/w3c/csswg-drafts/issues/3193

Of the added test cases, only the last one, "Returns reversed animations yet to
reach their active phase" fails without this code change. The others pass
because the animation is finished at that point but I added them for consistency
with the previous tests.

Differential Revision: https://phabricator.services.mozilla.com/D16001

--HG--
extra : moz-landing-system : lando
2019-01-10 00:31:54 +00:00
Emilio Cobos Álvarez
d2ed260822 Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
2019-01-03 17:48:33 +01:00
Brian Birtles
928d88aabb Bug 1433705 - Rename GetCurrentTime to GetCurrentTimeAsDuration; r=hiro
To avoid having to always work around conflicts with winbase.h.

Differential Revision: https://phabricator.services.mozilla.com/D13951

--HG--
extra : moz-landing-system : lando
2018-12-06 22:16:48 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Diego Pino Garcia
eca2cd1106 Bug 1498948 - Refactor KeyframeEffect constructor to use r-value reference. r=boris 2018-10-16 00:38:00 +03:00
Diego Pino Garcia
f56ddbca98 Bug 1339675 - Move TimingParams in call to SetSpecifiedTiming r=boris
--HG--
extra : histedit_source : 4d411a2a717ef0f0cd1c1b8cc4387bb3d52775d1
2018-10-12 11:28:00 +03:00
Xidorn Quan
ad0d10644f Bug 1418874 part 2 - Move ctor and dtor of AnimationEffect into cpp file. r=hiro
They require destructor of Animation, but that is an incomplete type in
AnimationEffect.h, and AnimationEffect.h cannot include Animation.h
because the latter already includes the former.

MozReview-Commit-ID: AunD7dI1QN5

--HG--
extra : rebase_source : c9331eb5186b09666419e0b7ab12517beb07793f
2018-06-14 20:00:20 -07:00
Brian Birtles
af7674e36b Bug 1456394 - Drop AnimationEffectTiming(ReadOnly) interfaces; r=bz,hiro
MozReview-Commit-ID: KKqAWemDXwv

--HG--
extra : rebase_source : 22541fef1d5286510a44591ec0eb4b43832a76a0
2018-05-07 12:58:37 +09:00
Brian Birtles
8dc6ef2391 Bug 1456394 - Add AnimationEffect.updateTiming(); r=bz,hiro
https://drafts.csswg.org/web-animations-1/#dom-animationeffect-updatetiming

MozReview-Commit-ID: ISgksSpH8yH

--HG--
extra : rebase_source : 0b9c03adba9c9068fa3ec1ff06541d587576a29f
2018-05-07 12:37:11 +09:00
Brian Birtles
79bd9b3a55 Bug 1456394 - Add AnimationEffect.getTiming(); r=bz,hiro
https://drafts.csswg.org/web-animations-1/#dom-animationeffect-gettiming

MozReview-Commit-ID: 8gnd5Gl0UkK

--HG--
extra : rebase_source : 12d28eac599bb2462ef8e6b32cf75e8bd14262eb
2018-05-07 12:32:38 +09:00
Brian Birtles
516b224d43 Bug 1456394 - Rename animation timing dictionaries; r=bz
As per the changes in:

  d4519d9bba (diff-4c9f5c055fb219a7fcad23a9a7a80b64R4206)

MozReview-Commit-ID: Iwvbp0H6jlg

--HG--
extra : rebase_source : 2c8bbab7aee617b65e5a7647ed146abdb0dde2d6
2018-05-07 12:09:54 +09:00
Brian Birtles
f8c518344a Bug 1456394 - Rename AnimationEffectReadOnly to AnimationEffect; r=bz,hiro
MozReview-Commit-ID: 8jzJiCWt5vs

--HG--
rename : dom/animation/AnimationEffectReadOnly.cpp => dom/animation/AnimationEffect.cpp
rename : dom/animation/AnimationEffectReadOnly.h => dom/animation/AnimationEffect.h
rename : dom/webidl/AnimationEffectReadOnly.webidl => dom/webidl/AnimationEffect.webidl
extra : rebase_source : 2bd6490fe9be47cfb760bda81a63c33ba0b0397d
2018-05-07 11:15:16 +09:00
Brian Birtles
d5b5205359 Bug 1153734 part 1 - Remove AnimationEffect; r=smaug
Most of this is fairly obvious. However, the addition of 'override' to
ElementPropertyTransition::Name() is not strictly necessary. It was simply added
because while making these changes I accidentally dropped the 'virtual' keyword
from the method in the superclass and the compiler didn't complain. Adding this
will hopefully make it harder to create the same bug in the future.

--HG--
rename : dom/animation/test/css-animations/test_animation-effect-name.html => dom/animation/test/css-animations/test_animation-name.html
rename : dom/animation/test/css-transitions/test_animation-effect-name.html => dom/animation/test/css-transitions/test_animation-name.html
2015-04-15 08:48:20 +09:00
Boris Zbarsky
dc24477d79 Bug 1117172 part 3. Change the wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv
The only manual changes here are to BindingUtils.h, BindingUtils.cpp,
Codegen.py, Element.cpp, IDBFileRequest.cpp, IDBObjectStore.cpp,
dom/workers/Navigator.cpp, WorkerPrivate.cpp, DeviceStorageRequestChild.cpp,
Notification.cpp, nsGlobalWindow.cpp, MessagePort.cpp, nsJSEnvironment.cpp,
Sandbox.cpp, XPCConvert.cpp, ExportHelpers.cpp, and DataStoreService.cpp.  The
rest of this diff was generated by running the following commands:

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObject\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(Binding(?:_workers)?::Wrap\((?:aCx|cx|aContext|aCtx|js), [^,)]+)\)/\1, aGivenProto)/g'
2015-03-19 10:13:33 -04:00
Brian Birtles
29081b3bb1 Bug 1045993 part 1 - Add AnimationEffect interface and Animation.effect member; r=dbaron, r=bz 2014-08-22 13:42:47 +01:00