Commit graph

183 commits

Author SHA1 Message Date
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Cosmin Sabou
599a15d354 Merge mozilla-inbound to mozilla-central. a=merge 2019-01-29 12:01:56 +02:00
prathiksha
08d52d1c56 Bug 1174327 - Add an Allow/Disallow autofill password option. r=MattN
Add an Allow/Disallow autofill password option

Differential Revision: https://phabricator.services.mozilla.com/D17565

--HG--
extra : moz-landing-system : lando
2019-01-25 01:29:16 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Kris Maglione
2fe0de01dc Bug 1519596: Part 1 - Remove several unnecessary/unused ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16377

--HG--
extra : rebase_source : 6c4311387d25de425806aeb6c4691e12c9fcb855
2019-01-11 16:59:23 -08:00
Neil Deakin
cb10352f4b Bug 1482389, replace TreeBoxObject with XULTreeElement inherited from XULElement, r=peterv,paolo
--HG--
rename : dom/webidl/TreeBoxObject.webidl => dom/chrome-webidl/XULTreeElement.webidl
rename : layout/xul/tree/TreeBoxObject.cpp => dom/xul/XULTreeElement.cpp
rename : layout/xul/tree/TreeBoxObject.h => dom/xul/XULTreeElement.h
2018-12-04 11:25:30 -05:00
Julien Wajsberg
22f0b04ab9 Bug 1433754 - Fix username filling on Fortuneo website r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D16389

--HG--
extra : moz-landing-system : lando
2019-01-12 17:18:34 +00:00
Matthew Noorenberghe
8ac0a7753f Bug 1386283 - Enable eslint 'brace-style' and 'curly' rules on passwordmgr with --fix. r=mconley
ignore-this-changeset for blame

Differential Revision: https://phabricator.services.mozilla.com/D16110

--HG--
extra : moz-landing-system : lando
2019-01-10 19:26:48 +00:00
Matthew Noorenberghe
3f7baf5de6 Bug 1386283 - Enable eslint 'indent' rule on passwordmgr with --fix. r=mconley
ignore-this-changeset for blame

Differential Revision: https://phabricator.services.mozilla.com/D16109

--HG--
extra : moz-landing-system : lando
2019-01-10 19:26:17 +00:00
Arshad Kazmi
54aa0aa1bc Bug 1474852 - Removed obsolete icon attributes from toolkit r=dao
Differential Revision: https://phabricator.services.mozilla.com/D6053

--HG--
extra : moz-landing-system : lando
2018-09-18 07:50:59 +00:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
irrationalagent
e31593630b Bug 1476393 - Record pwmgr histograms in sync ping r=markh,tcsc
MozReview-Commit-ID: CkZAwlCORtX

--HG--
extra : rebase_source : 3be3237c6a2d5919d839bc77cb1794fec0dcdec6
2018-08-03 09:30:06 -06:00
Bogdan Tara
8cd47f8f14 Backed out 2 changesets (bug 1476393) for toolkit/components/passwordmgr/ failures CLOSED TREE
Backed out changeset b22dd03454ff (bug 1476393)
Backed out changeset cb876d3e8a69 (bug 1476393)
2018-07-25 06:39:58 +03:00
irrationalagent
ada2400811 Bug 1476393 - Allow Histograms to Be Sent In Sync Ping r=tcsc
MozReview-Commit-ID: HhtcE5PF2sC

--HG--
extra : rebase_source : f8e82290d4b8d37b8692452138fcb33380046d53
2018-06-19 13:48:47 +02:00
Marco Bonardo
dbde0c7df9 Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp

--HG--
extra : rebase_source : 6f5ec9404f12eb988501df56c7ee264ade2b054c
2018-04-16 18:24:06 +02:00
Dorel Luca
c4fec6222b Backed out changeset 897bbf35e781 (bug 1453580) for XPCShell failure on services/sync/tests/unit/test_syncedtabs.js. CLOSED TREE 2018-04-18 14:06:34 +03:00
Marco Bonardo
b00d20562d Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp

--HG--
extra : rebase_source : e8a1adb7c1004eaefddc42d12048d445eecd6530
2018-04-16 18:24:06 +02:00
Jonathan Kingston
6d747cc6cb Bug 1374741 - Within toolkit/ make openUILinkIn() provide the correct triggeringPrincipal. r=Gijs
MozReview-Commit-ID: AX2S3bEKl1w

--HG--
extra : rebase_source : f8ab09abbf65224e7253f72c5db36e774c4daffc
2018-02-21 23:08:42 +00:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Tim Nguyen
6071f20f6c Bug 1430374 - Remove support for progressmeter tree cells. r=bz,dao
MozReview-Commit-ID: 3hydkeoneC0

--HG--
extra : rebase_source : eca404511d1fc2d9d7e9711fbd1accefd3781b16
2018-01-18 10:36:05 +00:00
Zibi Braniecki
1a111ee852 Bug 1428172 - Align mozIntl with Intl when working with constructors. r=nalexander
MozReview-Commit-ID: 5jGk1jXKkay

--HG--
extra : rebase_source : fc5445104a6d14cbacd417ce9b9b4b0bd0ea8212
2018-01-04 13:01:43 -08:00
Steve Jarvis
cc3fb7fbb2 Bug 1334663 - Add ability to copy and launch URL from password manager. r=MattN,rfeeley
MozReview-Commit-ID: JApe0OhTIg8

--HG--
extra : rebase_source : f53e7a030a17c5580b08605348a30d5061b96cba
extra : amend_source : 5808aa783f7a517e931d0df4c69af25b42e71141
2017-11-13 16:13:00 -08:00
Mark Banner
d7b2685724 Bug 1412890 - Enable ESLint rule mozilla/use-services for toolkit/components/passwordmgr. r=MattN
MozReview-Commit-ID: BNojtj1cAji

--HG--
extra : rebase_source : 8480740988f3d7f94358360926ae8957c06a0758
2017-10-30 16:28:39 +00:00
Attila Craciun
566b7a287d Backed out 1 changesets (bug 1412890) possible ESlint failure r=backout on a CLOSED TREE.
Backed out changeset cac71ff2481c (bug 1412890)
2017-11-01 10:32:50 +02:00
Mark Banner
7dcccb8252 Bug 1412890 - Enable ESLint rule mozilla/use-services for toolkit/components/passwordmgr. r=MattN
MozReview-Commit-ID: BNojtj1cAji

--HG--
extra : rebase_source : cfbe9b186e4be171674807a48d9e1accb67b34db
2017-10-30 16:28:39 +00:00
Mark Banner
4de6bf22b1 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
MozReview-Commit-ID: H5YVp3rnzGo

--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
2017-10-26 11:47:01 +01:00
Kris Maglione
a610196df3 Bug 1391707: Follow-up: Skip idle dispatch in passwordManager.js for increasing the failure rate of an intermittent. r=me
--HG--
extra : rebase_source : 521d1872b9216522ebd657a8c2b972932d390a04
extra : amend_source : 665eba699bee8fe8e7c4154458ab51bb429d8e9f
2017-09-11 18:43:35 -07:00
Evan Tseng
4697753e00 Bug 1382135 - Remove all colon signs on sub-dialogs because we already removed them all on each category pane and we should make same thing for sub-dialogs. r=jaws
MozReview-Commit-ID: 8md6CFBSM3B

--HG--
extra : rebase_source : 80bff2dec6a20d7710aa3252c3e2fb295286b294
2017-08-01 11:54:54 +08:00
Dan Banner
314a69c0d6 Bug 1370218 - [Mac] Pressing backspace to remove a password in the password dialog (in preferences) should leave the dialog open. r=MattN
MozReview-Commit-ID: HtbUJUJgncK

--HG--
extra : rebase_source : e3efbaaae61ef0003d2526c29ce3e29266dc5085
2017-06-23 20:09:21 +01:00
Ashhar Hasan
9ffb129a1f Bug 234973 - Make selected row visible after removing/editing entries in password manager. r=Dolske
Added a call to
'treeBoxObject.ensureRowIsVisible(signonsTree.view.selection.currentIndex)' in
'signonReloadDisplay()' to make sure the selection is visible regardless of the
operation which caused a call to signonReloadDisplay().

MozReview-Commit-ID: EztJ4sZcofi

--HG--
extra : rebase_source : 3fa8fd3f7bb22862607b350415dd738a8383871f
2017-03-13 03:26:58 +05:30
Florian Queze
f935ddc4b3 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
738d097aae Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
3c564a2b02 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Zibi Braniecki
9f6c244d29 Bug 1354445 - Migrate Intl.DateTimeFormat to mozIntl.DateTimeFormat in chrome. r=mak
MozReview-Commit-ID: 4z13lcLXN9T

--HG--
extra : rebase_source : 8043212542b95ca76cf5957fa1ca05e6943fb635
2017-04-08 23:04:32 -07:00
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Fischer.json
613e459869 Bug 1338757 - "Remove All Shown" and button in about:preferences should use its own accesskey, r=jaws
MozReview-Commit-ID: 2ucF0GqOCJV

--HG--
extra : rebase_source : 5c1899f808ff287365e6621199b865516224a2d8
2017-02-13 11:43:37 +08:00
Fischer.json
6fba9fc139 Bug 1338036 - Switch button label from "Remove All" to "Remove All Shown" when filtering by keyword in about:preferences, r=jaws
MozReview-Commit-ID: 8iK6bg8i0uT

--HG--
extra : rebase_source : 9f44d7ba2df0cb4017d4164dd5bdd5233de9400e
2017-02-09 12:00:12 +08:00
Matthew Noorenberghe
5fee7ef72c Bug 1330844 - Add a pwmgr notPasswordSelector:#cardNumber recipe for buy.gogoinflight.com. r=johannh
MozReview-Commit-ID: GWG3XNmrU9c

--HG--
extra : rebase_source : 385a56126882c0f0d72817ee8c7941cab37f8033
2017-01-12 18:22:28 -08:00
Matthew Noorenberghe
d4abc9557d Bug 1330810 - Disable password manager on www.united.com/travel/checkin/changefqtv.aspx. r=johannh
MozReview-Commit-ID: FCRvgYjm8BI

--HG--
extra : rebase_source : 67d1407617c5d9256889fef8740c431b84413649
2017-01-12 17:37:46 -08:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00