Commit graph

55 commits

Author SHA1 Message Date
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Jorg K
e6b1105269 Bug 1482627 - Switch off test_NewTabUtils.js::getTopFrecentSites_improveSearch for Thunderbird. r=ursula 2018-08-13 02:55:00 +03:00
Ursula Sarracini
130d05505f Bug 1480888 - Implement blocking system for special search shortcut top sites r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D3035

--HG--
extra : moz-landing-system : lando
2018-08-10 19:54:24 +00:00
Brindusan Cristian
3fba2fdf68 Backed out changeset 44e1ccd1d22b (bug 1480888) for xpcshell failure on toolkit/modules/tests/xpcshell/test_CanonicalJSON.js. CLOSED TREE 2018-08-10 19:22:22 +03:00
Ursula Sarracini
24b94b7aae Bug 1480888 - Implement blocking system for special search shortcut top sites r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D3035

--HG--
extra : moz-landing-system : lando
2018-08-10 15:12:58 +00:00
Brindusan Cristian
e40aaf2b8f Backed out changeset d103f117bb84 (bug 1480888) for xpcshell failures on /extensions/test/xpcshell/test_ext_topSites.js. 2018-08-10 08:36:36 +03:00
Ursula Sarracini
114388d304 Bug 1480888 - Implement blocking system for special search shortcut top sites r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D3035

--HG--
extra : moz-landing-system : lando
2018-08-09 19:52:16 +00:00
ahillier
659bda3774 Bug 1475012 - fix ordering of getTopFrecentSites in ActivityStreamProvider r=ursula
MozReview-Commit-ID: Eymz3kAoHuX

--HG--
extra : rebase_source : af84f35c0674679b17a09eacca518cc62793a499
2018-07-11 12:26:39 -07:00
Shane Caraveo
8273682972 Bug 1445836 - finalize topSites api on platform APIs that will be stable, r=Mardak,rpl
MozReview-Commit-ID: Esj5sJweJ4K

--HG--
extra : rebase_source : b965ebb11dc0038574150b78a535798a16fe7226
2018-07-06 09:33:50 -03:00
Ursula Sarracini
db33263bdc Bug 1468389 - Add a src parameter to Pocket URLs in Highlights r=nanj
MozReview-Commit-ID: AFjN4vR11NB

--HG--
extra : rebase_source : 012ed2f5ae068d40bfec64befe5b74695fe11aa1
2018-06-26 10:30:27 -04:00
Ursula Sarracini
98fd9cb926 Bug 1452732 - Add date_added fields to different highlight types r=andreio
MozReview-Commit-ID: JY4HABQRJr4

--HG--
extra : rebase_source : f5bf036f889ebbf585a8bb9d2e5e4977f914569a
2018-04-09 15:33:18 -04:00
Ursula Sarracini
12bbfa710e Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights r=Mardak
MozReview-Commit-ID: 5St8NablevZ

--HG--
extra : rebase_source : d58ee8389060632616818c012a4d6b61eae9c1e1
2018-02-28 14:16:46 -05:00
k88hudson
39dfbe5bf6 Bug 1431470 - Add getTotalBookmarksCount to NewTabUtils.jsm r=ursula
MozReview-Commit-ID: BlcBcMap2Xw

--HG--
extra : rebase_source : d1e523f4a290528868646d52302b219dbe9c781e
2018-02-27 17:50:16 -05:00
Ursula Sarracini
bc4e25c04f Bug 1440768 - Improve saved to pocket stories caching and updating r=Mardak
MozReview-Commit-ID: 3pHJSBVekWE

--HG--
extra : rebase_source : 38224f399fdbfff50a2d045d4d65242e3ead2a48
2018-02-26 14:17:09 -05:00
Ursula Sarracini
3ed65bb2b9 Bug 1439684 - Add caching to NewTabUtils for saved to Pocket items r=Mardak
MozReview-Commit-ID: LLHD9TKnKA8

--HG--
extra : rebase_source : d7901275e39beadf8bbf3e19ee633fc99151f226
2018-02-21 11:42:53 -05:00
Ursula Sarracini
099e0fe989 Bug 1436449 - Rename item_id to pocket_id for clearer way to identify saved Pocket items in NewTabUtils r=Mardak
MozReview-Commit-ID: 5DifxvQ6qF5

--HG--
extra : rebase_source : f2c5b79341a9467fb6bef6baa441e44f1a02ce19
2018-02-09 15:24:31 -05:00
Ursula Sarracini
eda0730782 Bug 1425496 - Add Recently Pocketed Items to Highlights r=Mardak
MozReview-Commit-ID: LyXKkQkPXte

--HG--
extra : rebase_source : 7cb303772463efd7179fcd672d022dc0a0e37015
2018-02-02 17:06:06 -05:00
Florian Quèze
032c961e0a Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs. 2017-12-21 11:08:17 +01:00
Ed Lee
cf71bbf47e Bug 1415812 - Fix broken Pocket disclaimer, missing rich icons and bug fixes to Activity Stream. r=k88hudson
MozReview-Commit-ID: CAHA3b13jCE

--HG--
extra : rebase_source : a147b717fe2915c20d6e4e1e8f752769295331e7
2017-11-15 12:27:46 -08:00
Mark Banner
0e947c9d32 Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak
MozReview-Commit-ID: GL9nKfypie1

--HG--
extra : rebase_source : 5cd1c4d848dc32611349e25eb7297ba50890f0a9
2017-10-26 10:14:14 +01:00
Ed Lee
51d90f6caa Bug 1401316 - Use favicon from either https or http version of the page. r=ursula
MozReview-Commit-ID: 3W3OUu0gffH

--HG--
extra : rebase_source : be7a2f73c4a29032e4b3e8506e863434c04e8e47
2017-09-19 12:51:47 -07:00
Sebastian Hengst
6a9067d75f Backed out changeset 26f9c5c3f434 (bug 1401316) for failing xpcshell's toolkit/modules/tests/xpcshell/test_NewTabUtils.js. r=backout 2017-09-19 23:42:24 +02:00
Ed Lee
65f8a0f73b Bug 1401316 - Use favicon from either https or http version of the page. r=ursula
MozReview-Commit-ID: 3W3OUu0gffH

--HG--
extra : rebase_source : 6ef0834840b54c3da3268114729b42a39de8e09e
2017-09-19 12:51:47 -07:00
Mike de Boer
9cb7adbcfc Bug 1354536 - Part 2 - Add an option to ActivityStreamLinks.getHighlights() to allow results to be returned including favicons. r=Mardak
MozReview-Commit-ID: 5NCTCtooScy

--HG--
extra : rebase_source : b01f5e74b29d43fc8635919f1618e0cf2980b85b
2017-09-19 16:17:09 +02:00
Ursula Sarracini
f6077dace1 Bug 1396104 - Use rich icons when getting top sites r=Mardak
MozReview-Commit-ID: IMv0osslTS3

--HG--
extra : rebase_source : d3b40e5be01ffdeab85415e60bd269b8b394769f
2017-09-08 15:28:39 -04:00
Ed Lee
0d6e05576c Bug 1396282 - Add query for getting Highlights (recent bookmarks and recent history with metadata). r=mak
Adds index to moz_bookmarks.dateAdded for use by Highlights query for recent bookmarks.
MozReview-Commit-ID: 7Gs8H0kUij2

--HG--
extra : rebase_source : 23498bcde4faeeb116c534dc9e124429a86d3e14
2017-09-02 13:15:04 -07:00
Ed Lee
85b1aa47dd Bug 1389125 - Refactor ActivityStreamProvider in preparation for Highlights. r=ursula
Add helpers for shared adjusting limit, bookmarkGuid sub-SELECT, WHERE and params. More efficiently select https and correctly select bookmarks. Remove _addETLD, getHistorySize and getBookmarksSize. Allow for activity stream caller to customize more options.

MozReview-Commit-ID: Lj9AhoFJar

--HG--
extra : rebase_source : fb4bb13969b47c28c1a137075304efb23c254182
2017-09-02 13:13:52 -07:00
Ursula Sarracini
79bf23d9a1 Bug 1395203 - Unable to delete from history if a top site is pinned r=Mardak
MozReview-Commit-ID: 23shFz944kh

--HG--
extra : rebase_source : 9204cf185d78dfcad9d79257ca0cbcf82eed5f33
2017-08-30 13:12:15 -04:00
Ursula Sarracini
ae69f895c2 Bug 1388863 - Bookmarking a link via Activity Stream context menu should give feedback r=adw
MozReview-Commit-ID: Bd2eed1rX91

--HG--
extra : rebase_source : 5a2cc568e78c04173d463b84647453d2ebdfedef
2017-08-14 16:27:39 -04:00
Ed Lee
d1f9f45ab4 Bug 1387694 - Top frecent sites query should dedupe to the more frecent rev_nowww. r=ursula
Refactor the SQL to be extremely fast and push complex logic to JS.
MozReview-Commit-ID: E6707hC9K5D

--HG--
extra : rebase_source : f19e275816f71a9e37b7fec4af35ed60d08bfbff
2017-08-05 01:55:06 -07:00
Ursula Sarracini
3a64151952 Bug 1383720 - Only show http and https sites in Top Sites r=Mardak
MozReview-Commit-ID: 2NNoKO9BJvo

--HG--
extra : rebase_source : 684de92cfb4578454d03fff2643a6de9d6b1f88a
2017-07-27 15:41:56 -04:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Ursula Sarracini
d02542fcae Bug 1345122 - Update NewTabUtils.jsm for Activity Stream's needs r=mak
MozReview-Commit-ID: 3SpJucjKNby

--HG--
extra : rebase_source : 4613cc7c8ab832cbf605d50e385513b6b84a75ee
2017-04-28 10:00:30 -04:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend
c5bb304fd9 Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm

--HG--
extra : rebase_source : 4073cebbef1694393efe312aaafbdb803adbd304
2016-11-11 15:22:34 -08:00
Dave Townsend
0a2c8f9b78 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ

--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Jared Wein
5040f17e00 Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6

--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Dave Townsend
76c0eab703 Bug 1229519: Fix toolkit/modules to pass eslint checks. r=mak
--HG--
extra : commitid : 9muV4FzxxCp
extra : rebase_source : 2d651bfb17cd89768cff1f62d2ee7550a9c2589d
extra : amend_source : 5a0584163aaec0534dab50a8cac8597b58214f24
2015-12-03 09:58:56 -08:00
Carsten "Tomcat" Book
08997000eb Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
e7ef778c9d Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)

--HG--
extra : rebase_source : 5d3db72337754bc7ab0ed0c30b2896100411ff92
2015-10-07 12:13:45 +02:00
Shu-yu Guo
d06b6030f6 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Marina Samuel
c195c91fb5 Bug 1145410: Return valid results when querying the provider cache while it's empty or being populated. r=adw 2015-03-20 17:46:24 -04:00
Marina Samuel
a4871bd274 Bug 1126186: Allow users to turn off all tiles that aren't history tiles and update newtab cogmenu wording. r=adw 2015-03-20 17:28:15 -04:00
Marina Samuel
5b0c9de307 Bug 1126184: Part 2: Select a single tile to show as the first unpinned tile based on a user's top sites. r=adw 2015-03-13 11:45:34 -04:00
Marina Samuel
7ff3ee3da3 Bug 1126184: Part 1: Make DirectoryLinksProvider listen to PlacesProvider and update its _topSitesWithRelatedLinks cache. r=adw 2015-03-13 11:45:31 -04:00
Marina Samuel
e22847194c Bug 1126183 - Provide a way to check if a site is part of the top 100 PlacesProvider links. r=adw 2015-02-04 16:49:15 -05:00
Ed Lee
d73c9ba84e Bug 1045760 - Enhance tiles more specifically than eTLD+1/baseDomain (e.g., no enhance bugzilla.mozilla.org for mozilla.org) [r=dao]
Use all levels of subdomain except for common subdomains that are actually the same site.
2014-08-29 13:35:59 -07:00