Commit graph

2588 commits

Author SHA1 Message Date
dpk
214e706476 Bug 1637431 - Gives meaningful tabs.query error message. r=robwu,geckoview-reviewers,agi
***
Bug 1637431 - Gives meaningful tabs.query error message. r=robwu

Differential Revision: https://phabricator.services.mozilla.com/D78466
2020-06-16 11:47:14 +00:00
Mark Banner
4ed84161a4 Bug 1638888 - Make disabling and enabling a WebExtension restore the default search engine correctly. r=mixedpuppy,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D76503
2020-06-16 08:54:24 +00:00
Mark Banner
191db56ecd Bug 1638888 - Simplify processSearchProviderManifestEntry to handle the not setting as default engine case first. r=mixedpuppy,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D79271
2020-06-16 08:54:16 +00:00
Drew Willcoxon
7024c06712 Bug 1640045 - Replace PlacesSearchAutocompleteProvider with UrlbarSearchUtils, remove its parseSubmissionURL function, and init the search service on the first query. r=mak
* Replace PlacesSearchAutocompleteProvider with UrlbarSearchUtils.
  * Move the module from toolkit to browser. The only consumers of
    PlacesSearchAutocompleteProvider are urlbar and UnifiedComplete.
  * I'd like to add functions to UrlbarUtils instead, but
    PlacesSearchAutocompleteProvider adds itself as an observer for search
    engine changes, and it keeps some state so that alias lookups are O(1). It
    has an init function to set that up. That's not quite as easy to do if I
    just added some functions to UrlbarUtils, and I think that O(1) lookups of
    aliases are worth keeping (vs. O(number of installed engines)), so I kept a
    separate module, now called UrlbarSearchUtils.
* Init the search service (via UrlbarSearchUtils) from
  UrlbarProvidersManager.startQuery so that every module involved in querying
  doesn't need to do it.
* Remove PlacesSearchAutocompleteProvider.currentEngine. Previous consumers can
  simply use Services.search directly now that the service is initialized early
  (see previous point).
* Remove PlacesSearchAutocompleteProvider.parseSubmissionURL. Here again
  consumers can use Services.search directly.

Differential Revision: https://phabricator.services.mozilla.com/D79244
2020-06-16 01:08:38 +00:00
Sonia Singla
4f63eefcef Bug 1638360 - Only show bookmark menu items for nodes with a bookmarkGuid. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D79605
2020-06-14 16:50:12 +00:00
Bogdan Tara
2b80bfb16b Backed out changeset 61bdbb94ab7a (bug 1637431) for browser_ext_tabs_cookieStoreId.js failures CLOSED TREE 2020-06-11 07:36:35 +03:00
dpk
43998630ac Bug 1637431 - Gives meaningful tabs.query error message. r=robwu,geckoview-reviewers,agi
***
Bug 1637431 - Gives meaningful tabs.query error message. r=robwu

Differential Revision: https://phabricator.services.mozilla.com/D78466
2020-06-11 03:44:23 +00:00
Mihai Alexandru Michis
9167a29a3a Backed out changeset 436777b95e22 (bug 1637431) for causing bc failures in browser_ext_tabs_cookieStoreId.js
CLOSED TREE
2020-06-11 06:35:23 +03:00
dpk
21f99d2072 Bug 1637431 - Removed a comment line, rev approved. r=robwu,geckoview-reviewers,agi
***
Bug 1637431 - Gives meaningful tabs.query error message. r=robwu

Differential Revision: https://phabricator.services.mozilla.com/D78466
2020-06-11 02:33:11 +00:00
Dana Keeler
82ce5c1a6e Bug 1637807 - add browser.pkcs11.autoload API to allow webextensions to enable osclientcerts r=mixedpuppy CLOSED TREE
This patch adds the setting `browser.pkcs11.autoload` that can be set to `true`
to cause Firefox to load the built-in "osclientcerts" module, which uses OS APIs to
provide access to client certificates. This means that webextensions can opt to
use a module developed and supported by Mozilla for TLS client authentication
rather than 3rd party modules that have historically caused stability and
performance issues for users.

This API is currently only available on Windows and macOS.

Differential Revision: https://phabricator.services.mozilla.com/D78353
2020-06-09 23:10:28 +00:00
Noemi Erli
26d0f6a6fd Backed out changeset a34e77d6c3bf (bug 1637807) for crashes @InvalidArrayIndex_CRASH CLOSED TREE 2020-06-10 04:52:30 +03:00
Daisuke Akatsuka
d681c2279f Bug 1626494: Add test of target-switching for devtools network. r=rpl,extension-reviewers
Depends on D67439

Differential Revision: https://phabricator.services.mozilla.com/D67440
2020-06-10 00:36:39 +00:00
Daisuke Akatsuka
337dbc0296 Bug 1626494: Address target-switching for devtools network. r=ochameau,rpl
Differential Revision: https://phabricator.services.mozilla.com/D67438
2020-06-10 00:33:59 +00:00
Dana Keeler
98b77a3266 Bug 1637807 - add browser.pkcs11.autoload API to allow webextensions to enable osclientcerts r=mixedpuppy
This patch adds the setting `browser.pkcs11.autoload` that can be set to `true`
to cause Firefox to load the built-in "osclientcerts" module, which uses OS APIs to
provide access to client certificates. This means that webextensions can opt to
use a module developed and supported by Mozilla for TLS client authentication
rather than 3rd party modules that have historically caused stability and
performance issues for users.

This API is currently only available on Windows and macOS.

Differential Revision: https://phabricator.services.mozilla.com/D78353
2020-06-09 23:10:28 +00:00
Johann Hofmann
20b1b77919 Bug 1515073 - Part 5 - Disable browser.navigation.requireUserInteraction in tests. r=Gijs
Depends on D27588

Differential Revision: https://phabricator.services.mozilla.com/D31604
2020-06-09 14:51:06 +00:00
Mark Banner
2e3146fbf2 Bug 1643004 - Move searchform test into other tests for OpenSearch/WebExtension engines. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D78714
2020-06-09 11:57:41 +00:00
Dão Gottwald
7e9799c2c7 Bug 1643606 - Remove remnants of the toolkit.cosmeticAnimations.enabled pref. r=Gijs,remote-protocol-reviewers,marionette-reviewers,extension-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D78462
2020-06-08 16:03:51 +00:00
Tomislav Jovanovic
e4d116f876 Bug 1642956 - Rename extension.whiteListedHosts to allowedOrigins r=mixedpuppy,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D78050
2020-06-04 21:39:27 +00:00
Rob Wu
8162b376d4 Bug 1642671 - Add tests for falsey result from runtime.onMessage r=zombie,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D77895
2020-06-03 17:26:43 +00:00
Andrea Marchesini
5ccae203ff Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 13:49:27 +00:00
Csoregi Natalia
e960b9f449 Backed out 7 changesets (bug 1640405, bug 1638358) for failures on browser_webconsole_network_messages_status_code.js. CLOSED TREE
Backed out changeset ef5f7479ddf8 (bug 1640405)
Backed out changeset 286e0c83eb30 (bug 1638358)
Backed out changeset 89e396b2896e (bug 1638358)
Backed out changeset 33ad5fa05209 (bug 1638358)
Backed out changeset d213264c1379 (bug 1638358)
Backed out changeset 6bc05236afb4 (bug 1638358)
Backed out changeset 87e9d0ed3982 (bug 1638358)
2020-06-02 15:16:42 +03:00
Andrea Marchesini
b4173bc59e Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-02 09:13:51 +00:00
Myeongjun Go
64fddbdb48 Bug 1612013 - add search provider with http for localhost URL r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D77644
2020-06-02 04:57:04 +00:00
Olli Pettay
f474d273b1 Bug 1353466, 'A browsing context is script-closable ... if it is a top-level browsing context whose session history contains only one Document', r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D76006
2020-06-01 20:01:11 +00:00
Razvan Maries
79fe28f0d6 Backed out 6 changesets (bug 1638358) for perma failures on browser_webconsole_navigate_to_parse_error.js. CLOSED TREE
Backed out changeset beb85cf281d5 (bug 1638358)
Backed out changeset 39f2e21623aa (bug 1638358)
Backed out changeset 2c873c72bf1f (bug 1638358)
Backed out changeset e91292c7c719 (bug 1638358)
Backed out changeset 0219ef931cd9 (bug 1638358)
Backed out changeset 4ac06f3992f4 (bug 1638358)
2020-06-02 00:24:46 +03:00
Andrea Marchesini
848f1f0043 Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-01 17:59:13 +00:00
Noemi Erli
e40be0aa72 Backed out 6 changesets (bug 1638358) for causing failures in test_Chrome_cookies.js CLOSED TREE
Backed out changeset 4e8fbe01aa38 (bug 1638358)
Backed out changeset 532731e94bb2 (bug 1638358)
Backed out changeset fad2ba760157 (bug 1638358)
Backed out changeset 932a3fdbd07c (bug 1638358)
Backed out changeset 05a62901a3f5 (bug 1638358)
Backed out changeset cddeada5c4a6 (bug 1638358)
2020-06-01 19:45:46 +03:00
Andrea Marchesini
165022b2c4 Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-01 11:43:19 +00:00
Tomislav Jovanovic
8f0bdce123 Bug 1583484 - Move extension messaging off MessageChannel r=geckoview-reviewers,mixedpuppy,agi
Differential Revision: https://phabricator.services.mozilla.com/D74026
2020-05-22 22:50:46 +00:00
Dorel Luca
82e6b1c0ab Backed out changeset 1e166841f170 (bug 1353466) for Mochitest failures in gecko/dom/base/nsGlobalWindowOuter.cpp. CLOSED TREE 2020-06-01 18:06:55 +03:00
Olli Pettay
428997aedb Bug 1353466, 'A browsing context is script-closable ... if it is a top-level browsing context whose session history contains only one Document', r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D76006
2020-05-29 20:37:47 +00:00
Dorel Luca
9574e25c80 Backed out 6 changesets (bug 1638358) for XPCShell failures in netwerk/cookie/test/unit/test_schemeMap.js. CLOSED TREE
Backed out changeset 745eab35e851 (bug 1638358)
Backed out changeset a45df1876e37 (bug 1638358)
Backed out changeset 1a85cc92d2fb (bug 1638358)
Backed out changeset 2156294cb158 (bug 1638358)
Backed out changeset 31101054c52c (bug 1638358)
Backed out changeset d284b50551ab (bug 1638358)
2020-06-01 14:38:22 +03:00
Andrea Marchesini
d1c11476f6 Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-01 10:28:51 +00:00
Mark Banner
cc617abea2 Bug 1641261 - Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D77429
2020-05-31 12:19:18 +00:00
Mihai Alexandru Michis
a46df46151 Backed out changeset d82a23f070f6 (bug 1641261) for causing xpcshell failures in test_override_allowlist.js
CLOSED TREE
2020-05-30 11:19:08 +03:00
Mark Banner
c562e03d91 Bug 1641261 - Handle the case when an app provided engine is hidden/removed, and a WebExtension wants to select as default. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D77429
2020-05-29 23:09:34 +00:00
Mark Banner
577303a05c Bug 1641881 - Switch browser_ext_settings_overrides_default_search.js to use a different search engine for testing. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D77471
2020-05-29 15:55:30 +00:00
Narcis Beleuzu
332eda16ac Backed out changeset 082fb07b2a02 (bug 1253129) for bc failures on browser_ext_windows_create_params.js . CLOSED TREE 2020-05-29 00:06:56 +03:00
Shane Caraveo
b1cae13cac Bug 1253129 warn when using focused property with windows.create r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D76944
2020-05-27 22:59:17 +00:00
Dão Gottwald
8ae6613380 Bug 1638068 - Stop setting toolkit.cosmeticAnimations.enabled in extension tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76138
2020-05-28 13:20:22 +00:00
Harry Twyford
e671b8b516 Bug 1623666 - Always show Top Sites in the Urlbar on empty searches. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D76245
2020-05-27 15:08:07 +00:00
Harry Twyford
166994cf8b Bug 1634279 - Allow accessing the TopSites feed even if Top Sites are hidden on the new tab page. r=dao,thecount,mixedpuppy
Creates a new pref, "...activity-stream.feeds.system.topsites" to control whether TopSitesFeed is enabled. The existing "...activity-stream-feeds.topsites" pref is kept to allow users to downgrade and to ensure that people who disabled Top Sites in the past will continue to not see Top Sites on the New Tab Page -- the difference being that Top Sites will now be generated for those users.

Differential Revision: https://phabricator.services.mozilla.com/D75603
2020-05-27 16:38:03 +00:00
Mark Banner
40cac5473a Bug 1635235 - Ensure browser_ext_settings_overrides_default_search.js can wait for search engine setup to complete to avoid intermittents. r=mixedpuppy
Depends on D76480

Differential Revision: https://phabricator.services.mozilla.com/D76910
2020-05-26 19:53:42 +00:00
Mark Banner
ceba0e848d Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey
This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.

We do not check for updates - if something is removed, we'll wait until next startup before processing it.

Also adds lots of tests for canOverride as this seems a critical part to get right.

Differential Revision: https://phabricator.services.mozilla.com/D76473
2020-05-26 19:40:42 +00:00
Csoregi Natalia
4d5f4e2f58 Backed out changeset 9855eb03a9f1 (bug 1402256) for failures on test_ext_all_apis.html. CLOSED TREE 2020-05-26 06:43:06 +03:00
Mélanie Chauvel (ariasuni)
a09b2821db Bug 1402256 - Add WebExtensions API to “warm up” a tab r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D71873
2020-05-26 02:29:45 +00:00
Mihai Alexandru Michis
33899422e7 Backed out 2 changesets (bug 1635235, bug 1635239) for causing Bug 1640583.
CLOSED TREE

Backed out changeset 97ecda13df18 (bug 1635239)
Backed out changeset c9f80397bbec (bug 1635235)
2020-05-25 16:43:03 +03:00
Gijs Kruitbosch
2f983e6cfa Bug 1638373 - remove Cu.isCrossProcessWrapper now that CPOWs are dead, r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D76597
2020-05-24 23:38:17 +00:00
Mark Banner
019b662f87 Bug 1635235 - Implement reading the allow override default search engine allowlist from remote settings. r=daleharvey
This implements reading the list from remote settings. We only read it at startup if necessary, or on add-on installation.

We do not check for updates - if something is removed, we'll wait until next startup before processing it.

Also adds lots of tests for canOverride as this seems a critical part to get right.

Differential Revision: https://phabricator.services.mozilla.com/D76473
2020-05-24 21:45:41 +00:00
Andreea Pavel
1320417128 Bug 1638027 - Disabled browser_ext_windows_size.js, browser_readerMode_readingTime.js, browser_showMenu.js on linux18.04 debug r=jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D76541
2020-05-22 22:13:38 +00:00