Commit graph

20 commits

Author SHA1 Message Date
Drew Willcoxon
eeeeea2f96 Bug 1618769 - Increase max chars for search suggestions, and don't fetch suggestions at all when max is reached due to paste. r=mak
* Add a new `allowSearchSuggestions` property to the query context. It defaults to true.
* `UrlbarInput` sets this property when it starts a query. If the event that started the query is a paste event and the pasted string's length is larger than maxChars, then don't allow suggestions. Otherwise do.
* `UrlbarProviderSearchSuggestions.isActive` returns false when `!context.allowSearchSuggestions`.
* `UrlbarProviderSearchSuggestions` doesn't truncate the query anymore.
* Keep the `browser.urlbar.maxCharsForSearchSuggestions` pref but use it only for pastes, and increase it from 20 to 100. I considered making a new pref but this way if a user changed it, then it still applies to pastes at least. I'm not sure it's important though.

Differential Revision: https://phabricator.services.mozilla.com/D70956
2020-04-17 00:42:23 +00:00
Marco Bonardo
a8354f1215 Bug 555694 - Address bar should not suggest switching to the current tab. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D65408

--HG--
extra : moz-landing-system : lando
2020-03-05 09:12:44 +00:00
Marco Bonardo
29429b36f7 Bug 1612496 - Use data-l10n-id to localize Tips and Interventions. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D61486

--HG--
extra : moz-landing-system : lando
2020-02-04 11:10:59 +00:00
Drew Willcoxon
416ccb5261 Bug 1608597 - Quantumbar: Replace restricting providers with a priority system. r=mak
Replace `isRestricting` with `getPriority` -- i.e., replace the binary restricting system with a general priority system. Instead of choosing restricting providers, the providers manager chooses the highest-priority providers.

Differential Revision: https://phabricator.services.mozilla.com/D60093

--HG--
extra : moz-landing-system : lando
2020-01-17 20:50:45 +00:00
Cosmin Sabou
4b24015c8a Backed out changeset c516b5d716f1 (bug 1608597) for browser chrome failures on browser_search_tips. 2020-01-17 20:10:21 +02:00
Drew Willcoxon
e693e42a59 Bug 1608597 - Quantumbar: Replace restricting providers with a priority system. r=mak
Replace `isRestricting` with `getPriority` -- i.e., replace the binary restricting system with a general priority system. Instead of choosing restricting providers, the providers manager chooses the highest-priority providers.

Differential Revision: https://phabricator.services.mozilla.com/D60093

--HG--
extra : moz-landing-system : lando
2020-01-17 16:11:31 +00:00
Marco Bonardo
2664dce2a5 Bug 1599842 - Restrict to a specific search engine from the QueryContext. r=adw
This is the last part needed to be able to restrict results without an explicit
typed token (either restriction or alias). Note this is all preparatory work,
there isn't a design for a feature using this yet, but we know at a certain
point we want a more usable representation of aliases and restriction tokens
and eventually a mode picker UI (search button).

Differential Revision: https://phabricator.services.mozilla.com/D57781

--HG--
extra : moz-landing-system : lando
2019-12-20 09:56:06 +00:00
Dão Gottwald
9e770a8ee9 Bug 1603437 - Make UrlbarInput::trimValue private. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D56946

--HG--
extra : moz-landing-system : lando
2019-12-13 12:49:07 +00:00
Marco Bonardo
4b9e5194b2 Bug 1599839 - Merge sources and acceptableSources in UrlbarQueryContext. r=adw,mixedpuppy
Rename acceptableSources to just sources, merge it with the existing sources property.

Differential Revision: https://phabricator.services.mozilla.com/D55082

--HG--
extra : moz-landing-system : lando
2019-12-02 17:20:39 +00:00
Drew Willcoxon
2687f37446 Bug 1594622 - Quantumbar: Remove the context.preselected property and rely on result.heuristic instead r=mak
Please see bug 1594622 for a description.

Differential Revision: https://phabricator.services.mozilla.com/D52120

--HG--
extra : moz-landing-system : lando
2019-11-08 18:50:00 +00:00
Dorel Luca
b6eeb7d5d3 Backed out changeset 35d4451f348d (bug 1588458) as requested by the dev 2019-10-15 19:04:22 +03:00
Sylvestre Ledru
0f71aeba53 Bug 1588458 - Replace dxr by searchfox in the doc r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D49140

--HG--
extra : moz-landing-system : lando
2019-10-15 15:27:13 +00:00
Marco Bonardo
f10ec767a4 Bug 1580834 - Add a Search in private window entry in the address bar results when only search suggestions are present r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D48082

--HG--
extra : moz-landing-system : lando
2019-10-07 15:51:59 +00:00
Dão Gottwald
d1607b78b7 Bug 1584525 - Remove unused controller option from UrlbarInput constructor. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D47429

--HG--
extra : moz-landing-system : lando
2019-09-30 12:41:43 +00:00
Drew Willcoxon
fa281a5519 Bug 1571913 - Quantumbar: Allow keyword offers to specify whether to show the keyword, and fix secondary text color when there's no title. r=dao
Replace the "is heuristic?" logic for hiding keywords in keyword offers with something more flexible. Here's how the top sites extension uses this new `keywordOffer` payload property: 8408d13d2f

When a result's title is hidden, use the title color for the secondary color.

Differential Revision: https://phabricator.services.mozilla.com/D40898

--HG--
extra : moz-landing-system : lando
2019-08-07 08:07:25 +00:00
Dão Gottwald
21af578b73 Bug 1570688 - Remove UrlbarController::viewContextChanged. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D40229

--HG--
extra : moz-landing-system : lando
2019-08-02 08:36:29 +00:00
Dão Gottwald
3514c20156 Bug 1568959 - Add notifications for the urlbar results view opening and closing. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D40170

--HG--
extra : moz-landing-system : lando
2019-08-02 07:25:25 +00:00
Ciure Andrei
2a4fcddae1 Backed out changeset 7768b6a6cfc7 (bug 1568959) for ESlint failures CLOSED TREE 2019-08-02 03:18:31 +03:00
Dão Gottwald
68864b02f7 Bug 1568959 - Add notifications for the urlbar results view opening and closing. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D40170

--HG--
extra : moz-landing-system : lando
2019-08-01 16:29:19 +00:00
Drew Willcoxon
cdc9484d3d Bug 1566932 - Move quantumbar docs to browser/components/urlbar/docs. r=mak
* Move AddressBar.rst into a new browser/components/urlbar/docs directory
* Break it up into several files, which makes the patch look way bigger than it really is because I used `hg cp` to preserve blame
* Add an Experiments & Extensions file/subsection, to be written later
* Rewrite the intro a little for wording and also to reflect the fact that quantumbar has shipped, and also tweak the wording of some subsection titles

Differential Revision: https://phabricator.services.mozilla.com/D38938

--HG--
rename : browser/docs/AddressBar.rst => browser/components/urlbar/docs/contact.rst
rename : browser/docs/AddressBar.rst => browser/components/urlbar/docs/debugging.rst
rename : browser/docs/AddressBar.rst => browser/components/urlbar/docs/overview.rst
rename : browser/docs/AddressBar.rst => browser/components/urlbar/docs/telemetry.rst
rename : browser/docs/AddressBar.rst => browser/components/urlbar/docs/utilities.rst
extra : moz-landing-system : lando
2019-07-23 17:54:03 +00:00
Renamed from browser/docs/AddressBar.rst (Browse further)