Commit graph

11 commits

Author SHA1 Message Date
Marco Bonardo
dd6f2af24c Bug 1605161 - The muxer shouldn't put non-search-suggestions results in the suggestions bucket. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D60840

--HG--
extra : moz-landing-system : lando
2020-01-23 16:53:04 +00:00
Drew Willcoxon
63a154b6a0 Bug 1597610 - Add browser.urlbar.onEngagement WebExtensions API. r=mak,mixedpuppy
Adds a `browser.urlbar.onEngagement` event. Listeners are passed the current engagement state: start, engagement, abandonment, or discard. The extension could use this to record its own parallel telemetry (scalars, event telemetry, etc.) per engagement.

Differential Revision: https://phabricator.services.mozilla.com/D53897

--HG--
extra : moz-landing-system : lando
2019-11-25 23:52:56 +00:00
Drew Willcoxon
2687f37446 Bug 1594622 - Quantumbar: Remove the context.preselected property and rely on result.heuristic instead r=mak
Please see bug 1594622 for a description.

Differential Revision: https://phabricator.services.mozilla.com/D52120

--HG--
extra : moz-landing-system : lando
2019-11-08 18:50:00 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Drew Willcoxon
095f8ab761 Bug 1547666 - Quantumbar extension API: Add onBehaviorRequested, onResultsRequested, onQueryCanceled, and Result type, and change some internals. r=mak,mixedpuppy
* Rename the browser.urlbar.onQueryReady event onBehaviorRequested to make its purpose and return value clear.
* Add a browser.urlbar.onResultsRequested event that's fired when a query starts so that providers can add results. Listeners should return an array of Result objects. Add the Result type. It has a `payload` property that can be an arbitrary object depending on the result type.
* Add a browser.urlbar.onQueryCanceled event that's fired when a query is canceled.
* Rename the QueryContext type to just Query. From an extension's point of view, there's no difference between Query and QueryContext like there is for the internal implementation, so "Context" is unnecessary imo.
* Internally, remove the extension listeners map from UrlbarProvidersManager. Instead, extension listeners are added directly to UrlbarProviderExtension instances, and then UrlbarProvidersManager just loops through extension providers, not a separate map of listeners.
* Since UrlbarProviderExtension is getting a little bigger, move it to its own file.
* Fix a bug in UrlbarMuxerUnifiedComplete where the heuristic result sometimes does not come first in the sorted results, depending on the timing of when results from UrlbarProviderUnifiedComplete and other providers are added.
* Move SkippableTimer to UrlbarUtils.jsm, add a logger property, and add a name property so that it's easy to figure out which timers time out.
* Add lots of tests.

Differential Revision: https://phabricator.services.mozilla.com/D34809

--HG--
extra : moz-landing-system : lando
2019-06-26 23:35:50 +00:00
Dão Gottwald
969b56a313 Bug 1522425 - Rename MATCH_SOURCE to RESULT_SOURCE. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D17837

--HG--
extra : moz-landing-system : lando
2019-01-29 09:29:21 +00:00
Dão Gottwald
9e40dea2a8 Bug 1522426 - Rename MATCH_TYPE to RESULT_TYPE. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D17628

--HG--
extra : moz-landing-system : lando
2019-01-25 16:14:21 +00:00
Dão Gottwald
40de07781f Bug 1515306 - Rename UrlbarMatch to UrlbarResult. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D17481

--HG--
rename : browser/components/urlbar/UrlbarMatch.jsm => browser/components/urlbar/UrlbarResult.jsm
extra : moz-landing-system : lando
2019-01-24 11:23:20 +00:00
Marco Bonardo
cc99e09b2b Bug 1511693 - Expose base classes for providers and muxers. r=Standard8
Creates base classes for providers and muxers. All the classes are exposed
by UrlbarUtils, for 2 reasons:
1. UrlbarProvidersManager on instantiation is importing provider modules, that
   may reimport the manager module. Exposing classes from it could cause a
   recursive failure.
2. It's nicer if only one of the urlbar modules exports multiple symbols (thus
   moving the QueryContext class here too)

Differential Revision: https://phabricator.services.mozilla.com/D14760

--HG--
extra : moz-landing-system : lando
2018-12-19 12:57:43 +00:00
Marco Bonardo
bc41334745 Bug 1502389 - Allow the view to limit searches to specific providers. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D14549

--HG--
extra : moz-landing-system : lando
2018-12-17 10:28:31 +00:00
Marco Bonardo
70a7e4ce9e Bug 1495183 - Create a first muxer implementation. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D13552

--HG--
extra : moz-landing-system : lando
2018-12-02 09:58:15 +00:00