Dan Banner
7caa92d5d8
Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
...
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Drew Willcoxon
73ad0ddaf3
Bug 1388835 - Hide page action urlbar buttons on about pages (about:preferences, etc.). r=Gijs
...
MozReview-Commit-ID: 9lid8VpPkJE
--HG--
extra : rebase_source : b57a37788f20345750d8daa5f73011bf6fac1ef8
2017-08-26 12:47:33 -07:00
Andrew Halberstadt
d2109610fb
Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
...
MozReview-Commit-ID: 5lO0uAjHMsw
--HG--
extra : rebase_source : 8607b3964da207a6076c79b6f1d75b40503cdd7d
2017-08-10 14:48:21 -04:00
Phil Ringnalda
0ff5a4285d
Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
...
MozReview-Commit-ID: 3HDE2C3wSU0
2017-08-10 20:21:19 -07:00
Andrew Halberstadt
f625fd5c37
Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
...
MozReview-Commit-ID: 5lO0uAjHMsw
--HG--
extra : rebase_source : d72a88962ec8d843e7be99e25f710887f01b6e1a
2017-08-10 14:48:21 -04:00
Michael Kohler
674e1b96fb
Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao
...
MozReview-Commit-ID: 8w1vfF2yRui
--HG--
extra : rebase_source : 222d8e9d3b9543552ff5b08967375fa46d62b896
2017-08-08 12:09:14 +02:00
Sebastian Hengst
ca40024d84
Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout
2017-08-05 23:15:16 +02:00
Michael Kohler
45d5f35624
Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
...
MozReview-Commit-ID: CoHv9mKpAe
--HG--
extra : rebase_source : 20d6404db9f90cfcb7de03d4c527ad6ed79d49f8
2017-08-05 20:37:40 +02:00
Mark Banner
18b22f0890
Bug 1336806 - Disable animation of the bookmark popup panel during tests to aid timing and avoid intermittent issues. r=mak
...
MozReview-Commit-ID: 115vkHVSEUm
--HG--
extra : rebase_source : 52a119ab314e63bb7efbc52c062fd870e521df8c
2017-07-18 19:23:20 +01:00
Wes Kocher
885fba8088
Backed out changeset 33a29b909d86 (bug 1336806) for frequent failures in browser_bookmark_popup.js a=backout
...
MozReview-Commit-ID: La4SjN79s5U
2017-07-17 13:08:59 -07:00
Mark Banner
bcdb06bc1b
Bug 1336806 - In browser_bookmark_popup.js' hover tests, place the mouse in the middle of the panel to try and avoid intermittents. r=mak
...
MozReview-Commit-ID: 3X89DkfWxQv
--HG--
extra : rebase_source : ad82ba9b6a0fdcab680dec54548055fe5b359c7d
2017-07-17 09:59:41 +01:00
Mark Banner
98f324b877
Bug 1380599 - Revert accidental change to from .click to doCommand in browser_bookmark_popup.js. r=mak
...
MozReview-Commit-ID: EHFXDmlG8p1
--HG--
extra : rebase_source : 38664253f0fbc56d64ee23c739b41e367a0ffb57
2017-07-13 07:33:12 +01:00
Mark Banner
6ba07150a4
Bug 1377599 - Fix typos to make the Star UI remove bookmarks correctly, and add an extra hook to ensure the tests passes in async mode. r=mak
...
MozReview-Commit-ID: FGBq9GTP2sB
--HG--
extra : rebase_source : 84147c433f8a6b86b493708bf71f0739cbf244af
2017-07-12 17:35:59 +01:00
Gijs Kruitbosch
86f574b586
Bug 1378161 - update browser_bookmark_popup to correctly deal with the non-photon case, r=mak
...
MozReview-Commit-ID: 6I2OBaYSdRb
--HG--
extra : rebase_source : 54dd1ad57d44cd13f05575d3e259800b5acff6e1
2017-07-04 21:57:49 +01:00
Gijs Kruitbosch
dd070a9e91
Bug 1352120 - move the bookmarks star into the url bar, r=mak
...
MozReview-Commit-ID: Ka5Wn2hrb1P
--HG--
extra : rebase_source : e22d25295066386c4becc1a430b78aaa9c40ae4f
2017-06-23 17:35:59 +01:00
Florian Quèze
5e3539e504
Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop.
2017-05-12 14:42:39 +02:00
Jared Wein
3dd99bad30
Bug 1294799 - Disable the autoclosing of the bookmark popup if there is any interaction with it such as mousedown or keypress. r=mak
...
MozReview-Commit-ID: JRo5ZVu0uFD
--HG--
extra : rebase_source : ffb0d7a8323595fe61e85fee200a2aca5bc63310
2017-02-10 11:11:57 -05:00
Jared Wein
7a7e2ed898
Bug 1334909 - Wait for BookmarkingUI to have all pending statements complete before continuing with test. r=mak
...
MozReview-Commit-ID: 1xMUm8aolOy
--HG--
extra : rebase_source : c61557946f805b0b9ce98d664f97b7318ec64188
2017-02-03 15:03:06 -05:00
Jared Wein
fdfcbce1e7
Bug 1335043 - Prevent the bookmark panel from closing automatically if the mouse is hovering over it. r=mak
...
MozReview-Commit-ID: 2jor6H2cQck
--HG--
extra : rebase_source : 970215308ca95d07c13179dcc5106e4e5eae14db
2017-01-30 10:34:53 -05:00
Jared Wein
783e0e02cd
Bug 1255985 - Switch from using BrowserTestUtils.openNewForegroundTab to .withNewTab to make sure that we yield until the tab is fully closed. r=Paolo
...
MozReview-Commit-ID: 8PGmikTeiJ6
--HG--
extra : rebase_source : 1e6275c47f4304cd69ba4a2decff2a87e3a84ca4
2017-01-26 16:56:50 -05:00
Masayuki Nakano
4515205f36
Bug 1331798 Bookmark panel for new bookmark shouldn't be closed automatically during composition and after text input without keyboard events nor composition events r=jaws
...
Bookmark panel for a new bookmark shouldn't be closed automatically during composition even if mouse cursor is moved outside the panel because user may click in IME's UI.
Additionally, editor might be modified without keyboard events nor composition events. In such case, the bookmark panel shouldn't be closed automatically too.
MozReview-Commit-ID: 1FAUmkXjid
--HG--
extra : rebase_source : b4bc6eeeebfeeafe12d9cb16df7b3d31e60c5ae5
2017-01-19 15:04:56 +09:00
Jared Wein
b33bfba51a
Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors. r=standard8
...
MozReview-Commit-ID: 2MhpvzUDgtK
--HG--
extra : rebase_source : 1df2b81badfe556928f6424c8990e4b3fde7056f
2017-01-06 12:09:28 -05:00
Jared Wein
33317c9d1b
Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
...
MozReview-Commit-ID: AQ0Q4zb2g2Q
--HG--
extra : rebase_source : b44f6ab87fc0d264fb04f0de22cfba5023530e0d
2017-01-03 17:02:09 -05:00
Phil Ringnalda
cfa6520d74
Backed out changeset 83d895c1c1ea (bug 1326712) for failures in browser_bookmark_popup.js
2017-01-03 19:36:42 -08:00
Jared Wein
5670df04ee
Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
...
MozReview-Commit-ID: AQ0Q4zb2g2Q
--HG--
extra : rebase_source : 642233413f4656683799e31398c9dd88dc2896d9
2017-01-03 17:02:09 -05:00
Dave Townsend
6a07a42125
Bug 1314343: Turn on no-unreachable in eslint. r=standard8
...
Unreachable code can be a sign of a mistake so we should turn this rule on.
MozReview-Commit-ID: LQphsNL7HBX
--HG--
extra : rebase_source : eb5fdb1157cac6e447492ac89bb15d83dc32eef6
2016-11-01 10:58:35 -07:00
Jared Wein
a182a61bce
Bug 1298559 - Enable eslint for /browser/base/content/test/ r=mattn
...
MozReview-Commit-ID: BZlkPTcLJMB
2016-08-31 12:53:24 -04:00
Jared Wein
78099b5a1b
Bug 1251071 - "New bookmark" popup disappears if I reopen it after creating bookmark. r=mak
...
MozReview-Commit-ID: DNqcu5vxrBG
* * *
MozReview-Commit-ID: 3KoNVklCK8d
2016-07-06 07:27:00 +02:00
Jared Wein
31e5034db8
Bug 1251134 - Remove redundant check for the panel state that is checked after a yield on a potential slow Places query. r=gijs
...
MozReview-Commit-ID: L46711lTbPC
--HG--
extra : transplant_source : NCF%EEh%06%27c%CE%9DE%F6r%DC%92%A3%DC%84q%84
2016-06-01 15:34:47 -04:00
Jared Wein
6277bcf9dd
Bug 1251107 - Move the mouseout code to popupHideFn(). r=gijs
...
The mouseout code triggers the hiding of the popup, but it was previously in the popupEditFn meaning that it ran before we expected the popup to close, which caused this race condition. I also had to tweak the contextmenu test because it was depending on a mousedown/click which we are no longer listening for (we replaced that with mouseover/mouseout).
MozReview-Commit-ID: 5mZujGuto5g
--HG--
extra : transplant_source : %A6X%9A%40%FD%7C%5C%F2gC%B1%1Bv%CF%F4%D5%B7%26q%7E
2016-02-25 00:30:37 -05:00
Jared Wein
2d2a2f8e9d
Bug 1219794 - Show the bookmark popup for new bookmarks and autoclose if no interaction. r=mak
...
MozReview-Commit-ID: FSx0bB4KqpQ
2016-02-18 15:36:22 -05:00