Commit graph

180 commits

Author SHA1 Message Date
Paolo Amadini
166ddcece1 Bug 1414244 - Part 7 - Remove unused code paths from PanelMultiview.jsm. r=Gijs
MozReview-Commit-ID: 9cwaAZXqDGO

--HG--
extra : rebase_source : 90cf1a99c2ca1a64709abfa7383462480282ba0f
2017-11-23 15:18:14 +00:00
Paolo Amadini
fc23659e93 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt

--HG--
extra : rebase_source : a94e212e8af35b77806d1d62e020a511ab62e224
2017-11-21 14:21:32 +00:00
Gijs Kruitbosch
8c1b02e3d4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv

--HG--
extra : rebase_source : c9dcbb76d787281ac2dcf18c59786205aeaacaf9
2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
d01a2b63d7 Bug 1388029 - remove notion of 'wide' widget and panel columns from the tree, r=jaws
MozReview-Commit-ID: IrCB3zn1BIT

--HG--
extra : rebase_source : efb192e8c82a4272078bd7754ef453113166b81c
2017-11-07 12:00:18 +00:00
Gijs Kruitbosch
f98c738db9 Bug 1388029 - remove useless param from PanelUI.showSubView, r=jaws
MozReview-Commit-ID: 9hkYtLxAOtQ

--HG--
extra : rebase_source : 76f0f2acb9c785e9497fccb493e5c158d9d35eb4
2017-11-07 11:54:47 +00:00
Gijs Kruitbosch
b8a8802972 Bug 1411011 - stop offering context menu (re)move options on skipintoolbarset items, r=jaws
Giving all these nodes ids doesn't seem like the right fix. `buildArea` already ignores skipintoolbarset
items before doing anything else with nodes, so bailing out early seemed like the right solution here.

MozReview-Commit-ID: H3EyqoospNR

--HG--
extra : rebase_source : 6dc06d18c82e2af5024be0aba271c270f7403839
2017-11-06 14:49:37 +00:00
Johann Hofmann
2807fe98d1 Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq

--HG--
extra : rebase_source : b786a695a954ef72eb08bf7ea5710fee7f3ead42
2017-10-25 13:07:46 +02:00
Sebastian Hengst
fabade716b Backed out changeset cc55d4e3d13d (bug 1410352) for eslint failure at browser/components/customizableui/CustomizableUI.jsm:4339: 'aEvent' is already declared in the upper scope. r=backout
--HG--
extra : rebase_source : 29fad97f166d57cc9b192874f0ec82ea8b6c044c
2017-10-25 16:53:27 +02:00
Johann Hofmann
ad3fb07012 Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq

--HG--
extra : rebase_source : f18647cf4631e489ef2787884d69b08ceabfee4d
2017-10-25 13:07:46 +02:00
Felipe Gomes
43ee76c5ed Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 2qNWebBpsMY

--HG--
extra : rebase_source : b30a4492f839186584c074b82a1969973cda48e0
2017-10-17 13:39:50 -02:00
Ryan VanderMeulen
e8cd5f653b Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies.
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
2017-10-17 10:07:55 -04:00
Felipe Gomes
4346cedc0e Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 8wbjdYIC3gb

--HG--
extra : rebase_source : 2ea1b77d4a9fd9c3eb17853c8ec655b309a3fa8c
2017-10-16 14:00:30 -02:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
d25b8d71e5 Bug 1406738 - do not set the 'overflowing' attribute if the overflow menu only contains 'special' widgets (like flexible spaces), r=jaws
MozReview-Commit-ID: 1C5XaTCIUKA

--HG--
extra : rebase_source : e8cbfd944c7085ef1a821e346c6ea022a3bb851b
2017-10-11 12:05:15 +01:00
Dão Gottwald
8fa6f14905 Bug 1406625 - Remove leftover code and styling for <toolbarbutton type="menu-button"> r=mikedeboer
MozReview-Commit-ID: 8wBsluIMZHq

--HG--
extra : rebase_source : 8733868d1afc6a34b6e9050b6bd80f01097a66f3
2017-10-07 20:10:24 +02:00
Sam Foster
f933fa62ca Bug 1395674 - Adding subviewbutton-nav class to menu-type toolbarbuttons and display the '>' in the overflow list. r=Gijs
MozReview-Commit-ID: I1pGXA3ecxT

--HG--
extra : rebase_source : ebfd4dbc2191a921ea04f0fcf56270ad945c3e37
2017-09-25 19:29:04 -07:00
Gijs Kruitbosch
bad4eae2ab Bug 1399517 - remove CustomizableUI placements for old buttons to avoid saved state corruption, r=mikedeboer
MozReview-Commit-ID: 3XKPuz9KwlD

--HG--
extra : rebase_source : d3f6bc2bbb815158c78909ed83a6f7f15c7b43c0
2017-09-18 17:34:50 +01:00
Gijs Kruitbosch
b7ec7b74c5 Bug 1399517 - CustomizableUI shouldn't try to insert items next to nodes that aren't in the right container, r=mikedeboer
MozReview-Commit-ID: H9KY7YQwmlQ

--HG--
extra : rebase_source : 75f92768868003280a8e187ce6f2bbc2b88dd8ca
2017-09-18 16:36:46 +01:00
Mike de Boer
4c850e0f21 Bug 1388180 - Update the overflow panel styling in Customize Mode and show the overflow button as in the opened state, but with a disabled looking icon. r=Gijs
MozReview-Commit-ID: 387PZ2jp1SS

--HG--
extra : rebase_source : 4b6e865d725d9aeb32b0de98b2cfdbb35d8f2349
2017-09-13 19:28:45 +02:00
Johann Hofmann
c90a0e9e12 Bug 1349552 - Part 2 - Add an extra drag space setting to customize mode. r=nhnt11
MozReview-Commit-ID: IWxdOeRwDeu

--HG--
extra : rebase_source : 953c988fdaab5a7bf64ecbdd363df846020063d9
2017-09-10 20:38:19 +02:00
Gijs Kruitbosch
3f3bcb5b73 Bug 1397447 - ensure the button is in the navbar by default, r=mak
MozReview-Commit-ID: H6r3dAEg4r1

--HG--
extra : rebase_source : fdb9b8d65745a57e3ac1ffa71cce10654032b177
2017-09-08 14:07:05 +01:00
Gijs Kruitbosch
ecf2be01ab Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : 11dc3f1b98f53f5897a3185253b68d2cf7d5083b
extra : source : 97f7f5175b2fc3adfb193783f7ecb70b5b9b4562
2017-09-08 14:16:36 +01:00
Kris Maglione
e3f6c844ae Bug 1391707: Follow-up: Skip idle in more places that incorrectly expect strict timing. r=me CLOSED TREE
MozReview-Commit-ID: BbMB5qk4F4e
2017-09-11 21:26:04 -07:00
Zibi Braniecki
70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
2017-09-09 22:17:19 -07:00
Sebastian Hengst
a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
923420c64a Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 9aeed150b6106210bbe06e8a98ae602e5471851b
2017-09-09 22:17:19 -07:00
Sebastian Hengst
8eb249afcc merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Paolo Amadini
fe96089fe4 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs
MozReview-Commit-ID: Tq8YrZWG6P

--HG--
extra : rebase_source : 2e02e0a809d08ff26291a027b73a54668d6d5f9d
2017-09-06 13:09:27 +01:00
Zibi Braniecki
0e1ced7d71 Bug 1395871 - Open toolbar menus on mousedown, rather than oncommand.
MozReview-Commit-ID: A3P4QBBgcB8

--HG--
extra : rebase_source : 2a1b660f6489c5aece8f8b25935ad5799779629d
2017-09-01 01:54:34 -07:00
Gijs Kruitbosch
8ec70a2c1b Bug 1393574 - fix flexible spacers not being removable in some circumstances, r=jaws
The goal of this patch is to ensure that:
- in default placements, specials have no unique ids
- in actual placements as stored by CUI, they do
- we reset the counter for those unique ids on reset.
- we re-number specials when building an area (like on startup, or when resetting),
  ensuring that the actual nodes always match the placements for a given area.
- we force saves after resetting, to ensure that the gNewElementCount is always persisted correctly.

This last part will also fix bug 1393661

MozReview-Commit-ID: HAS5J5ZSgB5

--HG--
extra : rebase_source : df62441169e07fb94e39f68a2b3e43f6ed7f464c
2017-09-06 10:02:44 +01:00
Steve Armand
e46ff00709 Bug 1368967 - Enable the ESLint generator-star-spacing rule across mozilla-central. r=standard8
MozReview-Commit-ID: 5do3eoCEAMR

--HG--
extra : rebase_source : 5f692e474e1d7d173fcb4c9c08617f0fe489e443
2017-09-04 00:49:32 -04:00
Gijs Kruitbosch
e47e6f071c Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6

--HG--
extra : rebase_source : af8ed6b6da9adc1badbdc5016aacb877511875f0
2017-08-25 13:32:47 +01:00
Gijs Kruitbosch
db2aefdf08 Bug 1385042 - hide spacers and separators added by CUI in popup windows, r=nhnt11
MozReview-Commit-ID: BB1j6j1QdxU

--HG--
extra : rebase_source : b495bc2661b2b23eaa82b7d7d8cf7a7b46175f23
2017-08-23 13:12:21 +01:00
Gijs Kruitbosch
9303f5c082 Bug 1383913 - fix popuphiding listener for overflow panel to only 'count' the panel itself hiding, r=mixedpuppy
MozReview-Commit-ID: K2nvSimItyx

--HG--
extra : rebase_source : ac880fa1a927c1cfe974661e8d306a1c9d7cbebc
2017-08-23 14:42:57 +01:00
Gijs Kruitbosch
ace9ca19d1 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : f2c8a292c5bddb2dfde656b0f37fe2abee371ea0
2017-08-16 15:54:36 +01:00
Gijs Kruitbosch
bdf83368d1 Bug 1391616 - make migration of existing hamburger panel contents actually work, r=jaws
MozReview-Commit-ID: 4YC4BWI10YW

--HG--
extra : rebase_source : e440a1008986a81674a72b033ddbd15a35453d26
2017-08-18 13:59:32 +01:00
Drew Willcoxon
3c27aee62b Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs
MozReview-Commit-ID: 1wANxaD3QaV

--HG--
extra : rebase_source : f87650ab8c09f7a313cda9b7ec73ee1e20d6fe34
2017-08-16 10:13:15 -07:00
Mike Taylor
71e035473c Bug 1373650. Unteach CustomizableUI about the Report Site Issue button. r=Gijs
MozReview-Commit-ID: BCXVJChZ0mt

--HG--
extra : rebase_source : 6c7dec5932e804f620f8af53d91f5d3e0961ef05
2017-08-04 15:35:18 -05:00
Wes Kocher
cff9e9b197 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 2YvHbITn9w3
2017-08-10 18:25:34 -07:00
Wes Kocher
936a9461f6 Merge inbound to m-c a=merge
MozReview-Commit-ID: KRQeIGmhAPA
2017-08-10 18:14:34 -07:00
Dão Gottwald
2c29c9f69a Bug 956731 - Remove legacy add-on bar and statusbar shims. r=Gijs
MozReview-Commit-ID: 2deeujcHYUM

--HG--
extra : rebase_source : 90e8c1f1c90655d3e38560b588af82da64fdc2a5
2017-08-10 09:17:48 +02:00
Kris Maglione
0ecfcbc93e Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj

--HG--
extra : rebase_source : 15761873b91efaf1d338b6361bf7168ab4348e0d
2017-08-09 13:03:36 -07:00
Gijs Kruitbosch
ce10833235 Bug 1383009 - add flexible spacers and library button to the navbar by default, r=jaws
Because we generate IDs for special nodes, we should update the inDefaultState getter to actually consider
these nodes to match even when the ids differ. This wasn't an issue before because specials weren't in the
default set for any nodes.

MozReview-Commit-ID: AI85yt2LuJD

--HG--
extra : rebase_source : 819e27885148deb588c057c4e811371a87f1d2fc
2017-08-07 19:10:40 +01:00
Kris Maglione
3c361e6c6d Bug 1387902: Don't attempt to localize browserAction widget properties. r=Gijs
We spend a lot of time at startup generating exception objects while trying to
retrieve nonexistent localized properties from string bundles. Since extension
widget values will never be localized this way, we should skip the string
bundle lookup entirely.

MozReview-Commit-ID: L9r59bf2Dgf

--HG--
extra : rebase_source : 04eb6f9a78215d0268d2eaee7f94fd5b4cff498b
2017-08-06 16:34:31 -07:00
Gijs Kruitbosch
45b4d7f5f4 Bug 1354117 - remove old panel code from CustomizableUI, add migration, r=jaws
MozReview-Commit-ID: 8kTETHR1P7X

--HG--
extra : rebase_source : 8eadae4ff04c153be7670154afe5f5005306136a
2017-08-01 12:56:48 +01:00
Gijs Kruitbosch
c4fb9878e0 Bug 1354117 - only dispatch view events once, and fix synced tabs button test, r=jaws
Prior to this patch, both CustomizableUI itself and the PanelMultiView module
tried to ensure that onViewShowing/Shown/Hiding/Hidden listeners were invoked
when the relevant DOM events fired.

PanelMultiView was doing this manually because CUI was only adding listeners
once the corresponding widget was created. Now that the relevant views can be
accessed without the corresponding widgets (via the fixed appMenu), there was
no guarantee that the listeners would be attached, and this caused empty
subviews.

Unfortunately, if the widget *was* present, it caused events to fire more than
once, which understandably broke consumers like the sync remote tabs widget,
which broke the test we're fixing up here. For other views, even if they were
not completely broken it at least did busy-work.

This patch removes the manual event invocation, and delegates the event
listener work to CUI from the PanelMultiView side. This ensures events fire,
and fire only once.

MozReview-Commit-ID: 94GhcrdcBuB

--HG--
extra : rebase_source : 4df42939aa06ec10b7f86c3c2e4fe75160c7e7bd
2017-08-01 12:45:55 +01:00
UK992
3f1f818fff Bug 1363485 - Add migration to new navbar layout r=Gijs
MozReview-Commit-ID: HIPq5rKgtlA

--HG--
extra : rebase_source : 88433e9470e2ccaec6ac8c58c6c96c75bef8acaa
2017-06-29 19:09:43 +02:00
UK992
b52599b66d Bug 1363485 - Move the Back, Forward, Reload and Stop buttons outside of the location bar container to the start of the toolbar along with the Home button r=Gijs
MozReview-Commit-ID: 2GxcXMxdbjW

--HG--
extra : rebase_source : 4c156a92a59ddb073d9ef743a986e7da2b8a034b
2017-06-29 01:09:05 +02:00
Sebastian Hengst
e087fbd0e2 Backed out changeset 1e6aea26ec16 (bug 1363485) for failing browser_urlbar_search_reflows.js on OSX debug with e10s and Windows. r=backout 2017-08-02 16:26:03 +02:00
Sebastian Hengst
a01cc8cc44 Backed out changeset 69063acda8eb (bug 1363485) 2017-08-02 16:25:05 +02:00