Commit graph

155 commits

Author SHA1 Message Date
Gijs Kruitbosch
3aefd1d81c Bug 1415056 - re-enable animations in the palette in customize mode, r=jaws
MozReview-Commit-ID: DXYBPCdXMBG

--HG--
extra : rebase_source : b19fabd92e2709909259b1517edba4b82a365f32
2017-12-04 12:15:10 +00:00
Xidorn Quan
843aaedf4d Bug 1417600 - Wait for another frame before setting animation out to ensure start of the animation. r=jaws
MozReview-Commit-ID: 96nGBDgdr05

--HG--
extra : rebase_source : a5bdf5ff0576a3d24d02e0e35effaa13c6eace43
2017-11-16 10:33:04 -08:00
Andreea Pavel
eaff9152a3 Backed out 1 changesets (bug 1417600) for failing browser/components/customizableui/test/browser_972267_customizationchange_events.js r=backout on a CLOSED TREE
Backed out changeset 04dac3301ecd (bug 1417600)
2017-11-17 12:51:12 +02:00
Xidorn Quan
948e8f416e Bug 1417600 - Wait for a style flush before setting animation out to ensure start of the animation. r=jaws
MozReview-Commit-ID: IhnmZ0L9yx

--HG--
extra : rebase_source : 013417c60cc85dbb90b8ab33afe60b55252d0b17
2017-11-16 10:33:04 -08:00
Johann Hofmann
3508660808 Bug 1362065 - Add the touchdownstartsdrag attribute to selected tabs on Windows. r=dao
This allows dragging them via touch gestures.

I'm not adding this attribute to all tabs (so that you need
to select a tab before dragging it), because the tab
strip can also be scrolled with touch gestures and
the two touch move actions would easily conflict
otherwise. It would also make it easier to accidentally
mess up your tabs when touching your window somehow.

MozReview-Commit-ID: IVWQtVGFE9j

--HG--
extra : rebase_source : b4d616f45de4362d2fd505dacbf7176d12a04e37
2017-11-10 12:06:50 +01:00
Gijs Kruitbosch
d01a2b63d7 Bug 1388029 - remove notion of 'wide' widget and panel columns from the tree, r=jaws
MozReview-Commit-ID: IrCB3zn1BIT

--HG--
extra : rebase_source : efb192e8c82a4272078bd7754ef453113166b81c
2017-11-07 12:00:18 +00:00
Jared Wein
aa66390484 Bug 1415054 - Handle RTL in empty customize mode better. r=gijs
MozReview-Commit-ID: HjqvOM1n14G

--HG--
extra : rebase_source : fb133bb320f37585f63f872ead38ba7e7f87e544
2017-11-08 15:32:21 -05:00
Johann Hofmann
93aef727a2 Bug 1299286 - Add the touchdownstartsdrag attribute to customize mode elements. r=jaws
MozReview-Commit-ID: LziDBjACA0

--HG--
extra : rebase_source : b0c08cb1ecafa6fce4b9e55ce3dae65412c5070e
2017-11-03 13:12:10 +01:00
Jared Wein
b8ffd9d167 Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : 319d160f3057173359f02adba44bdcc12a68e209
2017-10-31 14:38:15 -04:00
Coroiu Cristina
03154bfceb Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE
Backed out changeset b558ad2372bf (bug 1410666)
2017-11-02 01:02:12 +02:00
Jared Wein
2fdc4b7cdf Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : f85e763cc130a71ba0f4bda228a874ebf65b84be
2017-10-31 14:38:15 -04:00
Jared Wein
77a52a2953 Bug 1413030 - Polish up a few conditions when the customization palette is mostly empty. r=mconley
MozReview-Commit-ID: Gr4sXTZo7pG

--HG--
extra : rebase_source : 2960fd2f09655c44692dd708767593374762eefb
extra : amend_source : 0dc4fdcda68a05851dbe61f50768d91b0683c246
2017-10-24 17:23:22 -04:00
Jared Wein
49cd682e0d Bug 1409463 - Handle customization mode when only the Spacer is left. r=mconley
mconley helped with the initial setup here and they were reviewed by myself (jaws). His changes have been folded in to this patch since they didn't work as a standalone changeset.

MozReview-Commit-ID: E7U1ZciJl4D

--HG--
extra : rebase_source : 63400055b28fe15764190127996a0420c5f1f722
2017-10-15 14:11:57 -04:00
Erica Wright
6146d651bb Bug 1407754 - exiting customize mode quickly after adding a toolbar item to toolbar properly adds it to the toolbar. r=jaws
MozReview-Commit-ID: C7uvVVWoIeB

--HG--
extra : rebase_source : 423b5a7449410a5064405fdb18a87017eb668c6c
2017-10-13 09:27:48 -04:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Erica Wright
4a9eee97d9 Bug 1407435 - After animating out from the toolbar, the widget no longer remains invisible. r=jaws
MozReview-Commit-ID: 5WmcIFWqBYi

--HG--
extra : rebase_source : dfd6745bf0b4b0cebf59992dfebe5cfc0c93f842
2017-10-11 15:12:21 -04:00
Erica Wright
7e91455352 Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs
MozReview-Commit-ID: 5PxydbSfhpz

--HG--
extra : rebase_source : 3941fa6edb5e8eb0d14d6d04ad5b0d63ef1a5b84
2017-09-18 16:15:24 -04:00
Gijs Kruitbosch
19ef18501c Bug 1405720 - ensure only 1 theme is ever shown as selected in customize mode, r=jaws,johannh
The previous code here always set the `isActive` property on all themes. When writing the
patch for bug 1402981 I ran into issues because the default theme has an `isActive` property
anyway (it's a different type of object). So I tried to avoid setting `isActive` if it was
already present. Unfortunately, the result was that `isActive` values, once set, weren't
correctly updated. Worse, these values are (and were, prior to bug 1402981) persisted in
some cases.

There's no point persisting these values, all that will happen is that they'll start
mismatching the 'real' state of the world (LightweightThemeManager.currentTheme). So instead,
let's just not set the `isActive` property at all, and rely solely on the ID of the current
theme (or the default theme's ID, now that we no longer support non-lightweight-themes) to
establish whether any of the themes should appear selected or not.

MozReview-Commit-ID: 7rajS71FoQR

--HG--
extra : rebase_source : a99e04031ea9e122efdaf0436e354abe57439783
2017-10-05 15:17:12 +01:00
Jared Wein
5fde947458 Bug 1403382 - Dragging the back button out of the toolbar in customize mode shouldn't affect the toolbar height. r=Gijs
MozReview-Commit-ID: JOsb2y2pzqz

--HG--
extra : rebase_source : d8471cdda0dfc114c2efe7e200ca3c4f25ecabb8
2017-10-02 23:30:29 -04:00
Gijs Kruitbosch
d9dae67b93 Bug 1402929 - try to make overflow panel in customize mode easier to understand, r=mikedeboer
This moves the explanatory text from a pseudoelement to a real element,
and keeps only the image in a pseudoelement. It then uses a transitioned
opacity to fade that image in and out.

Because we need to fade this based on dragging items over the panel when
it's empty, it adds/removes a 'draggingover' attribute to handle the fade.

To cope with the extra element in the drag/drop container in customize mode,
this also makes the following changes:
- bail out of _onDragStart if there's no actual selected item.
- pick the fixed list in the panelHolder more reliably
- add a max-width to avoid the description making the panel wider

MozReview-Commit-ID: 9PEJSoJJ0Rp

--HG--
extra : rebase_source : 0a7865fcfd11eb5baca858cde71ea4e8b30d5afc
2017-09-29 17:55:50 +01:00
Maya Messinger
530424bf98 Bug 1396953 - fix flexible space widget disappearing when adding to toolbar r=Gijs
MozReview-Commit-ID: BuYzvBX439p

--HG--
extra : rebase_source : 2380bf5517da3982838e4c07dbc22a06c9f38465
2017-09-30 18:42:24 -04:00
Gijs Kruitbosch
49c8b259d5 Bug 1396423 - make it possible to drop items in what visually looks like the palette but isn't, r=mikedeboer
MozReview-Commit-ID: AqBwn9ovTjT

--HG--
extra : rebase_source : 58dd5d79db16d56be502f70cd7e533a4093f1c39
2017-09-29 15:40:48 +01:00
Gijs Kruitbosch
f207243be7 Bug 1402981 - add light and dark themes to the list of themes in customize mode by default, r=jaws
MozReview-Commit-ID: 4GxPEm119Yc

--HG--
extra : rebase_source : a1a6acf06e158fd937e6b53ea65cc91c2e4d02ce
2017-09-27 22:37:19 +01:00
Erica Wright
a9e25e23df Bug 1401152 - Disable 'add to overflow menu' in the customize mode *palette* context menu for flexible space. r=Gijs
MozReview-Commit-ID: 5sQPsxVaVYz

--HG--
extra : rebase_source : 6eab6e7e9d65bc0b45dea6dac7daf3cd23fc6c77
2017-09-21 18:15:02 -04:00
Mike de Boer
ecca1af556 Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs
MozReview-Commit-ID: IffDnXEqooR

--HG--
extra : rebase_source : 04344421e5152c1f7ba8959698ba7cff57448e15
2017-09-20 14:37:53 +02:00
Mike de Boer
c0b0c75c02 Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs
MozReview-Commit-ID: 44Q9NbKEJeC

--HG--
extra : rebase_source : 4895a170b403195cd1bc7023fc905deff12c2de2
2017-09-20 14:25:58 +02:00
Gijs Kruitbosch
088853fcdf Bug 1399935 - use horizontal panel for downloads checkbox panel at all times, r=mak
Rather than using left-hand-side at all times (which can go over the edge of the window
in some cases) this uses left or right-hand-side panels, always opening towards the
center of the window.

MozReview-Commit-ID: EvjDmKR1G5A

--HG--
extra : rebase_source : 12046edc24b564e035dff68a5e34bce3ff5fd507
2017-09-17 23:31:06 +01:00
Gijs Kruitbosch
27050c2c34 Bug 1399486 - show downloads auto hide panel after changing the pref instead of before, r=mak
Note that we will no longer show the panel if you use the context menu to move the item in one
window and have customize mode open in the other. I don't think that edgecase matters.

MozReview-Commit-ID: 3dzGr3cs2oQ

--HG--
extra : rebase_source : cc5f528557e35e48b0bc06e58b92fdcb7ecfa6fe
2017-09-17 18:09:35 +01:00
Johann Hofmann
c90a0e9e12 Bug 1349552 - Part 2 - Add an extra drag space setting to customize mode. r=nhnt11
MozReview-Commit-ID: IWxdOeRwDeu

--HG--
extra : rebase_source : 953c988fdaab5a7bf64ecbdd363df846020063d9
2017-09-10 20:38:19 +02:00
Gijs Kruitbosch
c3acd03b82 Bug 1397447 - add UI and automatic toggles to make the auto-hide functionality more seamless, r=mak
MozReview-Commit-ID: 9xN3N4aLwfv

--HG--
extra : rebase_source : 54333982cce1dcb7cb84331734f170d4d79fbc29
2017-09-11 18:54:48 +01:00
Jared Wein
6c68f6b603 Bug 1387313 - Allow dragging non-removable items (url bar, back/forward buttons) within their toolbar. r=Gijs
MozReview-Commit-ID: 1EQxMcLJn9J

--HG--
extra : rebase_source : 884ddb84896bec96b4cc05d2d067e8e3a69603c7
2017-08-21 14:20:40 -04:00
Gijs Kruitbosch
163ee80617 Bug 1390260 - make customize mode work in popup windows, r=mkaply
MozReview-Commit-ID: 7lokGRuqNHv

--HG--
extra : rebase_source : 0015e3c60e97f117ddf3a72410f455e648a1138e
2017-08-15 12:02:11 +01:00
Sebastian Hengst
ad97051e47 Backed out changeset fb0d8aeff611 (bug 1390260) for failing mochitest browser_bug422590.js. r=backout 2017-08-15 17:13:15 +02:00
Gijs Kruitbosch
426e66c658 Bug 1390260 - make customize mode work in popup windows, r=mkaply
MozReview-Commit-ID: 7lokGRuqNHv

--HG--
extra : rebase_source : 0015e3c60e97f117ddf3a72410f455e648a1138e
2017-08-15 12:02:11 +01:00
Gijs Kruitbosch
6ff153a8b2 Bug 1388990 - avoid breaking the broadcast/listener relationships of the back/fwd buttons when customizing, r=dao
MozReview-Commit-ID: EsH3lv8QXfJ

--HG--
extra : rebase_source : 20325d2b014abf9687c83eae3cda267eeda078eb
2017-08-12 11:56:22 +01:00
Gijs Kruitbosch
b584e361b6 Bug 1381556 - adjust panel widths to accommodate longer/wider content, r=mikedeboer
MozReview-Commit-ID: 6bOoRIfttEy

--HG--
extra : rebase_source : d7748809abe4ee617d0cb1a9d66a3e88728ecc63
2017-08-09 14:04:21 +01:00
Michael Kohler
674e1b96fb Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao
MozReview-Commit-ID: 8w1vfF2yRui

--HG--
extra : rebase_source : 222d8e9d3b9543552ff5b08967375fa46d62b896
2017-08-08 12:09:14 +02:00
Jared Wein
76f886b972 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU

--HG--
extra : rebase_source : 203f7449e8345ed5c779dfc4fd5e9bd515b89da8
2017-08-07 12:37:34 -04:00
Gijs Kruitbosch
31718d41ae Bug 1387182 - fix border (empty space) compensation when dragging items in customize mode in RTL, r=jaws
MozReview-Commit-ID: AblsJGmu5zm

--HG--
extra : rebase_source : 96b595132989f4cb43986430094864289debeac1
2017-08-07 12:14:19 +01:00
Sebastian Hengst
ca40024d84 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
45d5f35624 Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
MozReview-Commit-ID: CoHv9mKpAe

--HG--
extra : rebase_source : 20d6404db9f90cfcb7de03d4c527ad6ed79d49f8
2017-08-05 20:37:40 +02:00
Dão Gottwald
ee6b05b899 Bug 1387602 - Update customize mode favicon. r=Gijs
MozReview-Commit-ID: 7gin0zuJTN0

--HG--
extra : rebase_source : 7b1d2394e32f4ed5763bc9562a6e7e87bdbf2c74
2017-08-04 23:00:00 +02:00
Gijs Kruitbosch
f1b0d2d8c3 Bug 1354117 - remove old panel code from customize mode and update related CSS, r=jaws
MozReview-Commit-ID: IwKUWMTagCK

--HG--
extra : rebase_source : e6c54f3b5d6115574f22f31380a4a07601776d1c
2017-08-02 11:51:58 +01:00
Rajesh Kathiriya
48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
Jared Wein
18b59c778a Bug 1383689 - Remove uninterruptible reflow at setToolbarButtonHeightProperty@resource://gre/modules/BrowserUtils.jsm. r=Gijs
MozReview-Commit-ID: 9WoXQ1nMWTZ

--HG--
extra : rebase_source : cdee661cd33d0aa06aceda7fa3a37b0c78ee3123
2017-08-01 15:33:01 -04:00
Sebastian Hengst
804a36e668 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
22dfa54ef4 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
2017-07-25 23:45:41 +05:30
Jared Wein
1e2bf53f24 Bug 1381991 - Pin to Overflow animation is placed in the wrong position when using a non-default font-size. r=sfoster
MozReview-Commit-ID: ERE1FnTuIWF

--HG--
extra : rebase_source : 7ab56c4ccaf12a1ce72801197414013bc0e70ead
2017-07-20 12:31:06 -04:00
Dão Gottwald
2ee97c338a Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems. r=johannh
MozReview-Commit-ID: 72S5zENy1gX

--HG--
extra : rebase_source : bdecd5c216638da9e83787150cffa970ae8da059
2017-07-21 14:11:15 +02:00
Wes Kocher
6dbec35ae2 Backed out changeset 320f9642bcef (bug 1381991) because it blocks backing out 1355922 a=backout
MozReview-Commit-ID: 7gM0DJkbVwW
2017-07-21 00:36:04 -07:00