Dorel Luca
1208bc03a7
Merge mozilla-central to autoland r=merge on a CLOSED TREE
...
--HG--
extra : rebase_source : 5f22b0e83fd5f1b28e0c1ebbcc429c332835eb36
2017-12-07 00:27:29 +02:00
Paolo Amadini
b12ae1861e
Bug 1417042 - Remove the "panelview" binding. r=Gijs
...
MozReview-Commit-ID: 26uQb3pteQd
--HG--
extra : rebase_source : 93263ff4f1e0d38292dbfef3f7385ddd881b25ef
extra : source : bce38a7817ee39ccd38f57f73f5acf81a41e1f69
2017-12-06 10:37:25 +00:00
Edouard Oger
7fabe73930
Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
...
MozReview-Commit-ID: BDTdmcIOHmn
--HG--
extra : rebase_source : c2b534461715f8db1e6cb8bc7910311cc4ff6611
2017-11-30 16:01:40 -05:00
Edouard Oger
ae62aef149
Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
...
MozReview-Commit-ID: 5vBKH9NejVV
--HG--
extra : rebase_source : c160a5a1d7753d41c7afec3a822aefa9461684e6
2017-11-17 16:48:17 -05:00
Noemi Erli
e5e82c8496
Backed out changeset 932a77d8fbae (bug 1418466) for ES failures in /builds/worker/checkouts/gecko/browser/base/content/browser-sync.js r=backout on a CLOSED TREE
2017-11-30 18:44:16 +02:00
Edouard Oger
016b5734e5
Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh
...
MozReview-Commit-ID: 5vBKH9NejVV
--HG--
extra : rebase_source : e8628aba338b19142dc63add9bb380042096053f
2017-11-17 16:48:17 -05:00
Mike Conley
4250a7d5e6
Bug 1412471 - Fix intermittent failure in browser_panelUINotifications_fullscreen_noAutoHideToolbar.js by ensuring we wait for update popup. r=Gijs
...
MozReview-Commit-ID: Yypy0ls4Ap
--HG--
extra : rebase_source : 5ab46c85c58da785fe4ae31ed84da58698cc47fa
2017-11-24 10:55:41 -05:00
Dorel Luca
171c255f60
Backed out changeset 1ca98c1618a6 (bug 1422106) for failing browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE
2017-12-02 02:37:38 +02:00
Edouard Oger
afb8b81041
Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
...
MozReview-Commit-ID: BDTdmcIOHmn
--HG--
extra : rebase_source : 747637f3746356e3da208acc41a3629bd2597e2e
2017-11-30 16:01:40 -05:00
Dorel Luca
e07748b33c
Backed out changeset 3aff028846c0 (bug 1422106) for failing syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js and browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE
...
--HG--
extra : rebase_source : ec98a160ef77f13abc4b067f8836e290e3b11e21
2017-12-02 00:33:41 +02:00
Edouard Oger
2a41681065
Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
...
MozReview-Commit-ID: BDTdmcIOHmn
--HG--
extra : rebase_source : b1471e1ef0163b2d3b137852d285146f5a23f1fa
2017-11-30 16:01:40 -05:00
Gijs Kruitbosch
46b1167088
Bug 1420583 - fix new tab adjacency logic when using "restore defaults", r=jaws
...
When using "restore defaults", Customize mode unwraps all elements. The previous implementation
of _updateNewTabVisibility assumed that elements were wrapped in <toolbarpaletteitem>s when in
customize mode, but this isn't true during a reset. The new implementation just looks for the
<toolbarpaletteitem>s and their children as necessary.
MozReview-Commit-ID: FjNJ1n8foGi
--HG--
extra : rebase_source : c9de8a2a4d4dcf191281fead320acc2ddc1321d6
2017-11-27 15:23:42 +00:00
Tawny Hoover
a33fa6a1f2
Bug 1398992 = Make 'Recently Bookmarked' in Photon panels support browser.bookmarks.openInTabClosesMenu pref. r=jaws
...
MozReview-Commit-ID: 3Rio9EjwilT
--HG--
extra : rebase_source : dde522b0eb65b22ee74d8dfb6d5f1d1a5489237f
2017-11-24 21:54:54 -05:00
Gijs Kruitbosch
53181787f7
Bug 1418757 - new tab button isn't adjacent to the last tab when customizing in customize mode, r=jaws
...
MozReview-Commit-ID: bQoNfDD2sX
--HG--
extra : rebase_source : e8afb0662e82e3b879bd3b6e28aef27d477bf92c
2017-11-22 13:49:07 +00:00
Paolo Amadini
fc23659e93
Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
...
MozReview-Commit-ID: IjvSZZUHUMt
--HG--
extra : rebase_source : a94e212e8af35b77806d1d62e020a511ab62e224
2017-11-21 14:21:32 +00:00
Alphan Chen
54f4537537
Bug 980904 - Disable the Character Encoding menu when document is decoded as UTF-8 without errors. r=hsivonen,emk,Gijs
2017-11-23 15:03:41 +08:00
Tooru Fujisawa
50f5bf47cd
Bug 1418739 - Part 2: Remove unused delayedStartup parameter from BrowserTestUtils.waitForNewWindow. r=smaug
2017-11-21 03:41:56 +09:00
Mark Banner
ab78a2a54d
Bug 1371293 - Fix instances of space-before-function-paren failures after ESLint 4 upgrade. r=mossop
...
MozReview-Commit-ID: 5XfdCSDjLEG
--HG--
extra : rebase_source : 96335eec91a40f893ff28a1c002653b758d8f24d
2017-11-06 13:46:21 +00:00
Gijs Kruitbosch
7cc3de1624
Bug 1388029 - remove dead CSS relating to the old panel, r=jaws
...
MozReview-Commit-ID: FoXjvWPc9in
--HG--
extra : rebase_source : b098e2efc8f154aaae5f4ddfd30558fb0f3299c1
2017-11-07 12:52:56 +00:00
Gijs Kruitbosch
8c1b02e3d4
Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
...
MozReview-Commit-ID: L017kRfHfOv
--HG--
extra : rebase_source : c9dcbb76d787281ac2dcf18c59786205aeaacaf9
2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
974b0a4c68
Bug 1408166 - prevent search bar popup from ever showing when browser_940307_panel_click_closure_handling is running to avoid it interfering with context menu clicks, r=florian
...
MozReview-Commit-ID: jyRcdAKpxR
--HG--
extra : rebase_source : 66d4452809e8b66383bf8cfb02cfc695b9ade37a
2017-11-07 10:54:10 +00:00
Jared Wein
b8ffd9d167
Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
...
Original patch authored by Tim Nguyen (:ntim).
MozReview-Commit-ID: 6qQnRMQXPTH
--HG--
extra : rebase_source : 319d160f3057173359f02adba44bdcc12a68e209
2017-10-31 14:38:15 -04:00
Coroiu Cristina
03154bfceb
Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE
...
Backed out changeset b558ad2372bf (bug 1410666)
2017-11-02 01:02:12 +02:00
Jared Wein
2fdc4b7cdf
Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
...
Original patch authored by Tim Nguyen (:ntim).
MozReview-Commit-ID: 6qQnRMQXPTH
--HG--
extra : rebase_source : f85e763cc130a71ba0f4bda228a874ebf65b84be
2017-10-31 14:38:15 -04:00
Mark Banner
01008c7d57
Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian
...
MozReview-Commit-ID: 8pidN7x6MYh
--HG--
extra : rebase_source : 6a0d6800091231fc1535223bd7fc6df0ba40d47b
2017-10-30 09:55:39 +00:00
Edouard Oger
76547f53cc
Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
...
MozReview-Commit-ID: APdGc9avJDw
--HG--
extra : rebase_source : aaa788be5251607ebedcb5b690da0e2a1a64e2cb
2017-10-24 14:05:52 -04:00
Sebastian Hengst
93903f0306
Backed out 2 changesets (bug 1395460) for eslint failure at browser/components/uitour/UITour.jsm:556 (no return value from arrow function). r=backout on a CLOSED TREE
...
Backed out changeset 0bc6d186d609 (bug 1395460)
Backed out changeset 6c028123001d (bug 1395460)
2017-10-26 23:33:04 +02:00
Edouard Oger
58876ecbe9
Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
...
MozReview-Commit-ID: APdGc9avJDw
--HG--
extra : rebase_source : 9da1cea9fb6494c057bc6587a7bcbdb4ac127448
2017-10-24 14:05:52 -04:00
Felipe Gomes
43ee76c5ed
Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
...
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.
MozReview-Commit-ID: 2qNWebBpsMY
--HG--
extra : rebase_source : b30a4492f839186584c074b82a1969973cda48e0
2017-10-17 13:39:50 -02:00
Ryan VanderMeulen
e8cd5f653b
Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies.
...
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
2017-10-17 10:07:55 -04:00
Felipe Gomes
4346cedc0e
Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
...
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.
MozReview-Commit-ID: 8wbjdYIC3gb
--HG--
extra : rebase_source : 2ea1b77d4a9fd9c3eb17853c8ec655b309a3fa8c
2017-10-16 14:00:30 -02:00
Dan Banner
7caa92d5d8
Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
...
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Julian Descottes
6a18c24749
Bug 1361080 - filter out hidden devtools menu items in customizableui test;r=jaws
...
DevTools are adding a hidden menuitem "Enable DevTools..." that will be used to
propose an onboarding screen to users. This hidden button makes a customizable ui
test fail. It needs to be filtered out.
MozReview-Commit-ID: IX4SlpDHdsT
--HG--
extra : rebase_source : e2c9e26b27b1bf8788739f8d6384c19473ffdd23
2017-10-11 17:04:22 +02:00
Erica Wright
86e507bf06
Bug 1406191 - Cleanup browser_widget_animation.js, remove event listener and close panel correctly. r=johannh
...
MozReview-Commit-ID: 6IjrdxnWPqa
--HG--
extra : rebase_source : 5b52caffa1d523964ee485859dd562919f5f971a
2017-10-10 15:59:14 -04:00
Dão Gottwald
8fa6f14905
Bug 1406625 - Remove leftover code and styling for <toolbarbutton type="menu-button"> r=mikedeboer
...
MozReview-Commit-ID: 8wBsluIMZHq
--HG--
extra : rebase_source : 8733868d1afc6a34b6e9050b6bd80f01097a66f3
2017-10-07 20:10:24 +02:00
Erica Wright
7e91455352
Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs
...
MozReview-Commit-ID: 5PxydbSfhpz
--HG--
extra : rebase_source : 3941fa6edb5e8eb0d14d6d04ad5b0d63ef1a5b84
2017-09-18 16:15:24 -04:00
Gijs Kruitbosch
19ef18501c
Bug 1405720 - ensure only 1 theme is ever shown as selected in customize mode, r=jaws,johannh
...
The previous code here always set the `isActive` property on all themes. When writing the
patch for bug 1402981 I ran into issues because the default theme has an `isActive` property
anyway (it's a different type of object). So I tried to avoid setting `isActive` if it was
already present. Unfortunately, the result was that `isActive` values, once set, weren't
correctly updated. Worse, these values are (and were, prior to bug 1402981) persisted in
some cases.
There's no point persisting these values, all that will happen is that they'll start
mismatching the 'real' state of the world (LightweightThemeManager.currentTheme). So instead,
let's just not set the `isActive` property at all, and rely solely on the ID of the current
theme (or the default theme's ID, now that we no longer support non-lightweight-themes) to
establish whether any of the themes should appear selected or not.
MozReview-Commit-ID: 7rajS71FoQR
--HG--
extra : rebase_source : a99e04031ea9e122efdaf0436e354abe57439783
2017-10-05 15:17:12 +01:00
Edouard Oger
e29fd6597a
Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
...
MozReview-Commit-ID: AIBjAZZlYX6
--HG--
extra : rebase_source : cc4d0d3ca7d12b2f83b79fc7c5db9c05f77944cf
2017-09-20 13:16:19 -04:00
Sebastian Hengst
6c9c0c17e9
Backed out changeset 9ab9bde4021f (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout
2017-10-04 21:49:30 +02:00
Edouard Oger
27e4a543cc
Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
...
MozReview-Commit-ID: AIBjAZZlYX6
--HG--
extra : rebase_source : 23d246a20afd7069f095e29b2943851011813239
2017-09-20 13:16:19 -04:00
Sebastian Hengst
0b883eed0e
Backed out changeset 97fdb9d392e5 (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout
2017-10-04 21:12:32 +02:00
Edouard Oger
bc78c3795e
Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
...
MozReview-Commit-ID: AIBjAZZlYX6
--HG--
extra : rebase_source : 3172be8b46d44c50ea4f2c806771e10172057cf3
2017-09-20 13:16:19 -04:00
Gijs Kruitbosch
49c8b259d5
Bug 1396423 - make it possible to drop items in what visually looks like the palette but isn't, r=mikedeboer
...
MozReview-Commit-ID: AqBwn9ovTjT
--HG--
extra : rebase_source : 58dd5d79db16d56be502f70cd7e533a4093f1c39
2017-09-29 15:40:48 +01:00
Gijs Kruitbosch
f207243be7
Bug 1402981 - add light and dark themes to the list of themes in customize mode by default, r=jaws
...
MozReview-Commit-ID: 4GxPEm119Yc
--HG--
extra : rebase_source : a1a6acf06e158fd937e6b53ea65cc91c2e4d02ce
2017-09-27 22:37:19 +01:00
Mike de Boer
882fa06e25
Bug 1401991 - Ensure that we don't hide panelviews that are already reparented to another multi-view and ensure to hide other panels consistently. r=Gijs
...
* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
the binding is already gone.
* Generalize things into `hideAllViewsExcept(thisOne)`:
- Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
in there too,
- For Photon panels, do all the 'current' attribute setting in there. To show
a panel during transition, I introduced the 'in-transition' attribute.
* I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
that confuses some,
* Move the temporary panel handling, which contains an ephemeral panelmultiview
instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
* Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
* Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
specific transition, _if_ that's passed in as an argument. This resolves any
potential raciness that might occur when `showSubView()` is called again mid-transition.
* Skip the UITour element visibility check when it's inside a panelview, because
too many things need to happen and that check is too simple to be useful in
that case.
MozReview-Commit-ID: 5HpJKs1Ny5j
--HG--
extra : rebase_source : b810e1de2dbd75932a42d68e751fdaecd9fee69a
2017-09-29 13:51:51 +02:00
Sebastian Hengst
e0196045d0
Backed out changeset 8855ba3f65ba (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout
2017-09-28 20:27:50 +02:00
Edouard Oger
c602795751
Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh
...
MozReview-Commit-ID: AIBjAZZlYX6
--HG--
extra : rebase_source : 562023d6bfdb78aa2fad6c42948b57db8bc04f99
2017-09-20 13:16:19 -04:00
Mike de Boer
c0b0c75c02
Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs
...
MozReview-Commit-ID: 44Q9NbKEJeC
--HG--
extra : rebase_source : 4895a170b403195cd1bc7023fc905deff12c2de2
2017-09-20 14:25:58 +02:00
Andrew Halberstadt
7527e600f0
Bug 1392787 - Disable manifestparser tests using 'disabled' key instead of comment, r=jmaher
...
MozReview-Commit-ID: IQL7hWxQX9F
--HG--
extra : rebase_source : b78cbf7913fc1b0a27dfa085c38957e2bc2467d0
2017-08-22 16:56:02 -04:00
Gijs Kruitbosch
b7ec7b74c5
Bug 1399517 - CustomizableUI shouldn't try to insert items next to nodes that aren't in the right container, r=mikedeboer
...
MozReview-Commit-ID: H9KY7YQwmlQ
--HG--
extra : rebase_source : 75f92768868003280a8e187ce6f2bbc2b88dd8ca
2017-09-18 16:36:46 +01:00