Commit graph

238 commits

Author SHA1 Message Date
Boris Zbarsky
454784fb68 Bug 473390 part 2. Call SetInitialChildList on HTML frames even if the child list is empty, to bring HTML in line with everything else. r+sr=roc 2009-01-19 13:31:31 -05:00
Benjamin Smedberg
3498a5f86e Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
4872871d0b Fix some missed renames from bug 471356. r+sr=bzbarsky 2009-01-04 14:52:38 -05:00
L. David Baron
4690547534 Stop using nsAreaFrame for anything other than xul:label, which is the only thing for which it does anything different from nsBlockFrame, and rename it accordingly. (Bug 471356) r+sr=roc
--HG--
rename : layout/generic/nsAreaFrame.cpp => layout/xul/base/src/nsXULLabelFrame.cpp
rename : layout/generic/nsAreaFrame.h => layout/xul/base/src/nsXULLabelFrame.h
2008-12-29 10:07:38 -05:00
Olli Pettay
28cb4846da Bug 469720 - tabindex of -1 set in javascript ignored on file input, r+sr=bz 2008-12-17 09:33:33 +02:00
Boris Zbarsky
562d828fdd Bug 433616 part 1. Make it possible to create a document viewer with no parent widget or container, and make various code saner about handling null document/prescontext/documentviewer containers. r=roc, sr=jst 2008-09-28 15:14:28 -04:00
Boris Zbarsky
9599df476b Backing out changesets 2ea77fa990af, 7d2d8869e73c, 93441e4f521e, 43d2ee100f3b, a2d84821ea71 to see whether they're causing the Windows Txul or Mac Tp regressions 2008-09-29 08:51:29 -04:00
Boris Zbarsky
a6aec54eaf Bug 433616 part 1. Make it possible to create a document viewer with no parent widget or container, and make various code saner about handling null document/prescontext/documentviewer containers. r=roc, sr=jst 2008-09-28 15:14:28 -04:00
Taras Glek
74132a5585 bug 450777:deCOMtaminate nsNodeInfoManager::GetNodeInfo r+sr=jst 2008-09-12 15:32:18 -07:00
Robert O'Callahan
519c75bf87 Bug 331088. Handle file-control frame being torn down while the dialog is up. r=smaug,sr=mats 2008-08-15 22:21:31 +12:00
jst@mozilla.org
4b69a276d4 Landing fix for bug 419716. Make us consistently deal how we're pass param tags to object tags when parsing XHTML. Patch by mrbkap@gmail.com and bent.mozilla@gmail.com, r+sr=jonas@sicking.cc, a=beltzner 2008-04-17 15:30:51 -07:00
timeless@mozdev.org
b0e4df4591 Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-04-06 05:28:34 -07:00
timeless@mozdev.org
7f880e43ef reverting, wrong patch, missing AMBIGUOUS 2008-03-19 14:55:22 -07:00
timeless@mozdev.org
022712406a Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-03-19 14:19:35 -07:00
Olli.Pettay@helsinki.fi
065cc2d962 Bug 411212, cannot prevent file-picker from showing on <INPUT TYPE=FILE>, r+sr=roc+bzbarsky, a=mtschrep 2008-01-10 13:55:38 -08:00
reed@reedloden.com
4438253756 Bug 409587 - "input[type="file"] cropped when narrow width specified" [p=kinetik@flim.org (Matthew Gregan) r+sr=roc a1.9=beltzner] 2008-01-07 14:18:06 -08:00
reed@reedloden.com
5847c7c368 Bug 363696 - "Crash [@ nsHTMLReflowState::ComputeContainingBlockRectangle] with file upload control in xul" [p=kinetik@flim.org (Matthew Gregan) r=bzbarsky sr=roc a=blocking1.9+] 2007-11-26 19:35:50 -08:00
aaronleventhal@moonset.net
f98359daf4 Bug 385070. Accessible subtrees for anonymous content need to be shut down. Patch by Evan Yan. r=aaronlev, r+sr=roc for layout part, a=dsicor 2007-11-20 12:39:36 -08:00
Evan.Yan@Sun.COM
b93b199daf back out patch of bug 385070 which broke accessible tree, to make nightly build safe 2007-11-16 01:12:58 -08:00
aaronleventhal@moonset.net
f80f334157 Bug 385070. Nodes in anonymous content trees that are hidden not being shut down. Patch by Evan Yan. r=aaronlev, r+sr=roc, a=mconnor 2007-11-15 17:38:33 -08:00
neil@parkwaycc.co.uk
67f7e866a9 Bug 399968 Back out some parts from bug 258875 that have no effect r+sr+a=roc 2007-10-19 01:51:27 -07:00
aaronleventhal@moonset.net
c773b68f7e bug 397644. File control not exposed correctly to a11y apis. r+sr+a=roc 2007-09-27 18:09:14 -07:00
bzbarsky@mit.edu
34769343d2 When a file has already been selected, correctly prefill the filepicker with that file. Bug 374013, r+sr=sicking, a=dbaron 2007-08-14 11:42:10 -07:00
bzbarsky@mit.edu
9c59e9e4cc Introduce a setter for nsHTMLReflowState::mComputedHeight so that we're sure to
update the resize flags properly.  Bug 388084, r+sr+a=dbaron
2007-08-02 11:08:05 -07:00
bzbarsky@mit.edu
b66e0608e5 Update the visual look of a file input when privileged script sets its value.
Bug 387978, r+sr=sicking
2007-07-13 21:46:09 -07:00
jwalden@mit.edu
6d7584839a Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
mats.palmgren@bredband.net
42a227c78a Cleanup implementations of QueryInterface. b=385750 r+sr=dbaron r+sr=jst 2007-07-03 19:15:31 -07:00
Olli.Pettay@helsinki.fi
7817abfbca Bug 363089, Remove nsIDOMEventReceiver (this time passes mochitest), r+sr=jst 2007-05-14 02:11:38 -07:00
Olli.Pettay@helsinki.fi
40178e46a3 backout Bug 363089 2007-05-11 06:34:05 -07:00
Olli.Pettay@helsinki.fi
e1fb8b073b Bug 363089, Remove nsIDOMEventReceiver, r+sr=jst 2007-05-11 04:15:11 -07:00
bzbarsky@mit.edu
eeaa1a101b Rename nsIFrame::GetPresContext to nsIFrame::PresContext. Bug 376042, patch byTaras Glek <tglek@mozilla.com>, rs=roc. 2007-03-30 14:11:41 -07:00
dbaron%dbaron.org
9d7f938b99 Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc 2007-02-24 18:33:33 +00:00
mats.palmgren%bredband.net
ca7914d49f Make nsFileControlFrame, nsIsIndexFrame and nsLegendFrame QI to kBlockFrameCID. b=370933 r+sr=bzbarsky 2007-02-24 04:42:53 +00:00
asqueella%gmail.com
284a5ea424 bug 257868 - remove the nsIPresShell::SetAnonymousContentFor() API, make the frames store strong refs to the anonymous content instead. Decomtaminate nsIAnonymousContentCreator.
r+sr=roc
2007-02-18 17:34:09 +00:00
sharparrow1%yahoo.com
db47d007bc Bug 370303: Cleanup in layout/forms. r+sr=roc. 2007-02-15 10:58:31 +00:00
smontagu%smontagu.org
2932d47653 Remove obsolete state bit NS_BLOCK_SHRINK_WRAP. Bug 369243, r=bz, sr=dbaron 2007-02-15 05:07:57 +00:00
mats.palmgren%bredband.net
3737d80b97 OnChange is sometimes triggered for scripted changes. b=265047 r+sr=jst 2007-01-05 16:31:07 +00:00
timeless%mozdev.org
4e651390ef Bug 355300 There should be only one nsGkAtoms creature
r=dbaron
2006-12-26 17:47:52 +00:00
dbaron%dbaron.org
31f1898810 Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213. 2006-12-08 05:38:33 +00:00
bzbarsky%mit.edu
f0ebd23c1e Additional tweak to the patch for bug 355931 -- fix QI too. 2006-11-13 22:20:39 +00:00
bzbarsky%mit.edu
c4e415d4a7 Don't use frames to implement interfaces, dammit. Just don't! Bug 355931, r+sr=roc 2006-11-13 22:05:25 +00:00
bzbarsky%mit.edu
618c586548 When setting the textfield value via the filepicker, tell it that it's not
focused so that onchange will fire as it should.  Bug 355362, r+sr=jst
2006-10-15 15:39:35 +00:00
smontagu%smontagu.org
2a6805b2f8 Remove unnecessary hack for right-to-left file inputs. Bug 346726, r=uriber, sr=roc 2006-08-07 06:31:55 +00:00
mats.palmgren%bredband.net
47bd18fde6 Remove the special painting code for a 165-twips checkbox. Move the remaining parts of nsFormControlHelper to its consumers and remove nsFormControlHelper.{cpp,h} from the tree. b=343495 r+sr=roc (r=me on roc's part) 2006-07-06 10:43:51 +00:00
cvshook%sicking.cc
e9a820078f Bug 334977. Separate mFileName from mValue. r/sr=bz 2006-04-25 09:18:42 +00:00
roc+%cs.cmu.edu
a7f03736a9 Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc 2006-04-10 00:16:29 +00:00
roc+%cs.cmu.edu
0a10a79f62 Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc 2006-03-26 21:30:36 +00:00
pavlov%pavlov.net
131e8794e2 backing out roc's patch for bug 328926 due to crash running tests on vc8 machines. 2006-03-15 06:43:36 +00:00