Mark Banner
874f074b0d
Bug 1915486 - Fix document generation errors about 'Undefined substitution referenced' in migration component's JSDoc. r=migration-reviewers,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D220492
2024-08-29 15:21:53 +00:00
Mark Banner
a55c556aad
Bug 1870226 - Use typescript Record definitions rather than Object<> generic forms for jsdoc. r=zombie,webdriver-reviewers,omc-reviewers,aminomancer,kpatenio
...
Differential Revision: https://phabricator.services.mozilla.com/D219511
2024-08-23 16:43:56 +00:00
Mark Banner
a8b695dcda
Bug 1870226 - Fix missing jsdoc @returns for other browser code. r=firefox-desktop-core-reviewers ,backup-reviewers,kpatenio.
...
Differential Revision: https://phabricator.services.mozilla.com/D219510
2024-08-23 16:43:56 +00:00
Butkovits Atila
2837d313b2
Backed out 7 changesets (bug 1870226) for causing build bustages. CLOSED TREE
...
Backed out changeset 619244623dba (bug 1870226)
Backed out changeset e85a5647cae4 (bug 1870226)
Backed out changeset 21ea9baf83ea (bug 1870226)
Backed out changeset a506c0f0ce28 (bug 1870226)
Backed out changeset 77c78201a206 (bug 1870226)
Backed out changeset 7a98dfef087f (bug 1870226)
Backed out changeset f64ad89c2406 (bug 1870226)
2024-08-23 12:22:02 +03:00
Mark Banner
38fa6dd49f
Bug 1870226 - Use typescript Record definitions rather than Object<> generic forms for jsdoc. r=zombie,webdriver-reviewers,omc-reviewers,aminomancer,kpatenio
...
Differential Revision: https://phabricator.services.mozilla.com/D219511
2024-08-23 08:55:49 +00:00
Mark Banner
ed21888b2c
Bug 1870226 - Fix missing jsdoc @returns for other browser code. r=firefox-desktop-core-reviewers ,backup-reviewers,kpatenio.
...
Differential Revision: https://phabricator.services.mozilla.com/D219510
2024-08-23 08:55:48 +00:00
Sylvestre Ledru
45030f6970
Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
...
This new version of clang 17 also slightly changed the formatting.
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D215914
2024-07-17 11:15:31 +00:00
Joel Maher
3d4dfe804d
Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D214969
2024-07-09 13:01:55 +00:00
Joel Maher
da12dca273
Bug 1905919 - add os_integration tag for marionette migration test. r=migration-reviewers,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D215681
2024-07-04 15:56:44 +00:00
Jason Prickett
471ac8b38d
Bug 1901499 - Allow extensions success link to open in spotlight r=mconley
...
This patch allows the extensions success link to also be opened when the migration wizard is running in the spotlight. The issue seems to be that the browser element used in `OpenAboutAddons` doesn't exist when running in spotlight, so I've opted to instead allow the event to be handled with `OpenURL` when running in the aboutwelcome bundle, and also adding a parameter to handle trusted links with OpenURL.
Differential Revision: https://phabricator.services.mozilla.com/D213666
2024-06-18 19:51:37 +00:00
Jason Prickett
53a0149209
Bug 1896597 - Add custom event for migration wizard anchors to be handled in spotlight r=mconley,migration-reviewers,mviar
...
Differential Revision: https://phabricator.services.mozilla.com/D212898
2024-06-08 03:53:10 +00:00
Stanca Serban
df70b34d17
Backed out changeset 75215e4ff218 (bug 1896597) for causing mochitests failures.
2024-06-08 04:24:47 +03:00
Jason Prickett
4a3aa18e7e
Bug 1896597 - Add custom event for migration wizard anchors to be handled in spotlight r=mconley,migration-reviewers,mviar
...
Differential Revision: https://phabricator.services.mozilla.com/D212898
2024-06-08 00:47:23 +00:00
Daisuke Akatsuka
4ac50f3930
Bug 1894821: Throw NS_ERROR_FILE_TOO_BIG if the favicon data size is over than MAX_FAVICON_BUFFER_SIZE r=places-reviewers,mak,migration-reviewers,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D210261
2024-05-15 21:42:59 +00:00
Daisuke Akatsuka
daa9cee106
Bug 1552815: Use setFaviconForPage() instead of replaceFaviconData() r=mak,migration-reviewers,mconley
...
Depends on D192536
Differential Revision: https://phabricator.services.mozilla.com/D192537
2024-05-01 20:40:50 +00:00
Stanca Serban
a5a1a182a7
Backed out 5 changesets (bug 1552815) for causing bp-nu bustages in nsFaviconService.cpp. CLOSED TREE
...
Backed out changeset 4be83e948d32 (bug 1552815)
Backed out changeset 0b2d40719586 (bug 1552815)
Backed out changeset c17e4da85514 (bug 1552815)
Backed out changeset c66812747d09 (bug 1552815)
Backed out changeset 62b3d85f4ca3 (bug 1552815)
2024-05-01 09:58:57 +03:00
Daisuke Akatsuka
a7332a1e4f
Bug 1552815: Use setFaviconForPage() instead of replaceFaviconData() r=mak,migration-reviewers,mconley
...
Depends on D192536
Differential Revision: https://phabricator.services.mozilla.com/D192537
2024-05-01 05:47:09 +00:00
negin
578f9ba7b8
Bug 1886362 - Fix about:welcome import button not collapsing on panel click r=mconley,reusable-components-reviewers,migration-reviewers,omc-reviewers,mstriemer,emcminn
...
[try run](https://treeherder.mozilla.org/jobs?repo=try&revision=4b88f22a24d43c9927422b5f3bcca354 )
Differential Revision: https://phabricator.services.mozilla.com/D206946
2024-04-26 20:32:37 +00:00
Sandor Molnar
111bc93fa5
Backed out changeset 7b6284ac44a7 (bug 1886362) for causing bc failures @ browser_aboutwelcome_multistage_mr.js CLOSED TREE
2024-04-26 02:44:02 +03:00
negin
599c8b98ba
Bug 1886362 - Fix about:welcome import button not collapsing on panel click r=mconley,reusable-components-reviewers,migration-reviewers,mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D206946
2024-04-25 21:52:31 +00:00
Stanca Serban
708910a8f3
Backed out 5 changesets (bug 1552815) for causing bp-nu bustages in nsFaviconService.cpp.
...
Backed out changeset 08a2ac7a9834 (bug 1552815)
Backed out changeset bb9854e6ffe7 (bug 1552815)
Backed out changeset 4e06ccb2599e (bug 1552815)
Backed out changeset d28dd2aec9f4 (bug 1552815)
Backed out changeset 392389a8d495 (bug 1552815)
2024-04-24 03:03:10 +03:00
Daisuke Akatsuka
19c31d9c59
Bug 1552815: Use setFaviconForPage() instead of replaceFaviconData() r=mak,migration-reviewers,mconley
...
Depends on D192536
Differential Revision: https://phabricator.services.mozilla.com/D192537
2024-04-23 23:21:39 +00:00
Nikki Sharpley
a7ee336109
Bug 1885664 - PlacesQuery#getHistory() should have the option to fetch infinite history r=fxview-reviewers,places-reviewers,sclements
...
`PlacesQuery#getHistory()` now has the option to fetch all history by passing in Infinity daysOld
Differential Revision: https://phabricator.services.mozilla.com/D207446
2024-04-22 12:53:41 +00:00
Mark Banner
cbbf28809f
Bug 1799465 - Enable require-jsdoc rules by default, disabling on code where there are existing failures. r=frontend-codestyle-reviewers,migration-reviewers,backup-reviewers,mossop,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D206878
2024-04-08 13:34:13 +00:00
negin
93bb00b7a9
Bug 1889703 - Re-introduce embedded migration wizard default title r=migration-reviewers,aminomancer,mconley,omc-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D206683
2024-04-04 19:25:53 +00:00
Jason Prickett
4b0b6bbd2c
Bug 1876176 - Update migration wizard to support future experiments r=omc-reviewers,desktop-theme-reviewers,mconley,migration-reviewers,aminomancer,Itiel
...
Differential Revision: https://phabricator.services.mozilla.com/D201142
2024-03-22 02:29:57 +00:00
Sandor Molnar
f76d82bb40
Backed out 2 changesets (bug 1876176) for causing node newtab failures @ browser/components/aboutwelcome CLOSED TREE
...
Backed out changeset 4899c27af9c2 (bug 1876176)
Backed out changeset 9ae306e9577a (bug 1876176)
2024-03-21 20:57:54 +02:00
Sandor Molnar
7de23da35f
Bug 1876176 - Fix file-whitespace failure. a=lint-fix CLOSED TREE
2024-03-21 20:32:24 +02:00
Jason Prickett
175299ce36
Bug 1876176 - Update migration wizard to support future experiments r=omc-reviewers,desktop-theme-reviewers,mconley,migration-reviewers,aminomancer,Itiel
...
Differential Revision: https://phabricator.services.mozilla.com/D201142
2024-03-21 17:21:05 +00:00
Dave Townsend
a9a51bf046
Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Tim Giles
27ecbe8d71
Bug 1885421 - Fix migration wizard links not opening in new tabs. r=mconley,migration-reviewers
...
The support-text links should open a new tab instead of interrupting
the migration process.
Differential Revision: https://phabricator.services.mozilla.com/D204693
2024-03-15 16:11:33 +00:00
Mark Banner
9fe8bde13c
Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer
...
Differential Revision: https://phabricator.services.mozilla.com/D204182
2024-03-11 15:26:28 +00:00
Bojidar Marinov
061e6bc804
Bug 1839845 - Try switching to about:settings tab when opening about:preferences. r=Gijs,extension-reviewers,migration-reviewers,mconley,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D202735
2024-02-29 10:09:59 +00:00
Gregory Pappas
1dfbfcfd07
Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
...
Depends on D200551
Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 21:29:39 +00:00
Gregory Pappas
27838882b1
Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
...
Depends on D200546
Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 21:29:37 +00:00
Sandor Molnar
3951121cc6
Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
...
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Gregory Pappas
8a677e7f39
Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
...
Depends on D200551
Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 15:07:46 +00:00
Gregory Pappas
67cc3e9258
Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
...
Depends on D200546
Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 15:07:44 +00:00
Mark Banner
68faaa0166
Bug 1878110 - Change marionette based tests to import ES modules directly. r=arai,webdriver-reviewers,jgraham,application-update-reviewers,bytesized,migration-reviewers,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D200373
2024-02-23 18:39:31 +00:00
Mark Banner
8e8cc1684d
Bug 1879811 - Avoid re-enabling ESLint rules when they are already enabled by ESLint's recommended configuration, or mozilla-central's one. r=Gijs,webcompat-reviewers,extension-reviewers,devtools-reviewers,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D201361
2024-02-12 18:46:28 +00:00
Joel Maher
3ad5072cf1
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
221d7acc5b
Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures.
2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
96fbfbdfb0
Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Joel Maher
807575f8e1
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Erik Nordin
2a01092c90
Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster
...
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198826
2024-01-19 02:15:33 +00:00
Erik Nordin
736a5983b8
Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell
...
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198825
2024-01-19 02:15:33 +00:00
Gregory Pappas
1ea1f154f9
Bug 1872922 - Replace last few uses of XPCOMUtils.defineLazyGetter with ChromeUtils.defineLazyGetter and add linter error for XPCOMUtils.defineLazyGetter r=extension-reviewers,credential-management-reviewers,devtools-reviewers,Standard8,arai,robwu,Gijs,sgalich
...
Differential Revision: https://phabricator.services.mozilla.com/D198677
2024-01-17 15:54:00 +00:00
Henrik Skupin
5217f294ff
Bug 1836727 - [marionette] Fix MARIONETTE_MANIFESTS usage in moz.build files. r=webdriver-reviewers,necko-reviewers,application-update-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,Standard8,jesup,jdescottes,nalexander,sclements,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D197515
2024-01-11 10:34:29 +00:00
Mark Banner
8ce23e4908
Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in system modules. r=Gijs,perftest-reviewers,necko-reviewers,extension-reviewers,application-update-reviewers,fxview-reviewers,sync-reviewers,sessionstore-reviewers,reusable-components-reviewers,rpl,jesup,hjones,kshampur,skhamis,nalexander,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D197489
2024-01-05 09:22:34 +00:00
Nikki Sharpley
81c08a33fb
Bug 1864534 - remove firefox-view-next pref and update about AboutRedirector r=fxview-reviewers,Gijs
...
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
2024-01-04 15:40:22 +00:00