Commit graph

4775 commits

Author SHA1 Message Date
Matt Woodrow
4b70f9f830 Bug 1578624 - P11: Add a flag to ask the parent to not actually load the URI when opening a window, since we'll do it ourselves anyway. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D47867

--HG--
extra : moz-landing-system : lando
2019-10-09 07:54:45 +00:00
Matt Woodrow
83f0f46289 Bug 1578624 - P7: Listen for keyword-uri-fixup events from the parent process in browser.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D44763

--HG--
extra : moz-landing-system : lando
2019-10-09 06:37:51 +00:00
Narcis Beleuzu
3429292547 Backed out 11 changesets (bug 1578624) for bustages on WindowGlobalChild.h . CLOSED TREE
Backed out changeset 478897956ee0 (bug 1578624)
Backed out changeset ab9c09164df0 (bug 1578624)
Backed out changeset f461f10efa46 (bug 1578624)
Backed out changeset 9b958693a003 (bug 1578624)
Backed out changeset 3b8220a15051 (bug 1578624)
Backed out changeset 180407dc57a8 (bug 1578624)
Backed out changeset bb11892e2171 (bug 1578624)
Backed out changeset 4f5c28244290 (bug 1578624)
Backed out changeset 6c02bbe5c1c5 (bug 1578624)
Backed out changeset 1d762fdce921 (bug 1578624)
Backed out changeset 818bc6e20c7d (bug 1578624)

--HG--
extra : histedit_source : ea22e628bf35425402009e9af274602f342a7476
2019-10-09 08:52:25 +03:00
Matt Woodrow
d2a7eac05f Bug 1578624 - P11: Add a flag to ask the parent to not actually load the URI when opening a window, since we'll do it ourselves anyway. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D47867

--HG--
extra : moz-landing-system : lando
2019-10-03 23:15:19 +00:00
Matt Woodrow
74cf18e268 Bug 1578624 - P7: Listen for keyword-uri-fixup events from the parent process in browser.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D44763

--HG--
extra : moz-landing-system : lando
2019-10-04 02:02:33 +00:00
Harry Twyford
4ea53a93ad Bug 1586026 - Expand Megabar in window.focusAndSelectUrlbar. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D48104

--HG--
extra : moz-landing-system : lando
2019-10-08 12:39:30 +00:00
Mark Banner
526c10a89d Bug 1578381 - Rename HomePage.init to delayedStartup to better describe when it gets called normally. r=mixedpuppy
Depends on D48169

Differential Revision: https://phabricator.services.mozilla.com/D48195

--HG--
extra : moz-landing-system : lando
2019-10-07 17:05:09 +00:00
Michael Kaply
d3547ee818 Bug 158968 - Implement kiosk mode. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D41848

--HG--
extra : moz-landing-system : lando
2019-10-04 19:47:56 +00:00
James Teh
d9d82b8278 Bug 1576509: Add a function to announce a message to screen reader users. r=Gijs,yzen
Differential Revision: https://phabricator.services.mozilla.com/D47717

--HG--
extra : moz-landing-system : lando
2019-10-02 05:53:52 +00:00
Mark Hammond
42b1e658e0 Bug 1584076 - Hide the 'Firefox Services' label when there are no services. r=vbudhram
Differential Revision: https://phabricator.services.mozilla.com/D47720

--HG--
extra : moz-landing-system : lando
2019-10-01 14:33:01 +00:00
Sean Feng
660aac23aa Bug 1467970 - Unsupport cross docGroup adoption r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D43135

--HG--
extra : moz-landing-system : lando
2019-09-14 00:09:44 +00:00
Emilio Cobos Álvarez
06edb6f970 Bug 1583941 - Use a per-window event to handle dark mode changes in LightweightThemeConsumer.jsm. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D47241

--HG--
extra : moz-landing-system : lando
2019-09-26 13:21:40 +00:00
Mark Hammond
7ec2097ae8 Bug 1582633 - allow an FxA user to be signed in without sync being enabled. r=eoger,lina
Differential Revision: https://phabricator.services.mozilla.com/D46572

--HG--
extra : moz-landing-system : lando
2019-09-25 06:51:18 +00:00
Vijay Budhram
9ebe6010d5 Bug 1575706 - Add account sub menu to fxa toolbar menu r=eoger,markh
Differential Revision: https://phabricator.services.mozilla.com/D45725

--HG--
extra : moz-landing-system : lando
2019-09-20 17:00:51 +00:00
Marco Bonardo
8d45311eb0 Bug 1582505 - OpenViewOnFocus should not open the view on the new tab page using a shortcut. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D46491

--HG--
extra : moz-landing-system : lando
2019-09-19 21:20:34 +00:00
Gurzau Raul
5589deded8 Backed out changeset 4ce6c9d4041a (bug 1575706) for failing at browser_duplicateIDs.js on a CLOSED TREE. 2019-09-20 00:54:38 +03:00
Vijay Budhram
35c8f2a5ea Bug 1575706 - Add account sub menu to fxa toolbar menu r=eoger,markh
Differential Revision: https://phabricator.services.mozilla.com/D45725

--HG--
extra : moz-landing-system : lando
2019-09-19 19:27:02 +00:00
Jonathan Kingston
6c5244b7a9 Bug 1579444 - Remove offline storage usage prompt r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D46075

--HG--
extra : moz-landing-system : lando
2019-09-17 16:21:45 +00:00
Bogdan Tara
7fd9d0c40e Backed out changeset d6a50efcae08 (bug 1579444) for ES lint failure on OfflineAppsChild.jsm CLOSED TREE 2019-09-17 18:42:36 +03:00
Jonathan Kingston
d2f8bed096 Bug 1579444 - Remove offline storage usage prompt r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D46075

--HG--
extra : moz-landing-system : lando
2019-09-17 13:31:40 +00:00
prathiksha
474ef9a0f2 Bug 1561443 - Move _getErrorMessageFromCode from NetErrorChild.jsm to aboutNetError.js. r=fluent-reviewers,flod,johannh
Differential Revision: https://phabricator.services.mozilla.com/D36542

--HG--
extra : moz-landing-system : lando
2019-09-17 09:49:59 +00:00
Tim Nguyen
e043df8d78 Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250

--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 06:22:42 +00:00
Mihai Alexandru Michis
f9580519b8 Backed out changeset e859a5aebb5b (bug 1534455) for causing failures at test_bug437844.xul
--HG--
rename : toolkit/content/widgets/autocomplete-input.js => toolkit/content/widgets/autocomplete.xml
2019-09-17 07:51:36 +03:00
Tim Nguyen
5d8a3da397 Bug 1534455 - Convert autocomplete binding to a customized input element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33250

--HG--
rename : toolkit/content/widgets/autocomplete.xml => toolkit/content/widgets/autocomplete-input.js
extra : moz-landing-system : lando
2019-09-17 01:35:25 +00:00
Marco Bonardo
fdfb9d4446 Bug 1578856 - browser.fixup.dns_first_for_single_words and the keyword-uri-fixup UI are broken. r=adw
In the Quantum Bar it's usually the urlbar code that decides whether a search
string should be visited or searched. if dns_first_for_single_words is set,
we can't make a final decision, because that depends on a dns lookup. For now
we don't want to duplicate the docshell code, also because we must keep the
old behavior functioning for cases where the urlbar value is set without input.

Similarly, when the docshell decides to search for a single word host, and a
dns lookup resolves it, it also shows a prompt asking the user if he meant to
visit it instead of searching. Because the urlbar skips the docshell decision
making, we must manually call the fixup prompt code from the urlbar.

Differential Revision: https://phabricator.services.mozilla.com/D45743

--HG--
extra : moz-landing-system : lando
2019-09-16 16:46:34 +00:00
Johann Hofmann
8847236f13 Bug 1573502 - Always use system principal as triggeringPrincipal for about:certificate. r=jkt
about:certificate is always trusted and we don't have to use the content principal in browser.js

Differential Revision: https://phabricator.services.mozilla.com/D45939

--HG--
extra : moz-landing-system : lando
2019-09-16 09:06:00 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Dão Gottwald
57f477c599 Bug 1580248 - Fix urlbar height and vertical alignment in compact mode. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D45555

--HG--
extra : moz-landing-system : lando
2019-09-11 22:44:41 +00:00
Dão Gottwald
137323d6a0 Bug 1577472 - Always use position:absolute for the megabar so it doesn't get reframed on focus r=harry
Differential Revision: https://phabricator.services.mozilla.com/D44864

--HG--
extra : moz-landing-system : lando
2019-09-10 14:48:28 +00:00
Paul Zuehlcke
00119452fc Bug 1574480 - Updated browser.js and OfflineAppsChild.jsm to use PermissionManager principal methods. r=johannh,smaug
Differential Revision: https://phabricator.services.mozilla.com/D42620

--HG--
extra : moz-landing-system : lando
2019-09-10 10:57:07 +00:00
prathiksha
2a39a566d7 Bug 1553342 - Have Browser:CertExceptionError message exchanges happen over RPM. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D34581

--HG--
extra : moz-landing-system : lando
2019-09-05 20:04:03 +00:00
Coroiu Cristina
9683a17a37 Backed out changeset d2867a062f45 (bug 1574480) for browser-chrome failures at browser/base/content/test/general/browser_offlineQuotaNotification.js on a CLOSED TREE 2019-09-05 18:38:42 +03:00
Paul Zuehlcke
99bfbf1328 Bug 1574480 - Updated browser.js and OfflineAppsChild.jsm to use PermissionManager principal methods. r=johannh,smaug
Differential Revision: https://phabricator.services.mozilla.com/D42620

--HG--
extra : moz-landing-system : lando
2019-09-05 13:37:55 +00:00
Emma Malysz
392fe89b3a Bug 1569738, make PageInfo fission compatible r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D42978

--HG--
extra : moz-landing-system : lando
2019-08-29 20:31:19 +00:00
Paul Zuehlcke
c4e3669f0f Bug 1558439 - Log warning to web console when add-on installation was blocked due to fullscreen. r=johannh,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D44161

--HG--
extra : moz-landing-system : lando
2019-08-30 16:34:08 +00:00
Mark Banner
511a7ababf Bug 1562929 - Use the default private search engine in the context menu. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D43771

--HG--
extra : moz-landing-system : lando
2019-08-29 14:43:43 +00:00
Mark Banner
4256dfcab4 Bug 1562926 - Use the default private search engine in the address bar. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D43244

--HG--
extra : moz-landing-system : lando
2019-08-29 14:43:43 +00:00
Johann Hofmann
c987315cec Bug 1468355 - Optimize checking for site data usage for the site identity panel. r=Gijs
The idea here is that we avoid updating all site data in SiteDataManager.jsm
just for checking a single host/origin and that we optimize performance by prioritizing
the most common data type (cookies) and synchronous lookups (AppCache) and returning
early if any data was found.

We will still refresh the site data list for clearing once the user clicks on "Clear Site Data".

Differential Revision: https://phabricator.services.mozilla.com/D42800

--HG--
extra : moz-landing-system : lando
2019-08-28 21:45:30 +00:00
Andreas Farre
6e42fb98f8 Bug 1563619 - Handle subframe crashes in BrowserParent::ActorDestroy. r=mconley,kmag,peterv
Differential Revision: https://phabricator.services.mozilla.com/D40937

--HG--
extra : moz-landing-system : lando
2019-08-26 13:08:32 +00:00
Drew Willcoxon
292a6bb2ce Bug 1575038 - Quantumbar: Record engagement event telemetry when openViewOnFocus is triggered without mouse clicks. r=dao
We need to start engagement event recording when the view opens due to `openViewOnFocus`. We already do for mouse clicks since we call `engagementEvent.start` from `_on_mousedown`. But we don't for the Ctrl/Command-L key shortcut. The shortcut command calls `openLocation` in browser.js, which calls `gURLBar.startQuery` but not `engagementEvent.start`.

Every time we call `engagementEvent.start`, we do it before calling `input.startQuery`. The one exception is in `input._on_drop` because there we just handle the dropped value directly instead of starting a new query with it.

The inverse is also mostly true, i.e., every time we call `input.startQuery`, we also call `engagementEvent.start`. The three exceptions are: in UITour (where it looks like we should be calling `urlbar.search` instead), in `UrlbarInput` after picking a keyword offer result, and in `openLocation` in browser.js (mentioned above). So really the only valid place is after picking a keyword entry.

So, it makes sense to move `engagementEvent.start()` into `input.startQuery` so that callers don't have to call it. I added an `event` param to `startQuery`, since `engagementEvent.start` needs one. I considered removing that need. It's possible, but then we would need a way to avoid calling `engagementEvent.start` in the keyword offer case, so `startQuery` would need something like a `suppressEngagementEvent` param. `event` basically functions as that, so I left it.

Another thing to point out about this patch is that I chose to record a "typed" value when the pageproxystate is invalid and the view opens due to `openViewOnFocus`. The view does not show the user's top sites in that case, so "topsites" seems wrong.

Differential Revision: https://phabricator.services.mozilla.com/D42749

--HG--
extra : moz-landing-system : lando
2019-08-22 14:50:42 +00:00
Mark Banner
a05a7163d5 Bug 1551829 - Upgrade to ESLint 6.1.0. r=mossop
This picks up various improvements, especially to how configurations are handled and some new rules.

Differential Revision: https://phabricator.services.mozilla.com/D37271

--HG--
extra : moz-landing-system : lando
2019-08-21 19:08:44 +00:00
Dão Gottwald
a25a70aaf0 Bug 1575563 - Improve Megabar input layout. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D42864

--HG--
extra : moz-landing-system : lando
2019-08-21 19:13:15 +00:00
Thomas Nguyen
bbd6f51a56 Bug 1528697 - Add cenum referrerpolicy in ReferrerInfo.idl r=ckerschb,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D41955

--HG--
extra : moz-landing-system : lando
2019-08-21 13:28:23 +00:00
Abdoulaye O. Ly
2071196eb3 Bug 1571080 - [Fission] Port form validation to JSWindowActor. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D40483

--HG--
rename : browser/modules/FormValidationHandler.jsm => browser/actors/FormValidationParent.jsm
extra : moz-landing-system : lando
2019-08-19 18:20:19 +00:00
Mike Conley
d64c589ac1 Bug 1568320 - Add a context menu to the Picture-in-Picture toggle to allow for easy hiding. r=NeilDeakin,JSON_voorhees
Differential Revision: https://phabricator.services.mozilla.com/D40305

--HG--
extra : moz-landing-system : lando
2019-08-13 18:29:29 +00:00
Cosmin Sabou
b26c339222 Backed out 6 changesets (bug 1572189, bug 1572773, bug 1568974, bug 1571710, bug 1568972) for eslint failure on content/pageinfo/security.js. CLOSED TREE
Backed out changeset d0162a59fb9f (bug 1572773)
Backed out changeset c2105d0d65aa (bug 1572189)
Backed out changeset 49b0496a73ed (bug 1571710)
Backed out changeset 1ba4647f9bb9 (bug 1568974)
Backed out changeset a33c6ef60d25 (bug 1568974)
Backed out changeset 168b4675c975 (bug 1568972)
2019-08-13 21:23:23 +03:00
dleblanccyr
fe443d7006 Bug 1568974 - Adds error warning to certificate viewer. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D39531

--HG--
extra : moz-landing-system : lando
2019-08-13 14:09:44 +00:00
Jared Wein
776e7c17fb Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745

--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:49 +00:00
Bogdan Tara
844afcfb06 Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Jared Wein
bfdcad7ada Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745

--HG--
extra : moz-landing-system : lando
2019-08-08 01:38:50 +00:00