Commit graph

103 commits

Author SHA1 Message Date
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Mike de Boer
0fcde6db9c Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Sebastian Hengst
c3dc29271d Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Mike de Boer
bfdabc36cf Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Paolo Amadini
a0fc00495b Bug 1381411 - Implement the DownloadHistoryList object. r=mak
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB

--HG--
extra : rebase_source : e36faf63dadeba0c897b769cb7e14a2d01d0f628
extra : amend_source : 2c7a88b6e3d6de50b37c34a5579b3ab6fb0c10dd
2017-08-04 14:48:53 +01:00
Paolo Amadini
137d61ddbb Bug 1381409 - Part 3 - Use DownloadList notifications directly in front-end download views. r=mak
The DownloadList object now provides batch notifications directly, in preparation for linking front-end views to other types of download lists without having to use the DownloadsData indirection.

MozReview-Commit-ID: FOTz1YwGRE1

--HG--
extra : rebase_source : df2d50d50c45a98e257caaa6efa9d0da2fa79237
extra : source : 278858e3d78b5e371f865adac043d07b770f1d3f
2017-07-17 12:05:12 +01:00
Paolo Amadini
64bb3feb3b Bug 1381409 - Part 2 - Let each view keep the state of downloads relevant to it. r=mak
The front-end download views now maintain the old download state themselves, instead of relying on the DownloadsData object dispatching the onDownloadStateChanged notification.

This allows each view to keep only the state relevant to it, for example the Downloads Panel already keeps the state only for the visible items. This also makes it possible for each view to use a different hash than the one provided by the legacy stateOfDownload method, and allows bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 2D1ixsZCkCa

--HG--
extra : rebase_source : f429fe475ea1887180e269ee8aa0addcee76704d
extra : source : df5f46c825a10587149a7bbac2e126c3906e0393
2017-07-17 12:07:17 +01:00
Paolo Amadini
180e05ac9f Bug 1381409 - Part 1 - Always add Download objects in their original order. r=mak
When a new front-end view is added to the DownloadsData object, the Download objects it contains are loaded into the view starting with the newest, which is the opposite of the order used by the underlying DownloadList.

This was originally implemented as an optimization for the Downloads Panel, at a time when the full list of completed downloads was persisted in the same SQLite database as session downloads. This difference is now unnecessary given the low number of session downloads, and can be removed in preparation for bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 5EBkqvyXFq4

--HG--
extra : rebase_source : 44b8783e5c44460d3aa4fb9bd0834c981110e98e
extra : source : 56b8e456797c56c45ed791c0d40f43031e94dc22
2017-07-16 17:36:00 +01:00
Paolo Amadini
3c1829bf94 Bug 1357915 - Fix download commands operating on multiple items in the Library window. r=Standard8
This was regressed by bug 1264206 while removing legacy array comprehensions, because selectedItems is a NodeList and not an Array.

MozReview-Commit-ID: 61GG3SiiWwS

--HG--
extra : rebase_source : 3b3c1268be944d1942450336d4e9c652b4054b41
2017-07-18 10:19:48 +01:00
Florian Quèze
721c3ada5e Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Paolo Amadini
5c2404b2f6 Bug 1281186 - Remove uses of nsIDownloadManager from DownloadsCommon.jsm, DownloadsViewUI.jsm, and allDownloadsViewOverlay.js. r=mak
MozReview-Commit-ID: 28nc8aTea5v

--HG--
extra : rebase_source : 0fe2e78104e727488930b07c8c5a64ccc4274614
2017-05-05 11:20:53 +01:00
Florian Queze
4c6a68d1c9 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
159215e6f4 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
a363fb8c8b Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Yiren Wang
5f88f7294a Bug 1264206 - Enable ESLint for browser/components/downloads and fix the existing issues. r=Standard8
MozReview-Commit-ID: HDjTxdFCnRp
2017-04-03 10:25:05 +01:00
David Rajchenbach-Teller
4e3f201503 Bug 1087255 - Convert Download JS clients of RemovePage(s) to History.remove;r=paolo
MozReview-Commit-ID: KpXAh74W12E
2014-10-31 12:39:28 +01:00
Sean Lee
a9096e9882 Bug 1282662 - Part 1: Redesign the detail description of Download item in normal or hover cases.; r=Paolo
MozReview-Commit-ID: ITkv5XdQxEI

--HG--
extra : rebase_source : 0fd18d71be9af24fa05db0072fc9d6b58e6035b2
2016-12-07 11:54:41 -10:00
Pavan
9dadd8454a Bug 1324571 - Use cases of some multi-selection commands in Downloads Library not clear. r=mak
--HG--
extra : rebase_source : 418a88e1f0966bbdf747b94c5d1ea099accc0b87
2017-01-19 01:37:00 +01:00
Florian Quèze
028a82f682 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Sean Lee
15f00ba1a2 Bug 1282664 - Redesign the right-menu on a download item in Downloads Panel.; r=Paolo
MozReview-Commit-ID: DyTisE3dX1A

--HG--
extra : rebase_source : d87b91cb9a8b7875eddc42c4e2bad6234f433af7
2016-10-14 14:07:00 +08:00
Boris Zbarsky
bae20efd7f Bug 1298243 part 7. Change DataTransfer.types from being a DOMStringList to being a frozen array. r=mystor,gijs 2016-10-10 21:07:47 -04:00
Tooru Fujisawa
ec0657b9f6 Bug 92737 - Part 9: Download multiple files when multiple items are dropped on Downloads view in Library Window. r=enndeakin 2014-12-21 19:05:03 +09:00
Paolo Amadini
aebadaa666 Bug 1243445 - Pasting an invalid URL breaks the Downloads View in the Library. r=jaws
MozReview-Commit-ID: DCPhxiB1i0Y

--HG--
extra : rebase_source : 2ecf9925407929c07390fcdfaf3e778011be25f4
2016-08-22 14:22:18 +01:00
Sumit Tiwari
8d27110b79 Bug 1290698 - Replace Iterator() with Object.{values, entries}; r=mossop
MozReview-Commit-ID: DEoVeqEZWpd

--HG--
extra : rebase_source : 53b3a2be2cd5bfc444ce6047c44f20bb176e2337
2016-08-07 21:58:24 -04:00
Paolo Amadini
e3a101f136 Bug 1282050 - Fix the updating of download commands in the Library. r=jaws
MozReview-Commit-ID: 7zSMcKe2REi

--HG--
extra : rebase_source : a6bcdf4ff3d6d031c0b5438257e485afc6c65430
2016-07-15 15:09:10 +01:00
Jared Wein
5345120a69 Bug 1280799 - Update the state of the 'Clear Downloads' button when download item state changes, even if the item is selected. r=paolo
MozReview-Commit-ID: 2YXLDuBxkTe
2016-06-24 21:36:40 -04:00
Panos Astithas
6809a297cd Bug 1139472 - Extend the attention state of the Downloads Indicator to indicate success or failure. r=paolo
With this change two new attention states are introduced, "severe" and "warning",
along with the previous "success" and "no attention" states. "No attention" is
still a falsy value in order to mitigate any add-on compatibility issues.
"severe" and "warning states" now display an icon badge to the downloads button
(or the hamburger button if the downloads button is tucked away).

MozReview-Commit-ID: 3gc9Ji7zCXY
2016-04-22 23:09:07 +03:00
Paolo Amadini
f13e54ad79 Bug 1265387 - The default action for uncommon downloads should open the file directly. r=past
MozReview-Commit-ID: GrZev8J5MRN

--HG--
extra : rebase_source : 4f30d59be56c51801f42f9222a35dc86def9c819
2016-04-20 15:44:38 +01:00
Paolo Amadini
e0a1fb4878 Bug 1198181 - Part 5 - Change the unblock dialog actions based on the verdict. r=past
MozReview-Commit-ID: 3NkvpI9EqpB

--HG--
extra : rebase_source : 029bde9cc35128aea9c2fd61ab1d42b27ad78822
2016-04-20 11:16:00 +01:00
Paolo Amadini
916f990002 Bug 1198181 - Part 2 - Unify the code that updates the state of download items. r=jaws
MozReview-Commit-ID: KptYcAGbMG2

--HG--
extra : rebase_source : dadc1863d877de730107b12ff063c8695cf8c90d
2016-04-15 15:37:22 +01:00
Paolo Amadini
9f7804275b Bug 1139914 - Downloads with blocked data should be persisted across sessions. r=mak
MozReview-Commit-ID: 4XkSTaNZcLo

--HG--
extra : rebase_source : 98c24ae1561555ddf1c6c12b1fafeb08fa735dd1
2016-03-20 14:25:42 +00:00
Paolo Amadini
44ddde4b6e Bug 1254100 - Part 2 - Downloads blocked by Application Reputation should provide information about the verdict. r=mak
MozReview-Commit-ID: FYH5Tdtbzn

--HG--
extra : rebase_source : a59e79ac247d5f6d039d25f6ee6aea6cf2b5dbe6
2016-03-16 14:29:23 +00:00
Paolo Amadini
0fec3e127c Bug 1117145 - Part 5 - Share the implementation of some of the download item commands. r=jaws
MozReview-Commit-ID: La6km3izidY

--HG--
extra : rebase_source : 6cbd26296b0943e347fd71b263ce2a4dacb9115c
2016-02-14 17:28:12 +00:00
Paolo Amadini
f5f432c4df Bug 1117145 - Part 4 - Unify how commands are handled in the Downloads Panel and the Library. r=jaws
MozReview-Commit-ID: 2Irgwu5YI72

--HG--
extra : rebase_source : d1da32b41a36f383cc76039934ae022742a29840
2016-02-29 15:50:57 +00:00
Paolo Amadini
ad65b7856a Bug 1117145 - Part 3 - Share the download item binding between the Panel and the Library. r=jaws
MozReview-Commit-ID: D8wNJxSJm84

--HG--
extra : rebase_source : 4350fb37dc405949e50a04fd3e0fbed91a8a476e
2016-02-11 21:00:38 +00:00
Gijs Kruitbosch
fbf89fb02e Bug 120684 - use ChromeNodeList in toolkit's listboxes' selectedItems implementation, r=dao,smaug
--HG--
extra : commitid : DzQPAIbbhpX
extra : rebase_source : 4bd9ac283e1c789c2577dc5d4cc85511f35ac27d
2015-10-26 17:25:29 +01:00
Tooru Fujisawa
e3e8c7540e Bug 1207491 - Part 6: Remove use of expression closure from browser/components/downloads/. r=Gijs
--HG--
extra : commitid : 8BIIBSCXIf9
extra : rebase_source : cca677e0c83e99cca719f5b6f794060fa0144205
2015-09-23 18:36:20 +09:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Ian Neal
4dda949249 Bug 1195279 - Fix typo in allDownloadsViewOverlay.js following landing of bug 1127867 r=paolo
--HG--
extra : amend_source : a3240e58de847078529160c82c83f75f3b50b731
2015-08-17 15:26:29 -07:00
Birunthan Mohanathas
3ffa8d565d Bug 1166840 - Remove unused document argument in uses of nsIClipboardHelper.copyString. r=ehsan 2015-05-21 21:49:30 +01:00
ziyunfei
e1db0f779e Bug 1102219 - Part 4: Replace String.prototype.contains with String.prototype.includes in chrome code. r=till 2015-04-30 00:32:05 +09:00
Jared Wein
2d7032360c Bug 1137909 - part 2: context menuitem to unblock downloads and an X button to confirm the blocked download. r=paolo
--HG--
extra : rebase_source : 5c72469031f9d452c9fc4b579c8e4cb2a7099f88
2015-03-05 12:25:45 -05:00
Marco Bonardo
448c1ef44d Bug 1135348 - Fix about:downloads by adding missing XPCOMUtils imports. r=paolo 2015-02-26 19:06:15 +01:00
Paolo Amadini
cd4b3c7397 Bug 1129896 - Part 2 of 2 - Convert the shared front-end code to a JavaScript code module. r=mak
--HG--
rename : browser/components/downloads/content/downloadsViewCommon.js => browser/components/downloads/DownloadsViewUI.jsm
2015-02-16 18:49:56 +00:00
Paolo Amadini
640e8f8b8a Bug 1129896 - Part 1 of 2 - Keep cached metadata for history downloads indefinitely. r=mak 2015-02-16 18:49:54 +00:00
Paolo Amadini
6e91f09568 Bug 1127867 - Use the new back-end property to get the size of downloads asynchronously. r=mak 2015-02-16 18:49:52 +00:00