mirrors/gecko-dev
1
0
Fork 1
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-11-11 05:39:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
703060 commits 621 branches 98 tags 6.6 GiB
Commit graph

819 commits

Author SHA1 Message Date
Bogdan Tara
46ad559c5f Backed out changeset 1f4d7ab6cd6d (bug 1480529) for perma failing on browser_multiselect_tabs_bookmark.js 2018-10-02 18:33:49 +03:00
Jared Wein
1b023a3753 Bug 1480529 - Changed 'Bookmark All Tabs' to 'Bookmark Tab' for single tab selections. r=Felipe 
I changed the toolbar context menuitem from 'Bookmark All Tabs' to 'Bookmark Selected Tabs' because it is separated from a specific tab and thus it is not clear which tab would get bookmarked if only one is selected. This seemed much clearer to me in my testing. The wording of 'Bookmark Selected Tabs' is already used elsewhere where we have 'Reload Selected Tabs', 'Close Selected Tabs', etc.

Differential Revision: https://phabricator.services.mozilla.com/D7217

--HG--
extra : moz-landing-system : lando
 2018-10-02 03:19:01 +00:00
Jared Wein
3b23598f85 Bug 1480456 - Add 'Select All Tabs' into tab context menu. r=Felipe 
Differential Revision: https://phabricator.services.mozilla.com/D7129

--HG--
extra : moz-landing-system : lando
 2018-09-28 18:17:23 +00:00
Brendan Dahl
e3f9c55a17 Bug 1492619 - Use children instead of childNodes in customizable ui tests. r=bgrins 
Fixes browser_customization_context_menus.js

MozReview-Commit-ID: KtRIFGu5ILA

Differential Revision: https://phabricator.services.mozilla.com/D6335

--HG--
extra : moz-landing-system : lando
 2018-09-19 22:43:04 +00:00
Jonathan Kingston
555f89c8d7 Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop 
Differential Revision: https://phabricator.services.mozilla.com/D4552

--HG--
extra : source : 2cf17e4974823d09d0fdd1aef64e69e840b288a1
extra : intermediate-source : 4771e6948a78507aa95a56e5b324d87dc82e9009
 2018-08-29 15:44:56 +01:00
Brindusan Cristian
1db0587c0e Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE 
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
 2018-09-19 18:47:27 +03:00
Jonathan Kingston
f57a3dbfb5 Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop 
Differential Revision: https://phabricator.services.mozilla.com/D4552

--HG--
extra : source : 2cf17e4974823d09d0fdd1aef64e69e840b288a1
 2018-08-29 15:44:56 +01:00
arthur.iakab
d2e647e133 Backed out 10 changesets (bug 1485305)for failing browser chrome tests on browser_loadDisallowInherit.js 
Backed out changeset 138b8596a9cd (bug 1485305)
Backed out changeset d9f04aeeeef7 (bug 1485305)
Backed out changeset cd063d8afe4e (bug 1485305)
Backed out changeset 2f8a5a03ccb5 (bug 1485305)
Backed out changeset 8085d1eefd7c (bug 1485305)
Backed out changeset 3aaccb374a59 (bug 1485305)
Backed out changeset 3a111e9e5c9c (bug 1485305)
Backed out changeset 61aa1cfb0b01 (bug 1485305)
Backed out changeset bca973d90acc (bug 1485305)
Backed out changeset 4eb33bf25d6f (bug 1485305)
 2018-09-18 20:30:07 +03:00
Jonathan Kingston
48be04b556 Bug 1485305 - browser/ tests Ensure loadURI always passes a triggeringPrincipal() r=Mossop 
Differential Revision: https://phabricator.services.mozilla.com/D4552

--HG--
extra : source : 7a505f4e2d97aa9b9662d442ad0a1f0ee34687f4
 2018-08-29 15:44:56 +01:00
Gijs Kruitbosch
6b518d3722 Bug 1491243 - remove subscribe button, menu items and subscription section out of feed previews, r=florian 
This removes subscribe UI and functionality from the main browser window,
the page info window, and from feed previews. It may leave some stray strings
in subscribe.properties/dtd, which will be removed in bug 1477669 when the
preview code goes away completely.

Differential Revision: https://phabricator.services.mozilla.com/D5982

--HG--
extra : moz-landing-system : lando
 2018-09-18 06:06:27 +00:00
Coroiu Cristina
9a2b88d99e Backed out changeset d61965849528 (bug 1491243) for en-US failures at testing\firefox-ui\tests\puppeteer\test_page_info_window.py 2018-09-17 22:23:58 +03:00
Gijs Kruitbosch
1b1f1b759d Bug 1491243 - remove subscribe button, menu items and subscription section out of feed previews, r=florian 
This removes subscribe UI and functionality from the main browser window,
the page info window, and from feed previews. It may leave some stray strings
in subscribe.properties/dtd, which will be removed in bug 1477669 when the
preview code goes away completely.

Differential Revision: https://phabricator.services.mozilla.com/D5982

--HG--
extra : moz-landing-system : lando
 2018-09-17 18:06:05 +00:00
Gijs Kruitbosch
ef7146a4be Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11 
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : rebase_source : e51b66bb18d0e600814b48d5cd3ec9d5dea3028a
extra : source : 96b5a88ac0041a1bd382a731749e1fca9aa911ed
 2018-09-03 14:43:38 +01:00
Margareta Eliza Balazs
ffea0ab6ab Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-08-31 12:27:44 +03:00
Margareta Eliza Balazs
5ddcd7b745 Backed out changeset 96b5a88ac004 (bug 1486824) for causing frequent failures e.g: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js a=backout 2018-08-31 12:17:27 +03:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop 
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
 2018-08-31 05:59:17 +00:00
Gijs Kruitbosch
9d70cb3843 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11 
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
 2018-08-30 15:07:36 +00:00
Narcis Beleuzu
a4ec006bb0 Backed out changeset 4e195f7b2d6b (bug 1486824) for clipboard failures on OSX browser_editcontrols_update. a=backout 2018-08-30 15:59:59 +03:00
Gijs Kruitbosch
a8e2b8e702 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11 
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
 2018-08-29 17:58:25 +00:00
Mark Striemer
dedae0369d Bug 1482731 - Support Home and End in PanelMultiView navigation r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D4087

--HG--
extra : moz-landing-system : lando
 2018-08-28 09:17:56 +00:00
Brendan Dahl
f6923ccc24 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins 
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265

--HG--
extra : moz-landing-system : lando
 2018-08-25 00:16:27 +00:00
Paolo Amadini
33cef824d2 Bug 1484275 - ESLint quick fix, again. r=me 2018-08-24 08:58:06 +01:00
Paolo Amadini
6ea78024ca Bug 1484275 - ESLint quick fix. r=me 2018-08-24 08:39:47 +01:00
Paolo Amadini
866357cbca Bug 1484275 - Fix opening the main menu while another popup is open on Windows. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D3979

--HG--
extra : rebase_source : 5cf5b9fe368de3c78765cb154ef6532e2340d400
 2018-08-23 14:04:43 +01:00
Brian Grinstead
4995c61b0f Bug 1482667 - Migrate mochitest-browser tests in browser/ to use element variations of firstChild, etc;r=paolo 
Differential Revision: https://phabricator.services.mozilla.com/D3530

--HG--
extra : moz-landing-system : lando
 2018-08-17 16:45:52 +00:00
Brian Grinstead
b0b2b901d0 Bug 1470910 - Migrate input-box and input-box-spell to a Custom Element;r=paolo 
Instead of `<xul:hbox class="textbox-input-box">`, consumers now should use
`<xul:moz-input-box />`. This covers the normal case and also handles
[spellcheck=true] while sharing much of the code within one class.

MozReview-Commit-ID: DjvT8sFq3SQ

--HG--
rename : toolkit/content/widgets/textbox.xml => toolkit/content/widgets/textbox.js
 2018-08-02 20:53:59 -07:00
Kris Maglione
031076f2f3 Bug 1463291: Move docShell getter from Document to Window. r=bz 
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : source : fcfb99baa0f0fb60a7c420a712c6ae7c72576871
extra : histedit_source : 5be9b7b29a52a4b8376ee0bdfc5c08b12e3c775a
 2018-05-21 16:58:23 -07:00
Narcis Beleuzu
561ccb2ceb Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures 
Backed out changeset fcfb99baa0f0 (bug 1463291)
Backed out changeset 0d69b4fb1ed4 (bug 1463016)
 2018-07-29 03:55:23 +03:00
Kris Maglione
cb1ee1e34d Bug 1463291: Move docShell getter from Document to Window. r=bz 
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : rebase_source : a13c59d1a5ed000187c7fd8e7339408ad6e2dee6
 2018-05-21 16:58:23 -07:00
Paolo Amadini
f06351c23c Bug 1473748 - Part 2 - Simplify how navigable elements are initialized. r=johannh 
MozReview-Commit-ID: HN2ZYXNVi6m

--HG--
extra : rebase_source : 4373f26b679296d6f2237640dd248ce5bf8dd63c
 2018-07-23 11:28:23 +01:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Brian Grinstead
96dc530924 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs 
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t

--HG--
extra : rebase_source : c525350a1954740873e85b045cbb14a8b43aa89d
 2018-07-24 08:12:50 -07:00
Johann Hofmann
e7b9853987 Bug 1467385 - Use PanelMultiView APIs for keyboard navigation in the identity popup. r=Paolo 
PanelMultiView has its own concept of "selected", so we should use this rather than move focus
using advanceFocusIntoSubTree.

MozReview-Commit-ID: DW2JqqggLl1

--HG--
extra : rebase_source : ec7a6f83fdda176f3286cf4395dc72de6cad2466
 2018-07-02 14:34:25 +02:00
Kris Maglione
c1c1de7ce8 Bug 1467695: Wait for async disable operations to finish when calling addonChanged listeners. r=aswan 
MozReview-Commit-ID: 1vsevE8IgYU

--HG--
extra : source : 46e5404ad50cf39cfe8b10bbd9c45b4325d95d6e
extra : amend_source : 0bfd172b9ec37e7f169269aa37cbe547d2156c6d
extra : intermediate-source : c0ebdd0be6ba6f9748690d0ae5479977e2ea54bb
 2018-06-08 13:02:43 -07:00
Joel Maher
50b91c0a14 Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Csoregi Natalia
d2a7e3fcd3 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-05-10 19:45:06 +03:00
Gijs Kruitbosch
f289809963 Bug 1459913 - fix removable_false test to always execute the correct drag (layout race), rs=test-only 
--HG--
extra : rebase_source : 63cd78b81cccb99069a9dbfe78274040cb0ad589
 2018-05-10 09:44:49 +01:00
Gijs Kruitbosch
0809c549f1 Bug 962248 - rewrite zoom test to be less terrible, r=dthayer 
MozReview-Commit-ID: ByUM61fsOgh

--HG--
extra : rebase_source : e81915fbf2ecf35a90ef6a0c4be5b6fa4bf01d51
 2018-05-09 09:07:37 +01:00
Tooru Fujisawa
c12bdc0642 Bug 1420574 - Add CustomizableUITestUtils.prototype.{addSearchBar,removeSearchBar} to show search bar in nav bar and verify it does not overflow. r=Paolo 2018-05-09 09:48:40 +09:00
Gijs Kruitbosch
b40ddc17c4 Bug 1438490 - move overflow/underflow event handling out of toolbar.xml, r=jaws 
MozReview-Commit-ID: CwkCOIm9wNk

--HG--
extra : rebase_source : a746c9dc190e3309d9368083ce08c36f222a3407
 2018-05-01 15:44:19 +01:00
Gijs Kruitbosch
9654bc99a1 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian 
MozReview-Commit-ID: BFGRssWb9F

--HG--
extra : rebase_source : cf6011f2ecfe78df11a6741dfa074c7d985ec294
extra : source : 1ce48405e58a609299a84192df04d340cd90de63
 2018-04-20 15:09:44 +01:00
Andreea Pavel
7abcd926f5 Backed out changeset 1ce48405e58a (bug 1447619) for creating bug 1457257 and bug 1457289 on a CLOSED TREE 2018-04-28 20:46:51 +03:00
Gijs Kruitbosch
39d0e25c38 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian 
MozReview-Commit-ID: BFGRssWb9F

--HG--
extra : rebase_source : e8932810584e10a1de0c1b11c1a152d2dc0f48dd
 2018-04-20 15:09:44 +01:00
Tim Nguyen
92c9a958e1 Bug 1372694 - Stop making the default theme a heavyweight theme. r=kmag,aswan 
MozReview-Commit-ID: 30wMauuc9oo

--HG--
rename : browser/base/content/default-theme-icon.svg => toolkit/mozapps/extensions/content/default-theme-icon.svg
extra : rebase_source : 5e4cf784135f4a8e40a2ed8357ba651e7fce9728
 2018-04-01 13:53:31 +02:00
Jonathan Kingston
fea68cb968 Bug 1453528 - Fix opening of synced tabs with correct principal. r=markh 
MozReview-Commit-ID: 6MGXjsg3HmV

--HG--
extra : rebase_source : bc2782dbf14131325fd7ee4564524794350a1bc3
 2018-04-12 18:06:13 +01:00
Paolo Amadini
ea3963afc9 Bug 1444392 - Part 1 - Add test-only helpers to open and close the main menu. r=Gijs 
MozReview-Commit-ID: 9kvUdw2TeHB

--HG--
extra : rebase_source : 0b0a007ad517c0256fe67256391d87065bf645ef
extra : amend_source : c2c56528f12e38852e913e42e9e7f9e78e8623d9
extra : source : ec2f47133979d085739d383cc50358d6e9417979
 2018-04-04 11:34:16 +01:00
Edouard Oger
9b6026748b Bug 1184265 - Make last sync date be relative. r=markh 
MozReview-Commit-ID: 2hB9F7Elynh

--HG--
extra : rebase_source : dbf962b1fd3f4121f0bcc8276e932f0c49ab90b3
 2018-03-20 17:08:16 -04:00
Tooru Fujisawa
1adba8c1fc Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Kris Maglione
313b707b2e Bug 1443964: Part 3 - Remove no-cpows-in-tests rule. r=mconley 
The shims that this rule tests for no longer exist.

MozReview-Commit-ID: DMgP7Hczavc

--HG--
extra : rebase_source : 765ddd5c62c9449c07ed050e44d86a3bd5c0ae64
extra : amend_source : 627a7694ac07182200f876901ded7a34721cd228
 2018-03-07 19:31:28 -08:00
Gijs Kruitbosch
d2ebbb38df Bug 1358815 - remove sync reflow from find bar initialization, r=jaws 
This removes the sync reflow from almost all cases. The only case where we keep it is when a keypress
caught in content triggers a sync message to the parent process. We should clean this up in bug 1371523.

I've tried to fix the tests, but a lot of them seem to be disabled anyway...

MozReview-Commit-ID: 9k36p7q8MKy

--HG--
extra : rebase_source : 311ee41ba9456a5c5d58b81a0cfa999bcef0027e
 2018-03-12 14:01:44 +00:00
Brindusan Cristian
4f5a76dc76 Backed out 2 changesets (bug 1358815) for bc failures on browser_pdfjs_main.js CLOSED TREE 
Backed out changeset 880736d97de3 (bug 1358815)
Backed out changeset a2a0a0990e1a (bug 1358815)
 2018-03-15 21:23:12 +02:00
Gijs Kruitbosch
59e21359c8 Bug 1358815 - remove sync reflow from find bar initialization, r=jaws 
This removes the sync reflow from almost all cases. The only case where we keep it is when a keypress
caught in content triggers a sync message to the parent process. We should clean this up in bug 1371523.

I've tried to fix the tests, but a lot of them seem to be disabled anyway...

MozReview-Commit-ID: 9k36p7q8MKy

--HG--
extra : rebase_source : 311ee41ba9456a5c5d58b81a0cfa999bcef0027e
 2018-03-12 14:01:44 +00:00
Kris Maglione
83957914cc Bug 1445551: Part 1b - Whitelist unsafe CPOW use in existing tests. r=mconley 
MozReview-Commit-ID: 4ojwvjw9XGT

--HG--
extra : rebase_source : f7b79ad5998f1138266e89767ee1b434e4797b30
 2018-03-14 14:35:05 -07:00
Gijs Kruitbosch
5a6fb10278 Bug 1445350 - fix browser_panelUINotifications_multiWindow.js so it doesn't fail on win10, r=dthayer 
MozReview-Commit-ID: Jk3ah2Xtr58

--HG--
extra : rebase_source : 4c3bb805018df98b0755854a113433e6e9c83150
 2018-03-14 13:18:35 +00:00
Edouard Oger
dd1fce1d1a Bug 1441376 - Stop the Syncing animation manually in browser_remote_tabs_button.js test. r=Paolo 
The UIState.ON_UPDATE notification should be enough to reset the state of the
panel every time the test is about to be executed. Wrong.
In response to this notification, gSync.onActivityStop() is called, which disables
the syncing animation immediately ONLY if it has been running for at least 1.5sec
(which is almost never happening in tests), otherwise we get a setTimeout with
the remaining time.
When the sync animation is running, we also do not react to clicks (disabled),
hence the test failing.
We fix this by stopping the animation ourselves manually at the end of the test,
so any subsequent test will start with a correct UI state.

MozReview-Commit-ID: CrEb82Tw5SO

--HG--
extra : rebase_source : da4822c9fb6f41e6fbfeec5a63086c43aeca7944
 2018-03-09 16:03:48 -05:00
Dão Gottwald
179b1e9cd5 Bug 1443360 - Fix browser_panelUINotifications_fullscreen.js intermittent failure. r=Gijs 
MozReview-Commit-ID: FTP3NXqW0oy

--HG--
extra : rebase_source : a9325ed2598c04bc6214ba42b921d4dd23366465
 2018-03-08 10:24:10 +01:00
Dão Gottwald
3e27baea54 Bug 1443364 - Fix browser_901207_searchbar_in_panel.js intermittent failure. r=Gijs 
MozReview-Commit-ID: H0F7n3eoV3V

--HG--
extra : rebase_source : 219aeb63a4c9c5eadbabf3c97af1ec300ba09cb1
 2018-03-07 18:40:55 +01:00
Edouard Oger
4aea0be2d6 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc 
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : 16b7f01ed6f9b03534945d718c567dad0daa4ff3
 2018-02-22 16:30:39 +08:00
Narcis Beleuzu
8c7d795b53 Backed out 2 changesets (bug 1439777) for xpcshell failures on /test_errorhandler_2.js 
Backed out changeset d99402ad9ecc (bug 1439777)
Backed out changeset 1af3426dc956 (bug 1439777)
 2018-03-06 04:43:41 +02:00
Edouard Oger
934abf11b3 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc 
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : dd7218b5f0bd36dc4c71d2a7c95a92bba4da2d12
 2018-02-22 16:30:39 +08:00
Csoregi Natalia
1fd0486e23 Backed out 7 changesets (bug 1193394) for browser-chrome failures on browser_ext_popup_background.js. CLOSED TREE 
Backed out changeset 9683f24ff8ec (bug 1193394)
Backed out changeset 0e7140a7c841 (bug 1193394)
Backed out changeset a0e26f6b2784 (bug 1193394)
Backed out changeset 29e1fceaf48d (bug 1193394)
Backed out changeset b8632bbbd273 (bug 1193394)
Backed out changeset a54ef2d8f896 (bug 1193394)
Backed out changeset 55c94c05c57f (bug 1193394)
 2018-03-01 16:29:02 +02:00
Tooru Fujisawa
8809c05b7b Bug 1193394 - Part 5: Disable some tests that relies on descriptionHeightWorkaround. r=bustage CLOSED TREE 2018-03-01 20:03:13 +09:00
Paolo Amadini
91212fa6b1 Bug 1428839 - Part 4 - Avoid re-entrancy in PanelMultiView navigation functions. r=Gijs 
We now use the "active" property of views to track whether navigation is possible. This has the advantage of being already handled correctly when views are moved to a different panel, and is in line with the purpose of the "active" state. The note about using the "popupshown" event for navigation has been updated accordingly.

Keyboard navigation is also linked to the "active" property now, so there is no need to track the state of the "_transitioning" property anymore.

Since the goBack and showSubView methods can only be called when the view is active, we don't need to check for attempts to start a transition while the panel is closed anymore.

MozReview-Commit-ID: 3KT3A5EwGFy

--HG--
extra : rebase_source : c338362923a7574210c7329bb84316d549898fdc
 2018-02-27 15:33:33 +00:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Paolo Amadini
e0eef0a81d Bug 1440358 - Part 3 - Add tests for reopening a visible Library view. r=Gijs 
MozReview-Commit-ID: 3sJDnzUWFbz

--HG--
extra : rebase_source : 17280de3f1733f47e3619145d8289c1e7c548937
 2018-02-26 13:47:00 +00:00
Paolo Amadini
61b6cbe98e Bug 1440358 - Part 2 - Add tests for cancellation while opening a view. r=Gijs 
This includes both canceling the ViewShowing event and calling the hidePopup method of PanelMultiView.

MozReview-Commit-ID: Goo45SEBC3z

--HG--
extra : rebase_source : d78376d7a69dd47157e049da1aaa19e97b9bd12c
 2018-02-25 19:49:00 +00:00
Paolo Amadini
4d3254c032 Bug 1440358 - Part 1 - Add unit tests for PanelMultiView. r=Gijs 
MozReview-Commit-ID: 3WM2Skrg3QV

--HG--
extra : rebase_source : 10a8080363a1c17013e249947314671389d04613
 2018-02-26 13:45:09 +00:00
Paolo Amadini
53d37c96a7 Bug 1440333 - Part 3 - Raise the ViewShown event after the main view is active. r=Gijs 
This also adds a new "active" property that can be used by regression tests to determine whether they should still wait for the ViewShown event.

MozReview-Commit-ID: K25F09llooj

--HG--
extra : rebase_source : 9f6dad605243fcd3633260c4fa34011f9cfab27c
extra : source : 2dad70b2a723e67b45563dd3ac254911dd193439
 2018-02-26 13:18:22 +00:00
Paolo Amadini
acc856e8d4 Bug 1440333 - Part 2 - Rename the "current" attribute to "visible". r=Gijs 
MozReview-Commit-ID: EazXDT6JC3M

--HG--
extra : rebase_source : ecaba689f94e26dcb20321bf51cd1b76d22ac2e8
extra : source : c705b49c2bae3301998df83dc0b883d0fb4e5219
 2018-02-26 14:31:35 +00:00
Brindusan Cristian
81684073f2 Backed out 3 changesets (bug 1440333) for firefox-functional-test failures on test_no_certificate.py on a CLOSED TREE 
Backed out changeset 2dad70b2a723 (bug 1440333)
Backed out changeset c705b49c2bae (bug 1440333)
Backed out changeset 9906b468eb78 (bug 1440333)
 2018-02-26 16:19:18 +02:00
Paolo Amadini
885de209fb Bug 1440333 - Part 3 - Raise the ViewShown event after the main view is active. r=Gijs 
This also adds a new "active" property that can be used by regression tests to determine whether they should still wait for the ViewShown event.

MozReview-Commit-ID: K25F09llooj

--HG--
extra : rebase_source : 8c9e2a86285be6453cd60b3da448876e6dfa7e8a
 2018-02-26 13:18:22 +00:00
Paolo Amadini
76ef799b86 Bug 1440333 - Part 2 - Rename the "current" attribute to "visible". r=Gijs 
MozReview-Commit-ID: EazXDT6JC3M

--HG--
extra : rebase_source : 5cca4cd0cf565ffbdf75a9777dfc15b359dcda57
 2018-02-23 15:54:08 +00:00
Masayuki Nakano
cf83ee7bb4 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug 
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T

--HG--
extra : rebase_source : 2296b84bff8e22f01eeb48cd8614fac5db11136a
 2018-02-15 04:15:39 +09:00
Masayuki Nakano
8917ac460f Bug 1436926 - part 2: Remove unnecessary KeyboardEvent.code specification of callers of EventUtils.synthesizeKey() r=smaug 
Now, callers of EventUtils.synthesizeKey() don't need to specify
KeyboardEvent.code value anymore if they assume that active keyboard layout
is US keyboard layout.

Note that this patch changes the meaning of only test_bug551434.html.
Some callers in it don't match the key value and code value but that looks
like that they don't checking such odd keyboard events.  So, they must be
bug of the test.

MozReview-Commit-ID: Itxo7yZ9rkK

--HG--
extra : rebase_source : 856ef3715c924ca16e993ea57d92d1243b5cc6be
 2018-02-09 19:17:26 +09:00
Edouard Oger
626be20bbb Bug 1427674 - Unify FxA content server URL preferences. r=markh,tcsc 
MozReview-Commit-ID: 3zhHGAzQr0R

--HG--
extra : rebase_source : 013457dfb434c92134d2f244b389d21620c83595
 2018-01-30 13:21:35 -05:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
 2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE 
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
 2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
 2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE 
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
 2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
 2018-01-29 15:20:18 -08:00
Paolo Amadini
f26eb575e4 Bug 1432016 - Part 1 - Add a PanelView class using a base class shared with PanelMultiView. r=Gijs 
Only one method is moved to the PanelView class to simplify the keyboard navigation test.

MozReview-Commit-ID: CHB5FiT9ptn

--HG--
extra : rebase_source : ec588beae9f1208a37ce85f9d28029dfd979db24
 2018-01-22 12:46:48 +00:00
Kris Maglione
aec63e140c Backed out 3 changesets (bug 1431533) for Android mochitest bustage. CLOSED TREE 
MozReview-Commit-ID: 5ubE9EMQpZ9

--HG--
extra : histedit_source : df68d7595925c07d9d6e8bacc2c46e69556f479a%2C72b768b9825e20ede6603ead75f871c50dc041f7
 2018-01-24 22:04:59 -08:00
Kris Maglione
30b3a49bfd Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
MozReview-Commit-ID: 8V1ZT53ReiP

--HG--
extra : rebase_source : 12b5f8c3e125111db7382eb3d7d20a99fb2c35b3
extra : absorb_source : e99fa7f6eee02e7e6cadeb898c7fcf6dac9c902a
extra : histedit_source : d0dfc31fadc2b81d341c9d0cd1efec02923c003b
 2018-01-24 15:48:47 -08:00
Gijs Kruitbosch
1f11d6af6f Bug 1426250 - make tests actually pass valid mouse coordinates when testing Customize Mode, r=jaws 
MozReview-Commit-ID: IglKedBqrWQ

--HG--
extra : rebase_source : a388f02b8d5e00f7e670f41d049518be1de370dc
extra : histedit_source : 8f79f40d24f5456e22787a169cc9f6ae21c03c1e
 2018-01-05 21:35:27 +00:00
Tim Nguyen
e1b673bf04 Bug 1428938 - Remove legacy toolbar customization code. r=Gijs 
MozReview-Commit-ID: 1ppfxI7yYJW

--HG--
extra : rebase_source : b4a2c44dd5e244c81e479e6b43e9669cc031f349
 2018-01-11 16:35:17 +00:00
Paolo Amadini
1714b3aba4 Bug 1425736 - Don't show the attention badge for download failures on the application menu button. r=Gijs 
MozReview-Commit-ID: A882hXl5o0

--HG--
extra : rebase_source : 1584f1141c3e8bc1aeb62559a7136dc9f0745899
 2018-01-09 15:51:19 +00:00
Ian Moody
4228c58572 Bug 1425972 - Add a test for subview navigation on space keydown. r=Gijs 
MozReview-Commit-ID: Hb5WlqOtibS

--HG--
extra : rebase_source : c6584d917f03824d1f4ed2b11ddb69bf3165f307
 2017-12-20 16:48:19 +00:00
Ian Moody
576f8ac9fd Bug 1425972 - Add a test for interleaved arrow and tab navigation in the browser panel. r=Gijs 
MozReview-Commit-ID: DBIop59CWCG

--HG--
extra : rebase_source : a14f4c16ae098758c7805482c12780452f3efdbf
 2017-12-20 02:19:35 +00:00
Ian Moody
92dc6aecdf Bug 1425972 - Add a test for tab navigation in the browser panel. r=Gijs 
MozReview-Commit-ID: L3C65YgRYd5

--HG--
extra : rebase_source : 9de26250aa9f18cf69818898e04b6b49b136b899
 2017-12-20 00:18:19 +00:00
Tooru Fujisawa
034f9f1ec4 Bug 1424877 - Wait for the next event tick in promisePanelElementHidden in browser/components/customizableui/test/head.js. r=Gijs 2017-12-14 14:49:32 -06:00
Tooru Fujisawa
66fd8a5699 Bug 1424083 - Wait for the mouseover event instead of attribute in browser_customizemode_uidensity.js r=Paolo 2017-12-09 06:08:44 +09:00
Tooru Fujisawa
070eb80e9c Bug 1416446 - Part 0.2: Fix browser_981418-widget-onbeforecreated-handler.js to wait for events in correct order and timing. r=Paolo 2017-12-09 06:08:43 +09:00
Dorel Luca
9a04f22fb6 Backed out changeset 8ad560283f5e (bug 1416446) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 2017-12-09 18:59:48 +02:00
Dorel Luca
2761bd8ba2 Backed out changeset 56343b0de5c2 (bug 1424083) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 2017-12-09 18:58:40 +02:00
Tooru Fujisawa
b33da27b5b Bug 1424083 - Wait for the mouseover event instead of attribute in browser_customizemode_uidensity.js r=Paolo 2017-12-09 06:08:44 +09:00
Tooru Fujisawa
ef93d75551 Bug 1416446 - Part 0.2: Fix browser_981418-widget-onbeforecreated-handler.js to wait for events in correct order and timing. r=Paolo 2017-12-09 06:08:43 +09:00
Bill McCloskey
9f4d083047 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap) 
MozReview-Commit-ID: 2nQPOSGTr1s
 2017-12-07 12:55:24 -08:00
Neil Deakin
60e7f4183f Bug 1419925, implement a promise-oriented version of waitForClipboard, promiseClipboardChange, change a selection of tests to use this instead. Simplify some other clipboard tests that were unreliable before the fix for 1394757. r=jmaher 2017-12-07 08:39:50 -05:00
Dorel Luca
1208bc03a7 Merge mozilla-central to autoland r=merge on a CLOSED TREE 
--HG--
extra : rebase_source : 5f22b0e83fd5f1b28e0c1ebbcc429c332835eb36
 2017-12-07 00:27:29 +02:00
Paolo Amadini
b12ae1861e Bug 1417042 - Remove the "panelview" binding. r=Gijs 
MozReview-Commit-ID: 26uQb3pteQd

--HG--
extra : rebase_source : 93263ff4f1e0d38292dbfef3f7385ddd881b25ef
extra : source : bce38a7817ee39ccd38f57f73f5acf81a41e1f69
 2017-12-06 10:37:25 +00:00
Edouard Oger
7fabe73930 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh 
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : c2b534461715f8db1e6cb8bc7910311cc4ff6611
 2017-11-30 16:01:40 -05:00
Edouard Oger
ae62aef149 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh 
MozReview-Commit-ID: 5vBKH9NejVV

--HG--
extra : rebase_source : c160a5a1d7753d41c7afec3a822aefa9461684e6
 2017-11-17 16:48:17 -05:00
Noemi Erli
e5e82c8496 Backed out changeset 932a77d8fbae (bug 1418466) for ES failures in /builds/worker/checkouts/gecko/browser/base/content/browser-sync.js r=backout on a CLOSED TREE 2017-11-30 18:44:16 +02:00
Edouard Oger
016b5734e5 Bug 1418466 - Add Connect Another Device button to relevant Sync UI. r=dao,markh 
MozReview-Commit-ID: 5vBKH9NejVV

--HG--
extra : rebase_source : e8628aba338b19142dc63add9bb380042096053f
 2017-11-17 16:48:17 -05:00
Mike Conley
4250a7d5e6 Bug 1412471 - Fix intermittent failure in browser_panelUINotifications_fullscreen_noAutoHideToolbar.js by ensuring we wait for update popup. r=Gijs 
MozReview-Commit-ID: Yypy0ls4Ap

--HG--
extra : rebase_source : 5ab46c85c58da785fe4ae31ed84da58698cc47fa
 2017-11-24 10:55:41 -05:00
Dorel Luca
171c255f60 Backed out changeset 1ca98c1618a6 (bug 1422106) for failing browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE 2017-12-02 02:37:38 +02:00
Edouard Oger
afb8b81041 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh 
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : 747637f3746356e3da208acc41a3629bd2597e2e
 2017-11-30 16:01:40 -05:00
Dorel Luca
e07748b33c Backed out changeset 3aff028846c0 (bug 1422106) for failing syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js and browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js r=backout on a CLOSED TREE 
--HG--
extra : rebase_source : ec98a160ef77f13abc4b067f8836e290e3b11e21
 2017-12-02 00:33:41 +02:00
Edouard Oger
2a41681065 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh 
MozReview-Commit-ID: BDTdmcIOHmn

--HG--
extra : rebase_source : b1471e1ef0163b2d3b137852d285146f5a23f1fa
 2017-11-30 16:01:40 -05:00
Gijs Kruitbosch
46b1167088 Bug 1420583 - fix new tab adjacency logic when using "restore defaults", r=jaws 
When using "restore defaults", Customize mode unwraps all elements. The previous implementation
of _updateNewTabVisibility assumed that elements were wrapped in <toolbarpaletteitem>s when in
customize mode, but this isn't true during a reset. The new implementation just looks for the
<toolbarpaletteitem>s and their children as necessary.

MozReview-Commit-ID: FjNJ1n8foGi

--HG--
extra : rebase_source : c9de8a2a4d4dcf191281fead320acc2ddc1321d6
 2017-11-27 15:23:42 +00:00
Tawny Hoover
a33fa6a1f2 Bug 1398992 = Make 'Recently Bookmarked' in Photon panels support browser.bookmarks.openInTabClosesMenu pref. r=jaws 
MozReview-Commit-ID: 3Rio9EjwilT

--HG--
extra : rebase_source : dde522b0eb65b22ee74d8dfb6d5f1d1a5489237f
 2017-11-24 21:54:54 -05:00
Gijs Kruitbosch
53181787f7 Bug 1418757 - new tab button isn't adjacent to the last tab when customizing in customize mode, r=jaws 
MozReview-Commit-ID: bQoNfDD2sX

--HG--
extra : rebase_source : e8afb0662e82e3b879bd3b6e28aef27d477bf92c
 2017-11-22 13:49:07 +00:00
Paolo Amadini
fc23659e93 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs 
MozReview-Commit-ID: IjvSZZUHUMt

--HG--
extra : rebase_source : a94e212e8af35b77806d1d62e020a511ab62e224
 2017-11-21 14:21:32 +00:00
Alphan Chen
54f4537537 Bug 980904 - Disable the Character Encoding menu when document is decoded as UTF-8 without errors. r=hsivonen,emk,Gijs 2017-11-23 15:03:41 +08:00
Tooru Fujisawa
50f5bf47cd Bug 1418739 - Part 2: Remove unused delayedStartup parameter from BrowserTestUtils.waitForNewWindow. r=smaug 2017-11-21 03:41:56 +09:00
Mark Banner
ab78a2a54d Bug 1371293 - Fix instances of space-before-function-paren failures after ESLint 4 upgrade. r=mossop 
MozReview-Commit-ID: 5XfdCSDjLEG

--HG--
extra : rebase_source : 96335eec91a40f893ff28a1c002653b758d8f24d
 2017-11-06 13:46:21 +00:00
Gijs Kruitbosch
7cc3de1624 Bug 1388029 - remove dead CSS relating to the old panel, r=jaws 
MozReview-Commit-ID: FoXjvWPc9in

--HG--
extra : rebase_source : b098e2efc8f154aaae5f4ddfd30558fb0f3299c1
 2017-11-07 12:52:56 +00:00
Gijs Kruitbosch
8c1b02e3d4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws 
MozReview-Commit-ID: L017kRfHfOv

--HG--
extra : rebase_source : c9dcbb76d787281ac2dcf18c59786205aeaacaf9
 2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
974b0a4c68 Bug 1408166 - prevent search bar popup from ever showing when browser_940307_panel_click_closure_handling is running to avoid it interfering with context menu clicks, r=florian 
MozReview-Commit-ID: jyRcdAKpxR

--HG--
extra : rebase_source : 66d4452809e8b66383bf8cfb02cfc695b9ade37a
 2017-11-07 10:54:10 +00:00
Jared Wein
b8ffd9d167 Bug 1410666 - Remove unused PanelUI-popup code. r=mconley 
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : 319d160f3057173359f02adba44bdcc12a68e209
 2017-10-31 14:38:15 -04:00
Coroiu Cristina
03154bfceb Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE 
Backed out changeset b558ad2372bf (bug 1410666)
 2017-11-02 01:02:12 +02:00
Jared Wein
2fdc4b7cdf Bug 1410666 - Remove unused PanelUI-popup code. r=mconley 
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : f85e763cc130a71ba0f4bda228a874ebf65b84be
 2017-10-31 14:38:15 -04:00
Mark Banner
01008c7d57 Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian 
MozReview-Commit-ID: 8pidN7x6MYh

--HG--
extra : rebase_source : 6a0d6800091231fc1535223bd7fc6df0ba40d47b
 2017-10-30 09:55:39 +00:00
Edouard Oger
76547f53cc Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc 
MozReview-Commit-ID: APdGc9avJDw

--HG--
extra : rebase_source : aaa788be5251607ebedcb5b690da0e2a1a64e2cb
 2017-10-24 14:05:52 -04:00
Sebastian Hengst
93903f0306 Backed out 2 changesets (bug 1395460) for eslint failure at browser/components/uitour/UITour.jsm:556 (no return value from arrow function). r=backout on a CLOSED TREE 
Backed out changeset 0bc6d186d609 (bug 1395460)
Backed out changeset 6c028123001d (bug 1395460)
 2017-10-26 23:33:04 +02:00
Edouard Oger
58876ecbe9 Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc 
MozReview-Commit-ID: APdGc9avJDw

--HG--
extra : rebase_source : 9da1cea9fb6494c057bc6587a7bcbdb4ac127448
 2017-10-24 14:05:52 -04:00
Felipe Gomes
43ee76c5ed Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer 
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 2qNWebBpsMY

--HG--
extra : rebase_source : b30a4492f839186584c074b82a1969973cda48e0
 2017-10-17 13:39:50 -02:00
Ryan VanderMeulen
e8cd5f653b Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies. 
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
 2017-10-17 10:07:55 -04:00
Felipe Gomes
4346cedc0e Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer 
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 8wbjdYIC3gb

--HG--
extra : rebase_source : 2ea1b77d4a9fd9c3eb17853c8ec655b309a3fa8c
 2017-10-16 14:00:30 -02:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8 
MozReview-Commit-ID: Jm8BRgt6mIv
 2017-10-15 20:50:39 +01:00
Julian Descottes
6a18c24749 Bug 1361080 - filter out hidden devtools menu items in customizableui test;r=jaws 
DevTools are adding a hidden menuitem "Enable DevTools..." that will be used to
propose an onboarding screen to users. This hidden button makes a customizable ui
test fail. It needs to be filtered out.

MozReview-Commit-ID: IX4SlpDHdsT

--HG--
extra : rebase_source : e2c9e26b27b1bf8788739f8d6384c19473ffdd23
 2017-10-11 17:04:22 +02:00
Erica Wright
86e507bf06 Bug 1406191 - Cleanup browser_widget_animation.js, remove event listener and close panel correctly. r=johannh 
MozReview-Commit-ID: 6IjrdxnWPqa

--HG--
extra : rebase_source : 5b52caffa1d523964ee485859dd562919f5f971a
 2017-10-10 15:59:14 -04:00
Dão Gottwald
8fa6f14905 Bug 1406625 - Remove leftover code and styling for <toolbarbutton type="menu-button"> r=mikedeboer 
MozReview-Commit-ID: 8wBsluIMZHq

--HG--
extra : rebase_source : 8733868d1afc6a34b6e9050b6bd80f01097a66f3
 2017-10-07 20:10:24 +02:00
Erica Wright
7e91455352 Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs 
MozReview-Commit-ID: 5PxydbSfhpz

--HG--
extra : rebase_source : 3941fa6edb5e8eb0d14d6d04ad5b0d63ef1a5b84
 2017-09-18 16:15:24 -04:00
Gijs Kruitbosch
19ef18501c Bug 1405720 - ensure only 1 theme is ever shown as selected in customize mode, r=jaws,johannh 
The previous code here always set the `isActive` property on all themes. When writing the
patch for bug 1402981 I ran into issues because the default theme has an `isActive` property
anyway (it's a different type of object). So I tried to avoid setting `isActive` if it was
already present. Unfortunately, the result was that `isActive` values, once set, weren't
correctly updated. Worse, these values are (and were, prior to bug 1402981) persisted in
some cases.

There's no point persisting these values, all that will happen is that they'll start
mismatching the 'real' state of the world (LightweightThemeManager.currentTheme). So instead,
let's just not set the `isActive` property at all, and rely solely on the ID of the current
theme (or the default theme's ID, now that we no longer support non-lightweight-themes) to
establish whether any of the themes should appear selected or not.

MozReview-Commit-ID: 7rajS71FoQR

--HG--
extra : rebase_source : a99e04031ea9e122efdaf0436e354abe57439783
 2017-10-05 15:17:12 +01:00
Edouard Oger
e29fd6597a Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh 
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : cc4d0d3ca7d12b2f83b79fc7c5db9c05f77944cf
 2017-09-20 13:16:19 -04:00
Sebastian Hengst
6c9c0c17e9 Backed out changeset 9ab9bde4021f (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-10-04 21:49:30 +02:00
Edouard Oger
27e4a543cc Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh 
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : 23d246a20afd7069f095e29b2943851011813239
 2017-09-20 13:16:19 -04:00
Sebastian Hengst
0b883eed0e Backed out changeset 97fdb9d392e5 (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-10-04 21:12:32 +02:00
Edouard Oger
bc78c3795e Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh 
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : 3172be8b46d44c50ea4f2c806771e10172057cf3
 2017-09-20 13:16:19 -04:00
Gijs Kruitbosch
49c8b259d5 Bug 1396423 - make it possible to drop items in what visually looks like the palette but isn't, r=mikedeboer 
MozReview-Commit-ID: AqBwn9ovTjT

--HG--
extra : rebase_source : 58dd5d79db16d56be502f70cd7e533a4093f1c39
 2017-09-29 15:40:48 +01:00
Gijs Kruitbosch
f207243be7 Bug 1402981 - add light and dark themes to the list of themes in customize mode by default, r=jaws 
MozReview-Commit-ID: 4GxPEm119Yc

--HG--
extra : rebase_source : a1a6acf06e158fd937e6b53ea65cc91c2e4d02ce
 2017-09-27 22:37:19 +01:00
Mike de Boer
882fa06e25 Bug 1401991 - Ensure that we don't hide panelviews that are already reparented to another multi-view and ensure to hide other panels consistently. r=Gijs 
* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
   the binding is already gone.
 * Generalize things into `hideAllViewsExcept(thisOne)`:
    - Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
      in there too,
    - For Photon panels, do all the 'current' attribute setting in there. To show
      a panel during transition, I introduced the 'in-transition' attribute.
 * I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
   that confuses some,
 * Move the temporary panel handling, which contains an ephemeral panelmultiview
   instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
 * Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
 * Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
   specific transition, _if_ that's passed in as an argument. This resolves any
   potential raciness that might occur when `showSubView()` is called again mid-transition.
 * Skip the UITour element visibility check when it's inside a panelview, because
   too many things need to happen and that check is too simple to be useful in
   that case.

MozReview-Commit-ID: 5HpJKs1Ny5j

--HG--
extra : rebase_source : b810e1de2dbd75932a42d68e751fdaecd9fee69a
 2017-09-29 13:51:51 +02:00
Sebastian Hengst
e0196045d0 Backed out changeset 8855ba3f65ba (bug 1397744) for failing browser-chrome's browser/components/customizableui/test/browser_synced_tabs_menu.js. r=backout 2017-09-28 20:27:50 +02:00
Edouard Oger
c602795751 Bug 1397744 - Show the Sync animation immediately after clicking the manual sync button. r=markh 
MozReview-Commit-ID: AIBjAZZlYX6

--HG--
extra : rebase_source : 562023d6bfdb78aa2fad6c42948b57db8bc04f99
 2017-09-20 13:16:19 -04:00
Mike de Boer
c0b0c75c02 Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs 
MozReview-Commit-ID: 44Q9NbKEJeC

--HG--
extra : rebase_source : 4895a170b403195cd1bc7023fc905deff12c2de2
 2017-09-20 14:25:58 +02:00
Andrew Halberstadt
7527e600f0 Bug 1392787 - Disable manifestparser tests using 'disabled' key instead of comment, r=jmaher 
MozReview-Commit-ID: IQL7hWxQX9F

--HG--
extra : rebase_source : b78cbf7913fc1b0a27dfa085c38957e2bc2467d0
 2017-08-22 16:56:02 -04:00
Gijs Kruitbosch
b7ec7b74c5 Bug 1399517 - CustomizableUI shouldn't try to insert items next to nodes that aren't in the right container, r=mikedeboer 
MozReview-Commit-ID: H9KY7YQwmlQ

--HG--
extra : rebase_source : 75f92768868003280a8e187ce6f2bbc2b88dd8ca
 2017-09-18 16:36:46 +01:00
Gijs Kruitbosch
069f2c2997 Bug 1391280 - store last sidebar command irrespective of whether sidebar was open, r=bgrins,mixedpuppy 
MozReview-Commit-ID: HBfdW5vEZaD

--HG--
extra : rebase_source : 5058884698a2a2144b921a36abbe7c8c3a1fda52
 2017-08-23 14:06:26 +01:00
Johann Hofmann
0dbe3971c5 Bug 1349552 - Part 3 - Add a test for drag space in customize mode. r=nhnt11 
MozReview-Commit-ID: AiqY1J5WwYo

--HG--
extra : rebase_source : 4fb5cea18653a05f17c80595b48c8f3aae9b0d2a
 2017-09-10 20:39:21 +02:00
Gijs Kruitbosch
3f3bcb5b73 Bug 1397447 - ensure the button is in the navbar by default, r=mak 
MozReview-Commit-ID: H6r3dAEg4r1

--HG--
extra : rebase_source : fdb9b8d65745a57e3ac1ffa71cce10654032b177
 2017-09-08 14:07:05 +01:00
Gijs Kruitbosch
ecf2be01ab Bug 1397447 - make downloads button autohide by default, r=mak 
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : 11dc3f1b98f53f5897a3185253b68d2cf7d5083b
extra : source : 97f7f5175b2fc3adfb193783f7ecb70b5b9b4562
 2017-09-08 14:16:36 +01:00
Sebastian Hengst
6b5abf8cab merge mozilla-central to autoland. r=merge 2017-09-07 12:40:32 +02:00
Sebastian Hengst
8eb249afcc merge mozilla-inbound to mozilla-central. r=merge a=merge 
MozReview-Commit-ID: JSRVc5yW6Kx
 2017-09-07 12:39:12 +02:00
Paolo Amadini
fe96089fe4 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs 
MozReview-Commit-ID: Tq8YrZWG6P

--HG--
extra : rebase_source : 2e02e0a809d08ff26291a027b73a54668d6d5f9d
 2017-09-06 13:09:27 +01:00
Gijs Kruitbosch
81a14da14a Bug 1396966 - fix dnd in a test to work in small screens, r=mystor 
MozReview-Commit-ID: 7xqfLc1M0PA

--HG--
extra : rebase_source : 12031eea1a7106a00a0d921825c71731fdf33ea4
 2017-09-06 19:39:53 +01:00
Gijs Kruitbosch
8ec70a2c1b Bug 1393574 - fix flexible spacers not being removable in some circumstances, r=jaws 
The goal of this patch is to ensure that:
- in default placements, specials have no unique ids
- in actual placements as stored by CUI, they do
- we reset the counter for those unique ids on reset.
- we re-number specials when building an area (like on startup, or when resetting),
  ensuring that the actual nodes always match the placements for a given area.
- we force saves after resetting, to ensure that the gNewElementCount is always persisted correctly.

This last part will also fix bug 1393661

MozReview-Commit-ID: HAS5J5ZSgB5

--HG--
extra : rebase_source : df62441169e07fb94e39f68a2b3e43f6ed7f464c
 2017-09-06 10:02:44 +01:00
Ricky Chien
daac97d466 Bug 1349689 - Remove old preferences fork r=jaws 
MozReview-Commit-ID: GNPcQGUTUKJ

--HG--
rename : browser/components/preferences/in-content-new/findInPage.js => browser/components/preferences/in-content/findInPage.js
rename : browser/components/preferences/in-content-new/searchResults.xul => browser/components/preferences/in-content/searchResults.xul
rename : browser/components/preferences/in-content-new/tests/browser_checkspelling.js => browser/components/preferences/in-content/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content-new/tests/browser_engines.js => browser/components/preferences/in-content/tests/browser_engines.js
rename : browser/components/preferences/in-content-new/tests/browser_layersacceleration.js => browser/components/preferences/in-content/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content-new/tests/browser_masterpassword.js => browser/components/preferences/in-content/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js => browser/components/preferences/in-content/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content-new/tests/browser_security-1.js => browser/components/preferences/in-content/tests/browser_security-1.js
rename : browser/components/preferences/in-content-new/tests/browser_security-2.js => browser/components/preferences/in-content/tests/browser_security-2.js
extra : rebase_source : 9adc8231c896f93f7f262a09482b44a2875bd5fd
 2017-08-21 17:48:18 +08:00
Sebastian Hengst
51133fbff6 Backed out changeset df8215261c7e (bug 1349689) on request from rchien. r=backout 
--HG--
rename : browser/components/preferences/in-content/findInPage.js => browser/components/preferences/in-content-new/findInPage.js
rename : browser/components/preferences/in-content/searchResults.xul => browser/components/preferences/in-content-new/searchResults.xul
rename : browser/components/preferences/in-content/tests/browser_checkspelling.js => browser/components/preferences/in-content-new/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content/tests/browser_engines.js => browser/components/preferences/in-content-new/tests/browser_engines.js
rename : browser/components/preferences/in-content/tests/browser_layersacceleration.js => browser/components/preferences/in-content-new/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content/tests/browser_masterpassword.js => browser/components/preferences/in-content-new/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content/tests/browser_permissions_dialog.js => browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content/tests/browser_security-1.js => browser/components/preferences/in-content-new/tests/browser_security-1.js
rename : browser/components/preferences/in-content/tests/browser_security-2.js => browser/components/preferences/in-content-new/tests/browser_security-2.js
 2017-08-31 16:58:32 +02:00
Ricky Chien
3ff2ff68ed Bug 1349689 - Remove old preferences fork r=jaws 
MozReview-Commit-ID: GNPcQGUTUKJ

--HG--
rename : browser/components/preferences/in-content-new/findInPage.js => browser/components/preferences/in-content/findInPage.js
rename : browser/components/preferences/in-content-new/searchResults.xul => browser/components/preferences/in-content/searchResults.xul
rename : browser/components/preferences/in-content-new/tests/browser_checkspelling.js => browser/components/preferences/in-content/tests/browser_checkspelling.js
rename : browser/components/preferences/in-content-new/tests/browser_engines.js => browser/components/preferences/in-content/tests/browser_engines.js
rename : browser/components/preferences/in-content-new/tests/browser_layersacceleration.js => browser/components/preferences/in-content/tests/browser_layersacceleration.js
rename : browser/components/preferences/in-content-new/tests/browser_masterpassword.js => browser/components/preferences/in-content/tests/browser_masterpassword.js
rename : browser/components/preferences/in-content-new/tests/browser_permissions_dialog.js => browser/components/preferences/in-content/tests/browser_permissions_dialog.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_1.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_3.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_4.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js => browser/components/preferences/in-content/tests/browser_search_subdialogs_within_preferences_8.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_2.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_2.js
rename : browser/components/preferences/in-content-new/tests/browser_search_within_preferences_command.js => browser/components/preferences/in-content/tests/browser_search_within_preferences_command.js
rename : browser/components/preferences/in-content-new/tests/browser_security-1.js => browser/components/preferences/in-content/tests/browser_security-1.js
rename : browser/components/preferences/in-content-new/tests/browser_security-2.js => browser/components/preferences/in-content/tests/browser_security-2.js
extra : rebase_source : 6f59261adcb6cd3098b3596c01c9165ad6bfc03c
 2017-08-21 17:48:18 +08:00
Gijs Kruitbosch
e47e6f071c Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo 
MozReview-Commit-ID: FTvFDV5nuG6

--HG--
extra : rebase_source : af8ed6b6da9adc1badbdc5016aacb877511875f0
 2017-08-25 13:32:47 +01:00
Gijs Kruitbosch
58d91186ae Bug 1393133 - wait for the overflow button to be visible before activating it in tests, r=jaws 
MozReview-Commit-ID: 58GGrPVufZ3

--HG--
extra : rebase_source : 325709623de03b4fd7e1414fff5bb42474194551
 2017-08-24 17:25:24 +01:00
Gijs Kruitbosch
c6da57415c Bug 1389625 - clean up subview headers now that we use the title of the view instead, r=adw 
The panel-subview-header is always hidden in photon (sub)panels, and so we now never show it.
Removing it avoids having to readd the old label for the bookmarks view, remove some unused
strings, and I noticed that we accidentally left the PanelUI-sidebar container which is
unused since bug 1360282.

MozReview-Commit-ID: 4ProWA1sUUs

--HG--
extra : rebase_source : e887b156f450a62cf04228db13b8584810fdf5a0
 2017-08-24 14:03:15 +01:00
Wes Kocher
4ea67d0e07 Backed out changeset e774700fe070 (bug 1392787) for build bustage a=backout CLOSED TREE 
MozReview-Commit-ID: FRRUDa6rIuS
 2017-08-24 13:58:52 -07:00
Andrew Halberstadt
cae249f833 Bug 1392787 - Disable manifestparser tests using 'disabled' key instead of comment, r=jmaher 
MozReview-Commit-ID: IQL7hWxQX9F

--HG--
extra : rebase_source : d907a5b2192687d86e3291a936c943948ed6793f
 2017-08-22 16:56:02 -04:00
Jared Wein
6c68f6b603 Bug 1387313 - Allow dragging non-removable items (url bar, back/forward buttons) within their toolbar. r=Gijs 
MozReview-Commit-ID: 1EQxMcLJn9J

--HG--
extra : rebase_source : 884ddb84896bec96b4cc05d2d067e8e3a69603c7
 2017-08-21 14:20:40 -04:00
Gijs Kruitbosch
ace9ca19d1 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo 
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : f2c8a292c5bddb2dfde656b0f37fe2abee371ea0
 2017-08-16 15:54:36 +01:00
Gijs Kruitbosch
bdf83368d1 Bug 1391616 - make migration of existing hamburger panel contents actually work, r=jaws 
MozReview-Commit-ID: 4YC4BWI10YW

--HG--
extra : rebase_source : e440a1008986a81674a72b033ddbd15a35453d26
 2017-08-18 13:59:32 +01:00
Gijs Kruitbosch
b308974089 Bug 1366207 - remember previous view's selection when keyboard navigating panels, r=mikedeboer 
MozReview-Commit-ID: 14U7hkrBbJq

--HG--
extra : rebase_source : c6a0439d253d38a776445793b235b93ba5873f48
 2017-08-15 15:21:15 +01:00
Gijs Kruitbosch
d0f97efd43 Bug 1390260 - remove old customize test, add test that checks it works in main window, r=mkaply 
MozReview-Commit-ID: 9Tm8kLjxukB

--HG--
extra : rebase_source : a8d599d6e67151abdc2b65297b5cb5fcbc2dbea7
 2017-08-15 17:42:16 +01:00
Stone Shih
1b13c3deba Bug 1351148 Part8: Revise browser_1008559_anchor_undo_restore.js to continue the test after processing the mouse event. r=smaug. 
MozReview-Commit-ID: BYF94RsKhR6
 2017-07-16 12:38:13 +08:00
Sebastian Hengst
56c035fa36 merge mozilla-inbound to mozilla-central. r=merge a=merge 
MozReview-Commit-ID: 4cZJ3qFjvPY
 2017-08-12 23:49:21 +02:00
Gijs Kruitbosch
7c9b10befb Bug 1389285 - check that clicking history items actually works, r=mikedeboer 
MozReview-Commit-ID: 2WKqYaO8Iht

--HG--
extra : source : bff4d1e4243f2c1472d9339aa7060be4c819b637
 2017-08-11 14:05:48 +01:00
Gijs Kruitbosch
6ff153a8b2 Bug 1388990 - avoid breaking the broadcast/listener relationships of the back/fwd buttons when customizing, r=dao 
MozReview-Commit-ID: EsH3lv8QXfJ

--HG--
extra : rebase_source : 20325d2b014abf9687c83eae3cda267eeda078eb
 2017-08-12 11:56:22 +01:00
Andrew Halberstadt
d2109610fb Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8 
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : 8607b3964da207a6076c79b6f1d75b40503cdd7d
 2017-08-10 14:48:21 -04:00
Phil Ringnalda
0ff5a4285d Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland 
MozReview-Commit-ID: 3HDE2C3wSU0
 2017-08-10 20:21:19 -07:00
Mike Taylor
71e035473c Bug 1373650. Unteach CustomizableUI about the Report Site Issue button. r=Gijs 
MozReview-Commit-ID: BCXVJChZ0mt

--HG--
extra : rebase_source : 6c7dec5932e804f620f8af53d91f5d3e0961ef05
 2017-08-04 15:35:18 -05:00
Andrew Halberstadt
f625fd5c37 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8 
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : d72a88962ec8d843e7be99e25f710887f01b6e1a
 2017-08-10 14:48:21 -04:00
Sebastian Hengst
e5aac1d087 Backed out changeset bf603affd1e0 (bug 1388753) for failing browser-chrome's browser_947914_button_history.js. r=backout 2017-08-10 20:02:44 +02:00
Gijs Kruitbosch
ce10833235 Bug 1383009 - add flexible spacers and library button to the navbar by default, r=jaws 
Because we generate IDs for special nodes, we should update the inDefaultState getter to actually consider
these nodes to match even when the ids differ. This wasn't an issue before because specials weren't in the
default set for any nodes.

MozReview-Commit-ID: AI85yt2LuJD

--HG--
extra : rebase_source : 819e27885148deb588c057c4e811371a87f1d2fc
 2017-08-07 19:10:40 +01:00
Gijs Kruitbosch
12b877d713 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer 
MozReview-Commit-ID: 1vjP6IeIiPz

--HG--
extra : rebase_source : 1bf36537326b86fff6e3db814908cb64aaad3e57
 2017-08-09 18:02:36 +01:00
Dão Gottwald
2c29c9f69a Bug 956731 - Remove legacy add-on bar and statusbar shims. r=Gijs 
MozReview-Commit-ID: 2deeujcHYUM

--HG--
extra : rebase_source : 90e8c1f1c90655d3e38560b588af82da64fdc2a5
 2017-08-10 09:17:48 +02:00
Michael Kohler
674e1b96fb Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao 
MozReview-Commit-ID: 8w1vfF2yRui

--HG--
extra : rebase_source : 222d8e9d3b9543552ff5b08967375fa46d62b896
 2017-08-08 12:09:14 +02:00
Gijs Kruitbosch
768b0621d1 Bug 1385083 - history panel should actually list history, r=mikedeboer 
MozReview-Commit-ID: G98QMcmASv0

--HG--
extra : rebase_source : 4a8e533d21d0a4a1d464f1e5f546c82c81fce37f
 2017-08-07 15:24:49 +01:00
Sebastian Hengst
ca40024d84 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
45d5f35624 Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao 
MozReview-Commit-ID: CoHv9mKpAe

--HG--
extra : rebase_source : 20d6404db9f90cfcb7de03d4c527ad6ed79d49f8
 2017-08-05 20:37:40 +02:00
Sam Foster
bae82564b3 Bug 1352075 - Implement new animation for opening/closing the arrow panels. r=dao,mossop 
* Use new panel animation when opening arrow-panels (including bookmarks menu) to fade in and drop into position
* Linux/GTK is (still) excluded
* New animation is non-directional (i.e. LTR vs. RTL)

This was landed then backed out due to test failures. New since last review:

* Make opacity & transform transition durations equal - ensuring popup is not still moving when popupshown is fired
* Fix missing comma in transition-duration values
* Add animating attribute to the arrowpanel binding to disable pointer-events during the opening transition (via :jaws)
* Wait for popupshown rather than transitionend in bookmark reparenting test
* Fix specificity of CSS rules for panels/bookmarks-menu on edges other than the top (via :jaws)

MozReview-Commit-ID: DTnvyMryf5Y

--HG--
extra : rebase_source : 77895818356b1b366e93c6a8c508ae2b74dbca5c
 2017-07-27 11:07:23 -07:00
Gijs Kruitbosch
2b8e704244 Bug 1354117 - remove old panel code from panelUI and CSS, r=jaws 
MozReview-Commit-ID: G6a9ybDxqki

--HG--
extra : rebase_source : 6b2ec759d40d120842de9be9945fb27cda494745
 2017-08-01 19:59:38 +01:00
Gijs Kruitbosch
03a486b23d Bug 1354117 - fix telemetry and a number of tests that flip photon prefs, r=johannh 
MozReview-Commit-ID: 7ynaIQm22eS

--HG--
extra : rebase_source : 703ceae16cbf521de2fa1689668c68f1f06f682a
 2017-08-01 20:15:48 +01:00
Gijs Kruitbosch
c4fb9878e0 Bug 1354117 - only dispatch view events once, and fix synced tabs button test, r=jaws 
Prior to this patch, both CustomizableUI itself and the PanelMultiView module
tried to ensure that onViewShowing/Shown/Hiding/Hidden listeners were invoked
when the relevant DOM events fired.

PanelMultiView was doing this manually because CUI was only adding listeners
once the corresponding widget was created. Now that the relevant views can be
accessed without the corresponding widgets (via the fixed appMenu), there was
no guarantee that the listeners would be attached, and this caused empty
subviews.

Unfortunately, if the widget *was* present, it caused events to fire more than
once, which understandably broke consumers like the sync remote tabs widget,
which broke the test we're fixing up here. For other views, even if they were
not completely broken it at least did busy-work.

This patch removes the manual event invocation, and delegates the event
listener work to CUI from the PanelMultiView side. This ensures events fire,
and fire only once.

MozReview-Commit-ID: 94GhcrdcBuB

--HG--
extra : rebase_source : 4df42939aa06ec10b7f86c3c2e4fe75160c7e7bd
 2017-08-01 12:45:55 +01:00
Gijs Kruitbosch
beb6be4934 Bug 1354117 - Update various other customizableui tests for photon, r=adw 
There are no more help/quit buttons in the panel that shows up in customize mode,
and there are no more hyphenation quirks in items in the panel, so those tests
have been removed. The remaining tests are updated to test the correct panels.

MozReview-Commit-ID: LiUWejjZC7c

--HG--
rename : browser/components/customizableui/test/browser_photon_customization_context_menus.js => browser/components/customizableui/test/browser_customization_context_menus.js
extra : rebase_source : 49cef6ebeee140aefdb7a90d64b48c0da8179dc1
 2017-08-01 15:46:58 +01:00
Gijs Kruitbosch
277d122161 Bug 1354117 - fix or remove tests that drag items to the panel, r=adw 
The new panel doesn't have placeholders, or a distinction between wide and
narrow widgets, so those tests can just be removed.

MozReview-Commit-ID: D61AjwMbabG

--HG--
extra : rebase_source : 662a74e50ea05c5a4c5fdee476cae10fc9862775
 2017-07-31 18:26:38 +01:00
Gijs Kruitbosch
8216336ee8 Bug 1354117 - update panel button tests for photon, r=adw 
MozReview-Commit-ID: 94mIvlOenCg

--HG--
extra : rebase_source : 165971d09f4bf5129aafcf2d6c1e11c1315cd6a1
 2017-08-01 11:33:26 +01:00
Gijs Kruitbosch
1ad503ecf6 Bug 1354117 - update customize mode button state test, r=johannh 
Again, this test is mostly useless now, so I would also be fine with just removing it.

MozReview-Commit-ID: BwOGQ5pwSQd

--HG--
extra : rebase_source : 1e5b961e4f0f9f17d0aee3e6cd3aeb1d6bc75741
 2017-07-31 21:10:14 +01:00
Gijs Kruitbosch
cf5f0b7624 Bug 1354117 - remove wrap handling for the bookmarks toolbar button and tests verifying it, r=johannh 
MozReview-Commit-ID: CeSGIQrDPpw

--HG--
extra : rebase_source : 11a15f98fe7b4fc8fa26152ad5e5e43551cc8a3b
 2017-07-31 21:52:06 +01:00
Julian Descottes
a3fb1d41fb Bug 1387023 - initialize devtools before asserting menu items in browser_989751_subviewbutton_class.js;r=Gijs 
MozReview-Commit-ID: 9piucVkS0Y9

--HG--
extra : rebase_source : bea3a2a6c02fa7689b0b2437567dfb91d03701a0
 2017-08-03 14:04:54 +02:00
UK992
04a7b8f7ca Bug 1363485 - Update tests r=dao 
MozReview-Commit-ID: 4epuVQVCJPH

--HG--
extra : rebase_source : aef306464344009feb0e28295a0159cc9aab19ad
 2017-07-30 20:39:55 +02:00
Sebastian Hengst
4f5ee61f5b Backed out changeset f3e224764ca8 (bug 1363485) 2017-08-02 16:24:54 +02:00
UK992
4d606a1288 Bug 1363485 - Update tests r=dao 
MozReview-Commit-ID: 4epuVQVCJPH

--HG--
extra : rebase_source : aef306464344009feb0e28295a0159cc9aab19ad
 2017-07-30 20:39:55 +02:00