Commit graph

185 commits

Author SHA1 Message Date
Masatoshi Kimura
502bc1fe35 Bug 1601235 - Remove the second arg of nsIXULBrowserWindow::SetOverLink. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D55946

--HG--
extra : moz-landing-system : lando
2019-12-05 14:23:01 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Brian Grinstead
d7cccbcb04 Bug 1578569 - Restore padding-bottom on certain menupopups inside BMB_bookmarksPopup r=mak
This was removed in Bug 1573158, where the following line change forced it to 0px:
https://hg.mozilla.org/integration/autoland/rev/3f54e52c52eb#l2.12

This uses shadow parts instead of Shadow DOM + XBL selectors into the arrowscrollbox,
which unblocks arrowscrollbox Custom Element conversion and appears to have the same
visual effect as far as I can tell.

Differential Revision: https://phabricator.services.mozilla.com/D44556

--HG--
extra : moz-landing-system : lando
2019-09-04 18:37:04 +00:00
Jared Wein
776e7c17fb Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745

--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:49 +00:00
Bogdan Tara
844afcfb06 Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Alexander Surkov
002fc892ce Bug 1539651 - Convert places-popup-base and places-popup-arrow bindings to Custom Elements r=mak
Differential Revision: https://phabricator.services.mozilla.com/D33821

--HG--
rename : browser/components/places/content/menu.xml => browser/components/places/content/places-menupopup.js
extra : moz-landing-system : lando
2019-08-08 14:28:36 +00:00
Jared Wein
bfdcad7ada Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745

--HG--
extra : moz-landing-system : lando
2019-08-08 01:38:50 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Marco Bonardo
936159f4b1 Bug 1502119 - Remove obsolete nodeAnnotationChanged. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D34998

--HG--
extra : moz-landing-system : lando
2019-06-16 13:46:14 +00:00
Andrew Swan
9bedc4a90f Bug 1555496 Fix bookmark toolbar drag handlers r=bgrins
Code here explicitly references lastElementChild inside a toolbarbutton
but it doesn't have any tests so it wasn't caught when bug 1519577 landed :(

Differential Revision: https://phabricator.services.mozilla.com/D33104

--HG--
extra : moz-landing-system : lando
2019-05-30 03:29:19 +00:00
Andrew Swan
a745ec6099 Bug 1519577 Convert toolbarbutton to a custom element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D31941

--HG--
extra : rebase_source : 3709ef713f1a7dc9fbc2d0ac97f16bea757fcd2b
2019-05-20 10:01:02 -07:00
Ian Moody
67fb55f3b9 Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs
Result of running:
$ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24110

--HG--
extra : moz-landing-system : lando
2019-03-20 10:17:42 +00:00
Marco Bonardo
5c4e44ce0a Bug 1528751 - Add a custom eslint rule to check "consistent" if bracing. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D20753

--HG--
extra : moz-landing-system : lando
2019-02-28 08:39:33 +00:00
Jonas Allmann
fbe8b0661c Bug 1523813, Remove new Function from utilityOverlay.js, r=Gijs
Replaced new Function() by CustomEvent carrying original click event as sourceEvent.
Adapted all oncommand listeners to use event.sourceEvent instead of event.

Differential Revision: https://phabricator.services.mozilla.com/D18847

--HG--
extra : moz-landing-system : lando
2019-02-19 16:20:02 +00:00
Toby Ward
b7922e7f75 Bug 1435562 - browser.tabs.warnOnOpen is now respected when opening multiple items from the library. r=Standard8
- Unified openContainerNodeInTabs and openURINodesInTabs in PlacesUIUtils into openMultipleLinksInTabs
- Users are now warned when the amount of links to be opened is equal to or exceeds browser.tabs.maxOpenBeforeWarn

Differential Revision: https://phabricator.services.mozilla.com/D12983

--HG--
extra : moz-landing-system : lando
2018-12-10 17:04:18 +00:00
James Abbatiello
12cc731f36 Bug 430577 - Don't open dropdown on bookmarks toolbar folder when opening new tabs, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D13666

--HG--
extra : moz-landing-system : lando
2018-12-04 19:41:17 +00:00
Mark Banner
8b5c6973b6 Bug 1501811 - Remove livemarks support from browserPlacesViews/treeView. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D9701

--HG--
extra : moz-landing-system : lando
2018-10-26 07:40:15 +00:00
Gijs Kruitbosch
fd6e0060d2 Bug 1501592 - remove remaining expired feed telemetry, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D9665

--HG--
extra : moz-landing-system : lando
2018-10-25 10:52:59 +00:00
Brendan Dahl
f6923ccc24 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265

--HG--
extra : moz-landing-system : lando
2018-08-25 00:16:27 +00:00
Mark Banner
bf2dba5c9f Bug 1476228 - Enable comma-dangle ESLint rule for Places directories. r=mikedeboer
MozReview-Commit-ID: K8HcZfyF4Sz

Differential Revision: https://phabricator.services.mozilla.com/D3796

--HG--
extra : moz-landing-system : lando
2018-08-22 15:44:43 +00:00
Brian Grinstead
abf1620630 Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw

--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
2018-08-08 15:22:53 -07:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Marco Bonardo
8a103b5d04 Bug 1461685 - The bookmarks toolbar is empty if the first bookmark is a separator. r=standard8
MozReview-Commit-ID: JcDokxD2wXh

--HG--
extra : rebase_source : bf0579d079195070990e70042090861a9aa6a4d1
2018-05-16 15:24:23 +02:00
Gijs Kruitbosch
9654bc99a1 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F

--HG--
extra : rebase_source : cf6011f2ecfe78df11a6741dfa074c7d985ec294
extra : source : 1ce48405e58a609299a84192df04d340cd90de63
2018-04-20 15:09:44 +01:00
Andreea Pavel
7abcd926f5 Backed out changeset 1ce48405e58a (bug 1447619) for creating bug 1457257 and bug 1457289 on a CLOSED TREE 2018-04-28 20:46:51 +03:00
Kris Maglione
bf4d9f1be5 Bug 1456035: Part 5 - Convert manual QueryInterface to ChromeUtils.generateQI. r=mccr8
Manually-implemented QueryInterface functions don't benefit from the
MozQueryInterface optimizaions, and a lot of them are in hot code, and
implement a large number of interfaces.

MozReview-Commit-ID: 8OzglraowZt

--HG--
extra : rebase_source : 5fff3d9973a0ea976096339a63ce9ff628b68441
2018-04-23 12:58:34 -07:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Boris Zbarsky
76ead58490 Bug 1455674 part 19. Get rid of JS uses of nsIDOMElement. r=qdot
In nsBlocklistService.js we know we're dealing with actual nodes, so .nodeType
checks should be fine.
2018-04-26 23:37:34 -04:00
Gijs Kruitbosch
39d0e25c38 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F

--HG--
extra : rebase_source : e8932810584e10a1de0c1b11c1a152d2dc0f48dd
2018-04-20 15:09:44 +01:00
Marco Bonardo
4a3329832f Bug 1453638 - 'Open site' in live bookmarks is not working. r=jkt
MozReview-Commit-ID: 5KV8jDRxEjf

--HG--
extra : rebase_source : 48d04191db3f5f22c2d121ba5020d3b9bfa6e8af
2018-04-12 17:41:12 +02:00
Boris Zbarsky
b43b5abed4 Bug 1453345 part 5. Remove pointless JS implemenations of QI to nsIDOMEventListener. r=smaug
MozReview-Commit-ID: Db0v6GZ0deo
2018-04-12 00:03:45 -04:00
Jonathan Kingston
ff73ac0338 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja

--HG--
extra : rebase_source : 29d337e111d82e9c5729b5a59e1a16d06e67774c
2018-02-21 14:28:48 +00:00
Marco Bonardo
d666e0fda1 Bug 1421664 - 3 - Fix the UI and tests. r=standard8
test_419731.js can be removed since it is already covered by browser_bookmarkProperties_editTagContainer.js

MozReview-Commit-ID: K0LFuTptWyW

--HG--
extra : rebase_source : 10066aa0bdb6a598fc6af638fed455d58422b7fb
2018-03-22 14:13:07 +01:00
Marco Bonardo
fc2611f53a Bug 1446951 - 4 - Make QueriesToQueryString and QueryStringToQueries singular. r=standard8
MozReview-Commit-ID: K8x2x0kARDn

--HG--
extra : rebase_source : 6428ba1b52e5c6e4714ad970b1397e181ed42e72
2018-03-16 18:43:57 +01:00
Marco Bonardo
240b8426bf Bug 1446951 - 1 - Remove nsINavHistory::ExecuteQueries. r=standard8
MozReview-Commit-ID: ATQLGKzMtnn

--HG--
extra : rebase_source : 17fe8abde9832bd475137eb9b629096bc4d0d1a8
2018-03-16 15:38:05 +01:00
Mike Conley
a2c22e61fc Bug 1358719 - Get rid of synchronous layout flush in browserPlacesViews.js. r=mak
This uses promiseDocumentFlushed to make it easier to query for
layout information for the overflowing bookmark toolbar without
causing sync layout flushes. All DOM operations on the toolbar
have been moved to run within a requestAnimationFrame in order
to reduce the likelihood that other JavaScript that's about to
run will cause style or layout flushes.

MozReview-Commit-ID: 1GrARVc4RMJ

--HG--
extra : rebase_source : 749747d6525814c937299a20fe77821d12fc7715
2018-02-27 19:09:27 -05:00
Paolo Amadini
2065c0409c Bug 1443189 - Places subviews are not updated while they are open. r=Gijs
MozReview-Commit-ID: 5WHDqKsHjDJ

--HG--
extra : rebase_source : 3a325b44d09f462ec8b9c6a1e59a5743c3240fb4
2018-03-07 22:01:58 +00:00
Marco Bonardo
039ea5e750 Bug 1439315 - 6 - Move some utils into PlacesController or PlacesUIUtils. r=standard8
MozReview-Commit-ID: D7J6hY7Akro

--HG--
extra : rebase_source : 9e9f885db98c72a857c941b2eb6b8a294d1b570e
2018-02-28 13:51:28 +01:00
Marco Bonardo
388f9e4090 Bug 1439315 - 1 - rename InsertionPoint to PlacesInsertionPoint. r=standard8
MozReview-Commit-ID: 1NfkueEUPXC

--HG--
extra : rebase_source : 9e3e6f58742a0900fdd73e6c5ed5089f7d01da63
2018-02-28 12:10:12 +01:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mike Conley
4e9c3d2fe2 Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG

--HG--
extra : rebase_source : b8c9ae40dbdd0f5587d03e8b7c0833bd94032a78
2018-02-11 20:15:11 -05:00
Andreea Pavel
1aac7df383 Backed out 3 changesets (bug 1434376)for failing browser chrome at browser/base/content/test/performance/browser_urlbar_search_reflows.js on a CLOSED TREE
Backed out changeset b636251b75ab (bug 1434376)
Backed out changeset fccbba9cb959 (bug 1434376)
Backed out changeset b5128504011c (bug 1434376)
2018-02-25 12:44:28 +02:00
Mike Conley
96fbfba56f Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG

--HG--
extra : rebase_source : b8c9ae40dbdd0f5587d03e8b7c0833bd94032a78
2018-02-11 20:15:11 -05:00
Cosmin Sabou
43c66219ab Backed out 3 changesets (bug 1434376) for build bustages on SystemTimeConverter.h(177)
Backed out changeset 2ed5aefc5bc2 (bug 1434376)
Backed out changeset 1b474fb6d798 (bug 1434376)
Backed out changeset 4e6a21e50be0 (bug 1434376)
2018-02-23 23:17:42 +02:00
Mike Conley
2b1d67d232 Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG

--HG--
extra : rebase_source : cae6a58d3992b2e587b1fff90954f36c2f81e2ee
2018-02-11 20:15:11 -05:00
Gijs Kruitbosch
3350f8605a Bug 1350349 - collect data for feed reader usage to evaluate its future, r=mak,data-review=liuche
This patch adds data collection for 6 different data points:
- number of live bookmarks the user has
- number of times the user subscribes to a feed
- number of times we attempt to open feed preview
- number of times the user opens a feed popup in the UI
- number of times the user opens an entry from a feed popup in the UI.

MozReview-Commit-ID: DG9JDFXCjai

--HG--
rename : browser/components/feeds/test/valid-feed.xml => browser/components/feeds/test/browser/valid-feed.xml
extra : rebase_source : 9f3df4ca19eec0750092deb9066634a388ec59f7
2018-02-16 19:18:00 +00:00
Paolo Amadini
a623dbe5af Bug 1439358 - Part 6 - Decouple view events from view visibility. r=Gijs
This stops redundant ViewHiding and late ViewShown events from being dispatched when the panel is closed during a ViewShowing event or a transition, and stops dispatching ViewHiding events when a view becomes invisible but is still open.

The panelMultiView property on "panelview" nodes is now set to null when the view is closed, indicating that the view can be immediately reused in a different panel. The Places view had to be updated so it doesn't rely on this property during the PanelMultiViewHidden event.

MozReview-Commit-ID: B1yU6si3eD3

--HG--
extra : rebase_source : 440ddc3eabcbe9d0f02a172f8adf047c66ca53ac
2018-02-22 14:20:11 +00:00
Paolo Amadini
92a511a1a2 Bug 1439358 - Part 3 - Always raise ViewShowing events and don't update the "current" property. r=Gijs
The ViewShowing event is now called earlier and unconditionally, since we don't set the "current" attribute and call showMainView while the panel is closing anymore.

It is already the case that the ViewShowing event handlers don't depend on the "current" property, so we don't need to keep track of it before ViewShown events are dispatched.

MozReview-Commit-ID: Ii4SN03KjwW

--HG--
extra : rebase_source : 5e994fa4d54b2805b5eb10d9471bbb25bd21f24c
2018-02-19 11:17:52 +00:00
Mark Banner
50e5b04547 Bug 1437651 - Remove unused simulated-places-node references. r=mak
MozReview-Commit-ID: 6JzFXRykF2W

--HG--
extra : rebase_source : c7fa0ce9f6c9f0fe611ed49644a02042c9c80a12
2018-02-12 20:33:07 +00:00
Gijs Kruitbosch
a18c8b5531 Bug 1424672 - stop removing the header in the recently closed places views, r=mak,Paolo
MozReview-Commit-ID: J5HlyA8nxe2

--HG--
extra : rebase_source : c153742eb5e5179f5af917a1ad1b73e5c381e06d
2017-12-12 16:20:49 -06:00