Commit graph

34 commits

Author SHA1 Message Date
Ed Lee
acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Marco Bonardo
e02230cbe8 Bug 1616460 - Star panel tree view can move bookmarks even when it's not visible. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D64011

--HG--
extra : moz-landing-system : lando
2020-02-25 14:04:43 +00:00
Siddhant085
676ce0d13c Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753

--HG--
extra : moz-landing-system : lando
2020-01-16 18:38:54 +00:00
shindli
3d28702804 Backed out changeset 1bdfd7c37b02 (bug 1511700) for causing newtab node test failure CLOSED TREE 2020-01-13 22:33:58 +02:00
Siddhant085
d48342d7db Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753

--HG--
extra : moz-landing-system : lando
2020-01-13 16:25:39 +00:00
fluks
686acfc93a Bug 1230453 - Add a hidden preference to change the number of folders in the recent list of the "bookmark this page" popup. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D43679

--HG--
extra : moz-landing-system : lando
2019-10-22 07:57:49 +00:00
Tim Nguyen
8e222cab72 Bug 1586997 - Fix focusing the first input of edit bookmark dialogs. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D48955

--HG--
extra : moz-landing-system : lando
2019-10-11 14:16:42 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Victor Porof
4622859c92 Bug 1523957 - Convert trees to custom elements, r=bgrins, mak, standard8, MattN
***
Bug 1523957 - Part 0: Whitespace changes in tree.js, r=bgrins
***
Bug 1523957 - Part 1.1: Naively convert tree to a custom element, r=bgrins
***
Bug 1523957 - Part 1.2: Properly mixin BaseControl and extend XULTreeElement, r=bgrins
***
Bug 1523957 - Part 1.3: Use Shadow DOM for slotting children, r=bgrins
***
Bug 1523957 - Part 1.4: Properly handle key events in combination with shift modifiers, r=bgrins
***
Bug 1523957 - Part 1.5: Lint for the lint gods in tree.js, r=bgrins, standard8
***
Bug 1523957 - Part 2.1: Naively convert places-tree to a custom element, preserving history, r=bgrins
***
Bug 1523957 - Part 2.2: Lint for the lint gods in places-tree.js, r=bgrins
***
Bug 1523957 - Part 2.3: Fix browser_passwordmgr_editing.js, r=MattN
***
Bug 1523957 - Part 2.4: Fix browser_bookmarksProperties.js, r=bgrins
***
Bug 1523957 - Part 2.5: Make the edit bookmark tree lazily constructed so there aren't any trees left in the browser window markup, r=bgrins
***
Bug 1523957 - Part 2.6: Add eslint globals to places-tree.js, r=bgrins, standard8

--HG--
rename : browser/components/places/content/tree.xml => browser/components/places/content/places-tree.js
2019-02-21 15:39:53 +01:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
James Lee
9cc4a04230 Bug 1507809 - Remove 'ExcludeReadOnlyFolders' option from places' queries r=Standard8
Removed all references to 'ExcludeReadOnlyFolders' since Firefox doesn't
(and will not) support read only folders.

Differential Revision: https://phabricator.services.mozilla.com/D12821

--HG--
extra : moz-landing-system : lando
2018-11-26 13:18:05 +00:00
Marco Bonardo
884faebe39 Bug 1506461 - Enable inline suggestions for bookmark tags autocomplete. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D11773

--HG--
extra : moz-landing-system : lando
2018-11-21 15:10:53 +00:00
Tim Nguyen
0a931bdeff Bug 1502731 - Remove @hudButton@ and @hudButtonPressed@. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D10004

--HG--
extra : moz-landing-system : lando
2018-10-30 19:04:23 +00:00
Marco Bonardo
d77d9c899f Bug 1502655 - Remove remaining frontend livemarks code. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D9992

--HG--
extra : moz-landing-system : lando
2018-10-29 13:18:17 +00:00
Mark Banner
941f724d2f Bug 1494046 - Improve how the folder icon is selected on the folder list in the bookmark popup window. r=mak
Change to using an event listener to follow when the selection changes more accurately. Also switch to using GUIDs as they are better defined than indexes.

Differential Revision: https://phabricator.services.mozilla.com/D7537

--HG--
extra : moz-landing-system : lando
2018-10-23 15:52:22 +00:00
Mark Banner
109bbee514 Bug 1501337 - Fix a leak and uncleared listeners in places code relating to the edit bookmarks views. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D9546

--HG--
extra : moz-landing-system : lando
2018-10-23 17:58:43 +00:00
Doug Thayer
218843ef6a Bug 1426245 - Replace OnItemAdded with bookmark-item-added r=mak
See https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit#
for further info. This essentially follows the same philosophy as
the onVisits migration.

MozReview-Commit-ID: I4bOvFH0ZQR

Depends on D4605

Differential Revision: https://phabricator.services.mozilla.com/D4606

--HG--
extra : moz-landing-system : lando
2018-10-09 14:47:27 +00:00
Brindusan Cristian
10b00a8313 Backed out changeset 2f1229c179d3 (bug 1494046) for browser-chrome failures in browser_bookmark_add_tags.js. CLOSED TREE 2018-10-04 13:07:28 +03:00
Mark Banner
dece7b1fd1 Bug 1494046 - Improve how the folder icon is selected on the folder list in the bookmark popup window. r=mak
Change to using an event listener to follow when the selection changes more accurately. Also switch to using GUIDs as they are better defined than indexes.

Differential Revision: https://phabricator.services.mozilla.com/D7537

--HG--
extra : moz-landing-system : lando
2018-10-04 08:54:25 +00:00
Brendan Dahl
f6923ccc24 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265

--HG--
extra : moz-landing-system : lando
2018-08-25 00:16:27 +00:00
Mark Banner
bf2dba5c9f Bug 1476228 - Enable comma-dangle ESLint rule for Places directories. r=mikedeboer
MozReview-Commit-ID: K8HcZfyF4Sz

Differential Revision: https://phabricator.services.mozilla.com/D3796

--HG--
extra : moz-landing-system : lando
2018-08-22 15:44:43 +00:00
Brian Grinstead
abf1620630 Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw

--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
2018-08-08 15:22:53 -07:00
Marco Bonardo
3489683af3 Bug 1452067 - Move AllTags to an async method in the bookmarking API. r=Standard8
The tagging API is moving to the bookmarking API, this is one step

Differential Revision: https://phabricator.services.mozilla.com/D2316

--HG--
extra : moz-landing-system : lando
2018-07-25 14:04:14 +00:00
Paolo Amadini
da419e0e8e Bug 1472748 - Convert the listbox in "editBookmarkPanel.inc.xul" to "richlistbox". r=mak
This uses the same event handling as the "listbox" and "listitem-checkbox" bindings that are scheduled for removal, and copies the required styles locally.

There is no need to preserve the scroll position explicitly anymore, because "richlistbox" handles scrolling like regular elements, and we don't want to persist the position when the selector is closed and reopened.

MozReview-Commit-ID: 4gYhwlprPN7

--HG--
extra : source : a92f9683c6cdaeb5541b85eb77adf46448716a7b
2018-07-13 15:37:31 +01:00
Mark Banner
5b8ba7f27e Bug 1452645 - Remove load in sidebar functionality. r=lina,mak
Based on patch by mixedpuppy.

MozReview-Commit-ID: BZwOtr4VbCH

--HG--
extra : rebase_source : 2e3ad3fedaf82d0e5d3db9bcebf1c2faa46447e7
2018-06-06 21:00:45 +01:00
Mark Banner
8fd7fd6712 Bug 1469418 - Fix updating the folder name in the bookmarks properties menulist when it changes. r=mak
MozReview-Commit-ID: C1uPLL4SDd7

Differential Revision: https://phabricator.services.mozilla.com/D1701
2018-06-19 22:59:47 +00:00
Mark Banner
332df0f776 Bug 1467807 - Stop supporting passing ids to (places)tree.selectItems and selectLeftPaneContainerByHierarchy. r=mak
MozReview-Commit-ID: 8E1VUKU2Ya2

Differential Revision: https://phabricator.services.mozilla.com/D1594
2018-06-08 16:09:37 +00:00
Mark Banner
ea3dbe0fdd Bug 1460579 - Replace the 'bookmarkPropertiesDialog/folderLastUsed' annotation with a key/value pair in moz_meta. r=mak
MozReview-Commit-ID: GpEPxOMDret

--HG--
extra : rebase_source : ca691591356d12d17c6e51f5fc3b0cd4cfe687da
2018-05-11 07:35:59 +01:00
Mark Banner
9f30e28934 Bug 1463738 - Remove the Bookmark description UI. r=dao
This removes the bookmark description UI, but leaves the backend in-place for a release or two, so that users have time to save anything they want (e.g. via backup).
The backend will be removed in bug 1402890.

MozReview-Commit-ID: La4AYFar7eK

--HG--
extra : rebase_source : 02bfe3cacdac331d09d5e62a1a70f48b68741670
2018-05-23 17:15:09 +01:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Boris Zbarsky
b43b5abed4 Bug 1453345 part 5. Remove pointless JS implemenations of QI to nsIDOMEventListener. r=smaug
MozReview-Commit-ID: Db0v6GZ0deo
2018-04-12 00:03:45 -04:00
Marco Bonardo
d666e0fda1 Bug 1421664 - 3 - Fix the UI and tests. r=standard8
test_419731.js can be removed since it is already covered by browser_bookmarkProperties_editTagContainer.js

MozReview-Commit-ID: K0LFuTptWyW

--HG--
extra : rebase_source : 10066aa0bdb6a598fc6af638fed455d58422b7fb
2018-03-22 14:13:07 +01:00
Brendan Dahl
c52106c442 Bug 1444228 - Remove editBookmarkOverlay.xul. r=standard8
Move the main contents of editBookmarkOverlay.xul into an include file and
inline the DTD and CSS files where used. Convert several chrome tests to
browser tests since the preprocessor is hard to use within the testing
framework.


MozReview-Commit-ID: DpPBOpZSuBN

--HG--
rename : browser/components/places/content/editBookmarkOverlay.js => browser/components/places/content/editBookmark.js
rename : browser/components/places/content/editBookmarkOverlay.xul => browser/components/places/content/editBookmarkPanel.inc.xul
rename : browser/components/places/tests/chrome/test_bug427633_no_newfolder_if_noip.xul => browser/components/places/tests/browser/browser_bug427633_no_newfolder_if_noip.js
rename : browser/components/places/tests/chrome/test_bug485100-change-case-loses-tag.xul => browser/components/places/tests/browser/browser_bug485100-change-case-loses-tag.js
rename : browser/components/places/tests/chrome/test_bug631374_tags_selector_scroll.xul => browser/components/places/tests/browser/browser_bug631374_tags_selector_scroll.js
rename : browser/components/places/tests/chrome/test_editBookmarkOverlay_keywords.xul => browser/components/places/tests/browser/browser_editBookmark_keywords.js
rename : browser/components/places/tests/chrome/test_editBookmarkOverlay_tags_liveUpdate.xul => browser/components/places/tests/browser/browser_editBookmark_tags_liveUpdate.js
rename : browser/themes/linux/places/editBookmarkOverlay.css => browser/themes/linux/places/editBookmark.css
rename : browser/themes/osx/places/editBookmarkOverlay.css => browser/themes/osx/places/editBookmark.css
rename : browser/themes/windows/places/editBookmarkOverlay.css => browser/themes/windows/places/editBookmark.css
extra : rebase_source : aca072691251c1a44e82ab8091796abd2b140e22
2018-03-16 09:26:49 -07:00
Renamed from browser/components/places/content/editBookmarkOverlay.js (Browse further)