Commit graph

2692 commits

Author SHA1 Message Date
Nika Layzell
975ef89398 Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594
2020-04-21 22:33:00 +00:00
Cosmin Sabou
190731f374 Backed out 5 changesets (bug 1625513) for bc failures on browser_identity_UI.js. CLOSED TREE
Backed out changeset 88ac5d853e38 (bug 1625513)
Backed out changeset 8ac6db819435 (bug 1625513)
Backed out changeset cc19c74910d1 (bug 1625513)
Backed out changeset 8c235f0f967c (bug 1625513)
Backed out changeset 24a646225c68 (bug 1625513)
2020-04-22 00:17:08 +03:00
Nika Layzell
8438107f7a Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594
2020-04-21 18:33:39 +00:00
Noemi Erli
c0bd1834c8 Backed out 19 changesets (bug 1602318) for causing multiple failures
Backed out changeset 4b3345b2e33b (bug 1602318)
Backed out changeset 7240b27afe28 (bug 1602318)
Backed out changeset a7091729d8c9 (bug 1602318)
Backed out changeset e496ab6c0857 (bug 1602318)
Backed out changeset 184da6309f0c (bug 1602318)
Backed out changeset 79b540f8619d (bug 1602318)
Backed out changeset b298015ee960 (bug 1602318)
Backed out changeset 6d0783cd5e01 (bug 1602318)
Backed out changeset cbc308486b17 (bug 1602318)
Backed out changeset 94142944fb54 (bug 1602318)
Backed out changeset 7c1eeb299b78 (bug 1602318)
Backed out changeset 0fc27502503a (bug 1602318)
Backed out changeset 0fc27c2e09d9 (bug 1602318)
Backed out changeset b5e2aa4741b2 (bug 1602318)
Backed out changeset 57d568114c5a (bug 1602318)
Backed out changeset 8f7360d827dc (bug 1602318)
Backed out changeset 78930a97c2df (bug 1602318)
Backed out changeset 8015780587cd (bug 1602318)
Backed out changeset bc9da03cb3a3 (bug 1602318)
2020-04-21 03:46:41 +03:00
Matt Woodrow
11a6a14a87 Bug 1602318 - Make some browser tests wait on the test uri to load instead of any uri. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D70624
2020-04-20 23:01:44 +00:00
Noemi Erli
6ce4e6b1e0 Backed out 4 changesets (bug 1625513) for causing assertion in WindowGlobalChild.cpp
Backed out changeset 0366bbc9e0f7 (bug 1625513)
Backed out changeset 3554e0be2e66 (bug 1625513)
Backed out changeset ad09a911bc43 (bug 1625513)
Backed out changeset f2dbff5d584f (bug 1625513)
2020-04-20 22:28:20 +03:00
Nika Layzell
8624c6d38b Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594
2020-04-20 16:57:01 +00:00
Coroiu Cristina
43be71277d Backed out 2 changesets (bug 1625500) for multiple failures on a CLOSED TREE
Backed out changeset 7d80233bcfcd (bug 1625500)
Backed out changeset 0a35b13dfcde (bug 1625500)
2020-04-17 15:36:05 +03:00
Gijs Kruitbosch
cc39a339a0 Bug 1625500 - fix use of .then(x, x) in the tree, r=marionette-reviewers,Standard8,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D68614
2020-04-17 11:41:49 +00:00
Mike Conley
fe91befa60 Bug 1628953 - Re-enable some sessionstore tests for Fission. r=alchen
Differential Revision: https://phabricator.services.mozilla.com/D70474

--HG--
extra : moz-landing-system : lando
2020-04-14 09:14:00 +00:00
Oana Pop Rus
90abf0bc61 Backed out 2 changesets (bug 1625513) for bc failures in browser/base/content/test/siteIdentity/browser_identity_UI.js on a CLOSED TREE
Backed out changeset 876b33334577 (bug 1625513)
Backed out changeset 69f75d37ae8e (bug 1625513)

--HG--
extra : rebase_source : e8752080577e762777eff9cda7a695bfa2ccd4cf
2020-04-09 00:57:32 +03:00
Nika Layzell
e7ed7401ba Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594

--HG--
extra : moz-landing-system : lando
2020-04-08 16:56:37 +00:00
Nika Layzell
7031bc0da0 Bug 1616353 - Part 12: Remove or fix tests which try to set OriginAttributes too late, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D67059

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:57 +00:00
Nika Layzell
98528edbf2 Bug 1616353 - Part 6.2: Remove setOriginAttributesBeforeLoading API, r=smaug
This API is no longer possible to implement, as it will always try to set the
OriginAttributes on a content BrowsingContext after it has been attached, and JS
can never observe a detached BrowsingContext.

Users of this API are instead changed to perform assertions that
originAttributes have already been set correctly.

Differential Revision: https://phabricator.services.mozilla.com/D67046

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:14 +00:00
Mike Conley
42d8fd6275 Bug 1627420 - Ensure we clear userTyped properties when doing a process flip. r=mattwoodrow
This effectively also undoes the change introduced in 3166149f37f1 (bug 1615302),
and makes it so that instead of ignoring the userTyped values, we clear them
out in the parent when doing a process flip before sending them down to
the new child process.

Differential Revision: https://phabricator.services.mozilla.com/D69862

--HG--
extra : moz-landing-system : lando
2020-04-07 01:55:04 +00:00
Cosmin Sabou
3a544c8273 Backed out 2 changesets (bug 1625513) for causing several reftest failures. CLOSED TREE
Backed out changeset 64dfd2e32a7b (bug 1625513)
Backed out changeset a78ae89b25b6 (bug 1625513)

--HG--
extra : amend_source : b2383d74665a38a1fcf6cf0c3b62f6700002055c
extra : histedit_source : c9251ae9cdf46168c15328aa83655e2f93c95b85
2020-04-06 20:11:51 +03:00
Cosmin Sabou
aefb5f9c88 Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp.
Backed out changeset 3a43210e4900 (bug 1616353)
Backed out changeset cb77e9149cf8 (bug 1616353)
Backed out changeset 3aacc7cfe33f (bug 1616353)
Backed out changeset c026b06063a5 (bug 1616353)
Backed out changeset 580e790c5d17 (bug 1616353)
Backed out changeset 6f09bc1c476d (bug 1616353)
Backed out changeset 6955906262c0 (bug 1616353)
Backed out changeset a7700472807a (bug 1616353)
Backed out changeset a4735096e01b (bug 1616353)
Backed out changeset bd1706c57d91 (bug 1616353)
Backed out changeset 363c13296fda (bug 1616353)
Backed out changeset e414df387524 (bug 1616353)
Backed out changeset 765d3364cca0 (bug 1616353)
Backed out changeset 8a13355b4ac4 (bug 1616353)
Backed out changeset ada17fb8fca7 (bug 1616353)
Backed out changeset 6b6b99af186d (bug 1616353)
Backed out changeset ea966e78b296 (bug 1616353)
Backed out changeset cb88e0bbb3b9 (bug 1616353)
Backed out changeset f89a89015114 (bug 1616353)
Backed out changeset ae6058552969 (bug 1616353)
Backed out changeset f42bb5b48c1b (bug 1616353)
Backed out changeset 1ab9d22c73bb (bug 1616353)
Backed out changeset 2692c2c1396b (bug 1616353)
Backed out changeset 11a279c8da08 (bug 1616353)
2020-04-06 20:03:02 +03:00
Nika Layzell
312045489f Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Differential Revision: https://phabricator.services.mozilla.com/D68594

--HG--
extra : moz-landing-system : lando
2020-04-06 15:17:40 +00:00
Nika Layzell
8a55bc1226 Bug 1616353 - Part 12: Remove or fix tests which try to set OriginAttributes too late, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D67059

--HG--
extra : moz-landing-system : lando
2020-04-06 14:30:33 +00:00
Nika Layzell
f0e314fa2a Bug 1616353 - Part 6.2: Remove setOriginAttributesBeforeLoading API, r=smaug
This API is no longer possible to implement, as it will always try to set the
OriginAttributes on a content BrowsingContext after it has been attached, and JS
can never observe a detached BrowsingContext.

Users of this API are instead changed to perform assertions that
originAttributes have already been set correctly.

Differential Revision: https://phabricator.services.mozilla.com/D67046

--HG--
extra : moz-landing-system : lando
2020-04-06 14:29:50 +00:00
Andrea Marchesini
9bea58365a Bug 1624146 - Cookie code refactoring - part 10 - CookieService under mozilla::net, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D67759

--HG--
rename : netwerk/cookie/nsCookieService.cpp => netwerk/cookie/CookieService.cpp
rename : netwerk/cookie/nsCookieService.h => netwerk/cookie/CookieService.h
extra : moz-landing-system : lando
2020-04-06 12:26:14 +00:00
Emma Malysz
e2f8c97e91 Bug 1624511, ensure that tab crashes within the same content process can be restored. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68318

--HG--
extra : moz-landing-system : lando
2020-03-27 15:28:11 +00:00
Alphan Chen
4634499277 Bug 1623934 - Move SessionHistoryListener back to ConteneSessionStore.jsm r=peterv,mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D68354

--HG--
extra : moz-landing-system : lando
2020-03-27 12:34:37 +00:00
Dão Gottwald
0e85250451 Bug 1624294 - Remove underused Utils.hasRootDomain. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D67839

--HG--
extra : moz-landing-system : lando
2020-03-24 15:15:31 +00:00
Mike Conley
ba02ddc1e1 Bug 1618936 - Make the front-end more robust in how it handles content process launch failures. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D67003

--HG--
extra : moz-landing-system : lando
2020-03-20 19:50:20 +00:00
Paul Bone
f883d39f44 Bug 1618445 - pt 3. Move session store logging into SessionStoreInternal r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D65441

--HG--
extra : moz-landing-system : lando
2020-03-20 03:16:12 +00:00
Paul Bone
2be997e3ec Bug 1618445 - pt 2. Move process switch logging to E10SUtils r=mattwoodrow
* Create new logger.
 * Use logger for process switch logging.
 * Remove "[process-switch]: " string from log messages, it is redundant.

This may eventually move to a whole new module if/when process switching
moves there.

Differential Revision: https://phabricator.services.mozilla.com/D65440

--HG--
extra : moz-landing-system : lando
2020-03-20 03:15:54 +00:00
Paul Bone
174c6843ab Bug 1618445 - pt 1. Improve logging in SessionStore.jsm r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D65439

--HG--
extra : moz-landing-system : lando
2020-03-20 03:15:31 +00:00
Matt Woodrow
7cf2c4f018 Bug 1615302 - Don't use userTypedValue as the URL to restore when doing a remoteness update through SessionStore. r=alchen,mconley
Differential Revision: https://phabricator.services.mozilla.com/D66705

--HG--
extra : moz-landing-system : lando
2020-03-19 22:28:54 +00:00
Alphan Chen
cb65e20cb3 Bug 1507287 - Make sessionRestore work with session history living in the parent process. r=peterv,mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D46281

--HG--
extra : moz-landing-system : lando
2020-03-19 14:31:52 +00:00
Narcis Beleuzu
87ef7e0ec7 Backed out 6 changesets (bug 1618445) for leaks at mozilla::dom::Console::CreateInstance
Backed out changeset 0a996e80d92a (bug 1618445)
Backed out changeset 4281c434f737 (bug 1618445)
Backed out changeset 846b67024a9a (bug 1618445)
Backed out changeset 439d0b9ba0fc (bug 1618445)
Backed out changeset 79ae5f86d927 (bug 1618445)
Backed out changeset c09a442d8ddf (bug 1618445)
2020-03-17 11:14:12 +02:00
Paul Bone
065927a4a5 Bug 1618445 - pt 3. Move session store logging into SessionStoreInternal r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D65441

--HG--
extra : moz-landing-system : lando
2020-03-17 04:26:12 +00:00
Paul Bone
7cb945b749 Bug 1618445 - pt 2. Move process switch logging to E10SUtils r=mattwoodrow
* Create new logger.
 * Use logger for process switch logging.
 * Remove "[process-switch]: " string from log messages, it is redundant.

This may eventually move to a whole new module if/when process switching
moves there.

Differential Revision: https://phabricator.services.mozilla.com/D65440

--HG--
extra : moz-landing-system : lando
2020-03-17 04:25:33 +00:00
Paul Bone
4bce55271e Bug 1618445 - pt 1. Improve logging in SessionStore.jsm r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D65439

--HG--
extra : moz-landing-system : lando
2020-03-17 04:24:58 +00:00
Noemi Erli
744bc34135 Backed out changeset 4c6b9209306d (bug 1507287) for causing geckoview failures CLOSED TREE 2020-03-16 23:23:09 +02:00
Alphan Chen
a9d46bba49 Bug 1507287 - Make sessionRestore work with session history living in the parent process. r=peterv,mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D46281

--HG--
extra : moz-landing-system : lando
2020-03-16 18:33:32 +00:00
Ed Lee
acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Boris Zbarsky
cf6ef6a24b Bug 1467437. Align with other browsers and the spec for whether hashchange and popstate events bubble. r=smaug
I think I caught all the places in our tree that add event listeners for these
events on a non-Window (and hence depend on bubbling behavior), but I'm a
little worried about what happens if webextensions do bareword
addEventListener() for these events...

Differential Revision: https://phabricator.services.mozilla.com/D66798

--HG--
extra : moz-landing-system : lando
2020-03-13 17:45:50 +00:00
Mark Banner
2c4e35b0a6 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509

--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Mark Banner
15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Dão Gottwald
1f136fd774 Bug 1610475 - Move URLBarSetURI to UrlbarInput. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D65535

--HG--
rename : browser/components/urlbar/tests/browser/browser_URLBarSetURI.js => browser/components/urlbar/tests/browser/browser_UrlbarInput_setURI.js
extra : moz-landing-system : lando
2020-03-06 16:27:16 +00:00
Marco Bonardo
a8354f1215 Bug 555694 - Address bar should not suggest switching to the current tab. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D65408

--HG--
extra : moz-landing-system : lando
2020-03-05 09:12:44 +00:00
Daniel Varga
8d900cf3ef Backed out changeset e51b4e883adc (bug 1507287) for not having proper review 2020-03-03 18:23:07 +02:00
Alphan Chen
9ead74bd10 Bug 1507287 - Make sessionRestore work with session history living in the parent process. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D46281

--HG--
extra : moz-landing-system : lando
2020-03-03 16:16:03 +00:00
Mike de Boer
929799eef6 Bug 440895 - Add support for Mac OSX spaces in session restore, which allows any window to be restored to their respective (work)space. r=mconley,mstange,nika
Differential Revision: https://phabricator.services.mozilla.com/D61457

--HG--
extra : moz-landing-system : lando
2020-03-02 13:36:39 +00:00
Dan Glastonbury
89e79e2d97 Bug 1616171 - P2: nsILoadInfo::targetBrowsingContext attribute. r=mattwoodrow,nika
This new attribute on nsILoadInfo allows retrieving the BrowsingContext and
BrowsingContextId for the BC of the document to be loaded by an nsILoadInfo.

Differential Revision: https://phabricator.services.mozilla.com/D63127

--HG--
extra : moz-landing-system : lando
2020-02-25 23:17:53 +00:00
Neil Deakin
3ecfb3109d Bug 1598305, replace frame script in test browser_aboutSessionRestore.js with SpecialPowers.spawn, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D61913

--HG--
extra : moz-landing-system : lando
2020-02-19 22:28:37 +00:00
Neil Deakin
8485e07b43 Bug 1598305, replace frame script in test browser_crashedTabs.js with SpecialPowers.spawn, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D61894

--HG--
extra : moz-landing-system : lando
2020-02-20 18:30:58 +00:00
egao
a3a95d7b94 Bug 1613983 - adjust test manifests for linux64 browser-chrome tests on ubuntu 1804, r=jmaher.
Depends on D63435

Differential Revision: https://phabricator.services.mozilla.com/D63436

--HG--
extra : moz-landing-system : lando
2020-02-20 13:50:30 +00:00
Brian Grinstead
3d2d2d0ea7 Bug 1608281 - Automated rewrite away from reading properties on the global this in JSM files - round 1 r=mossop
This patch was generated with a script. It doesn't include all files:

- Files that use the preprocessor or fail to parse are skipped
- Files that are loaded as JSMs but don't use the .jsm extension are skipped (those will be renamed in Bug 1609269)

It was generated with the following command using d855222aa2/no-this-property-read.js:

```
hg revert --all &&
cp .gitignore .rgignore &&
rg --files-without-match -g '*.jsm' '^#endif|^#include|^#filter' | jscodeshift --stdin --transform ~/Code/jsm-rewrites/no-this-property-read.js --ignore-pattern ./mobile/android/modules/Sanitizer.jsm --ignore-pattern ./js/xpconnect/tests/unit/syntax_error.jsm &&
./mach eslint `hg st | rg '^M ' | sed 's/^M //'`
```

Differential Revision: https://phabricator.services.mozilla.com/D60187

--HG--
extra : moz-landing-system : lando
2020-01-29 21:50:04 +00:00