Commit graph

6 commits

Author SHA1 Message Date
Drew Willcoxon
eeeeea2f96 Bug 1618769 - Increase max chars for search suggestions, and don't fetch suggestions at all when max is reached due to paste. r=mak
* Add a new `allowSearchSuggestions` property to the query context. It defaults to true.
* `UrlbarInput` sets this property when it starts a query. If the event that started the query is a paste event and the pasted string's length is larger than maxChars, then don't allow suggestions. Otherwise do.
* `UrlbarProviderSearchSuggestions.isActive` returns false when `!context.allowSearchSuggestions`.
* `UrlbarProviderSearchSuggestions` doesn't truncate the query anymore.
* Keep the `browser.urlbar.maxCharsForSearchSuggestions` pref but use it only for pastes, and increase it from 20 to 100. I considered making a new pref but this way if a user changed it, then it still applies to pastes at least. I'm not sure it's important though.

Differential Revision: https://phabricator.services.mozilla.com/D70956
2020-04-17 00:42:23 +00:00
Ed Lee
acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Mark Banner
1b0a484ab0 Bug 1609937 - Get test_UrlbarQueryContext_restrictSource.js working with the search modern configuration. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D60247

--HG--
extra : moz-landing-system : lando
2020-01-17 17:50:59 +00:00
Marco Bonardo
2664dce2a5 Bug 1599842 - Restrict to a specific search engine from the QueryContext. r=adw
This is the last part needed to be able to restrict results without an explicit
typed token (either restriction or alias). Note this is all preparatory work,
there isn't a design for a feature using this yet, but we know at a certain
point we want a more usable representation of aliases and restriction tokens
and eventually a mode picker UI (search button).

Differential Revision: https://phabricator.services.mozilla.com/D57781

--HG--
extra : moz-landing-system : lando
2019-12-20 09:56:06 +00:00
Marco Bonardo
ed30695cc8 Bug 1603393 - Perma failure in test_UrlbarQueryContext_restrictSource.js when merging to beta. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D56953

--HG--
extra : moz-landing-system : lando
2019-12-13 15:27:56 +00:00
Marco Bonardo
1e94dca2f5 Bug 1599840 - part 2 - Set restricting behavior based on QueryContext sources. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D56354

--HG--
extra : moz-landing-system : lando
2019-12-11 16:52:09 +00:00