Commit graph

14 commits

Author SHA1 Message Date
Marco Bonardo
1cf8ec89c1 Bug 1613276 - Visit data: URIs containing spaces rather than searching them. r=adw
Ignore whitespaces when tokenizing strings looking like data: urls.
Improve the tokenizer to better distinguish possible origins from text, by
using the domains whitelist.
Fix a regexp mistake uncovered by the test.

Differential Revision: https://phabricator.services.mozilla.com/D71791
2020-04-22 09:44:20 +00:00
Marco Bonardo
5a7c296d45 Bug 1630996 - Adjust urlbar tokenizer mail regexp. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D71345
2020-04-17 19:00:25 +00:00
Mark Banner
2c4e35b0a6 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509

--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Marco Bonardo
45b356558e Bug 1583616 - Some numbers are searched and not autofilled. r=Standard8
The tokenizer currently thinks large numbers are "broken" IPs, thus it says they
can't be an origin. Unfortunately we use that same code path to identify possible
origin prefixes, and origins can start with a number. Thus we end up searching
rather than autofilling the origin.

For now fix the heuristic for IPs, in the future we may evaluate splitting these
code paths.

Differential Revision: https://phabricator.services.mozilla.com/D48187

--HG--
extra : moz-landing-system : lando
2019-10-07 14:16:02 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Drew Willcoxon
aa16935357 Bug 1545916 - Make quantumbar match highlighting case insensitive. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D28751

--HG--
extra : moz-landing-system : lando
2019-04-25 18:12:06 +00:00
Marco Bonardo
06d433199e Bug 1541399 - Ensure we don't fetch search suggestions for file urls. r=adw
Fixes the tokenizer to recognize file:/// urls, plus adds a second layer of
protection, so that if URI fixup thinks the typed string may be an url, we don't
fetch suggestions for it.

Differential Revision: https://phabricator.services.mozilla.com/D26282

--HG--
extra : moz-landing-system : lando
2019-04-08 23:50:21 +00:00
Marco Bonardo
20e5ae9990 Bug 1538050 - Split restriction characters only if they are at the beginning or end of the search string. r=adw
The new tokenizer, to make more natural typing restrictions like "?search terms", "search terms?" or "%my tab",
splits out restriction characters if they appear at the beginning or end of the search string. This means
keywords and aliases can't in general begin or end with a restriction character, but we don't have an input
check to prevent those.
For now the tokenizer can't recognize keywords or aliases, because it can't be made asynchronous until the
Quantum Bar is the default implementation, and anyway the complexity must be considered at that point.

The best we can do is to stop splitting out restriction character in the middle of the search string.
This will allow a part of the old interaction like searching for "keyword? something".

This patch also prevents us from splitting a %encoded string, fixing bug 1538715.

Differential Revision: https://phabricator.services.mozilla.com/D24929

--HG--
extra : moz-landing-system : lando
2019-03-27 10:40:54 +00:00
Marco Bonardo
a5fe67550e Bug 1521366 - Searching for a space in the Quantum Bar causes an infinite loop. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D19979

--HG--
extra : moz-landing-system : lando
2019-02-15 20:55:30 +00:00
Marco Bonardo
de59370b24 Bug 1514780 - Use the Quantum Bar tokenizer in UnifiedComplete. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D16676

--HG--
extra : moz-landing-system : lando
2019-01-17 11:26:29 +00:00
Marco Bonardo
134e4ec293 Bug 1499743 - Address Bar restriction characters: remove typed, change url and search r=adw
Remove the "~" typed restriction character.
Change the url restriction character to "$" and the search one to "?".

Differential Revision: https://phabricator.services.mozilla.com/D9494

--HG--
extra : moz-landing-system : lando
2018-10-24 12:49:00 +00:00
Marco Bonardo
8f1401cf22 Bug 1478582 - Bug 14785825 - Move address bar model tokenization to a module. r=adw
This is a first stab at the new tokenizer.
It's not expected to be perfect yet, but good enough to be modified and replace the existing code in unifiedComplete with just a few modifications.
It's mostly intended to start setting up a code and tests structure.

Differential Revision: https://phabricator.services.mozilla.com/D2838

--HG--
extra : moz-landing-system : lando
2018-09-06 15:12:10 +00:00
Coroiu Cristina
ee08c248cc Backed out changeset c291d6d95022 (bug 1478582) for browser-chome failures at browser/base/content/test/static/browser_all_files_referenced.js 2018-09-06 17:26:22 +03:00
Marco Bonardo
7d48aaf18e Bug 1478582 - Bug 14785825 - Move address bar model tokenization to a module. r=adw
This is a first stab at the new tokenizer.
It's not expected to be perfect yet, but good enough to be modified and replace the existing code in unifiedComplete with just a few modifications.
It's mostly intended to start setting up a code and tests structure.

Differential Revision: https://phabricator.services.mozilla.com/D2838

--HG--
extra : moz-landing-system : lando
2018-09-05 23:38:17 +00:00