Commit graph

189 commits

Author SHA1 Message Date
Mike de Boer
7c75a303b6 Bug 1378790 - Remove keyboard navigation event listeners when a photonpanelmultiview instance is destroyed. r=Gijs
MozReview-Commit-ID: JcAUwLClq7M

--HG--
extra : rebase_source : 004bfd1962f52e910226fb3ff2a4ad83eb93e425
2017-07-06 16:30:07 +02:00
Paolo Amadini
ef0d210719 Bug 1377793 - Fix scrolling in the non-Photon main menu. r=Gijs
MozReview-Commit-ID: 88IsXDvYjyK

--HG--
extra : rebase_source : 4601c2ba6f848ceeeac5db26cfe6621bf7e15a6e
2017-07-05 16:28:58 +01:00
Gijs Kruitbosch
dbd7fca428 Bug 1369729 - use descriptionheightworkaround for sync panel, r=mconley,Paolo
MozReview-Commit-ID: LQg6NEgCqz2

--HG--
extra : rebase_source : a039936a4c8e416c16171cacf73dab781d77ab50
2017-06-28 17:50:43 +01:00
Mike de Boer
b4756f63f5 Bug 1354159 - Part 2 - Introduce a new Places view type, PlacesPanelview, which can visualize query results inside panelview nodes. r=Gijs,mak
MozReview-Commit-ID: Ft1RC7dsqKD

--HG--
extra : rebase_source : e9448ee073b5341efc63496ae6504a764ee43f30
2017-06-29 17:57:24 -07:00
Carsten "Tomcat" Book
2a387535b8 Backed out changeset a6d7647024de (bug 1369729) for reflow issues 2017-06-23 15:48:54 +02:00
Gijs Kruitbosch
70c55f0619 Bug 1369729 - use descriptionheightworkaround for sync panel, r=Paolo
MozReview-Commit-ID: LQg6NEgCqz2

--HG--
extra : rebase_source : ebc990e44e7025e90a0a0415df6ce102ba4ba8f0
2017-06-19 16:06:01 +01:00
Sebastian Hengst
7648740589 Backed out changeset c0772946156f (bug 1369729) for failing browser-chrome's browser_appmenu_reflows.js with unexpected uninterruptible reflow. r=backout 2017-06-23 12:53:23 +02:00
Gijs Kruitbosch
28f0bb0532 Bug 1369729 - use descriptionheightworkaround for sync panel, r=Paolo
MozReview-Commit-ID: LQg6NEgCqz2

--HG--
extra : rebase_source : bfe13f52ec729a24ac53854b67d4613fd47b52bb
2017-06-19 16:06:01 +01:00
Mike de Boer
f7e1f14006 Bug 1370580 - Part 1 - Ensure that the overflow rules are set the exact same way for the temporary panel as for the appMenu panel. r=Gijs
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.

MozReview-Commit-ID: 45aYzVHwRYv

--HG--
extra : rebase_source : 0bf4fc4effc9de9e431ee50dfcf5fc7206e252cf
2017-06-16 15:41:57 +02:00
Sebastian Hengst
be35e9d97b Backed out changeset af176d040fad (bug 1370580) for frequently failing browser_ext_sidebarAction.js on Linux debug. r=backout a=backout
MozReview-Commit-ID: AwnMjAQTdmC
2017-06-17 23:18:55 +02:00
Mike de Boer
5df9078641 Bug 1370580 - Part 1 - Ensure that the overflow rules are set the exact same way for the temporary panel as for the appMenu panel. r=Gijs
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.

MozReview-Commit-ID: 45aYzVHwRYv

--HG--
extra : rebase_source : 0bf4fc4effc9de9e431ee50dfcf5fc7206e252cf
2017-06-16 15:41:57 +02:00
Sebastian Hengst
a4809151b2 Backed out changeset d6be7dc56cc5 (bug 1370580) for failing test-oop-extensions/browser_ext_browserAction_popup_resize.js. r=backout 2017-06-15 19:24:39 +02:00
Mike de Boer
5704197fbf Bug 1370580 - Part 1 - Ensure that the overflow rules are set the exact same way for the temporary panel as for the appMenu panel. r=Gijs
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.

MozReview-Commit-ID: 45aYzVHwRYv

--HG--
extra : rebase_source : f142e3dbba0d70effe129dad43f139e494070d82
2017-06-15 12:49:18 +02:00
Mike de Boer
386ed7219e Bug 1369095 - calculate the size of the panel to be shown off-screen to work around all the panel layout issues. r=Paolo
MozReview-Commit-ID: ENxCccxcUZk

--HG--
extra : rebase_source : bff74375471ccce984caa2bbb7d3ab9ffe3e1fca
2017-06-13 14:06:35 +02:00
Wes Kocher
6dbc3e8839 Backed out changeset 9933f2d4d188 (bug 1369095) for timeouts in browser_page_action_menu.js a=backout CLOSED TREE
MozReview-Commit-ID: CErzYNn287D
2017-06-09 09:19:45 -07:00
Mike de Boer
3e8fc24e90 Bug 1369095 - calculate the size of the panel to be shown off-screen to work around all the panel layout issues. r=Paolo
MozReview-Commit-ID: ENxCccxcUZk

--HG--
extra : rebase_source : 3d95b5e816e3a385b2f126634d4365743522ac3e
2017-06-09 15:52:18 +02:00
Carsten "Tomcat" Book
247a47fac9 Merge mozilla-central to mozilla-inbound 2017-06-08 15:16:36 +02:00
Gijs Kruitbosch
635be35297 Bug 1369564 - fix min-width issues with panels, r=mikedeboer
MozReview-Commit-ID: 3h5hCvcJbTc

--HG--
extra : rebase_source : 05eb487b4e069eb6b57a0e21fdaea1995c9c3e09
2017-06-06 16:12:40 +01:00
Mike de Boer
221a21cbd3 Bug 1367970 - when switching panels quickly, the auto-resize workaround can cause wonky animations. Clear the timeout when a new animation starts. r=Gijs
MozReview-Commit-ID: CpQFjDDm2BR

--HG--
extra : rebase_source : 971fe451fc50ddde02842dfef38c1e8908c05620
2017-06-06 18:18:42 +02:00
Mike de Boer
aaabd56ab2 Bug 1369339 - make sure to flush layout when necessary for the description height workaround in panelviews. r=Paolo
This caused regressions in various panels, like the Identity panel, resulting in
cut-off descriptions and labels. Our first concern is correctness, then we try
performance.

MozReview-Commit-ID: GH7BZ9waXeW

--HG--
extra : rebase_source : 82feb289936d99939ee664cf7b2aff32c1039b85
2017-06-07 12:42:05 +02:00
Gijs Kruitbosch
f4827a11b6 Bug 1369407 - make showMainView only switch views if the main view isn't current, dispatch ViewHiding, and fix view child assumptions, r=mikedeboer
MozReview-Commit-ID: JWKr8pBd58m

--HG--
extra : rebase_source : 5c7fe081b914be2274bbf83799cfa15f43144a9a
2017-06-02 11:13:33 +01:00
Paolo Amadini
688babc889 Bug 1367776 - Calculate the maximum height of panelmultiview before the panel is displayed. r=Gijs
This allows the panel to open correctly when scrollable views like History are displayed as the main view, for example when the History button is moved to the toolbar.

MozReview-Commit-ID: ELSbC0RpuaK

--HG--
extra : rebase_source : c1de4919c524c63f9ffdcda8576308fce223cad3
extra : amend_source : 5af3fe6044e23ccf4302cc2a8099afbd22fd1672
2017-06-01 15:49:35 +01:00
Gijs Kruitbosch
97ff0dc3a1 Bug 1354155 - use photon panelmultiview for individual subviews, r=mikedeboer
MozReview-Commit-ID: 9iEHcGDLbJt

--HG--
extra : rebase_source : f4fca8bac9565ea75c3f528ffd85c702935ce86f
2017-05-30 16:30:25 +01:00
Mike de Boer
38aba49f90 Bug 1364738 - Fix up multi-line labels inside panelviews that have wrapped around and align elements in the banner. r=Gijs,Paolo
I updated, extended and refined Paolo's descriptionHeightWorkaround method to
support multi-line toolbar button labels.
Made the app menu use that method to ensure no scrollbars appear.
Also updated the styling of the banner to have icon and label align correctly
with those of the other buttons inside the panelview.

MozReview-Commit-ID: IzbahG0kyTu

--HG--
extra : rebase_source : 8a6c4e5ac7b1c0d30f53b732730629b5d8ca7166
2017-05-30 14:21:59 +02:00
Mike de Boer
34074f18c2 Bug 1366205 - add a browser mochitest with full coverage of the new menu panel keyboard navigation feature. r=Gijs
This also fixes two issues I found whilst writing the tests:
1. Exclude hidden items from the set of navigable buttons and
2. Exclude disabled items from the set of navigable buttons whilst navigating,
because they may get disabled in the meantime (like with the edit controls).

MozReview-Commit-ID: 5WThVoTZjbV

--HG--
extra : rebase_source : e0bd85192e7b1043ecf04b7d9d3b546aadb004c9
2017-05-26 13:44:55 +02:00
Paolo Amadini
33ebc4466d Bug 1009116 - Redo resizing architecture of panelmultiview. r=Gijs
The height of the "panelmultiview" binding is now determined by the stack layout code, and doesn't have to be calculated manually via JavaScript anymore. This allows the removal of mutation and overflow observers, and reduces the number of synchronous layouts being made.

There is still a workaround included for wrapping blocks not being taken into account in height calculations.

MozReview-Commit-ID: 9rrPU5O5hUx

--HG--
extra : rebase_source : b872c14a553c4293ac476d5d22c634a5a0f6cb24
extra : intermediate-source : bf96469b6ea7daee29eb75a60d11f017a1c86a64
extra : source : 719bb4e7286fbd3baf32061929e4b7d9f953c671
2017-05-23 17:08:01 +01:00
Mike de Boer
870e1626b0 Bug 1365647 - Make sure that the panel height never shrinks below the height of the main view in panelviews, like the main menu. r=Gijs
MozReview-Commit-ID: EhjDg3Sci1y

--HG--
extra : rebase_source : bf943bbab5b8d77e73c4957dfe9cb87c64ad5659
2017-05-23 12:07:50 +02:00
Mike de Boer
af01a5fa65 Bug 1354144 - add support for keyboard navigation inside panel views. r=Gijs
MozReview-Commit-ID: GVMyXroGmAn

--HG--
extra : rebase_source : 146eae8a189b2536d2d3774466e2252315e3f1a1
2017-05-22 12:53:43 +02:00
Mike de Boer
29b1cec867 Bug 1364672 - take the padding of the views into account when calculating the height of each sub view. r=Gijs
It's ok to cache the padding size of the main view and re-use it in this case,
because the padding is maintained for each view consistently.
The performance characteristics are therefore maintained.

MozReview-Commit-ID: GYT59NIiBET

--HG--
extra : rebase_source : 5bf7962367f1ff48f4e61a20535a4fbda82f419e
2017-05-17 18:05:58 +02:00
Mike de Boer
1b6021c0de Bug 1363753 - Add an option for panelmultiviews to keep the width of the mainView synchronized across all other subviews. r=Gijs
MozReview-Commit-ID: ALgU1xWydWB

--HG--
extra : rebase_source : 2825b93ec67b4d841df39ef0a61a9de429ceac9d
2017-05-15 15:02:32 +02:00
Florian Quèze
1d0e28a791 Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Quèze
2e2f358aa9 Bug 1353542 - pre-script hand-written cleanup patch, r=Mossop. 2017-05-12 14:41:20 +02:00
Mike de Boer
9c6cf33558 Bug 1354127 - Add a 'More' toolbar button to the Photon app menu. r=Gijs
This also improves the styling of checkbox buttons inside the menu and improves
support for adopting panelviews into the app menu from another area properly.

MozReview-Commit-ID: 1I9CeBx3zrz

--HG--
extra : rebase_source : 2db487c3e8fb56bca20f8bf51367b724c677b10f
2017-05-11 16:23:16 -04:00
Mike de Boer
62d93fdf1a Bug 1353360 - implement Photon design spec for panel menus. r=Gijs
MozReview-Commit-ID: BPMkiiP31BP

--HG--
extra : rebase_source : b36c5580f11f0d3ad6f4451eb2e2d60cb792e053
2017-05-10 17:29:36 -04:00
Mike de Boer
9dae7f8028 Bug 1354141 - Introduce a new binding for Photon panels that allows for more granular control in behavior and to fork the styles entirely. r=Gijs
MozReview-Commit-ID: CDzn5r0YmYO

--HG--
extra : rebase_source : 45a7bd3d75b23af7c8e9ea812a0e66870902eaef
2017-05-10 16:05:05 -04:00
Sebastian Hengst
8c67cb83ed Backed out changeset 3e704f6d9476 (bug 1354141) for failing mochitest browser_ext_browserAction_popup_resize.js. r=backout on a CLOSED TREE 2017-05-10 19:34:14 +02:00
Mike de Boer
ca1311454d Bug 1354141 - Introduce a new binding for Photon panels that allows for more granular control in behavior and to fork the styles entirely. r=Gijs
MozReview-Commit-ID: CDzn5r0YmYO

--HG--
extra : rebase_source : 85496d5acc4303a2076210c470b670f36869dc83
2017-05-10 11:06:06 -04:00
Mike de Boer
b15749b719 Bug 1363178 - Move the panelmultiview JS implementation to a separate module. r=Gijs
MozReview-Commit-ID: 92GCeTOp2cP

--HG--
rename : browser/components/customizableui/content/panelUI.xml => browser/components/customizableui/PanelMultiView.jsm
extra : rebase_source : a7ce301d6a3bbec13cc29ee618e06cf3864e499e
2017-05-08 16:42:16 -04:00