Commit graph

647 commits

Author SHA1 Message Date
Oriol Brufau
91cda569e3 Bug 1452970 - Add auto-hide option to Download toolbar icon context menu r=Gijs
MozReview-Commit-ID: VVPQesdzJ6

--HG--
extra : rebase_source : 4e53ac52adcfd2862a73ba875b59690027b13da0
2018-04-14 11:26:03 +02:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Kris Maglione
a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Mike de Boer
ecf63670d4 Bug 1034036 - Part 2: Rename and shorten getMostRecentBrowserWindow to getTopWindow and modernize the style used in BrowserWindowTracker.jsm. r=dao
MozReview-Commit-ID: EvgAhq4uR3a

--HG--
extra : rebase_source : 8fd8040cd1eee94675d4e9ca0c8ccc60db9e1bf7
2018-04-11 12:05:59 +02:00
Mike de Boer
d16ee58ded Bug 1034036 - Part 1: Merge RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm into one module called 'BrowserWindowTracker.jsm'. r=dao
MozReview-Commit-ID: 9qzq1aGvjDu

--HG--
rename : browser/modules/UpdateTopLevelContentWindowIDHelper.jsm => browser/modules/BrowserWindowTracker.jsm
extra : rebase_source : 9c4a728e13fd691d377e7f221c5632646115daca
2018-04-11 12:05:56 +02:00
Florian Quèze
22cb324da8 Bug 854464 - round the percentComplete value of the download indicator before setting it to set it at most 100 times, r=paolo. 2018-04-16 14:27:13 +02:00
Marco Castelluccio
dbeabc37e3 Bug 1423667 - Reenable some tests that were disabled because of a Clang update. r=jmaher
--HG--
extra : rebase_source : 1ace11df58e858905e9d53c32d9cf8e1f75046d4
2018-04-05 09:20:47 +01:00
Brendan Dahl
9f9ae1e187 Bug 1443971 - Remove allDownloadsViewOverlay.xul. r=Paolo
This overlay was used in two places: places.xul and
contentAreaDownloadsView.xul. Move the commandset, menuppop and
downloadsRichListBox into include files. Inline the scripts and
DTDs.

MozReview-Commit-ID: LroiQlRTE2T

--HG--
rename : browser/components/downloads/content/allDownloadsViewOverlay.js => browser/components/downloads/content/allDownloadsView.js
rename : browser/components/downloads/content/allDownloadsViewOverlay.xul => browser/components/downloads/content/downloadsCommands.inc.xul
rename : browser/components/downloads/content/allDownloadsViewOverlay.xul => browser/components/downloads/content/downloadsContextMenu.inc.xul
rename : browser/components/downloads/content/allDownloadsViewOverlay.xul => browser/components/downloads/content/downloadsRichListBox.inc.xul
rename : browser/themes/linux/downloads/allDownloadsViewOverlay.css => browser/themes/linux/downloads/allDownloadsView.css
rename : browser/themes/osx/downloads/allDownloadsViewOverlay.css => browser/themes/osx/downloads/allDownloadsView.css
rename : browser/themes/shared/downloads/allDownloadsViewOverlay.inc.css => browser/themes/shared/downloads/allDownloadsView.inc.css
rename : browser/themes/windows/downloads/allDownloadsViewOverlay.css => browser/themes/windows/downloads/allDownloadsView.css
extra : rebase_source : 978d2ddd1e177374b0fc354ca46f11bfc447fe59
2018-03-19 16:21:50 -07:00
Ursula Sarracini
8189974edc Bug 1448143 - Factor out a size getter from DownloadsViewUI.jsm so other consumers can access it r=Mardak
MozReview-Commit-ID: EgyfXz1ntys

--HG--
extra : rebase_source : 8a2fcdd366764a6cf0d51a14d7df2f70fb1a3af0
2018-03-23 14:21:48 -04:00
Michael Webster
1a8239407b Bug 1418749 - Add a TaskbarProgress implementation for gtk3/x11. r=paolo,karlt
This adds support for download progress reporting via the XApp
method currently used in the Cinnamon desktop, by establishing a new
X11 window property to be supported/read by the window manager.

See https://github.com/linuxmint/xapps/blob/master/libxapp/xapp-gtk-window.c,
as well as https://github.com/linuxmint/muffin/commit/39045da0ea06f
for more details.

The property-setting code lives in nsWindow - it's a small and stable
enough chunk that it made more sense to do this than actually depend on
another external library.  As nsWindow is already using x11 calls, this
seemed the safest place for it, without affecting the build.

The TaskbarProgress instance is initialized via the DownloadsTaskbar
js module, and is handed a pointer to the current main window to call
SetProgress on.  Most of the javascript side of this is in line with
how the other platforms are handled.

Without a supporting window manager/desktop environment (currently just
Cinnamon/Muffin 3.6,) the simplest way to observe working behavior is
by calling 'xprop -spy' on the browser window being testing and watching
for updates during a download.

--HG--
extra : rebase_source : 0606f6c87116204ec290c19276072d0c1c35691e
2018-03-08 18:43:00 +02:00
Mark Banner
a32bc883e7 Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
MozReview-Commit-ID: ERT1Fili25d

--HG--
extra : rebase_source : c62ad4e97fc5da7c59cbb03ba08928f7bbe5be6b
2018-03-01 20:06:06 +00:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Sebastian Hengst
769222fadf merge mozilla-inbound to mozilla-central. a=merge
--HG--
rename : browser/base/content/tabbrowser.xml => browser/base/content/tabbrowser.js
2018-02-28 12:54:12 +02:00
Tooru Fujisawa
9a32a77bc1 Bug 1435910 - Part 0.2: Add BrowserTestUtils.{promiseAlertDialogOpen,promiseAlertDialog}. r=Gijs 2018-02-28 10:36:42 +09:00
Brendan Dahl
f4384d768c Bug 1439766 - Replace editMenuOverlay.xul by inlining and preprocessing. r=Gijs
The overlay elements with children of editMenuOverlay.xul are moved into
include files (editMenuCommands.inc.xul and editMenuKeys.inc.xul). For
the other single elements in the overlay, the attributes are inlined
wherever they are used.

MozReview-Commit-ID: 792cuzUvQxT

--HG--
extra : rebase_source : 58e4c05bde16cee873d37c6198de102d048499c2
2018-02-22 15:48:24 -08:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Ciure Andrei
befcb6cb4f Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-02-23 02:06:26 +02:00
Paolo Amadini
f37e407659 Bug 1439358 - Part 2 - Don't use the "current" property when restoring focus from the blocked downloads subview. r=Gijs
MozReview-Commit-ID: ASmmdQMctr5

--HG--
extra : rebase_source : 7d990c407e63e6c5a2db3c644e84da7f243e9909
2018-02-22 12:20:53 +00:00
Brendan Dahl
aa526601d4 Bug 1434077 - Inline indicators overlay. r=Paolo
This is part of the work to remove XUL overlays. The overlay was originally
created to help startup performance, but inlining the overlay seems to
no longer have detrimental effects to performance and is more straightforward.

MozReview-Commit-ID: 7sfVel6qvgv

--HG--
extra : rebase_source : b6311cf1fb98851b4f4203c314ae9ecc8160d766
2018-02-14 12:20:58 -08:00
Brendan Dahl
bd38c4bf4c Bug 1434077 - Inline downloads overlay. r=Paolo
This is part of the work to remove XUL overlays. The overlay was originally
created to help startup performance, but using a hidden panel instead seems to
have no detrimental effects to performance and is more straightforward.

MozReview-Commit-ID: JlWcZEhPXyH

--HG--
rename : browser/components/downloads/content/downloadsOverlay.xul => browser/components/downloads/content/downloadsPanel.inc.xul
extra : rebase_source : 60a9fec344b1e346594015cd36947fe1779257a7
2018-02-06 15:55:50 -08:00
Boris Zbarsky
fce30e834b Bug 1436508 part 10. Remove use of nsIDOMKeyEvent in JS. r=masayuki
MozReview-Commit-ID: GGciORX62Yh
2018-02-09 11:17:09 -05:00
Paolo Amadini
d59df3cdd5 Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs
MozReview-Commit-ID: 3VzoxJ3Ociy

--HG--
extra : source : 22c83b1d417d7c7bd21a71109f4800f5d37bbb77
extra : intermediate-source : 6de7133c267288a468804f67f91df68b10b9793e
2018-02-06 09:02:27 +00:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Paolo Amadini
d5882582e3 Bug 1424469 - The Downloads view in the Library window doesn't get focus when opened. r=mak
We have to keep track of the focused element while we remove the richlistbox element temporarily.

MozReview-Commit-ID: AePydUyyUS7

--HG--
extra : rebase_source : 1dbab87a07a4d95780e0abf29efec94ea73344cf
extra : amend_source : 6e685a648e0ba674eba791e1dc7138f67bd7f1e0
2018-01-30 14:38:25 +00:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Paolo Amadini
1714b3aba4 Bug 1425736 - Don't show the attention badge for download failures on the application menu button. r=Gijs
MozReview-Commit-ID: A882hXl5o0

--HG--
extra : rebase_source : 1584f1141c3e8bc1aeb62559a7136dc9f0745899
2018-01-09 15:51:19 +00:00
Ryan VanderMeulen
d945b2a059 Bug 1423667 - Disable some tests that fail on Windows Code Coverage builds with clang-cl r317840. rs=marco
--HG--
extra : histedit_source : d2f4b4d59301469c4cabb7198f0f98c5247eab84
2017-12-06 20:40:46 -05:00
Paolo Amadini
fc2d7ac38d Bug 1419005 - Remove the "download-toolbarbutton" binding. r=mak
MozReview-Commit-ID: Al6jXNz4jjM

--HG--
extra : rebase_source : 96db291791a9181bcf4a0094a49ae70558ac992b
2017-11-20 14:20:29 +00:00
Paolo Amadini
fc23659e93 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt

--HG--
extra : rebase_source : a94e212e8af35b77806d1d62e020a511ab62e224
2017-11-21 14:21:32 +00:00
Paolo Amadini
5bf848634e Bug 1414244 - Part 5 - Remove the "panel-mainview" container. r=Gijs
MozReview-Commit-ID: 3NDGiy3Mwtq

--HG--
extra : rebase_source : 9c46b5dd69df05ff7688eae2e6b4aabaca4e2d8d
2017-11-11 22:56:15 +00:00
Mark Banner
42cb2dc6a3 Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop
MozReview-Commit-ID: 9m9iss3jUJJ

--HG--
extra : rebase_source : e6a6f9dec168ab1d0e0343236db65f3dd1b44aeb
2017-10-11 15:43:51 +01:00
Erica Wright
ca7e87e24c Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE

--HG--
extra : rebase_source : 9f6eeffb105baf8fe54c509369c6b5eadc88c598
2017-09-13 15:49:32 -04:00
Phil Ringnalda
dcda41b943 Backed out changeset 5b9d2ebcf44e (bug 1033395) for failures in browser_overflow_anchor.js
MozReview-Commit-ID: LfhmJLydnaF
2017-10-16 22:01:54 -07:00
Erica Wright
d29984c27b Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE

--HG--
extra : rebase_source : 6e2d645505f154ae556827032af2e51f32657484
2017-09-13 15:49:32 -04:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Erica Wright
7e91455352 Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs
MozReview-Commit-ID: 5PxydbSfhpz

--HG--
extra : rebase_source : 3941fa6edb5e8eb0d14d6d04ad5b0d63ef1a5b84
2017-09-18 16:15:24 -04:00
Mike de Boer
934012625c Bug 1398346 - Follow up patch to correct one of the selectors to be more precise and avoid potential issues. rs=Paolo
MozReview-Commit-ID: 4nZ16XB7xQA
2017-09-29 15:54:14 +02:00
Mike de Boer
5f1c377014 Bug 1398346 - Hide the 'Open File' status label for failed downloads and/ or downloads where the file went missing for items in the Downloads subview in the Library panel. r=Paolo
MozReview-Commit-ID: 1j9tkqydyVZ

--HG--
extra : rebase_source : 6beaf5ce90095c784341780340450ff32daf4d9c
2017-09-29 14:18:10 +02:00
Mike de Boer
4b693cc30d Bug 1395615 - Implement the "file moved or missing" check for download items in the Library Downloads subview. r=Paolo
MozReview-Commit-ID: 62VJbzJwxVW

--HG--
extra : rebase_source : 8a33f8c14ebf892363da8edd8aca8565beca920d
2017-09-26 17:55:18 +02:00
Mike de Boer
f4a0fc828d Bug 1401930 - Correct query selectors in DownloadsSubview code. r=Paolo
MozReview-Commit-ID: FDl7k7QkMv2

--HG--
extra : rebase_source : d4f875f789b7c5dc3777baa44d8bb685aa9a5f15
2017-09-21 14:01:37 +02:00
Mike de Boer
a4b9e1a983 Bug 1398106 - Check the disabled state for each menuitem in the context menu for a Download in the Library subview. r=Paolo
The 'cmd_delete' command was clashing with another controller which keeps
disabling the menuitem, so it's been renamed to 'downloadsCmd_delete' instead.

MozReview-Commit-ID: IiWEVMt0dfW

--HG--
extra : rebase_source : 4ac0e2c72d83cd799d4bf78bdf5253e81e97bbf5
2017-09-21 13:49:34 +02:00
Boris Zbarsky
624fdefa57 Bug 1400898 part 1. Remove the one script use of nsIDOMChromeWindow. r=farre
MozReview-Commit-ID: I31eceiJP55
2017-09-19 10:13:22 -04:00
Blake Winton
ab01ad862f Bug 1388167 - Unify doorhanger footer styles. ui-r=abenson r=johannh
MozReview-Commit-ID: GGd9sHa2Ga0

--HG--
extra : rebase_source : 9a4dc328c9b81b30743f37aca25d0ec85cab532c
2017-08-21 15:49:32 -04:00
Gijs Kruitbosch
e931ee1884 Bug 1399490 - fix unhiding the downloads button in customize mode if it was moved to the palette, r=nhnt11
MozReview-Commit-ID: 7Q8yPzBVxim

--HG--
extra : rebase_source : 865ec5357bcadabb12d7f08692cd4995b9914fc6
2017-09-13 16:24:13 +01:00
Gijs Kruitbosch
c3acd03b82 Bug 1397447 - add UI and automatic toggles to make the auto-hide functionality more seamless, r=mak
MozReview-Commit-ID: 9xN3N4aLwfv

--HG--
extra : rebase_source : 54333982cce1dcb7cb84331734f170d4d79fbc29
2017-09-11 18:54:48 +01:00
Gijs Kruitbosch
ecf2be01ab Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : 11dc3f1b98f53f5897a3185253b68d2cf7d5083b
extra : source : 97f7f5175b2fc3adfb193783f7ecb70b5b9b4562
2017-09-08 14:16:36 +01:00
Zibi Braniecki
70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
2017-09-09 22:17:19 -07:00
Sebastian Hengst
a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
923420c64a Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 9aeed150b6106210bbe06e8a98ae602e5471851b
2017-09-09 22:17:19 -07:00
Sebastian Hengst
8eb249afcc merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Paolo Amadini
fe96089fe4 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs
MozReview-Commit-ID: Tq8YrZWG6P

--HG--
extra : rebase_source : 2e02e0a809d08ff26291a027b73a54668d6d5f9d
2017-09-06 13:09:27 +01:00
Zibi Braniecki
0e1ced7d71 Bug 1395871 - Open toolbar menus on mousedown, rather than oncommand.
MozReview-Commit-ID: A3P4QBBgcB8

--HG--
extra : rebase_source : 2a1b660f6489c5aece8f8b25935ad5799779629d
2017-09-01 01:54:34 -07:00
Mike de Boer
d9febd9d56 Bug 1354532 - Part 2 - To facilitate the DownloadsSubview, add a 'LimitedHistoryDownloadsData' and 'LimitedPrivateHistoryDownloadData' dataview. r=Paolo
MozReview-Commit-ID: Jkyj2SQ7F00

--HG--
extra : rebase_source : 00650aacdab727e612648127cb5a0d5ce995b662
2017-09-06 17:16:02 +02:00
Mike de Boer
0fcde6db9c Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Sebastian Hengst
c3dc29271d Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Sebastian Hengst
f807d2849c Backed out changeset 63909748b3ce (bug 1354532) 2017-09-06 16:47:12 +02:00
Mike de Boer
330e35542c Bug 1354532 - Part 2 - To facilitate the DownloadsSubview, add a 'LimitedHistoryDownloadsData' and 'LimitedPrivateHistoryDownloadData' dataview. r=Paolo
MozReview-Commit-ID: Jkyj2SQ7F00

--HG--
extra : rebase_source : 6342507ccd83187fc1e6690f8ba1a59c26d4c589
2017-09-06 16:23:06 +02:00
Mike de Boer
bfdabc36cf Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Wes Kocher
7ea5ed6e6a Merge m-c to autoland, a=merge
MozReview-Commit-ID: LEKykpTAKjv
2017-08-25 17:32:33 -07:00
Johann Hofmann
b5ba1bbb3c Bug 1139913 - Downloads with partial data should still keep the placeholder on disk. r=mak
This prevents naming conflicts if a paused or blocked download is retried from the original page.

MozReview-Commit-ID: 4rFZ5rP8saJ

--HG--
extra : rebase_source : 82dd14f0eb2f43c2404dff6e78aa564d07ba06d7
extra : source : d2a4fa2a4005db6c39aece63208059a86c5e35a5
2017-08-25 16:42:45 +01:00
Gijs Kruitbosch
e47e6f071c Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6

--HG--
extra : rebase_source : af8ed6b6da9adc1badbdc5016aacb877511875f0
2017-08-25 13:32:47 +01:00
Blake Winton
fff59923b4 Bug 1384692 - Update the download doorhanger style. ui-r=amylee, r=Paolo.
MozReview-Commit-ID: 4pY9JxnLNYk

--HG--
extra : rebase_source : a6573e33298e84fca2fc8de92c932f770dcc53b2
2017-08-01 09:18:11 -04:00
Paolo Amadini
e9f7da41fa Bug 1393418 - Fix initialization of the Downloads Indicator on startup. r=mak
MozReview-Commit-ID: GEQZoak5MFl

--HG--
extra : rebase_source : d06fdd9e0a07e70cf3d3143c3ecefd0e3365a350
2017-08-24 13:34:08 +01:00
Gijs Kruitbosch
ace9ca19d1 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : f2c8a292c5bddb2dfde656b0f37fe2abee371ea0
2017-08-16 15:54:36 +01:00
Paolo Amadini
f19bdfadcf Bug 1296554 - Show a static progress bar for downloads of unknown size. r=jaws
MozReview-Commit-ID: HgRl7vlTp3Z

--HG--
extra : rebase_source : 629e19cccc4c15aae0e244488cf3fe2e8008b449
2017-08-21 14:52:33 +01:00
Sam Foster
cb750380af Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65

--HG--
extra : rebase_source : 6c7fe7fd3b1d0401247d964d378c6829b04e2b93
2017-08-11 16:06:02 -07:00
Sebastian Hengst
549eba284b Backed out changeset bf522e33426e (bug 1388183) for eslint failure browser/components/downloads/content/indicator.js. r=backout on a CLOSED TREE 2017-08-17 22:04:54 +02:00
Sam Foster
c01a1898f4 Bug 1388183 - Queue and play the last download notification instead of truncating/aborting it. r=Paolo
* Maintain a _nextNotificationType LIFO "queue" of one, to play overlapping events in series
* _showNotification assumes everything could have changed since it was last called
* Signature of showEventNotification is unchanged, but most of its work is now done in _showNotification

MozReview-Commit-ID: 8sv4DZoZU65

--HG--
extra : rebase_source : 9d6a0fc905b42e8843693f6c5fe8cd1444d08868
2017-08-11 16:06:02 -07:00
Andrew Halberstadt
d2109610fb Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : 8607b3964da207a6076c79b6f1d75b40503cdd7d
2017-08-10 14:48:21 -04:00
Phil Ringnalda
0ff5a4285d Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
MozReview-Commit-ID: 3HDE2C3wSU0
2017-08-10 20:21:19 -07:00
Wes Kocher
cff9e9b197 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 2YvHbITn9w3
2017-08-10 18:25:34 -07:00
Kris Maglione
0ecfcbc93e Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj

--HG--
extra : rebase_source : 15761873b91efaf1d338b6361bf7168ab4348e0d
2017-08-09 13:03:36 -07:00
Andrew Halberstadt
f625fd5c37 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : d72a88962ec8d843e7be99e25f710887f01b6e1a
2017-08-10 14:48:21 -04:00
Jared Wein
76f886b972 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU

--HG--
extra : rebase_source : 203f7449e8345ed5c779dfc4fd5e9bd515b89da8
2017-08-07 12:37:34 -04:00
Masatoshi Kimura
ca088e461c Bug 389565 - Remove nsIExternalProtocolService::LoadUrl. r=Paolo
MozReview-Commit-ID: lMq06cPWYB

--HG--
extra : rebase_source : 5c48597cbe4491fff93d3e757efa5ecad0f7fc22
2017-08-06 11:25:42 +09:00
Paolo Amadini
a0fc00495b Bug 1381411 - Implement the DownloadHistoryList object. r=mak
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB

--HG--
extra : rebase_source : e36faf63dadeba0c897b769cb7e14a2d01d0f628
extra : amend_source : 2c7a88b6e3d6de50b37c34a5579b3ab6fb0c10dd
2017-08-04 14:48:53 +01:00
Sam Foster
6130972950 Bug 1376519 - Photon download notifications. r=Paolo
* Filmstrip style svg animation for start download notification, vertically centered to allow for variable-height toolbar buttons
* Simultaneous identifer "dip" animation on the icon for download start
* Identifier icon bounce animation for download finish (no notification animation in the #downloads-animation-container)
* Always measure the anchor element as toolbarheight may change in a session (e.g. switching to compact mode)
* Conditionally include the start/finish pngs for non-Photon builds
* Have #downloads-notification-anchor hidden by default, and show it before measuring for placement. This avoids the interference with scrolling/APZ when the notifier element is tall enough to overlap the tabbrowser element

MozReview-Commit-ID: LJF6iV9HiJi

--HG--
extra : rebase_source : 80238cf0240c32943667ee4c141c756813b2728e
2017-07-31 09:36:27 -07:00
Paolo Amadini
54a5e2c5a7 Bug 830415 - Part 2 - Move the front-end code that stores download metadata in history to the DownloadHistory module. r=mak
Regression tests will be added in bug 1381411 when methods to retrieve the metadata will be available.

MozReview-Commit-ID: I3MgwM0EOty

--HG--
extra : source : 6b7ffdcb3f99be007e88c685fd54a8132d844101
2017-07-26 16:12:57 +01:00
Marco Bonardo
12415f39f7 Bug 1275878 - Part 1: move back clear history operations to History.clear(). r=adw
MozReview-Commit-ID: DbEJgKbTxd7

--HG--
extra : rebase_source : f257f99aff6eebc44fac46d0e2d2579dae50ace2
2016-05-17 09:35:45 +02:00
Florian Quèze
b5647ed1c0 Bug 1381853 - lazy load downloads scripts into the browser window, r=mconley. 2017-07-23 00:18:00 +02:00
Paolo Amadini
073b04818f Bug 1354568 - Show the final file size in the Downloads Panel. r=mak
MozReview-Commit-ID: I9D2yaYpwHD

--HG--
extra : rebase_source : 445bc80d50dd3401175c1be639715679bb42d6b4
2017-07-18 15:00:19 +01:00
Paolo Amadini
137d61ddbb Bug 1381409 - Part 3 - Use DownloadList notifications directly in front-end download views. r=mak
The DownloadList object now provides batch notifications directly, in preparation for linking front-end views to other types of download lists without having to use the DownloadsData indirection.

MozReview-Commit-ID: FOTz1YwGRE1

--HG--
extra : rebase_source : df2d50d50c45a98e257caaa6efa9d0da2fa79237
extra : source : 278858e3d78b5e371f865adac043d07b770f1d3f
2017-07-17 12:05:12 +01:00
Paolo Amadini
64bb3feb3b Bug 1381409 - Part 2 - Let each view keep the state of downloads relevant to it. r=mak
The front-end download views now maintain the old download state themselves, instead of relying on the DownloadsData object dispatching the onDownloadStateChanged notification.

This allows each view to keep only the state relevant to it, for example the Downloads Panel already keeps the state only for the visible items. This also makes it possible for each view to use a different hash than the one provided by the legacy stateOfDownload method, and allows bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 2D1ixsZCkCa

--HG--
extra : rebase_source : f429fe475ea1887180e269ee8aa0addcee76704d
extra : source : df5f46c825a10587149a7bbac2e126c3906e0393
2017-07-17 12:07:17 +01:00
Paolo Amadini
180e05ac9f Bug 1381409 - Part 1 - Always add Download objects in their original order. r=mak
When a new front-end view is added to the DownloadsData object, the Download objects it contains are loaded into the view starting with the newest, which is the opposite of the order used by the underlying DownloadList.

This was originally implemented as an optimization for the Downloads Panel, at a time when the full list of completed downloads was persisted in the same SQLite database as session downloads. This difference is now unnecessary given the low number of session downloads, and can be removed in preparation for bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 5EBkqvyXFq4

--HG--
extra : rebase_source : 44b8783e5c44460d3aa4fb9bd0834c981110e98e
extra : source : 56b8e456797c56c45ed791c0d40f43031e94dc22
2017-07-16 17:36:00 +01:00
Paolo Amadini
3c1829bf94 Bug 1357915 - Fix download commands operating on multiple items in the Library window. r=Standard8
This was regressed by bug 1264206 while removing legacy array comprehensions, because selectedItems is a NodeList and not an Array.

MozReview-Commit-ID: 61GG3SiiWwS

--HG--
extra : rebase_source : 3b3c1268be944d1942450336d4e9c652b4054b41
2017-07-18 10:19:48 +01:00
Gijs Kruitbosch
dbd7fca428 Bug 1369729 - use descriptionheightworkaround for sync panel, r=mconley,Paolo
MozReview-Commit-ID: LQg6NEgCqz2

--HG--
extra : rebase_source : a039936a4c8e416c16171cacf73dab781d77ab50
2017-06-28 17:50:43 +01:00
Sam Foster
9afb8e9798 Bug 1375309 - Implement Photon download progressbar r=Paolo
* Split out the arrow and progressbar in the indicatorOverlay for individual animation.
* Group icon and progressbar parts into addressable elements in a single download-icons.svg

MozReview-Commit-ID: KAn0gFqjKjc

--HG--
extra : rebase_source : 4df5377be7d6d0b42eaebd1e28286b81fd555ec2
2017-06-28 15:03:52 -07:00
Blake Kaplan
a922e0a67a Bug 1375710 - Remove CPOWs from browser_iframe_gone_mid_download.js. r=Gijs
MozReview-Commit-ID: JUF8Vdx0vsy

--HG--
extra : rebase_source : 5be556124776c4dacce7cbabf1df70662c36f433
2017-05-16 18:58:28 -07:00
Florian Quèze
2924991bf6 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Florian Quèze
721c3ada5e Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Paolo Amadini
10ee6a5c4e Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P

--HG--
extra : rebase_source : 3a9ea310d3e4a8642aabbc10636c04bfe2e77070
2017-06-19 11:32:37 +01:00
Mark Striemer
f69d99cef4 Bug 1369771 - Confirm launch of executables other than .exe on Windows r=Paolo
MozReview-Commit-ID: 2TbLbdMc3d3

--HG--
extra : rebase_source : 9380ca04af2d9a9dbf1bedba558231897ed9ff4f
2017-05-29 16:38:54 -05:00
Edouard Oger
adde19d4f4 Bug 1369855 - Update sinon.js to version 2.3.2. r=markh
MozReview-Commit-ID: FPB4HebP3g7

--HG--
extra : rebase_source : 1e55c1dbc8bff59e1a7a097e4a6a58a19bc95688
2017-06-02 15:50:30 -04:00
Sebastian Hengst
d1ec3e6aa9 merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-05-24 11:27:29 +02:00
Paolo Amadini
33ebc4466d Bug 1009116 - Redo resizing architecture of panelmultiview. r=Gijs
The height of the "panelmultiview" binding is now determined by the stack layout code, and doesn't have to be calculated manually via JavaScript anymore. This allows the removal of mutation and overflow observers, and reduces the number of synchronous layouts being made.

There is still a workaround included for wrapping blocks not being taken into account in height calculations.

MozReview-Commit-ID: 9rrPU5O5hUx

--HG--
extra : rebase_source : b872c14a553c4293ac476d5d22c634a5a0f6cb24
extra : intermediate-source : bf96469b6ea7daee29eb75a60d11f017a1c86a64
extra : source : 719bb4e7286fbd3baf32061929e4b7d9f953c671
2017-05-23 17:08:01 +01:00