Commit graph

110 commits

Author SHA1 Message Date
Gijs Kruitbosch
baf3266cde Bug 1341097 - part 1: group frecency notifications from history notifications, r=mak
When updating a large number of places, sending runnables to the main thread
for every single one of them whose frecency we update is not conducive to a
responsive UI. This only gets worse once more observers care about these
notifications (e.g. when the library is open).

To avoid this on startup when importing from other browsers, this patch adds
and uses an option to group the frecency notifications. Later patches will
also use the option to avoid other notifications where possible.

MozReview-Commit-ID: D5KqPDu86bo

--HG--
extra : rebase_source : ad5bbce40eaa802a6a88bc0c9a9c7026fd056598
2017-02-21 20:00:24 +00:00
Dão Gottwald
75df2a0b7d Bug 1338522 - Add telemetry for UI responsiveness during import of profile data from another browser. r=francois,Gijs
MozReview-Commit-ID: Cmh0rhZEPDo

--HG--
extra : rebase_source : 303278eeced0fa177a2147d0fe1e010c976e7c76
2017-02-18 00:01:50 +01:00
Dão Gottwald
e247cf9a5f Bug 1338812 - Call TelemetryStopwatch only once per item (history / bookmarks / logins) rather than for each resource. r=Gijs
MozReview-Commit-ID: 7c5DgKDIFTv

--HG--
extra : rebase_source : 9141f895c95f31b682e047d7df203aed32e3d65b
2017-02-11 21:14:52 +01:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Aman Dwivedi
6cbcc32370 Bug 1323685 - Remove workarounds for bug 449811. r=mak 2016-12-22 16:33:28 +05:30
Gijs Kruitbosch
70e962988d Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak
MozReview-Commit-ID: 7HCA7cKhws4

--HG--
extra : rebase_source : 711f3575093b84bf6dfb18e7750f49c58858ebbc
2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
f9853bee1e Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN
MozReview-Commit-ID: JZbOkmZ7ZZG

--HG--
extra : rebase_source : fc36e4a137e6eef890091fb46e5f149a3cc1c46f
2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
fb5973dfbc Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak
MozReview-Commit-ID: 8pKlBmDVX5X

--HG--
extra : rebase_source : 88a07f15e920d570576d0220f541f156f6da86f9
2016-11-30 11:48:03 +00:00
Sebastian Hengst
e36b2e502c Backed out changeset 12aa73f4a982 (bug 1285577) 2016-12-20 22:54:35 +01:00
Sebastian Hengst
7ed2722b24 Backed out changeset 78a3cd5bf313 (bug 1285577) 2016-12-20 22:54:31 +01:00
Sebastian Hengst
d87d8e6640 Backed out changeset 10388e609fe3 (bug 1285577) 2016-12-20 22:54:26 +01:00
Gijs Kruitbosch
75e4193f12 Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak
MozReview-Commit-ID: 7HCA7cKhws4

--HG--
extra : rebase_source : 16091dde8d36cb05d794a4a32341f57d470242be
2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
7ae04355c1 Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN
MozReview-Commit-ID: JZbOkmZ7ZZG

--HG--
extra : rebase_source : c6f10003226c22404a31b1c33a5c4bef654fed4a
2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
d50600d402 Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak
MozReview-Commit-ID: 8pKlBmDVX5X

--HG--
extra : rebase_source : 0673ea396eff2cfbcc656b7f89cd50ac850e13dc
2016-11-30 11:48:03 +00:00
Gijs Kruitbosch
46cf9c683d Bug 1319816 - fix default browser determination on Windows 7 and below in the automigration case, r=jaws
As noted on the bug, because we call getMigratorKeyForDefaultBrowser() multiple times,
its value no longer reflects the (deleted) registry key for subsequent calls.

While we can fix this for the automigrate case by just passing the default we determined a few
lines earlier (and that seems worth doing to avoid busywork), there are 2 small problems
with this:

1) if the default browser has no data, `migratorKey` won't be set, and so we'll call the same
method again anyway, and the message reported in the error console will be that we can't
migrate from Firefox, when the real problem is that we can't migrate from the original
default browser.

2) there are other callers besides AutoMigrate. Specifically, migration.js also calls this
method.

To deal with these, I've fixed getMigratorKeyForDefaultBrowser() to return the same
registry-based value for its lifetime if we hit the 'the default is firefox, go look for an
earlier default' case.

I've verified that either the s/aMigratorKey/migratorKey/ or the change to
getMigratorKeyForDefaultBrowser() are sufficient to make this work properly in the
automigration case.

While I was here, I also updated one of the error messages to be more explicit.

MozReview-Commit-ID: GeUNTfScMMB

--HG--
extra : rebase_source : 09b4b5fef85c4668bc0931de2c8cf3d1a32e2b42
2016-11-23 16:06:00 +00:00
Gijs Kruitbosch
6793d0542b Bug 1319788 - fix typo in getting a telemetry histogram, r=mak
MozReview-Commit-ID: 22CFX0Ueo1q

--HG--
extra : rebase_source : c721aa1ad1868aaa0b13a7eea53e9b69826c7ccb
2016-11-23 14:47:55 +00:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Gijs Kruitbosch
9437918402 Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL

--HG--
extra : rebase_source : ce2776740d29ae6eb5e93d8d791ca917510352b8
2016-10-22 14:40:48 +01:00
Wes Kocher
7e9c4a34c8 Backed out changeset 77012ce07e57 (bug 1279501) a=gijs 2016-11-01 10:47:59 -07:00
Gijs Kruitbosch
58ae0a7f8c Bug 1314237 - detect nightly/devedition as 'firefox' in migration code, r=mikedeboer
MozReview-Commit-ID: 6vQa59i81Gb

--HG--
extra : rebase_source : e5bc06bc2874cd378a2a8efb1f491a31e446e043
2016-11-01 11:57:30 +00:00
Gijs Kruitbosch
8aab2885d4 Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL

--HG--
extra : rebase_source : 288154d79b230fd1205449af81b8361215c04161
2016-10-22 14:40:48 +01:00
Jared Wein
5040f17e00 Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6

--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Gijs Kruitbosch
8d23ab9355 Bug 1311043 - make eslint much more strict in browser/components/migration/, and fix issues, r=mikedeboer
MozReview-Commit-ID: RXO68w3Kv3

--HG--
extra : rebase_source : b25a1976f2be89f12c2ad14e649270bacd17d174
2016-10-18 16:03:06 +01:00
Gijs Kruitbosch
bacfbe04f5 Bug 1309614 - finish initializing places before we import stuff, r=mak
MozReview-Commit-ID: JucE0HjQdwC

--HG--
extra : rebase_source : 6161cdcedae0d00770b37625fde004959c3be17c
2016-10-13 17:02:29 +01:00
Gijs Kruitbosch
25c200c77f Bug 1305770 - make cookies and passwords import from Chrome without locking, r=mak
MozReview-Commit-ID: CbozmZHwAgz

--HG--
extra : rebase_source : 489a800ad1381bd6daa99040008fba24861d99ff
2016-10-03 16:17:06 +01:00
Gijs Kruitbosch
51d95ff8de Bug 1279240 - use registry key to deduce default browser when possible, r=jaws
MozReview-Commit-ID: 7kDMRrt5JNK

--HG--
extra : rebase_source : b277027ff3850a1629e60b6ba2bbc555e17535b3
2016-09-23 16:27:20 +01:00
Wes Kocher
485474bedb Backed out 3 changesets (bug 1279240) for leaks on Windows VM mochitests a=backout
Backed out changeset 4b69e32e3a83 (bug 1279240)
Backed out changeset d0d5180dc062 (bug 1279240)
Backed out changeset dc1b725b47d4 (bug 1279240)
2016-09-29 17:44:41 -07:00
Gijs Kruitbosch
9521db52b6 Bug 1279240 - use registry key to deduce default browser when possible, r=jaws
MozReview-Commit-ID: 7kDMRrt5JNK

--HG--
extra : rebase_source : 0626785b92074bc9a97e529b541bcf5309d80545
2016-09-23 16:27:20 +01:00
Jinank Jain
3fc0725787 Bug 1276701 - Remove Windows code from Safari migrator. r=Gijs
MozReview-Commit-ID: CuV2xSmXnq
2016-08-23 14:49:39 -07:00
Gijs Kruitbosch
e8ac5e77fb Bug 1289436 - add telemetry for the length of time we take to import data, r=jaws,bsmedberg
MozReview-Commit-ID: CkbHJVRucr5

--HG--
extra : rebase_source : fc6c698e7df76a54fd7a30d5b840f5d838370c7b
2016-07-26 18:05:08 +01:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Gijs Kruitbosch
c99c0d5e93 Bug 1289229 - disable automigration undo if people create/change bookmarks/logins, r=mak
MozReview-Commit-ID: DAoNV9H71Yv

--HG--
extra : rebase_source : b75fce027c28a98566523f54427b7f965e79ad52
2016-07-26 12:48:37 +01:00
Gijs Kruitbosch
b1bd30f80e Bug 1199678 - recognize MS Edge in MigrationUtils.jsm for default browser detection, r=Dolske
MozReview-Commit-ID: Bmuyv59fRAv

--HG--
extra : rebase_source : 0869e916cf5adda158f417d0a50160a37bc8ff40
2016-06-29 19:37:48 +01:00
Gijs Kruitbosch
579b36016a Bug 1276694 - store recency of browser data in telemetry when importing to see how good a predictor default browser is, r=dolske,bsmedberg
MozReview-Commit-ID: 16uPNGGDE68

--HG--
extra : rebase_source : fdb3ad8a3429079cb23cddd4a003b03043a95728
2016-05-30 17:10:54 +01:00
Gijs Kruitbosch
c7b3a300d9 Bug 1271775 - shut up eslint warning about return value, rs=bustage
MozReview-Commit-ID: ESoog14WDSw

--HG--
extra : rebase_source : b0321f9911090894d6a1167d267289fb64e33a6c
2016-06-10 10:11:51 +01:00
Gijs Kruitbosch
592e9bcfd9 Bug 1271775 - allow bypassing the initial migration dialog, r=jaws
MozReview-Commit-ID: LkhHl7ipGEb

--HG--
extra : rebase_source : f61fd08c394196468a7594acf8bb8926da04d0f2
2016-06-01 19:00:53 +01:00
Gijs Kruitbosch
b46aa62ca8 Bug 1275114 - add telemetry to determine how to make browser choices when automatically migrating on first profile startup, r=bsmedberg,Dolske
MozReview-Commit-ID: zVmKTBzAS9

--HG--
extra : rebase_source : 3a311a15534ffe769df550ca4fac320c6f6131f2
2016-05-24 11:44:49 +01:00
Marco Bonardo
6961882734 Bug 1272652 - Firefox fails to import bookmarks from Chrome if it also imports a large history. r=gijs
MozReview-Commit-ID: 3w5TIPi2S8d

--HG--
extra : rebase_source : 616e2fe71ab04404608f06475752e50c9d4b2b92
extra : histedit_source : bcd1e9d41927a72a9dcf3c804ad75454b8948db6%2C852a5b150616724887b4d2ea37d4aa3a1f3006da
2016-05-24 17:29:30 +02:00
Wes Kocher
71155ee202 Backed out changeset 684824592e64 (bug 1272652) for marionette failures 2016-05-23 15:13:08 -07:00
Marco Bonardo
2f9de36860 Bug 1272652 - Firefox fails to import bookmarks from Chrome if it also imports a large history. r=gijs
MozReview-Commit-ID: 3w5TIPi2S8d

--HG--
extra : rebase_source : 923d3b65cd5f5d74f0ecea8db6b8a68c71012981
2016-05-20 17:00:43 +02:00
Gijs Kruitbosch
939515d3cc Bug 1265368 - enable resetting non-default profiles, r=MattN
MozReview-Commit-ID: KpW9JgghFkn

--HG--
extra : rebase_source : e1a6ce0a05ccd6ef94026c6fdeaf6421d5cffe03
extra : histedit_source : ca0ed957aa68ed495cc2d8897aae3e553dd2ebff%2C8ce1e45de095401a6cc85f912cfebacd384eb989
2016-05-05 21:38:49 +01:00
Gijs Kruitbosch
dc4b4997fd Bug 1246591 - remove preprocessing and fix any other issues, r=MattN
--HG--
extra : commitid : ERDudjbCnHC
extra : rebase_source : df5f44f84c5c56f76a65c887cd5b374284562a61
2016-02-08 12:54:38 +00:00
Mike Hommey
276ffb9010 Bug 1235107 - Move bookmarks.html to a chrome localized location. r=dolske 2016-01-05 20:03:43 +09:00
Gijs Kruitbosch
04b6f41448 Bug 1219707 - fix argument passing to migration.js, r=jaws
--HG--
extra : commitid : 8GHFDaUhXA2
2015-10-29 12:16:15 +00:00
Tooru Fujisawa
8ed7719ea4 Bug 1216775 - Remove for-each from browser/. r=Gijs
--HG--
extra : commitid : 5KlVHJwTU1Q
extra : rebase_source : 6526234004427109c826cb63f42c9def8ca31281
2015-10-19 01:27:39 +09:00
Gijs Kruitbosch
b4048dc695 Bug 731025 - Add telemetry for migrator usage and errors, r=MattN,p=bsmedberg
--HG--
extra : commitid : 1TzjbWkzOq7
extra : rebase_source : fad923bd73689a49315e0e737553f0fd146a8d57
2015-10-07 13:34:46 +01:00
Tooru Fujisawa
a80925cf2f Bug 1207491 - Part 7: Remove use of expression closure from browser/components/migration/. r=Gijs
--HG--
extra : commitid : 9jirohhjOQ7
extra : rebase_source : e790d293ad5f9211e4da401dbe1be0175aa18097
2015-09-23 18:36:21 +09:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Gijs Kruitbosch
025771fc44 Bug 1196311 - actually ship edge migrator, r=jaws
--HG--
extra : commitid : 7VewJalFyq9
extra : rebase_source : 76d50265d9b00417b245136e481d79bc6a37bdc1
extra : amend_source : 8a9b388f4fe7c1d12618f7cc5f063271da27ef20
2015-08-19 17:41:30 +01:00
Gijs Kruitbosch
14f5fec011 Bug 1192032 - add edge bookmarks/favorites migrator, r=MattN
--HG--
extra : commitid : AMbRF5FXwqD
extra : rebase_source : 228ab0ac7d4fd5d744e8dcb78d0ebd7045019ed2
2015-08-11 16:53:10 +01:00
Bernardo P. Rittmeyer
e2a7d78267 Bug 706005 - Chrome migrator notifies user to close browser. r=MattN
--HG--
extra : commitid : 5oD1YL5zeLw
extra : rebase_source : 24a99b34f8bfa458b2db0f79ffd1335a40e7dd15
2015-08-07 23:36:32 -07:00
Matthew Noorenberghe
18dca7a7aa Bug 706973 - Support migration from Chromium/Canary. r=Mano
--HG--
extra : commitid : 3KP329DkUM0
2015-08-06 00:02:22 -07:00
Hector Zhao
3dd846b978 Bug 1164752 - Include 360 secure browser in migration. r=mak
--HG--
extra : transplant_source : %2B%B6%90%B7l%BC%8B%B9m%08%7F%03%90%CC7jH%16Vw
2015-05-13 18:00:55 +08:00
Marco Bonardo
9b2ba80009 Bug 1094876 - Migrators should use new Bookmarks.jsm API. r=ttaubert 2015-04-20 16:32:49 +02:00
Abhishek Bhattacharya
d1a4be8680 Bug 1123309 - Remove Dict.jsm. r=mak,gfritzsche,felipe 2015-04-08 15:49:47 -03:00
Neil Rashbrook
6778078a1e Bug 1100118 Allow migration from Firefox to Firefox Developer Edition r=MattN 2015-02-14 21:29:49 +00:00
Birunthan Mohanathas
c8c41d6efe Bug 1038458 - Part 4: Flatten browser/components/migration/{public,src}/ directories. r=mak
--HG--
rename : browser/components/migration/src/BrowserProfileMigrators.manifest => browser/components/migration/BrowserProfileMigrators.manifest
rename : browser/components/migration/src/ChromeProfileMigrator.js => browser/components/migration/ChromeProfileMigrator.js
rename : browser/components/migration/src/FirefoxProfileMigrator.js => browser/components/migration/FirefoxProfileMigrator.js
rename : browser/components/migration/src/IEProfileMigrator.js => browser/components/migration/IEProfileMigrator.js
rename : browser/components/migration/src/MigrationUtils.jsm => browser/components/migration/MigrationUtils.jsm
rename : browser/components/migration/src/ProfileMigrator.js => browser/components/migration/ProfileMigrator.js
rename : browser/components/migration/src/SafariProfileMigrator.js => browser/components/migration/SafariProfileMigrator.js
rename : browser/components/migration/public/nsIBrowserProfileMigrator.idl => browser/components/migration/nsIBrowserProfileMigrator.idl
rename : browser/components/migration/src/nsIEHistoryEnumerator.cpp => browser/components/migration/nsIEHistoryEnumerator.cpp
rename : browser/components/migration/src/nsIEHistoryEnumerator.h => browser/components/migration/nsIEHistoryEnumerator.h
2014-07-26 09:31:57 -07:00
Renamed from browser/components/migration/src/MigrationUtils.jsm (Browse further)