Commit graph

60 commits

Author SHA1 Message Date
Diego Pino Garcia
3c5b7bc26a Bug 1446158 - Create a handleEvent custom element mixin to forward events from handleEvent to on* methods. r=MattN 2018-12-20 03:28:00 +02:00
Coroiu Cristina
8b010df0fc Backed out changeset 7ca43b63f0e9 (bug 1446158) for ESlint failure at browser/components/payments/res/containers/address-form.js 2018-12-18 22:08:03 +02:00
Diego Pino Garcia
76f1ed4180 Bug 1446158 - Create a handleEvent custom element mixin to forward events from handleEvent to on* methods. r=MattN 2018-12-18 06:56:00 +02:00
Diego Pino Garcia
29cb3d46ea Bug 1476873 - Use Element.toggleAttribute instead of custom handling for setAttribute vs. removeAttribute. r=Mattn 2018-12-15 01:58:00 +02:00
Jared Wein
6989ff6cec Bug 1477113 - Dispatch paymentmethodchange event from the front-end. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D13740

--HG--
extra : moz-landing-system : lando
2018-12-13 18:48:54 +00:00
Narcis Beleuzu
99f7b49656 Backed out changeset 3fa420b71260 (bug 1477113) for bc failures on browser_total.js. CLOSED TREE 2018-12-13 09:53:39 +02:00
Jared Wein
bbfb132319 Bug 1477113 - Dispatch paymentmethodchange event from the front-end. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D13740

--HG--
extra : moz-landing-system : lando
2018-12-13 06:35:30 +00:00
Matthew Noorenberghe
865adcf2a7 Bug 1495549 - Clear paymentMethod errors when the paymentMethod changes. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D13451

--HG--
extra : moz-landing-system : lando
2018-12-11 18:18:15 +00:00
Matthew Noorenberghe
b82e3514a4 Bug 1495549 - Clear merchant payer errors when the payer address changes. r=jaws
Depends on D12605

Differential Revision: https://phabricator.services.mozilla.com/D12606

--HG--
extra : moz-landing-system : lando
2018-12-11 18:17:31 +00:00
Matthew Noorenberghe
a41a15391f Bug 1495549 - Clear merchant shipping errors when the shipping address changes. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D12605

--HG--
rename : browser/components/payments/test/browser/browser_retry.js => browser/components/payments/test/browser/browser_retry_fieldErrors.js
extra : moz-landing-system : lando
2018-12-11 18:16:30 +00:00
Sam Foster
44f245f69d Bug 1481481 - Create separate forms for shipping, payer and billing address r=MattN
* New AddressForm instances for each address type
* Move selected-state-key out of state for the address forms, and into an attribute
* Remove passing form title via state, just use data-title-edit and data-title-add on the element
* Remove shippingOption form title logic from address picker, just set the right attribute values from PaymentDialog
* Move setting the extraRequiredFields data attribute the payer form needs out to the payment-dialog's render.
* Amend onboarding logic to direct to billing address form when necessary
* Fix-up tests

Differential Revision: https://phabricator.services.mozilla.com/D11545

--HG--
extra : moz-landing-system : lando
2018-11-21 19:23:27 +00:00
Matthew Noorenberghe
04e84ad672 Bug 1482689 - Don't import payment-dialog.js from other elements. r=sfoster
Importing payment-dialog.js ends up importing every other element because it imports the elements needed to render the full dialog.
We don't want all of our elements to depend on every other payment one so we shouldn't import payment-dialog.js anywhere in non-test code.

Differential Revision: https://phabricator.services.mozilla.com/D10576

--HG--
extra : moz-landing-system : lando
2018-11-06 00:19:10 +00:00
Cosmin Sabou
d5f49855cd Backed out 2 changesets (bug 1482689) for browser chrome failures on browser_address_edit.js
Backed out changeset 61b49da4b9cb (bug 1482689)
Backed out changeset c810cab5dbdb (bug 1482689)
2018-11-05 18:28:15 +02:00
Matthew Noorenberghe
2e969bf86c Bug 1482689 - Don't import payment-dialog.js from other elements. r=sfoster
Importing payment-dialog.js ends up importing every other element because it imports the elements needed to render the full dialog.
We don't want all of our elements to depend on every other payment one so we shouldn't import payment-dialog.js anywhere in non-test code.

Differential Revision: https://phabricator.services.mozilla.com/D10576

--HG--
extra : moz-landing-system : lando
2018-11-01 22:01:50 +00:00
Jared Wein
9d2ad063d8 Bug 1483412 - Make the telephone number field required on the payer form if requestPayerPhone is true. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D10597

--HG--
extra : moz-landing-system : lando
2018-11-01 22:38:03 +00:00
Matthew Noorenberghe
ec9bd73e34 Bug 1435871 - Open prefs from Payment Request in a tab. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D8497

--HG--
extra : moz-landing-system : lando
2018-10-20 03:40:05 +00:00
Matthew Noorenberghe
b059591dff Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7934

--HG--
extra : moz-landing-system : lando
2018-10-20 03:39:32 +00:00
Jared Wein
e85599dc8f Bug 1494551 - Sort the formautofill data by the last used time. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D9174

--HG--
extra : moz-landing-system : lando
2018-10-19 17:00:31 +00:00
Brindusan Cristian
1420f3437e Backed out 2 changesets (bug 1435871) for multiple browser-chrome failures on payments. CLOSED TREE
Backed out changeset 0f7592b662e2 (bug 1435871)
Backed out changeset 039f6d65036e (bug 1435871)
2018-10-19 12:36:13 +03:00
Matthew Noorenberghe
783e80be91 Bug 1435871 - Open prefs from Payment Request in a tab. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D8497

--HG--
extra : moz-landing-system : lando
2018-10-19 05:06:30 +00:00
Dorel Luca
001975a583 Backed out 3 changesets (bug 1435871) for mochitest crashes. CLOSED TREE
Backed out changeset 8eab3320b8c5 (bug 1435871)
Backed out changeset 29777ddd9def (bug 1435871)
Backed out changeset afdc3066f12c (bug 1435871)
2018-10-17 23:06:14 +03:00
Matthew Noorenberghe
27419e1f5b Bug 1435871 - Open prefs from Payment Request in a tab. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D8497

--HG--
extra : moz-landing-system : lando
2018-10-17 18:46:12 +00:00
Jared Wein
4a3b48e09b Bug 1470199 - Add a tooltip for the CVV input. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7473

--HG--
extra : moz-landing-system : lando
2018-10-13 00:39:02 +00:00
Matthew Noorenberghe
963ec2ea52 Bug 1496698 - Remove Custom Elements polyfill from Web Payments UI. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7863

--HG--
extra : moz-landing-system : lando
2018-10-05 15:37:25 +00:00
Matthew Noorenberghe
fb139159d2 Bug 1435163 - Show the summary page after the processing page when retry() is called. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D7159

--HG--
extra : moz-landing-system : lando
2018-09-29 00:17:50 +00:00
Sam Foster
b6ecb8ed07 Bug 1477102 - Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7025

--HG--
extra : moz-landing-system : lando
2018-09-28 16:53:37 +00:00
Matthew Noorenberghe
e2db9b25d4 Bug 1490805 - Make the CVV field required on the payment-summary screen. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D6848

--HG--
extra : moz-landing-system : lando
2018-09-27 05:40:35 +00:00
Matthew Noorenberghe
4aaa87fe69 Bug 1432939 - Link to Firefox Options/Preferences from the PaymentRequest dialog. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D6724

--HG--
extra : moz-landing-system : lando
2018-09-25 17:26:38 +00:00
Jared Wein
cca9a56686 Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN
Contributions by Matthew Noorenberghe <mozilla@noorenberghe.ca>

Differential Revision: https://phabricator.services.mozilla.com/D6420

--HG--
extra : rebase_source : eb6ef8494e76e1ceef14cd8b9214fa6d1ba782b5
2018-09-21 00:15:56 -07:00
Noemi Erli
3185c676dd Backed out 2 changesets (bug 1490077) for failures in browser/components/payments/test/mochitest/test_address_option.html on a CLOSED TREE
Backed out changeset 9b038cd736cf (bug 1490077)
Backed out changeset 29f6f86fb9cd (bug 1490077)
2018-09-21 11:01:46 +03:00
Jared Wein
e4f770624b Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN
Contributions by Matthew Noorenberghe <mozilla@noorenberghe.ca>

Differential Revision: https://phabricator.services.mozilla.com/D6420
2018-09-21 00:15:56 -07:00
Matthew Noorenberghe
514f9fcc29 Bug 1463545 - Replace grid layout of <address-option> with a new two line design. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5186

--HG--
extra : moz-landing-system : lando
2018-09-20 21:07:20 +00:00
Sam Foster
de8e9161fa Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824

--HG--
extra : moz-landing-system : lando
2018-09-19 18:15:11 +00:00
Bogdan Tara
726c5b5e54 Backed out changeset 7351a4c8d1a1 (bug 1429181) for multiple payment-related failures CLOSED TREE 2018-09-15 00:58:48 +03:00
Sam Foster
3b20596ca5 Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824

--HG--
extra : moz-landing-system : lando
2018-09-14 20:28:41 +00:00
Matthew Noorenberghe
db94a77ef1 Bug 1478029 - Don't select a shipping option by default for the user. r=sfoster
Honour the .selected value provided by the merchant.

Differential Revision: https://phabricator.services.mozilla.com/D3668

--HG--
extra : rebase_source : a7ea701d875f3052dabad16ca90419f7f3f3849c
extra : amend_source : 1fe3c1ecff45d73761ae848d044911c27e1840ae
2018-08-17 17:03:29 -07:00
Jared Wein
559a6cb6d4 Bug 1476348 - Show missing field validation errors on the summary page. r=MattN
MozReview-Commit-ID: 5dOzxWH0pWp

--HG--
extra : rebase_source : 1de025d22f01c5b293355b0fe0732543769bf761
2018-08-03 18:51:31 -04:00
Jared Wein
b5298bb1f5 Bug 1477699 - Show a generic error message when a merchant-supplied error message isn't present. r=MattN
MozReview-Commit-ID: Dn4mnvzunVd

--HG--
extra : rebase_source : b606aa2717febdf7d014c5254bd28148ebfc64be
2018-07-31 15:09:58 -04:00
Jared Wein
55494981b1 Bug 1475521 - Payments shouldn't be processed without selecting a shipping address. r=MattN
MozReview-Commit-ID: CXxqYB3iOy

--HG--
rename : browser/components/payments/test/mochitest/test_payment_dialog.html => browser/components/payments/test/mochitest/test_payment_dialog_required_top_level_items.html
extra : rebase_source : dfd5f1d345231acc6684453ed8b6564c5664790c
2018-07-27 12:03:46 -04:00
Matthew Noorenberghe
97013686ad Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3

--HG--
extra : rebase_source : e80fd0a269f4565300e3923223a2ac483f4cf33e
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
84558567ed Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs

--HG--
extra : rebase_source : 07cc1137c4f925a4f5554c2680c624d59da5fcd8
2018-07-23 20:34:40 -07:00
Cosmin Sabou
80a830bce7 Backed out 5 changesets (bug 1476204) for browser chrome failures on browser_editCreditCardDialog. CLOSED TREE
Backed out changeset 10f3d1014592 (bug 1476204)
Backed out changeset a88879ea32e8 (bug 1476204)
Backed out changeset 001f13f2dd21 (bug 1476204)
Backed out changeset f0f464e3c27c (bug 1476204)
Backed out changeset ed92000eca20 (bug 1476204)
2018-07-26 04:12:56 +03:00
Matthew Noorenberghe
ae5eb48179 Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3

--HG--
extra : rebase_source : 0bb5a17967092d89f63f96c240ac78c0df671bce
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
6cad3245bb Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs

--HG--
extra : rebase_source : 80eeed03264f000b97572fa03c1c322540cd554e
2018-07-23 20:34:40 -07:00
Matthew Noorenberghe
791b509e81 Bug 1463538 - Make all <input> in the PaymentRequest debug panel live. r=sfoster
MozReview-Commit-ID: 4nutxHpmnlc

--HG--
extra : rebase_source : 5c4a431997b39bd34675ddf244e641af35a3c1ae
2018-07-23 20:01:19 -07:00
Gurzau Raul
cd2f4fd65e Backed out 4 changesets (bug 1463538) for failing on /payments/test/browser/browser_payments_onboarding_wizard.js
Backed out changeset 1c945ede0071 (bug 1463538)
Backed out changeset 8ccd9f4b230d (bug 1463538)
Backed out changeset e078fb39875e (bug 1463538)
Backed out changeset 798bf0d7928c (bug 1463538)
2018-07-24 11:16:21 +03:00
Matthew Noorenberghe
cfe6725edf Bug 1463538 - Make all <input> in the PaymentRequest debug panel live. r=sfoster
MozReview-Commit-ID: 4nutxHpmnlc

--HG--
extra : rebase_source : 5c4a431997b39bd34675ddf244e641af35a3c1ae
2018-07-23 20:01:19 -07:00
Sam Foster
799c3f4923 Bug 1447777 - Add completion fail and timeout error pages. r=MattN
* A new CompletionErrorPage / completion-error-page element which represents the content of the completion error
* Leave the dialog open when complete() results in a 'fail' or 'timeout'.
* The 'done' button on the fail & timeout error page closes the dialog by sending a message up to the paymentDialogWrapper.
* Rewrite the pay button rendering logic to ensure it is disabled when it should be
* Retry handling and UI not addressed here. Will need a new bug when the DOM support has landed.
* Extend completeStatus support in debugging.html and group like actions to tidy up a bit

MozReview-Commit-ID: GDhJqrj14uT

* Add tests to verify that the dialog stays open when completion fails or times out
* Add tests to verify that complete() throws after the timeout
* Rework completeStatus mochitest for PaymentDialog

MozReview-Commit-ID: 4ZNVEYMp7h5

--HG--
extra : rebase_source : 1d8e691eb44e74156a956dff73e1359af2a6934a
2018-07-20 15:51:52 -07:00
Sam Foster
4fe42163ad Bug 1447777 - Move state.completionState to state.request.completeStatus. r=MattN
* Spot-fix order details test to clone request before modifying it

MozReview-Commit-ID: AXjI1veRSk9

--HG--
extra : rebase_source : ee12efc493c343b9f18cee2cb281a5fe6731731d
2018-07-19 19:45:58 -07:00
prathiksha
cbf299a9dd Bug 1475080 - Clean up the pickers on the payment summary page to match the spec. r=MattN
MozReview-Commit-ID: FOyD7DkwjHk

--HG--
extra : rebase_source : 16790a4774df3e2bc34d9e6cd92405e9cd7b7a9e
2018-07-20 11:13:43 -07:00