Commit graph

64 commits

Author SHA1 Message Date
Sam Foster
44f245f69d Bug 1481481 - Create separate forms for shipping, payer and billing address r=MattN
* New AddressForm instances for each address type
* Move selected-state-key out of state for the address forms, and into an attribute
* Remove passing form title via state, just use data-title-edit and data-title-add on the element
* Remove shippingOption form title logic from address picker, just set the right attribute values from PaymentDialog
* Move setting the extraRequiredFields data attribute the payer form needs out to the payment-dialog's render.
* Amend onboarding logic to direct to billing address form when necessary
* Fix-up tests

Differential Revision: https://phabricator.services.mozilla.com/D11545

--HG--
extra : moz-landing-system : lando
2018-11-21 19:23:27 +00:00
Sam Foster
aa95912b8b Bug 1482689 - Use AddressPicker for the card billing address UI. r=MattN
* New BillingAddressPicker subclass of AddressPicker which just overrides some of the state-related behavior that
* Allow the RichSelect's popupBox (<select>) to be assigned after the constructor
* A couple new mochitests for the new/different behavior
* Update the test to expect 'edit' to be hidden when the empty option is selected

Differential Revision: https://phabricator.services.mozilla.com/D9321

--HG--
extra : moz-landing-system : lando
2018-11-06 00:28:46 +00:00
Brindusan Cristian
94b707cdd4 Backed out changeset ea5d6df24de0 (bug 1482689) as requested by sfoster. 2018-11-06 02:20:51 +02:00
Sam Foster
47668991be Bug 1482689 - Use AddressPicker for the card billing address UI. r=MattN
* New BillingAddressPicker subclass of AddressPicker which just overrides some of the state-related behavior that
* Allow the RichSelect's popupBox (<select>) to be assigned after the constructor
* A couple new mochitests for the new/different behavior
* Update the test to expect 'edit' to be hidden when the empty option is selected

Differential Revision: https://phabricator.services.mozilla.com/D9321

--HG--
extra : moz-landing-system : lando
2018-11-06 00:04:42 +00:00
Cosmin Sabou
d5f49855cd Backed out 2 changesets (bug 1482689) for browser chrome failures on browser_address_edit.js
Backed out changeset 61b49da4b9cb (bug 1482689)
Backed out changeset c810cab5dbdb (bug 1482689)
2018-11-05 18:28:15 +02:00
Sam Foster
2dbcd5bcca Bug 1482689 - Use AddressPicker for the card billing address UI. r=MattN
* New BillingAddressPicker subclass of AddressPicker which just overrides some of the state-related behavior that isn't applicable to billing addresses.
* A couple new mochitests for the new/different behavior

Differential Revision: https://phabricator.services.mozilla.com/D9321

--HG--
extra : moz-landing-system : lando
2018-11-05 15:16:02 +00:00
Jared Wein
4a3b48e09b Bug 1470199 - Add a tooltip for the CVV input. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7473

--HG--
extra : moz-landing-system : lando
2018-10-13 00:39:02 +00:00
Sam Foster
b1cda8a12a Bug 1473662 - Save button should be labelled 'Next' when adding a new address or card. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7209

--HG--
extra : moz-landing-system : lando
2018-09-28 20:00:03 +00:00
Matthew Noorenberghe
05d5fb0939 Bug 1490805 - Add a required CSC/CVV field to the add card page. r=jaws
Depends on D6882

Differential Revision: https://phabricator.services.mozilla.com/D6883

--HG--
extra : moz-landing-system : lando
2018-09-27 17:26:24 +00:00
Jared Wein
3dc4f24d54 Bug 1470168 - Add tooltip beside 'Save to Firefox' checkbox. r=MattN
I had to move the tooltip to appear above the help icon to make sure that it cause scrollbars to appear on the address form.

Differential Revision: https://phabricator.services.mozilla.com/D6912

--HG--
extra : moz-landing-system : lando
2018-09-27 14:11:39 +00:00
Matthew Noorenberghe
4aaa87fe69 Bug 1432939 - Link to Firefox Options/Preferences from the PaymentRequest dialog. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D6724

--HG--
extra : moz-landing-system : lando
2018-09-25 17:26:38 +00:00
Matthew Noorenberghe
514f9fcc29 Bug 1463545 - Replace grid layout of <address-option> with a new two line design. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5186

--HG--
extra : moz-landing-system : lando
2018-09-20 21:07:20 +00:00
Sam Foster
0f49c56e72 Bug 1491065 - Use 'Next' as label for the save buttons during onboarding. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D6318

--HG--
extra : moz-landing-system : lando
2018-09-19 22:10:50 +00:00
Sam Foster
ed3af174cd Bug 1470183 - Add 3rd suggestion to failure page directing users to merchant for more info. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D6322

--HG--
extra : moz-landing-system : lando
2018-09-19 20:57:26 +00:00
Sam Foster
de8e9161fa Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824

--HG--
extra : moz-landing-system : lando
2018-09-19 18:15:11 +00:00
Bogdan Tara
726c5b5e54 Backed out changeset 7351a4c8d1a1 (bug 1429181) for multiple payment-related failures CLOSED TREE 2018-09-15 00:58:48 +03:00
Sam Foster
3b20596ca5 Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824

--HG--
extra : moz-landing-system : lando
2018-09-14 20:28:41 +00:00
Jared Wein
ee03acf81a Bug 1489629 - Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5320

--HG--
extra : moz-landing-system : lando
2018-09-10 18:16:55 +00:00
Jared Wein
57e533640d Bug 1487395 - Update strings on error pages, as well as convert apostrophes to use 'smart-quotes'. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5068

--HG--
extra : moz-landing-system : lando
2018-09-06 19:43:19 +00:00
Jared Wein
066ed9e934 Bug 1477100 - Show the labels as placeholders inside of the fields. r=MattN
Show the labels as placeholders inside of the fields.

Differential Revision: https://phabricator.services.mozilla.com/D2955

--HG--
extra : rebase_source : 4ca24b7b6833c3c1bcd4821ec127fe07c24b44d0
2018-08-17 16:25:46 -07:00
Jared Wein
559a6cb6d4 Bug 1476348 - Show missing field validation errors on the summary page. r=MattN
MozReview-Commit-ID: 5dOzxWH0pWp

--HG--
extra : rebase_source : 1de025d22f01c5b293355b0fe0732543769bf761
2018-08-03 18:51:31 -04:00
Jared Wein
b5298bb1f5 Bug 1477699 - Show a generic error message when a merchant-supplied error message isn't present. r=MattN
MozReview-Commit-ID: Dn4mnvzunVd

--HG--
extra : rebase_source : b606aa2717febdf7d014c5254bd28148ebfc64be
2018-07-31 15:09:58 -04:00
Jared Wein
9849e2000e Bug 1472278 - Localize the required form asterisk on the address-form, basic-card-form, and CVV entry field. r=MattN
MozReview-Commit-ID: 7VN1VY7QziT

--HG--
extra : rebase_source : b28017164a32758271059b0337e295ca4883f14b
2018-07-30 21:13:36 -04:00
Jared Wein
f9f97a19b6 Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN

--HG--
extra : rebase_source : 88eff9da5e84abf8ee726ceb7fcf338ecc1f50ee
2018-07-30 17:52:24 -04:00
Brindusan Cristian
d0b636e70f Backed out changeset d402c7b803c6 (bug 1477114) as requested by jaws. 2018-08-02 23:18:53 +03:00
Jared Wein
66c08eb74d Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN

--HG--
extra : rebase_source : e2ed448ec2e82a5c874e5186ee318773f3250c09
2018-07-30 17:52:24 -04:00
Jared Wein
b891ceac20 Bug 1478175 - Implement the branding in the lower left corner of the payment-summary page. r=sfoster
MozReview-Commit-ID: Dp8SdEzlrG3

--HG--
extra : rebase_source : d7144c0c83a1574bba6f85d7aae123cf5fdecb24
2018-07-30 17:24:16 -04:00
Jared Wein
6ecd2e45dd Bug 1468153 - Update the edit strings (Add/Update) and the failure strings to use the hostname. r=sfoster
MozReview-Commit-ID: HcOMsP5zWBg

--HG--
rename : browser/components/payments/test/mochitest/test_labelled_checkbox.html => browser/components/payments/test/mochitest/test_completion_error_page.html
extra : rebase_source : a5e2ed74badabed047e707620f977081ae99247b
2018-07-30 14:22:52 -04:00
Matthew Noorenberghe
97013686ad Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3

--HG--
extra : rebase_source : e80fd0a269f4565300e3923223a2ac483f4cf33e
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
84558567ed Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs

--HG--
extra : rebase_source : 07cc1137c4f925a4f5554c2680c624d59da5fcd8
2018-07-23 20:34:40 -07:00
Cosmin Sabou
80a830bce7 Backed out 5 changesets (bug 1476204) for browser chrome failures on browser_editCreditCardDialog. CLOSED TREE
Backed out changeset 10f3d1014592 (bug 1476204)
Backed out changeset a88879ea32e8 (bug 1476204)
Backed out changeset 001f13f2dd21 (bug 1476204)
Backed out changeset f0f464e3c27c (bug 1476204)
Backed out changeset ed92000eca20 (bug 1476204)
2018-07-26 04:12:56 +03:00
Matthew Noorenberghe
ae5eb48179 Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3

--HG--
extra : rebase_source : 0bb5a17967092d89f63f96c240ac78c0df671bce
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
6cad3245bb Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs

--HG--
extra : rebase_source : 80eeed03264f000b97572fa03c1c322540cd554e
2018-07-23 20:34:40 -07:00
Matthew Noorenberghe
791b509e81 Bug 1463538 - Make all <input> in the PaymentRequest debug panel live. r=sfoster
MozReview-Commit-ID: 4nutxHpmnlc

--HG--
extra : rebase_source : 5c4a431997b39bd34675ddf244e641af35a3c1ae
2018-07-23 20:01:19 -07:00
Gurzau Raul
cd2f4fd65e Backed out 4 changesets (bug 1463538) for failing on /payments/test/browser/browser_payments_onboarding_wizard.js
Backed out changeset 1c945ede0071 (bug 1463538)
Backed out changeset 8ccd9f4b230d (bug 1463538)
Backed out changeset e078fb39875e (bug 1463538)
Backed out changeset 798bf0d7928c (bug 1463538)
2018-07-24 11:16:21 +03:00
Matthew Noorenberghe
cfe6725edf Bug 1463538 - Make all <input> in the PaymentRequest debug panel live. r=sfoster
MozReview-Commit-ID: 4nutxHpmnlc

--HG--
extra : rebase_source : 5c4a431997b39bd34675ddf244e641af35a3c1ae
2018-07-23 20:01:19 -07:00
Sam Foster
799c3f4923 Bug 1447777 - Add completion fail and timeout error pages. r=MattN
* A new CompletionErrorPage / completion-error-page element which represents the content of the completion error
* Leave the dialog open when complete() results in a 'fail' or 'timeout'.
* The 'done' button on the fail & timeout error page closes the dialog by sending a message up to the paymentDialogWrapper.
* Rewrite the pay button rendering logic to ensure it is disabled when it should be
* Retry handling and UI not addressed here. Will need a new bug when the DOM support has landed.
* Extend completeStatus support in debugging.html and group like actions to tidy up a bit

MozReview-Commit-ID: GDhJqrj14uT

* Add tests to verify that the dialog stays open when completion fails or times out
* Add tests to verify that complete() throws after the timeout
* Rework completeStatus mochitest for PaymentDialog

MozReview-Commit-ID: 4ZNVEYMp7h5

--HG--
extra : rebase_source : 1d8e691eb44e74156a956dff73e1359af2a6934a
2018-07-20 15:51:52 -07:00
prathiksha
cbf299a9dd Bug 1475080 - Clean up the pickers on the payment summary page to match the spec. r=MattN
MozReview-Commit-ID: FOyD7DkwjHk

--HG--
extra : rebase_source : 16790a4774df3e2bc34d9e6cd92405e9cd7b7a9e
2018-07-20 11:13:43 -07:00
Matthew Noorenberghe
c3f7468b65 Bug 1469464 - PaymentRequest footer styling. r=sfoster
MozReview-Commit-ID: BbuIitPlUpQ

--HG--
extra : rebase_source : bf7bb73ecbb0699618f7e5f7068e37facb3ca322
2018-07-11 22:59:46 -07:00
Matthew Noorenberghe
798c0466a9 Bug 1469464 - Consistent PaymentRequest footer positioning with <payment-request-page>. r=sfoster
MozReview-Commit-ID: Oq06q6xF0e

--HG--
extra : rebase_source : 76ee5c4a8e23db6a24e755e09eff05cdf0ae9f52
2018-07-12 09:52:30 -07:00
Matthew Noorenberghe
915ebd8a24 Bug 1469464 - Display the currency code with the total. r=sfoster
MozReview-Commit-ID: JJIbFBAYC9U

--HG--
extra : rebase_source : fa9cf2891af0b01e26771117573efffa7f0c9688
2018-07-07 23:23:43 -07:00
Matthew Noorenberghe
0f22754c42 Bug 1469464 - Always hide View All, remove summary heading, add 'Pay to'. r=sfoster
MozReview-Commit-ID: 5XQNH97o65T

--HG--
extra : rebase_source : 2f958be4842ff19804a034764bb22b7ae5743005
2018-07-11 23:16:12 -07:00
Coroiu Cristina
6a139fd913 Backed out 6 changesets (bug 1469464) for browser-chrome failures at browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE
Backed out changeset f9d4885e8956 (bug 1469464)
Backed out changeset 59c418929764 (bug 1469464)
Backed out changeset 58c1a79fb661 (bug 1469464)
Backed out changeset 90654d5df81a (bug 1469464)
Backed out changeset 9453814beada (bug 1469464)
Backed out changeset 4b86bde79c91 (bug 1469464)
2018-07-12 10:52:02 +03:00
Matthew Noorenberghe
f1eed5e0e8 Bug 1469464 - PaymentRequest footer styling. r=sfoster
MozReview-Commit-ID: BbuIitPlUpQ

--HG--
extra : rebase_source : 5cc86a83db89181f1135940c1fe1ae7c19309c07
2018-07-11 22:59:46 -07:00
Matthew Noorenberghe
247c83fb67 Bug 1469464 - Consistent PaymentRequest footer positioning with <payment-request-page>. r=sfoster
MozReview-Commit-ID: Oq06q6xF0e

--HG--
extra : rebase_source : b27a8fb478be645dc434abb57b722340102771a3
2018-07-11 23:43:27 -07:00
Matthew Noorenberghe
4e41358d92 Bug 1469464 - Display the currency code with the total. r=sfoster
MozReview-Commit-ID: JJIbFBAYC9U

--HG--
extra : rebase_source : fa9cf2891af0b01e26771117573efffa7f0c9688
2018-07-07 23:23:43 -07:00
Matthew Noorenberghe
886274fc2d Bug 1469464 - Always hide View All, remove summary heading, add 'Pay to'. r=sfoster
MozReview-Commit-ID: 5XQNH97o65T

--HG--
extra : rebase_source : 2f958be4842ff19804a034764bb22b7ae5743005
2018-07-11 23:16:12 -07:00
Matthew Noorenberghe
630e6a5e49 Bug 1466720 - Default PaymentRequest dialog styles for background, <a>, and debugging.html. r=jaws
MozReview-Commit-ID: 5WFzbFFBvYj

--HG--
extra : rebase_source : 3b0a9acb3c6f4230b0f24b745c498e69d79080b4
2018-06-13 11:40:11 -07:00
prathiksha
b77efbe6b0 Bug 1462779 - Show the billing address page during on-boarding if requestShipping is false and there are no saved addresses. r=MattN
MozReview-Commit-ID: E7KM4cIielG

--HG--
extra : rebase_source : bb90ddd192b37e94dbf637a429d3dc0c38002a20
2018-05-18 16:44:25 -07:00
Matthew Noorenberghe
723ab85b29 Bug 1462149 - Use &brandShortName; instead of hard-coded Firefox in strings for the payments UI. r=sfoster
MozReview-Commit-ID: 5VgPnVbi1Zm

--HG--
extra : rebase_source : 1916602551a73b02a7543cd25fbf3f7b863a31b4
2018-05-22 15:53:38 -07:00