Commit graph

10 commits

Author SHA1 Message Date
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Mark Banner
527f0b892c Bug 1517769 - History sidebar shouldn't reference TelemetryStopwatch via 'this'. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D15732

--HG--
extra : moz-landing-system : lando
2019-01-08 09:30:55 +00:00
Kris Maglione
ade8c9ede8 Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888

--HG--
extra : source : afd0a13bcfff4c92ad2497ec687f466484481667
extra : amend_source : 501bca3f94a0cb0c8bec1f30d0b3f64a50b04e48
extra : intermediate-source : bc03f101937e373fdaca735f3f356960a5239bc0
2018-10-25 19:04:01 -07:00
arthur.iakab
0c81738411 Backed out 2 changesets (bug 1482091) for bc failures on browser_domFullscreen_fullscreenMode.js
Backed out changeset bc03f101937e (bug 1482091)
Backed out changeset 28a19b7290ab (bug 1482091)
2018-11-03 01:08:36 +02:00
Kris Maglione
7fa01216a4 Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888

--HG--
extra : source : afd0a13bcfff4c92ad2497ec687f466484481667
extra : amend_source : bf22d8e9ce5c081902bd5c75b892cc434a167300
2018-10-25 19:04:01 -07:00
arthur.iakab
cf2aa54f83 Backed out 2 changesets (bug 1482091)for failing browser chrome failures on browser_panelUINotifications_fullscreen_noAutoHideToolbar.js
Backed out changeset afd0a13bcfff (bug 1482091)
Backed out changeset a19c6b3e0402 (bug 1482091)
2018-11-02 23:01:15 +02:00
Kris Maglione
96f3e16d1a Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888

--HG--
extra : rebase_source : a9daea3a9efea37acdbcaecda8bf0b7f69631de4
extra : histedit_source : bb8b416b1387da9de3bd95c7a171f10426a22602
2018-10-25 19:04:01 -07:00
Tim Nguyen
0c68c54d3e Bug 1418602 - Allow theming sidebars. r=mconley
MozReview-Commit-ID: 97zkU7raehV

--HG--
extra : rebase_source : 02a80c78170723bf9d7d2e72834fc26850894dbc
2018-08-06 17:46:43 +01:00
Brian Grinstead
4121127ab8 Bug 1445764 - Move Places imports from XUL to JS for the Places documents;r=standard8
MozReview-Commit-ID: 1LKRgTlaupu

--HG--
extra : rebase_source : ac36bf61df6d77f495e018ac6a972d78e3cbc173
2018-07-03 14:26:49 -07:00
Marco Bonardo
2d456d10c4 Bug 1448810 - Rename the Places sidebar files and merge sidebarUtils into PlacesUIUtils. r=standard8
MozReview-Commit-ID: GsPPBhiTPul

--HG--
rename : browser/components/places/content/bookmarksPanel.js => browser/components/places/content/bookmarksSidebar.js
rename : browser/components/places/content/bookmarksPanel.xul => browser/components/places/content/bookmarksSidebar.xul
rename : browser/components/places/content/history-panel.js => browser/components/places/content/historySidebar.js
rename : browser/components/places/content/history-panel.xul => browser/components/places/content/historySidebar.xul
extra : rebase_source : 6394e16be1df21d182647ea06c4cf592e8136071
2018-03-26 21:15:41 +02:00
Renamed from browser/components/places/content/history-panel.js (Browse further)