Commit graph

5 commits

Author SHA1 Message Date
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Andrea Marchesini
612caa865c Bug 1462662 - Wipe the container for privacy.usercontext.about_newtab_segregation.enabled on shutdown, r=johannh 2018-05-29 17:35:28 +02:00
Cosmin Sabou
63954a642e Backed out changeset 62ed84f80e37 (bug 1462662) for mochitest browser chrome failures on browser_startup.js. CLOSED TREE 2018-05-29 20:16:46 +03:00
Andrea Marchesini
c0f1056898 Bug 1462662 - Wipe the container for privacy.usercontext.about_newtab_segregation.enabled on shutdown, r=johannh 2018-05-29 17:35:28 +02:00
Marco Bonardo
fa2de7886f Bug 1434414 - Locking the 'sanitize on shutdown' pref causes sanitization to happen at every startup. r=johannh
MozReview-Commit-ID: 6PvRFmaZsBC

--HG--
extra : rebase_source : 9b9a670abf6037d239b3b8efd025b9341f45d820
2018-02-15 00:42:58 +01:00