Commit graph

66 commits

Author SHA1 Message Date
Alexandre Poirot
f439c41435 Bug 1520835 - Removed now-useless front pool from DebuggerClient. r=jdescottes
Depends on D20704

Differential Revision: https://phabricator.services.mozilla.com/D20705

--HG--
extra : moz-landing-system : lando
2019-02-22 18:32:38 +00:00
Alexandre Poirot
252ea7758f Bug 1520835 - Remove unused attachTarget methods. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D20704

--HG--
extra : moz-landing-system : lando
2019-02-22 18:32:52 +00:00
yulia
e7f1f95776 Bug 1485664 - remove attachConsole from the debugger client; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D20150

--HG--
extra : moz-landing-system : lando
2019-02-20 10:27:50 +00:00
yulia
1c4e7ce305 Bug 1485664 - move webconsole client to front directory; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D18838

--HG--
rename : devtools/shared/webconsole/client.js => devtools/shared/fronts/webconsole.js
extra : moz-landing-system : lando
2019-02-19 16:00:45 +00:00
yulia
63ec6c691d Bug 1485664 - Change "attachConsole" in the debuggerClient so that it is compatible with a front; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D18837

--HG--
extra : moz-landing-system : lando
2019-02-19 16:04:30 +00:00
Julian Descottes
60c1290864 Bug 1525654 - Move version compatibility check to dedicated module and add unit-tests;r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D18934

--HG--
extra : moz-landing-system : lando
2019-02-12 18:20:40 +00:00
yulia
d5b3aa8f66 Bug 1518777 - move webConsoleClient.detach to destroy; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D16681

--HG--
extra : moz-landing-system : lando
2019-01-24 11:50:36 +00:00
Alexandre Poirot
a75ca7eaa0 Bug 1520773 - Prevent infinite loops in DebuggerClient.close. r=yulia
If any callback fired by DebuggerClient.close ends up calling close again, it will introduce an infinite loop.

Depends on D15826

Differential Revision: https://phabricator.services.mozilla.com/D15827

--HG--
extra : moz-landing-system : lando
2019-01-21 11:04:08 +00:00
Alexandre Poirot
9d435e1006 Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes
MozReview-Commit-ID: 4CMHJ3tV7Rc

Depends on D14174

Differential Revision: https://phabricator.services.mozilla.com/D14175

--HG--
extra : moz-landing-system : lando
2018-12-17 11:56:30 +00:00
Alexandre Poirot
c3d53c83bb Bug 1508285 - Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form. r=yulia
MozReview-Commit-ID: 6TOInM5BmYe

Differential Revision: https://phabricator.services.mozilla.com/D14173

--HG--
extra : moz-landing-system : lando
2018-12-17 11:56:26 +00:00
Logan Smyth
b03057f1e8 Bug 1513655 - Remove source-map module and usage from the debugger server. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D14296

--HG--
extra : moz-landing-system : lando
2018-12-14 19:49:08 +00:00
Cosmin Sabou
f292d9f90e Backed out changeset 4d61e1b695c9 (bug 1513655) for ESlint failure on devtools/server/actors/thread.js. CLOSED TREE 2018-12-14 21:37:34 +02:00
Logan Smyth
432ea8fcdc Bug 1513655 - Remove source-map module and usage from the debugger server. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D14296

--HG--
extra : moz-landing-system : lando
2018-12-14 19:09:15 +00:00
Alexandre Poirot
90639c1f6b Bug 1509315 - Pass the full target form to all BrowsingContextTargetFront instances. r=yulia
For now, we only pass { actor } for all tab target fronts created via DebuggerClient.attachTarget,
whereas parent process target fronts were passing the full form from RootFront.getProcess.

MozReview-Commit-ID: 1H2NxFv8glY

Differential Revision: https://phabricator.services.mozilla.com/D12730

--HG--
extra : moz-landing-system : lando
2018-11-27 21:47:52 +00:00
Alexandre Poirot
2118292883 Bug 1506546 - Refactor listAddons call sites. r=yulia
Adapt to the new returned value of listAddons
and also always call it from RootFront instead of DebuggerClient.
Fix the spec in order to expose reload on the front (it was a miss from a previous patch).

MozReview-Commit-ID: AQ5EOQEqnxX

Depends on D12575

Differential Revision: https://phabricator.services.mozilla.com/D12576

--HG--
extra : moz-landing-system : lando
2018-11-27 19:17:48 +00:00
Alexandre Poirot
78feeeba2d Bug 1506546 - Change the spec type of listAddons and accomodate using the front rather than the form. r=yulia
MozReview-Commit-ID: 4MAjszUiGUZ

Depends on D12573

Differential Revision: https://phabricator.services.mozilla.com/D12574

--HG--
extra : moz-landing-system : lando
2018-11-27 19:18:28 +00:00
Andreea Pavel
772607498b Backed out 7 changesets (bug 1506546) fo failing devtools at devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_system_addons.js on a CLOSED TREE
Backed out changeset fbe3f2183f32 (bug 1506546)
Backed out changeset 8972a2f14015 (bug 1506546)
Backed out changeset 00fe26234b3d (bug 1506546)
Backed out changeset 7d8e650e25c2 (bug 1506546)
Backed out changeset a293a37483b9 (bug 1506546)
Backed out changeset 7b75250a4f12 (bug 1506546)
Backed out changeset 23ad29cb776e (bug 1506546)
2018-11-27 14:37:14 +02:00
Alexandre Poirot
1ecba9148a Bug 1506546 - Refactor listAddons call sites. r=yulia
Adapt to the new returned value of listAddons
and also always call it from RootFront instead of DebuggerClient.
Fix the spec in order to expose reload on the front (it was a miss from a previous patch).

MozReview-Commit-ID: AQ5EOQEqnxX

Depends on D12575

Differential Revision: https://phabricator.services.mozilla.com/D12576

--HG--
extra : moz-landing-system : lando
2018-11-27 11:23:22 +00:00
Alexandre Poirot
31a22e9610 Bug 1506546 - Change the spec type of listAddons and accomodate using the front rather than the form. r=yulia
MozReview-Commit-ID: 4MAjszUiGUZ

Depends on D12573

Differential Revision: https://phabricator.services.mozilla.com/D12574

--HG--
extra : moz-landing-system : lando
2018-11-27 11:23:18 +00:00
Alexandre Poirot
49ef5b5792 Bug 1506548 - Return WorkerTargetFront from listWorkers instead of form. r=yulia
MozReview-Commit-ID: 4CBQNwC8tKq

Depends on D11762

Differential Revision: https://phabricator.services.mozilla.com/D11763

--HG--
extra : moz-landing-system : lando
2018-11-15 10:23:50 +00:00
Alexandre Poirot
a8d8b5dffc Bug 1506545 - Instantiate Target for ContentProcessTargetActor via its front. r=yulia
MozReview-Commit-ID: EE4d0YULRBU

Depends on D11614

Differential Revision: https://phabricator.services.mozilla.com/D11615

--HG--
extra : moz-landing-system : lando
2018-11-13 20:39:58 +00:00
Alexandre Poirot
2bd793e484 Bug 1497467 - Convert AddonClient to protocol.js front. r=yulia
MozReview-Commit-ID: 78Oqsq4mGqW

Differential Revision: https://phabricator.services.mozilla.com/D10391

--HG--
extra : moz-landing-system : lando
2018-11-05 16:16:37 +00:00
Alexandre Poirot
a0551db83f Bug 1497470 - Create a ContentProcessTargetFront front to match ContentProcessTargetActor. r=yulia
MozReview-Commit-ID: LFfG7WRHu3a

Differential Revision: https://phabricator.services.mozilla.com/D10189

--HG--
extra : moz-landing-system : lando
2018-11-05 15:02:10 +00:00
Alexandre Poirot
0b6019ede3 Bug 1499022 - Rename BrowsingContextFront to BrowsingContextTargetFront. r=jdescottes
MozReview-Commit-ID: 4ipRMnu2vkh

Differential Revision: https://phabricator.services.mozilla.com/D9116

--HG--
extra : moz-landing-system : lando
2018-10-30 10:14:20 +00:00
Alexandre Poirot
e4de264d0a Bug 1485661 - Convert RootClient to protocol.js front. r=yulia
MozReview-Commit-ID: 1FfeXpVNYTk

Differential Revision: https://phabricator.services.mozilla.com/D8820

--HG--
rename : devtools/shared/client/root-client.js => devtools/shared/fronts/root.js
extra : moz-landing-system : lando
2018-10-30 08:08:20 +00:00
Mark Banner
ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Alexandre Poirot
6cd123eae4 Bug 1494632 - Convert WorkerClient to protocol.js front. r=jdescottes
MozReview-Commit-ID: BbtEReeG4v9

Depends on D7462

Differential Revision: https://phabricator.services.mozilla.com/D7463

--HG--
extra : moz-landing-system : lando
2018-10-16 09:39:11 +00:00
Alexandre Poirot
4b85a3b27f Bug 1485660 - Adapt DebuggerClient._pools to accept Front's and (now) Pool's. r=jdescottes
MozReview-Commit-ID: EWka8fMBcK5

Depends on D7462

Differential Revision: https://phabricator.services.mozilla.com/D8518

--HG--
extra : moz-landing-system : lando
2018-10-15 08:36:21 +00:00
Alexandre Poirot
e7998a50ec Bug 1485660 - Convert TabClient to a front. r=jdescottes
TabClient appears to be a client for any actor that inherits from browsing context target actor.
So let it be a front for that.

MozReview-Commit-ID: KmpClxJ53N7

Depends on D7457

Differential Revision: https://phabricator.services.mozilla.com/D7458

--HG--
extra : moz-landing-system : lando
2018-10-15 08:36:07 +00:00
Alexandre Poirot
1fd7cbd0a7 Bug 1485660 - Allows calling DebuggerClient.close twice in a row. r=jdescottes
MozReview-Commit-ID: uACM0VtJ5E

Differential Revision: https://phabricator.services.mozilla.com/D7456

--HG--
extra : moz-landing-system : lando
2018-10-15 08:36:03 +00:00
Brindusan Cristian
c328bc1cdf Backed out 8 changesets (bug 1485660) for damp failures on front.hasRequests. CLOSED TREE
Backed out changeset 7a2f29bbe2a8 (bug 1485660)
Backed out changeset 26e82fa62444 (bug 1485660)
Backed out changeset 9bb2f56f219d (bug 1485660)
Backed out changeset 40a3c2dd1b38 (bug 1485660)
Backed out changeset cfb160882db9 (bug 1485660)
Backed out changeset 3642f2d66777 (bug 1485660)
Backed out changeset 9026679753b2 (bug 1485660)
Backed out changeset dccca441b980 (bug 1485660)
2018-10-11 22:33:35 +03:00
Alexandre Poirot
cf0d0480eb Bug 1497644 - Always call Root actor's getProcess request via RootClient.getProcess r=yulia
I also made its argument mandatory, so that later in root spec we can use a non-nullable number.

MozReview-Commit-ID: BUPgI1ww1gC

Differential Revision: https://phabricator.services.mozilla.com/D8141

--HG--
extra : moz-landing-system : lando
2018-10-11 16:26:45 +00:00
Alexandre Poirot
4790bc0138 Bug 1485660 - Convert TabClient to a front. r=jdescottes
TabClient appears to be a client for any actor that inherits from browsing context target actor.
So let it be a front for that.

MozReview-Commit-ID: KmpClxJ53N7

Depends on D7457

Differential Revision: https://phabricator.services.mozilla.com/D7458

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:26 +00:00
Alexandre Poirot
d99221792f Bug 1485660 - Allows calling DebuggerClient.close twice in a row. r=jdescottes
MozReview-Commit-ID: uACM0VtJ5E

Differential Revision: https://phabricator.services.mozilla.com/D7456

--HG--
extra : moz-landing-system : lando
2018-10-11 15:46:22 +00:00
Alexandre Poirot
f2092025cc Bug 1497292 - Switch RootClient calls from callbacks to promises. r=yulia
MozReview-Commit-ID: B1Z3tCjCHU3

Differential Revision: https://phabricator.services.mozilla.com/D8023

--HG--
extra : moz-landing-system : lando
2018-10-09 08:06:10 +00:00
Daisuke Akatsuka
670b00e560 Bug 1494171: Make tabs on android debuggable. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D7258

--HG--
extra : moz-landing-system : lando
2018-10-01 12:48:23 +00:00
Alexandre Poirot
3ad83b9241 Bug 1492856 - Remove compatiblity code to guard against miss of RootActor.getRoot r=jdescottes
MozReview-Commit-ID: L5kkG9r7Rtv

Differential Revision: https://phabricator.services.mozilla.com/D6755

--HG--
extra : moz-landing-system : lando
2018-09-26 21:12:16 +00:00
Alexandre Poirot
e490a53de2 Bug 1492826 - Better document TabTarget.attach as well as DebuggerClient.attachTarget and attachConsole. r=jdescottes
Depends On D6162

Differential Revision: https://phabricator.services.mozilla.com/D6388

--HG--
extra : moz-landing-system : lando
2018-09-24 16:24:07 +00:00
Alexandre Poirot
c7a9923fc3 Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6162

MozReview-Commit-ID: Exz5fWyWyfN
2018-09-24 09:52:59 -07:00
shindli
51a3c01ced Backed out 9 changesets (bug 1485676) for failures in browser/tools/mozscreenshots/devtools/browser_devtools.js CLOSED TREE
Backed out changeset d358feec4ca1 (bug 1485676)
Backed out changeset ed554dbb062f (bug 1485676)
Backed out changeset 6e78058df94d (bug 1485676)
Backed out changeset 3a6f1b0e71f4 (bug 1485676)
Backed out changeset 16d2403aa787 (bug 1485676)
Backed out changeset 454eddf52157 (bug 1485676)
Backed out changeset 926f725f2183 (bug 1485676)
Backed out changeset fb03f174bd5f (bug 1485676)
Backed out changeset ceb93dd1799a (bug 1485676)
2018-09-24 15:27:27 +03:00
Alexandre Poirot
d2897f66aa Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6162

MozReview-Commit-ID: Exz5fWyWyfN
2018-09-24 01:25:03 -07:00
Gurzau Raul
ad28ad0169 Backed out 9 changesets (bug 1485676) for failing at damp inspector/cold-open.js on a CLOSED TREE
Backed out changeset 4de2e71debfe (bug 1485676)
Backed out changeset e63025150c7a (bug 1485676)
Backed out changeset f9ef30ae3f7f (bug 1485676)
Backed out changeset a83636fab16a (bug 1485676)
Backed out changeset b1fd24929e09 (bug 1485676)
Backed out changeset acb27b915742 (bug 1485676)
Backed out changeset ba2157632772 (bug 1485676)
Backed out changeset d1d6b9bc2372 (bug 1485676)
Backed out changeset d7646ea8640b (bug 1485676)
2018-09-22 19:42:04 +03:00
Alexandre Poirot
f98d0997fe Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
Summary:
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Reviewers: yulia!

Tags: #secure-revision

Bug #: 1485676

Differential Revision: https://phabricator.services.mozilla.com/D6162

MozReview-Commit-ID: Exz5fWyWyfN
2018-09-22 08:34:21 -07:00
arthur.iakab
6877b6a75c Backed out 9 changesets (bug 1485676)for perma failures in devtools/client/canvasdebugger/test/browser_canvas-actor-test-01.js CLOSED TREE
Backed out changeset 9f5ec2aa7109 (bug 1485676)
Backed out changeset 0d530c1316a4 (bug 1485676)
Backed out changeset 03278e6fe685 (bug 1485676)
Backed out changeset 275463260056 (bug 1485676)
Backed out changeset 4c5a956b33f7 (bug 1485676)
Backed out changeset d8fe80bb0e3c (bug 1485676)
Backed out changeset 56240996921f (bug 1485676)
Backed out changeset ec0a322f5cc9 (bug 1485676)
Backed out changeset f0f4f9407970 (bug 1485676)
2018-09-21 12:48:48 +03:00
Alexandre Poirot
cffaacada5 Bug 1485676 - Rename DebuggerClient.attachTab to attachTarget. r=jdescottes
This method isn't specific to tabs. It can attach to any "target" actor that inherits from BrowsingContextActor.

Depends On D6161

Differential Revision: https://phabricator.services.mozilla.com/D6162

--HG--
extra : moz-landing-system : lando
2018-09-21 08:08:24 +00:00
Alexandre Poirot
162cf2b6ee Bug 1487337 - Bump devtools compatibility threshold up to 62 (current release version) r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D6252

--HG--
extra : moz-landing-system : lando
2018-09-20 09:11:26 +00:00
Alexandre Poirot
fb4cd85e35 Bug 1222047 - Manage device and preference fronts via client.mainRoot.getFront. r=yulia
Summary: Depends On D3317

Tags: #secure-revision

Bug #: 1222047

Differential Revision: https://phabricator.services.mozilla.com/D3318

MozReview-Commit-ID: 3jaFZbXVLuw
2018-08-23 03:51:40 -07:00
Alexandre Poirot
f68f33087a Bug 1466691 - Replace callback style in favor of promise for TabClient methods. r=jryans
MozReview-Commit-ID: 6Is4O8KQhgY

--HG--
extra : rebase_source : 8987e85385bd202a8e9100a230eff1c1fcdcb4f9
2018-06-05 01:50:40 -07:00
Alexandre Poirot
6f1c06f3e9 Bug 1466691 - Remove useless attachTrace method. r=jryans
MozReview-Commit-ID: KHh57uwJnNI

--HG--
extra : rebase_source : 683d969d41877e18af093fdeef1fc23d4392df76
2018-06-05 01:13:17 -07:00
J. Ryan Stinnett
be021da252 Bug 1172897 - Rename BrowserAddonActor to AddonTargetActor. r=ochameau
MozReview-Commit-ID: 4iI6BQaleJS

--HG--
rename : devtools/server/actors/addon.js => devtools/server/actors/targets/addon.js
extra : rebase_source : f48676bdda8b68226a00cb29c164180526389c4a
2018-06-04 18:37:02 -05:00