Commit graph

13 commits

Author SHA1 Message Date
Alexandre Poirot
9a08694477 Bug 1515862 - Set global and target scope front IDs from getFront helper. r=jdescottes
Ideally, formAttributeName would be a field on the prototype of each front,
but unfortunately, Firefox doesn't support ES Class's fields yet. So it is
put as an instance attribute instead.

This patch streamline the manually set actorID and the retrieval of actor ID
from root or target front's form into `getFront` helper method.
So that all the specific related to the lazy actor is now inside of this helper.
It also moves the special "this.manage(this)" to this helper.
We might be able to followup on this one and finally have only the root front
being self managed. But the initialize method makes it hard.

Note the special tweak made to devtools/client/responsive.html/manager.js
Hopefully this can be removed once the target classes are merged.

Depends on D15832

Differential Revision: https://phabricator.services.mozilla.com/D17615

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:50 +00:00
Alexandre Poirot
10ba88604c Bug 1515116 - Let Front's constructor set the actorID instead of doing it manually. r=jdescottes
Depends on D14915

Differential Revision: https://phabricator.services.mozilla.com/D14916

--HG--
extra : moz-landing-system : lando
2019-01-03 10:20:35 +00:00
Alexandre Poirot
2f8299a363 Bug 1515116 - Remove all useless constructor methods on Fronts. r=jdescottes
Depends on D14914

Differential Revision: https://phabricator.services.mozilla.com/D14915

--HG--
extra : moz-landing-system : lando
2019-01-03 10:09:42 +00:00
Alexandre Poirot
37fcc38aa4 Bug 1510949 - Make protocol.js support es6 classes for fronts. r=yulia
MozReview-Commit-ID: JegR2JsyNrI

Differential Revision: https://phabricator.services.mozilla.com/D13780

--HG--
extra : moz-landing-system : lando
2018-12-11 16:32:41 +00:00
Mark Banner
ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Julian Descottes
640fe52298 Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4

--HG--
extra : rebase_source : 65de1b0aba412d9044b5196115f74276caa058f2
2018-06-01 12:36:09 +02:00
J. Ryan Stinnett
23ff4cc75d Bug 1443081 - Apply spacing via eslint --fix for DevTools. r=jdescottes
MozReview-Commit-ID: 2RVNt140Zte
2018-03-12 13:44:41 -05:00
Sebastian Hengst
cb76f56d60 Backed out changeset 6bc38f188ef2 (bug 1330099) for devtools failures. r=backout 2017-01-11 23:21:56 +01:00
Tim Nguyen
d7ea1c1605 Bug 1330099 - Enable object-shorthand eslint rule. r=jryans
MozReview-Commit-ID: 3wA25rfznBv
2017-01-11 21:22:15 +00:00
Florian Quèze
55f78ce0fa Bug 1329182 - remove trailing newURI null parameters in devtools/, r=jaws. 2017-01-09 20:27:26 +01:00
Eddy Bruel
f389d7ede3 Bug 1295171 - Reintroduce the old Actor/FrontClass constructors. r=jryans
Heintroduce the old Actor/FrontClass constructors.
2016-08-22 16:25:57 +02:00
Eddy Bruel
2bdbd75fa0 Bug 1288423 - Rename Actor/FrontClassWithSpec to Actor/FrontClass. r=fitzgen 2016-08-10 17:36:04 +02:00
Nick Fitzgerald
84bd208e23 Bug 1277673 - Decouple the ActorActorFront and ActorRegistryFront from the ActorActor and ActorRegistryActor respectively; r=ejpbruel 2016-06-03 10:45:10 -07:00