Commit graph

11 commits

Author SHA1 Message Date
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Toby Ward
3b7ee7c100 Bug 1496082: Enable ESLint for docshell/test/navigation and docshell/test/unit (manual fixes) r=bzbarsky
Implemented the manual linting fixes for docshell/test/navigation, docshell/test/unit and docshell/test/unit_ipc
Depends on D9430

Differential Revision: https://phabricator.services.mozilla.com/D10080

--HG--
extra : moz-landing-system : lando
2018-11-07 13:49:05 +00:00
Dorel Luca
6617a8c922 Backed out 2 changesets (bug 1496082) for mochitest faiures in docshell/test/navigation/test_bug270414.html
Backed out changeset 776b54474da9 (bug 1496082)
Backed out changeset 0852730f9ecd (bug 1496082)
2018-11-06 22:40:36 +02:00
Toby Ward
a69d8ab823 Bug 1496082: Enable ESLint for docshell/test/navigation and docshell/test/unit (manual fixes) r=bzbarsky
Implemented the manual linting fixes for docshell/test/navigation, docshell/test/unit and docshell/test/unit_ipc
Depends on D9430

Differential Revision: https://phabricator.services.mozilla.com/D10080

--HG--
extra : moz-landing-system : lando
2018-11-06 17:03:39 +00:00
Bogdan Tara
98c46b95b5 Backed out 2 changesets (bug 1496082) for test_bug270414.html failures CLOSED TREE
Backed out changeset 74780d0a4848 (bug 1496082)
Backed out changeset 4f87e383a807 (bug 1496082)
2018-11-06 17:58:24 +02:00
Toby Ward
dec5a37fbe Bug 1496082: Enable ESLint for docshell/test/navigation and docshell/test/unit (manual fixes) r=bzbarsky
Implemented the manual linting fixes for docshell/test/navigation, docshell/test/unit and docshell/test/unit_ipc
Depends on D9430

Differential Revision: https://phabricator.services.mozilla.com/D10080

--HG--
extra : moz-landing-system : lando
2018-11-06 14:54:38 +00:00
Florian Quèze
032c961e0a Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs. 2017-12-21 11:08:17 +01:00
Florian Quèze
fc6379e827 Bug 1329182 - remove trailing newURI null parameters in the rest of the tree, r=jaws. 2017-01-09 20:27:26 +01:00
Nicholas Hurley
1f3e7e88b7 Bug 1213443 - Parallelism for <link rel=prefetch> r=bz
--HG--
extra : rebase_source : 386f6fb7b4fb5513bb4821ba59d2d205ce9b75b4
2015-10-19 12:46:57 -07:00
Cykesiopka
ca4fe03bf6 Bug 443015 - Remove deprecated nsIPrefetchService methods. r=bz 2013-05-29 20:56:10 -04:00
Dave Camp
bf4b7538a7 Bug 442584 - Prefetching stops working until Firefox is restarted. r=jduell, sr=jst 2009-02-24 23:12:12 -08:00