Commit graph

2120 commits

Author SHA1 Message Date
Andrea Marchesini
1739e25925 Bug 1545758 - Move dom/file IPC components into mozilla::dom namespace - IPCBlobInputStream actors, r=qdot
Differential Revision: https://phabricator.services.mozilla.com/D28191

--HG--
extra : moz-landing-system : lando
2019-04-26 18:04:02 +00:00
Andrea Marchesini
69fd7c57d7 Bug 1545758 - Move dom/file IPC components into mozilla::dom namespace - PendingIPCBlob actors, r=qdot
Differential Revision: https://phabricator.services.mozilla.com/D28189

--HG--
extra : moz-landing-system : lando
2019-04-26 18:01:08 +00:00
Andrea Marchesini
35bde55efd Bug 1534712 - Port FileCreatorHelper to PBackground, r=smaug
FileCreatorHelper creates a FileBlobImpl on the main-thread and, because of
this, we end up executing I/O operations on that thread, slowing down other
components.  With this patch, FileCreatorHelper logic is moved to PBackground.

That the 'type' getter is still called on the main-thread because FileBlobImpl
uses nsIMIMEService which is a non thread-safe component.

Differential Revision: https://phabricator.services.mozilla.com/D27641

--HG--
extra : moz-landing-system : lando
2019-04-26 17:53:07 +00:00
Yaron Tausky
6e39f30075 Bug 1544750 - Part 1: Refactor some IndexedDB code to use ErrorResult r=asuth
This is mostly laying the groundwork for further refactoring.

Differential Revision: https://phabricator.services.mozilla.com/D27666

--HG--
extra : moz-landing-system : lando
2019-04-26 16:53:59 +00:00
Bogdan Tara
240b24fbe1 Backed out 5 changesets (bug 1534712, bug 1545758) for test_ext_webrequest_upload.html failures CLOSED TREE
Backed out changeset 447b0f5a5802 (bug 1545758)
Backed out changeset 0528f8f11814 (bug 1545758)
Backed out changeset d85c68071b54 (bug 1545758)
Backed out changeset 10b380bc5b0c (bug 1545758)
Backed out changeset 57136f4e7b54 (bug 1534712)
2019-04-25 12:36:51 +03:00
Andrea Marchesini
3512672cd3 Bug 1545758 - Move dom/file IPC components into mozilla::dom namespace - IPCBlobInputStream actors, r=qdot
Differential Revision: https://phabricator.services.mozilla.com/D28191

--HG--
extra : moz-landing-system : lando
2019-04-25 07:44:47 +00:00
Andrea Marchesini
50fa1de562 Bug 1545758 - Move dom/file IPC components into mozilla::dom namespace - PendingIPCBlob actors, r=qdot
Differential Revision: https://phabricator.services.mozilla.com/D28189

--HG--
extra : moz-landing-system : lando
2019-04-25 07:44:03 +00:00
Andrea Marchesini
cbdda85d6e Bug 1534712 - Port FileCreatorHelper to PBackground, r=smaug
FileCreatorHelper creates a FileBlobImpl on the main-thread and, because of
this, we end up executing I/O operations on that thread, slowing down other
components.  With this patch, FileCreatorHelper logic is moved to PBackground.

That the 'type' getter is still called on the main-thread because FileBlobImpl
uses nsIMIMEService which is a non thread-safe component.

Differential Revision: https://phabricator.services.mozilla.com/D27641

--HG--
extra : moz-landing-system : lando
2019-04-25 07:41:10 +00:00
Brindusan Cristian
f92b05e5f0 Merge inbound to mozilla-central. a=merge
--HG--
rename : dom/ipc/TabParent.cpp => dom/ipc/BrowserParent.cpp
2019-04-25 00:54:01 +03:00
Tom Tung
b20f7ff351 Bug 1481164 - Dispatch to the Background thread even when the Connection is a nullptr in IdleConnectionRunnable::Run(); r=janv
Differential Revision: https://phabricator.services.mozilla.com/D28520

--HG--
extra : moz-landing-system : lando
2019-04-23 18:05:41 +00:00
Tom Tung
b3aba7b188 Bug 1528690 - P3 - Change more assertions to diagnostic assertion to get more information on Nightly; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D28455

--HG--
extra : moz-landing-system : lando
2019-04-23 13:25:23 +00:00
Sylvestre Ledru
a1dce6440a Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D28329

--HG--
extra : moz-landing-system : lando
2019-04-22 16:35:03 +00:00
Ryan Hunt
d6509bb237 Bug 1534395 - Rename TabChild to BrowserChild. r=nika
This commit renames TabChild to BrowserChild.

Differential Revision: https://phabricator.services.mozilla.com/D28135

--HG--
rename : dom/base/InProcessTabChildMessageManager.cpp => dom/base/InProcessBrowserChildMessageManager.cpp
rename : dom/base/InProcessTabChildMessageManager.h => dom/base/InProcessBrowserChildMessageManager.h
rename : dom/ipc/TabChild.cpp => dom/ipc/BrowserChild.cpp
rename : dom/ipc/TabChild.h => dom/ipc/BrowserChild.h
extra : rebase_source : e7fcfb845a971a2760e73d517e24da18ce2551b5
extra : histedit_source : d1991334ccb107fe56e478865f22fd97b041a317
2019-04-09 17:39:01 -05:00
Ryan Hunt
0eeced87be Bug 1534395 - Rename TabParent to BrowserParent. r=nika
This commit renames TabParent to BrowserParent.

Differential Revision: https://phabricator.services.mozilla.com/D28133

--HG--
rename : dom/ipc/TabParent.cpp => dom/ipc/BrowserParent.cpp
rename : dom/ipc/TabParent.h => dom/ipc/BrowserParent.h
extra : rebase_source : d2706b9f42177d8de16068b7b1d088a44b8720a4
extra : histedit_source : a617ddac45c58050ef799116a67d2d983f2a8f6d%2C1d1dabd8761a32d548a6fbf1027be960698f6a5e
2019-04-09 16:38:15 -05:00
Ciure Andrei
77a04f415d Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2019-04-24 01:23:49 +03:00
Kris Maglione
c9ee4462eb Bug 1546500: Avoid dispatching synchronous thread shutdown runnables. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D28555

--HG--
extra : rebase_source : 49c83199d51c208922bf55277a7d6052a36c199a
extra : amend_source : 6d2d246159d23723d24c0327e6adbf975545d7bd
2019-04-23 13:16:15 -07:00
violet
4e74fce92e Bug 1499854 - Binary should not be affected by locale r=asuth
Key::ToLocaleBasedKey() overlooked the existence of |eBinary| type,
probably because |eBinary| was added later and the code wasn't updated
properly.

Differential Revision: https://phabricator.services.mozilla.com/D24882

--HG--
extra : moz-landing-system : lando
2019-04-20 01:34:50 +00:00
Tom Tung
96cc526deb Bug 1528690 - P2 - Change some assertions to diagnostic assertion to get more information on Nightly; r=asuth
Depends on D28148

Differential Revision: https://phabricator.services.mozilla.com/D28149

--HG--
extra : moz-landing-system : lando
2019-04-19 14:35:33 +00:00
Tom Tung
8e88ce043f Bug 1528690 - P1 - Mitigate the issue by checking the pointer before accessing it; r=asuth
The real problem is because the connection was closed for some reason. This
patch won't resolve the issue by only let the operation and the transaction fail
to escape from the crash. Note that it also changing an assertion when the
transaction is either commiting or aborting. This is prevent the problem for
closing connection is worser than we expected.

Differential Revision: https://phabricator.services.mozilla.com/D28148

--HG--
extra : moz-landing-system : lando
2019-04-19 14:32:53 +00:00
Andreea Pavel
e5b695eefd Merge mozilla-inbound to mozilla-central. a=merge 2019-04-19 00:36:23 +03:00
Brian Grinstead
7ab932d712 Bug 1544051 - Part 2 - Remove some references to AddTask.js that aren't caught by the script in part 3 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D27760

--HG--
extra : moz-landing-system : lando
2019-04-18 16:50:39 +00:00
Bogdan Tara
a14816abd2 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2019-04-18 00:49:46 +03:00
violet
10f7f3704a Bug 1509168 - Use JS_GetObjectAsArrayBufferView() to retrieve ArrayBufferView data r=asuth
When using JS_IsArrayBufferViewObject() to check ArrayBufferView object,
we should use JS_GetObjectAsArrayBufferView() to get its length and data.
Because in rare case there might be a wrapper on the object, JS_GetObjectAsArrayBufferView()
will handle it, js::GetArrayBufferViewLengthAndData() won't.

Differential Revision: https://phabricator.services.mozilla.com/D24009

--HG--
extra : moz-landing-system : lando
2019-04-17 12:59:20 +00:00
violet
0a2e5d2dc2 Bug 1505821 - DeserializeFromString should append an empty string for a trailing comma r=asuth
KeyPath [..., ''] will be serialized to have a trailing comma, when deserializing it, we should
append back the empty string. Otherwise we will get inconsistent result with the KeyPath::Parse() method, causing assertions failure.

Differential Revision: https://phabricator.services.mozilla.com/D24724

--HG--
extra : moz-landing-system : lando
2019-04-17 12:52:46 +00:00
Jan Varga
bb200f7d87 Bug 1541771 - LSNG: Don't cache usage in InitOrigin if it's not for temporary storage initialization; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D27490
2019-04-15 13:35:38 +02:00
Brian Grinstead
c4fa4cfc0c Bug 1544322 - Part 4 - Remove the [type] attribute for multiline <script> tags loading files in /tests/SimpleTest/ r=bzbarsky
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the case where the script src is on the line below the script tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 4` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27459

--HG--
extra : moz-landing-system : lando
2019-04-16 04:01:46 +00:00
Brian Grinstead
911776d674 Bug 1544322 - Part 3 - Remove the [type] attribute for multiline <script> tags loading files in chrome://mochikit/content/ r=bzbarsky
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the case where the script src is on the line below the script tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 3` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27458

--HG--
extra : moz-landing-system : lando
2019-04-16 03:59:25 +00:00
Brian Grinstead
0d460e3432 Bug 1544322 - Part 2.2 - Remove the [type] attribute for one-liner <script> tags loading files in /tests/SimpleTest/ in dom/ r=bzbarsky
This is split from the previous changeset since if we include dom/ the file size is too
large for phabricator to handle.

This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 2` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27457

--HG--
extra : moz-landing-system : lando
2019-04-16 03:53:28 +00:00
Jan Varga
4a63e6637b Bug 1539393 - TransactionDatabaseOperationBase::ActorDestroy doesn't check if we are waiting for the Continue message; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D27429
2019-04-13 16:52:29 +02:00
Andrea Marchesini
bd74d6c75d Bug 1536411 - StoragePrincipal - part 3 - IDBFactory, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D24027

--HG--
extra : moz-landing-system : lando
2019-04-12 05:31:13 +00:00
Jan Varga
9581f4b34a Bug 1543089 - IDB: Detect missing unregister calls for live databases and factory ops using CheckedUnsafePtr; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D26716
2019-04-09 15:48:20 +02:00
Jan Varga
2001874a68 Bug 1542541 - FactoryOp::ActorDestroy needs to do cleanup if the actor was waiting for the PermissionRetry message; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D26433
2019-04-06 23:27:07 +02:00
Sylvestre Ledru
03c8e8c2dd Bug 1519636 - clang-format-8: Reformat recent changes to the Google coding style r=Ehsan
clang-format-8 upstream had some improvements wrt macros
See: https://reviews.llvm.org/D33440
This is why the diff is bigger than usual

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D26098

--HG--
extra : moz-landing-system : lando
2019-04-05 21:41:42 +00:00
Jan Varga
d99e1a2b0c Bug 1538619 - TransactionDatabaseOperationBase::SendFailureResult not called if the actor has been destroyed; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D24744
2019-03-25 19:11:01 +01:00
Jan Varga
0269846741 Bug 1540668 - IDB: Add a timer for ShutdownWorkThreads; r=asuth, dr=chutten
Differential Revision: https://phabricator.services.mozilla.com/D25745
2019-04-02 13:16:55 +02:00
Eden Chuang
72b79c6fbd Bug 1442778 - Add "chromeContext" parameter to console API and console service messages. r=smaug
1. Adding a new attribute chromeContext in ConsoleEvent
2. Adding a new boolean attribute isFromChromeContext in nsIConsoleMessage
3. Sending IsFromChromeContext to the parent process

Differential Revision: https://phabricator.services.mozilla.com/D23330

--HG--
extra : moz-landing-system : lando
2019-04-01 22:42:34 +00:00
Andrea Marchesini
484db81418 Bug 1455020 - Extend CheckInnerWindowCorrectness() to check the state of the worker, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25486

--HG--
extra : moz-landing-system : lando
2019-04-01 16:46:46 +00:00
Andrea Marchesini
da174a4757 Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 18:05:11 +00:00
Daniel Varga
7af208ab28 Backed out changeset 98452610cfcc (bug 1539407) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE
--HG--
extra : histedit_source : 236c5d6a7a4440a7b545c1ec5a0a72a8c5777b6b
2019-03-29 18:01:58 +02:00
Andrea Marchesini
788d12712b Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D25041

--HG--
extra : moz-landing-system : lando
2019-03-29 14:12:04 +00:00
Oana Pop Rus
226e6c59d9 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-03-28 12:23:56 +02:00
Oana Pop Rus
47e94b5d6e Merge inbound to mozilla-central. a=merge 2019-03-28 12:11:35 +02:00
Mark Banner
dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:14 +00:00
Andrew McCreight
dcf186c6a2 Bug 1539261, part 1 - IndexedDB changes. r=asuth
The second place doesn't return an error because that's what some
earlier code in the method does. Hopefully that is ok.

Differential Revision: https://phabricator.services.mozilla.com/D24991

--HG--
extra : moz-landing-system : lando
2019-03-27 20:41:10 +00:00
arthur.iakab
7ae8fb76e1 Backed out 2 changesets (bug 1539261) for multiple build bustages on /fuzz-tests/testStructuredCloneReader.cpp CLOSED TREE
Backed out changeset 526daf87fff9 (bug 1539261)
Backed out changeset 5b070b6ae224 (bug 1539261)
2019-03-27 21:59:29 +02:00
Andrew McCreight
bef5751910 Bug 1539261, part 1 - IndexedDB changes. r=asuth
The second place doesn't return an error because that's what some
earlier code in the method does. Hopefully that is ok.

Differential Revision: https://phabricator.services.mozilla.com/D24991

--HG--
extra : moz-landing-system : lando
2019-03-27 19:34:44 +00:00
Jan Varga
2b16bbc8e9 Bug 1534202 - Don't schedule a file deletion after quota client shutdown; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D24970
2019-03-26 21:49:40 +01:00
Cosmin Sabou
78fc71e3c3 Backed out changeset 7fa7d6e6dedc (bug 1442778) for devtools failures on browser_webconsole_check_stubs_console_api.js CLOSED TREE 2019-03-26 20:27:55 +02:00
Eden Chuang
5e4df764d9 Bug 1442778 - Add "chromeContext" parameter to console API and console service messages. r=smaug
1. Adding a new attribute chromeContext in ConsoleEvent
2. Adding a new boolean attribute isFromChromeContext in nsIConsoleMessage
3. Sending IsFromChromeContext to the parent process

Differential Revision: https://phabricator.services.mozilla.com/D23330

--HG--
extra : moz-landing-system : lando
2019-03-26 15:18:20 +00:00
Ian Moody
fe4fab15e3 Bug 1537776 - dom/ automated ESLint no-throw-literal fixes. r=asuth,mccr8
Result of running:
$ mach eslint -funix dom/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24369

--HG--
extra : moz-landing-system : lando
2019-03-25 16:03:38 +00:00