Commit graph

66 commits

Author SHA1 Message Date
Jorg K
15ee3d3e8f Bug 1527236 - Allow % in URLs for Thunderbird. r=valentin 2019-02-12 18:43:30 +01:00
Valentin Gosu
08d4ca8e92 Bug 1517025 - Do not allow percent symbol in URL hostnames r=kershaw
Differential Revision: https://phabricator.services.mozilla.com/D16694

--HG--
extra : moz-landing-system : lando
2019-02-11 21:49:19 +00:00
Margareta Eliza Balazs
ca2235a67e Backed out 4 changesets (bug 1517025) for multiple failures e.g.: toolkit/components/telemetry/tests/unit/test_PingAPI.js CLOSED TREE
Backed out changeset 1e173178e49f (bug 1517025)
Backed out changeset c29889dea969 (bug 1517025)
Backed out changeset 48c7d643d2fa (bug 1517025)
Backed out changeset 419cb778d531 (bug 1517025)
2019-01-21 16:13:56 +02:00
Valentin Gosu
e6aa11c264 Bug 1517025 - Do not allow percent symbol in URL hostnames r=kershaw
Differential Revision: https://phabricator.services.mozilla.com/D16694

--HG--
extra : moz-landing-system : lando
2019-01-21 08:39:34 +00:00
Valentin Gosu
1c5f254e6b Bug 1495313 - Allow password with empty username in URLs r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D11254

--HG--
extra : moz-landing-system : lando
2018-11-14 19:10:42 +00:00
Andreea Pavel
7c4a91dd37 Backed out changeset 9ad299b5161b (bug 1495313) for failing mochitest dom/security/test/cors/test_CrossSiteXHR.html on a CLOSED TREE 2018-11-14 20:55:00 +02:00
Valentin Gosu
3777cffb41 Bug 1495313 - Allow empty username in URLs r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D11254

--HG--
extra : moz-landing-system : lando
2018-11-14 15:24:21 +00:00
Mark Banner
82aadc6ada Bug 1470455 - Add the 'expected' arguments to throws/rejects for netwerk. r=mcmanus
MozReview-Commit-ID: 40K0YkBQfue

--HG--
extra : rebase_source : 22276acde28f0152963324d176e6925e9b69f374
2018-06-21 17:08:24 +01:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Valentin Gosu
ed218f0a19 Bug 1433958 - Change code that sets nsIURI.scheme to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: GgyIkZSG2y3

--HG--
extra : rebase_source : 5398a29d8cb910c909ed88e1a6cbd9fd63e6b745
2018-02-26 20:43:47 +01:00
Valentin Gosu
2a78b51a84 Bug 1433958 - If setting the host succeeds, SetHostPort should not return an error code r=mayhemer
WebPlatformTests expect that when calling
url.host = "host:" // port missing
url.host = "host:65536" // port too big
url.host = "host:bla" // invalid port
that the hostname will be set, but the port will be left unchanged.
Since DOM APIs are the only consumers for SetHostPort it means we can change this behaviour to match the WPT expectations.
As such, SetHostPort will return NS_OK if setting the host succeded, and will ignore if setting the port failed.

MozReview-Commit-ID: LoMw8hCWlCv

--HG--
extra : rebase_source : db28b73d98060c2f66f899afe1a4ae26f4db85db
2018-02-26 20:43:47 +01:00
Valentin Gosu
27e9e0be9f Bug 1433958 - Change code that sets nsIURI.host to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: 7T5gCu8WOfa

--HG--
extra : rebase_source : 752c34e5f9dde2e16fc9243c11860b987acbcb93
2018-02-26 20:43:47 +01:00
Valentin Gosu
ec9082b60a Bug 1433958 - Change code that sets nsIURI.query to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: JKW8IsaFY10

--HG--
extra : rebase_source : 45ffa07c34739adf4de681fec1370645b0f74985
2018-02-26 20:43:46 +01:00
Valentin Gosu
4c1c2d2005 Bug 1433958 - Change code that sets nsIURI.ref to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: 4caicZFBkcQ

--HG--
extra : rebase_source : fe32f156392a9e0ce69fa6030278eaca43a69482
2018-02-26 20:43:46 +01:00
Valentin Gosu
139db586dc Bug 1433958 - Don't fail when setting an empty password if the username is already empty r=mayhemer
We normally fail in nsStandardURL::SetPassword if the username is empty.
But if the password we are trying to set is also empty, we should't really fail.

MozReview-Commit-ID: FIDqkPrb1gp

--HG--
extra : rebase_source : 9080c44e91e27acd210f3ace3a234528513928c3
2018-02-26 20:43:46 +01:00
Valentin Gosu
55537212a8 Bug 1433958 - Change code that sets nsIURI.password to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: I8igxClMM5L

--HG--
extra : rebase_source : edca02a7b10ab2e9f5f5498a1164890b9aa75985
2018-02-26 20:43:46 +01:00
Valentin Gosu
8617010c5f Bug 1433958 - Change code that sets nsIURI.username to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: 7E63pAIOZCs

--HG--
extra : rebase_source : 54164efbc967146f4811552498aea5e5db1edfc2
2018-02-26 20:43:46 +01:00
Valentin Gosu
84b854ce2c Bug 1433958 - Change code that sets nsIURI.userPass to use nsIURIMutator r=mayhemer
* Code in XMLHttpRequestMainThread is converted to set the username and password individually. This is because when the parameters are empty, it ended up calling SetUserPass(":") which always returns an error.

MozReview-Commit-ID: 3cK5HeyzjFE

--HG--
extra : rebase_source : f34400c11245d88648b0ae9c196637628afa9517
2018-02-26 20:43:46 +01:00
Valentin Gosu
710c2e2fc9 Bug 1433958 - Change code that sets nsIURI.filePath to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: GYHpakKPEbe

--HG--
extra : rebase_source : 521966b446284fbe215dfc8518acafc5de9ded5c
2018-02-26 20:43:45 +01:00
Valentin Gosu
7bd0336d01 Bug 1433958 - Change code that sets nsIURI.pathQueryRef to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: HVyZ3E1XuLN

--HG--
extra : rebase_source : fd122b3122e0f3eb371d429bd86ad35d09dcfbf6
2018-02-26 20:43:45 +01:00
Valentin Gosu
b563071323 Bug 1433958 - Change code that uses nsIURI.hostPort to use nsIURIMutator r=mayhemer
MozReview-Commit-ID: IuUurzUP5Rw

--HG--
extra : rebase_source : 5c1fd0938613247b6bb24ef11b57307f3bf24fae
2018-02-26 20:43:45 +01:00
Valentin Gosu
7183e543b2 Bug 1432320 - (Part 2) Change calls to nsIURL.{fileName,fileBaseName,fileExtension} setters to use nsIURLMutator r=mayhemer
MozReview-Commit-ID: D5aTl1i14gI

--HG--
extra : rebase_source : 6d4a8606da971426c554c31d188567cf1e6c8741
2018-01-31 02:33:06 +01:00
Valentin Gosu
b53812bfed Bug 1432187 - Change code to use nsIStandardURLMutator.{init,setDefaultPort} r=mayhemer
MozReview-Commit-ID: K2Uy9ET3Ay6

--HG--
extra : rebase_source : fb5e19bc7b71a6f0264471bf8f07febf1bc55900
2018-01-24 20:33:02 +01:00
Valentin Gosu
da90b10e9f Bug 1431204 - Change calls to nsIURI.spec setter to use nsIURIMutator instead r=mayhemer
* changes call to use nsIURIMutator.setSpec()
* Add new NS_MutateURI constructor that takes new Mutator object
* Make nsSimpleNestedURI::Mutate() and nsNestedAboutURI::Mutate() return mutable URIs
* Make the finalizers for nsSimpleNestedURI and nsNestedAboutURI make the returned URIs immutable

MozReview-Commit-ID: 1kcv6zMxnv7

--HG--
extra : rebase_source : 99b13e9dbc8eaaa9615843b05e1539e19b527504
2018-01-19 15:19:42 +01:00
Valentin Gosu
f943b98a02 Bug 1426501 - Change JS code to use nsIURIMutator instead of the nsIURI.spec setter r=mayhemer
MozReview-Commit-ID: FI6WrsQT2ke

--HG--
extra : rebase_source : 2b286c47c19ebd112a0c47fbe0a4c23bdb04755f
2018-01-08 15:20:29 +01:00
Florian Quèze
0f55cd45be Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs. 2017-12-21 11:10:23 +01:00
Florian Quèze
032c961e0a Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs. 2017-12-21 11:08:17 +01:00
Valentin Gosu
b3e75dbf06 Bug 1386683 - Do not escape the ' character in the URL hash r=junior
MozReview-Commit-ID: DkoDvWGbWfu

--HG--
extra : rebase_source : 22de804e82136114a0688ce271cac8c49f8c4f23
2017-08-06 11:13:04 +02:00
Masatoshi Kimura
f143125cc2 Bug 1326520 - Rename nsIURI.path to pathQueryRef. r=valentin.gosu
MozReview-Commit-ID: DqJdTGopR9G

--HG--
extra : rebase_source : e8c9eb03468c075b79013b6e0bd8b367229c24cd
2017-07-29 20:50:21 +09:00
Valentin Gosu
da0fc06913 Bug 1386195 - mDisplayHost must be initalized even when host does not start with xn-- r=dragana
MozReview-Commit-ID: HnDqw8oyE2r
2017-08-01 14:24:53 +03:00
Valentin Gosu
6f0b819964 Bug 1385883 - nsStandardURL - make sure we always check if the host is ascii r=jduell
SetRef and several other methods call InvalidateCache, which in turn sets mCheckedIfHostA to false.
That means that each time before trying to access mDisplayHost we need to make sure it is properly initalized.

MozReview-Commit-ID: Agtsy6Lx7Nb
2017-08-01 01:51:48 +03:00
Valentin Gosu
2a645b1ab7 Bug 945240 - Add unit test for new behaviour r=mcmanus,smaug
MozReview-Commit-ID: In47wgDKbhR

--HG--
extra : rebase_source : 8dc68e6e82152b232ffe13f985c65a014563a052
2017-07-11 19:10:37 +02:00
Valentin Gosu
e0f474ede9 Bug 1326175 - Stop preserving empty passwords in URLs r=mcmanus
MozReview-Commit-ID: 7wdZSJmpErF

--HG--
extra : rebase_source : 100061a5c1921f1a10cf339207548aceb3afbe49
2017-03-27 23:56:28 +02:00
Valentin Gosu
5847af980b Bug 1324243 - Normalize IPv6 r=manishearth
MozReview-Commit-ID: 1UFIdeWrz1E

--HG--
extra : rebase_source : cb7e44b0afe06426e3268e80d94a2f59af633b9b
2017-03-09 00:55:05 +01:00
Carsten "Tomcat" Book
a25648d3cd Backed out changeset 189b914221f4 (bug 1324243) for wpt-11 bustage 2017-03-06 14:13:03 +01:00
Valentin Gosu
0cb0b2702b Bug 1324243 - Normalize IPv6 r=manishearth
MozReview-Commit-ID: Kxe9eLqvKp6

--HG--
extra : rebase_source : 195cafb81adeb9d5fa0a84535144debe1b26f6ff
2017-03-01 00:01:15 +01:00
Junior Hsu
a9616aa8f5 Bug 1338154 - not normalize ipv4 for resource and chrome uri. r=valentin 2017-02-13 03:10:00 +08:00
Valentin Gosu
f2fd6230e6 Bug 1337629 - Restrict allowed hostname characters r=mcmanus
MozReview-Commit-ID: H8u2C5oSiT9
2017-02-09 01:55:49 +01:00
Valentin Gosu
ff510f7133 Bug 1275746 - Don't allow empty host name for URLTYPE_AUTHORITY URLs r=mcmanus
* Return NS_ERROR_MALFORMED_URI if mURLType is URLTYPE_AUTHORITY and the hostname is empty.
* Make sure nsStandardURL::SetFile calls init with the correct arguments

MozReview-Commit-ID: 7t3mZtAbMF3
2016-07-07 15:06:08 +03:00
Valentin Gosu
627f600a3e Bug 1314859 - SetHost should also call NormalizeIPv4 r=mcmanus
MozReview-Commit-ID: 79sQrld6TBG
2016-11-06 23:26:04 +01:00
Valentin Gosu
3a14f83970 Bug 1305204 - (Part 3) Backout bug 1275746 a=backout
MozReview-Commit-ID: B627xyv9BRm
2016-10-23 14:24:49 +02:00
Thomas Wisniewski
0748df2882 Bug 1302312 - Treat URLs with username or password but no host info as malformed. r=valentin
--HG--
extra : rebase_source : 24fdcd9682cbcc3bb6850bf7708ea859264f4661
2016-09-13 12:47:16 -04:00
Junior Hsu
df4fd78a0e Bug 1190027 - Test setters for tab and newline. r=valentin
--HG--
extra : rebase_source : e76167e426468700c7cdda5d3abb64979ae8dd4b
2016-08-18 03:15:00 -04:00
Junior Hsu
5536544c0b Bug 1288049 - Canonicalize IPv4 for nsStandardURL, r=valentin 2016-08-09 03:18:00 +02:00
Valentin Gosu
c6165ca8ee Bug 1288482 - Backout bug 1042347. r=mcmanus
MozReview-Commit-ID: J3LmMfQ854V
2016-07-24 23:35:12 +02:00
Valentin Gosu
eaee61d467 Bug 1275746 - Don't allow empty host name for URLTYPE_AUTHORITY URLs r=mcmanus
* Return NS_ERROR_MALFORMED_URI if mURLType is URLTYPE_AUTHORITY and the hostname is empty.
* Make sure nsStandardURL::SetFile calls init with the correct arguments

MozReview-Commit-ID: 7t3mZtAbMF3
2016-07-13 15:19:33 +03:00
Valentin Gosu
fa4080a0a7 Bug 1272284 - Encode C0 controls in path, query and hash r=mcmanus
MozReview-Commit-ID: 1zGRjVmAWts
2016-05-25 16:23:38 +02:00
Valentin Gosu
78d21aba95 Bug 1271955 - Strip leading and trailing C0 controls and space for urls passed to new URL() r=mcmanus
MozReview-Commit-ID: B7BiKE6P7GA
2016-05-25 16:23:37 +02:00
Valentin Gosu
1863d8b9cd Bug 652186 - Implement URL Standard's backslash replacement r=mcmanus
* * *
[mq]: test

MozReview-Commit-ID: JAZ36DstjFs

--HG--
extra : rebase_source : ccce437c84a15319fa05db4c14c5d784b66f6638
2016-03-03 15:50:16 +01:00
Valentin Gosu
9980689593 Bug 1042347 - %2e entered in URL bar not normalized leading to denormalized request r=mcmanus 2016-02-10 13:13:23 +01:00