Automatic update from web-platform-tests
Added two new test to evaluate the break-word+break-spaces combination. (#16124)
--
wpt-commits: add24188a1226f3598ad6b455e71641c9ac6a5fd
wpt-pr: 16124
Automatic update from web-platform-tests
Use Ahem for these tests. (#16137)
Safari renders incorrectly these cases due to a bug (https://webkit.org/b/196169) when using monospace font.
--
wpt-commits: 3ad4a3b1dfbb5199cb6e60ef5981a63afc5c438d
wpt-pr: 16137
Automatic update from web-platform-tests
Fixed some typos and mistakes in the css-text WTP test suite
Typos and formatting changes mostly, but also some errors related to the
line-height property that caused errors in Firefox.
Change-Id: Ieac66a25511dbd3386d6a737b63dfbd5e677ec2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538189
Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#643832}
--
wpt-commits: 0b2be811fa3587838fdb1399195610a176de3872
wpt-pr: 16058
Automatic update from web-platform-tests
Added two new test to evaluate the break-word+break-spaces combination. (#16124)
--
wpt-commits: add24188a1226f3598ad6b455e71641c9ac6a5fd
wpt-pr: 16124
Automatic update from web-platform-tests
Use Ahem for these tests. (#16137)
Safari renders incorrectly these cases due to a bug (https://webkit.org/b/196169) when using monospace font.
--
wpt-commits: 3ad4a3b1dfbb5199cb6e60ef5981a63afc5c438d
wpt-pr: 16137
Automatic update from web-platform-tests
Fixed some typos and mistakes in the css-text WTP test suite
Typos and formatting changes mostly, but also some errors related to the
line-height property that caused errors in Firefox.
Change-Id: Ieac66a25511dbd3386d6a737b63dfbd5e677ec2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538189
Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#643832}
--
wpt-commits: 0b2be811fa3587838fdb1399195610a176de3872
wpt-pr: 16058
Automatic update from web-platform-tests
Remove inactive reviewers (#14798)
This removes reviewers who have had more than three review requests in
the past year but who haven't reviewed anything.
Adds a few extra reviewers based on discussions in the PR thread
looking for reviewers for directories that otherwise would've ended up
with none.
--
wpt-commits: a5f707c18b3d893a6e332994064911c2f11e800d
wpt-pr: 14798
Automatic update from web-platform-tests
Updated the css-text test suite
Added a few additional tests to verify some leading white-space cases
with different properties.
Fixed also some typos and bad design choices in some tests.
Change-Id: Ic702d9ce4bd969408c4760724f1f9d4a1f6eb6fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520829
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#640320}
--
wpt-commits: 5883163db70d3401826497db01908f8a0f5138d9
wpt-pr: 15813
(The tests currently fail on macOS using mozilla CI because of the old version of macOS present there,
which has an emoji font that doesn't support some of these sequences. On macOS 10.13, the tests pass
as expected, so the failure annotations are temporary until the test environment is updated in bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1530474.)
Depends on D25101
Differential Revision: https://phabricator.services.mozilla.com/D25102
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
[LayoutNG] Fix 3 cases of break opportunities after nowrap
This patch fixes lines to break in the following conditions:
1. When wrappable elements appear inside of nowrap elements.
2. When wrappable spaces after nowrap appear inside of nowrap
elements.
3. When non-space break opportunities appear after nowrap.
fast/text/whitespace/018.html improves but still doesn't pass.
It doesn't pass in Edge/Gecko, and at least some of what it
expects look questionable. Further investigation is deferred
to future CLs.
Bug: 920177
Change-Id: Ieba4d446b818120f423b87a7f4a44b3c63a9d995
Reviewed-on: https://chromium-review.googlesource.com/c/1477629
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635180}
--
wpt-commits: 67e1c4c4f8a43d17bcf89b6f5a197d21765f4b46
wpt-pr: 15509
Automatic update from web-platform-tests
[LayoutNG] Fix 3 cases of break opportunities after nowrap
This patch fixes lines to break in the following conditions:
1. When wrappable elements appear inside of nowrap elements.
2. When wrappable spaces after nowrap appear inside of nowrap
elements.
3. When non-space break opportunities appear after nowrap.
fast/text/whitespace/018.html improves but still doesn't pass.
It doesn't pass in Edge/Gecko, and at least some of what it
expects look questionable. Further investigation is deferred
to future CLs.
Bug: 920177
Change-Id: Ieba4d446b818120f423b87a7f4a44b3c63a9d995
Reviewed-on: https://chromium-review.googlesource.com/c/1477629
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635180}
--
wpt-commits: 67e1c4c4f8a43d17bcf89b6f5a197d21765f4b46
wpt-pr: 15509
Automatic update from web-platform-tests
Make Japanese linebreaking tests more robust against rounding
These tests were comparing offsetLeft, but there were pixel differences
which made some of the tests fails. Using a less than 1
getClientBoundingRect().left difference instead, cleaning up the code
and removing expectations file due to these robustly passing now. The
pixel differences are not relevant to the intention of the test.
Bug: 927287
Change-Id: I5235489457183aa7a3ea25b40ccfa96dfef3f980
Reviewed-on: https://chromium-review.googlesource.com/c/1448451
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627998}
--
wpt-commits: 74449e61abd3b495373253f83dd0d5638668e79d
wpt-pr: 15187
Automatic update from web-platform-tests
Make Chinese linebreaking tests more robust against rounding
These tests were comparing offsetLeft, but there were pixel differences
which made some of the tests fails. Using a less than 1
getClientBoundingRect().left difference instead, cleaning up the code
and removing expectations file due to these robustly passing now. The
pixel differences are not relevant to the intention of the test.
Bug: 927287
Change-Id: I74fe8d64edb1a52de4fd0dbb3143843b305f8156
Reviewed-on: https://chromium-review.googlesource.com/c/1448215
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627968}
--
wpt-commits: 7a7d3b23c4fdec31f85ca1083c91dffe6ecf67c7
wpt-pr: 15184
Automatic update from web-platform-tests
Reland [css-text] New value 'break-spaces' for the white-space property
This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea
The build failure that caused the revert has been fixed in
https://crrev.com/c/1430010TBR=kojii@chromium.org
Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] https://github.com/w3c/csswg-drafts/pull/2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}
Bug: 767634
Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4
Reviewed-on: https://chromium-review.googlesource.com/c/1415254
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#625718}
--
wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2
wpt-pr: 15042
Automatic update from web-platform-tests
[css-text] Parsing of CSS Text properties (#14962)
Test that CSS Text 3 properties accept the grammar
from the specification
https://www.w3.org/TR/css-text-3/#property-index
--
wpt-commits: ad7a8f60ff24f1acf7e4a7e3acdf9fd1ebe70b2d
wpt-pr: 14962
Automatic update from web-platform-tests
Revert "[css-text] New value 'break-spaces' for the white-space property"
This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550
Sample Failed Step: compile
Original change's description:
> [css-text] New value 'break-spaces' for the white-space property
>
> Finally the CSS WG decided [1] to move back the 'break-spaces' value to
> the 'white-space' property. This makes the parsing logic easier than
> the previous approach of using the 'overflow-wrap' property.
>
> This new value prevents the white-space sequence to collapse and gives
> breaking opportunities after every preserved white-space.
>
> https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>
> Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
> end of a line cannot be hung or visually collapsed, since we want them
> to be preserved and broken.
>
> [1] https://github.com/w3c/csswg-drafts/pull/2841
>
> Bug: 767634
> Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
> Reviewed-on: https://chromium-review.googlesource.com/c/1136543
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#623324}
Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 767634
Reviewed-on: https://chromium-review.googlesource.com/c/1415914
Cr-Commit-Position: refs/heads/master@{#623339}
--
wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764
wpt-pr: 14904
Automatic update from web-platform-tests
[css-text] New value 'break-spaces' for the white-space property
Finally the CSS WG decided [1] to move back the 'break-spaces' value to
the 'white-space' property. This makes the parsing logic easier than
the previous approach of using the 'overflow-wrap' property.
This new value prevents the white-space sequence to collapse and gives
breaking opportunities after every preserved white-space.
https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
end of a line cannot be hung or visually collapsed, since we want them
to be preserved and broken.
[1] https://github.com/w3c/csswg-drafts/pull/2841
Bug: 767634
Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
Reviewed-on: https://chromium-review.googlesource.com/c/1136543
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623324}
--
wpt-commits: 250f9793781f3dcab7f7a3ee9d22cbdf707bdf68
wpt-pr: 13720
Automatic update from web-platform-tests
[css-text] overflow-wrap:break-word does not change the min-content size
--
wpt-commits: 69c2a2b356e180785ce276fd842959193bcb5a3c
wpt-pr: 14667
Automatic update from web-platform-tests
[css-text-3] Rework text-indent tests
These tests used to have anti aliasing artefacts. A previous commit
(cf1491254cca) solved that, at the expense of making the tests
impractical to review manually, and no longer self descriptive.
This change fixes that, while keeping the tests robust to anti aliasing
artefacts.
--
wpt-commits: 01bcaf75435db95e0ba06df42ccbd35aeef33f2f
wpt-pr: 13510
Automatic update from web-platform-tests
[css-text] overflow-wrap and intrinsic sizing
Goes together with the spec changes for https://github.com/w3c/csswg-drafts/issues/2465
--
[css-text] break-spaces has moved from overflow-wrap to white-space
--
Merge pull request #10627 from frivoal/text-2465
[css-text] white-space and intrinsic sizing
--
wpt-commits: b439b5793f217eeb5ec1dd941161f6206ab2938d, ae2ef2d8cf5cab2db0a477411ea7f9cc79f6f737, 67b751ef3b96755111d9f845efd3b21c014d68bc
wpt-pr: 10627
Automatic update from web-platform-tests
[css-text] text-transform must not disturb shaping in arabic
Related to https://github.com/w3c/csswg-drafts/issues/2135
--
Merge pull request #13385 from frivoal/text-2135
[css-text] text-transform must not disturb shaping in arabic
--
wpt-commits: a1e342c18c90f8386adf9e23495814ed6e7f2804, 9b22a2f64e0199794898ae88bf29ae558e2a2f5a
wpt-pr: 13385
Automatic update from web-platform-tests
[css-text] Improve text-transform:full-size-kana tests
Rework the tests from https://github.com/web-platform-tests/wpt/pull/13504,
so that:
* They fit within 600px × 600px (as generally required for reftests)
* They are easier for a human reader to review: being asked whether two
characters are the same when the only difference expected is size is
much easier if you have a reference for the right and wrong size.
Only doing this in tests 001 to 004,
as for the rest there's not (always) a corresponding small character.
* The test that check that nothing happens on already full-size kana
only applies the (ineffective) transform to one character in each pair
as otherwise, it isn't really testing anything
--
Merge pull request #13461 from frivoal/text-3143
[css-text] Test for text-tranform:full-size-kana
--
wpt-commits: cf5dba33625ba1c4491054fa4a0ad3a1243f7a43, a546e84c5c9aa5e1481cfbdeef0d70530c811508
wpt-pr: 13461
Automatic update from web-platform-tests
[css-text] plain-text copy & paste does not preserve text-transform
This is a test for https://github.com/w3c/csswg-drafts/issues/627
--
Merge pull request #13428 from frivoal/text-627
[css-text] plain-text copy & paste does not preserve text-transform
--
wpt-commits: 176d04ddd933ec150424b7f2c923ad6c4519b618, e13446ad8a47fa1643f3afa987d0da950822023b
wpt-pr: 13428
Automatic update from web-platform-tests
Refiling which spec some tests are filed against
The connection to writing-modes is a bit thin, but at least there's a
section on bidi there. css-text was the wrong place to file it, and
bikeshed's wpt facilities would complain if the tests weren't linked to
from any section of the spec.
--
wpt-commits: 748c200dd4b8f2f1b839db70440f27ffed163f80
wpt-pr: 14583
--HG--
rename : testing/web-platform/tests/css/css-text/astral-bidi/adlam-anti-ref.html => testing/web-platform/tests/css/css-writing-modes/astral-bidi/adlam-anti-ref.html
rename : testing/web-platform/tests/css/css-text/astral-bidi/adlam-ref.html => testing/web-platform/tests/css/css-writing-modes/astral-bidi/adlam-ref.html
rename : testing/web-platform/tests/css/css-text/astral-bidi/cypriot-anti-ref.html => testing/web-platform/tests/css/css-writing-modes/astral-bidi/cypriot-anti-ref.html
rename : testing/web-platform/tests/css/css-text/astral-bidi/cypriot-ref.html => testing/web-platform/tests/css/css-writing-modes/astral-bidi/cypriot-ref.html
rename : testing/web-platform/tests/css/css-text/astral-bidi/support/adlam.css => testing/web-platform/tests/css/css-writing-modes/astral-bidi/support/adlam.css
rename : testing/web-platform/tests/css/css-text/astral-bidi/support/cypriot.css => testing/web-platform/tests/css/css-writing-modes/astral-bidi/support/cypriot.css
Automatic update from web-platform-tests
[css-text] Remove "exploratory" comment for test backed up by the spec
The comment about this test being exploratory is wrong.
Assuming that the claim that
“people using indic scripts expect the user agent
to keep the orthographic syllable as a single unit”
is true, the spec definition's of typographic character/letter unit
are sufficient to justify the test.
--
wpt-commits: 691e737caf050c5aac0f9675409d73238a3f55d2
wpt-pr: 14575
Automatic update from web-platform-tests
[css-text] Correct test metadata (#14551)
The section title is out of date and unneeded. Deleting it.
The link is broken. Fixing it.
--
wpt-commits: eb97f99b6065746b50ce41d313908acd06dbe600
wpt-pr: 14551
Automatic update from web-platform-tests
[css-text] Typo in Thai text
Since we're testing dictionary based word-boundary detection, it seems
quite important to avoid spelling mistakes. The Thai word “and” is
spelled “และ” and not “แและ”.
--
wpt-commits: 81f23a9e43fc5ae0a06b59609c88959a7363c66a
wpt-pr: 14556
Automatic update from web-platform-tests
[css-text] Fix test
It used an incorrect flag (ahem), and the description sentence was
ambiguous.
--
wpt-commits: 0065f28dbff10c61e73a9e0a60b81675f9d32e83
wpt-pr: 14555
Automatic update from web-platform-tests
Delete tests that can never fail
These tests claims to test overflow-wrap, but it never overflows, so the
property never gets the chance to do anything.
The description is also confusing, as it asks the reviewer to check
things that cannot be seen visually: whether the black box is one or two
rows cannot be seen, since they are contiguous.
--
wpt-commits: 75f54944ed436a05802a310b101d74732f95cd28
wpt-pr: 14550
Automatic update from web-platform-tests
Remove incorrect tests
Both these tests will render incorrectly if a specific font isn't
available, and they don't install it themselves, making them misleading.
Moreover, word-break-break-all-009's reference is just a copy of the
test, and relies on automatic line breaking instead of manually inserted
<br>s, so it will always pass.
Finally, these tests could be fixed, but they are testing things that
are already covered by other tests, so deleting them is appropriate.
--
wpt-commits: a22f78b49f0f2ab2198bd97be961a777473b68ab
wpt-pr: 14547
Automatic update from web-platform-tests
Remove unneeded tests
These 4 tests are not technically wrong, but they are not automated,
and they don't cover any aspect of the spec that isn't already covered
by other tests.
--
wpt-commits: 1a70ecd97624eb434a602948227cb7c998bde716
wpt-pr: 14546
Automatic update from web-platform-tests
[LayoutNG] Exclude trailing preserved spaces when avoiding floats
This patch fixes an interoperability issue where trailing
preserved spaces should be excluded when avoiding floats.
All 4 implementations are interoperable on this regard.
This patch adds NGLineInfo::HasOverflow(), because knowing
whether the line has overflow or not is easy and fast,
while knowing the exact inline size excluding trailing
preserved spaces may involve reshaping.
Other cases also have interoperability problems, such as
`text-align` or `min-content`. I'll investigate them in
following patches.
Bug: 913995
Change-Id: Ibf13f1fcc28bbd99d44b56611141efa49d6d1c89
Reviewed-on: https://chromium-review.googlesource.com/c/1374329
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616155}
--
wpt-commits: beeeae31ad5419adf95d5dcfca395af7955d768c
wpt-pr: 14481
