Followup on the previous commit, the same pattern occured in the Histograms section.
MozReview-Commit-ID: 41SiI1nBLSm
--HG--
extra : rebase_source : 2e642658c5721cab41f25c4a6c81f38390badef7
The "Keyed Histograms" category didn't alway have the "has-data" class although there were some data to display. "option" was compared to a string but it's a dom element, so its value should be compared instead.
MozReview-Commit-ID: 3eC0UPpJaNJ
--HG--
extra : rebase_source : 84e87676959008c4f884d171788682506ac11804
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm
MozReview-Commit-ID: 1Nc3XDu0wGl
--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
Refactored a call to ChromeHangs.render() I forgot while fixing the "Show raw stack data" link (Bug 1427484).
MozReview-Commit-ID: 3Ul1wCRhdxG
--HG--
extra : rebase_source : a9cb33d4862947eed80832507a4a315a8ae81f99
Put a table heading to each search section in the about:telemetry homepage.
MozReview-Commit-ID: 7DaFjy6lbcq
--HG--
extra : rebase_source : c8a735989fc120560dc65c2f86adea2594f93b66
The "Show raw stack data" button in the Browser Hangs section produced nothing but removing the "Browser Hangs" section from the about:telemetry navigation menu. I looked at the way the Late Writes section works and patched the Chrome Hangs render calls accordingly.
MozReview-Commit-ID: Gq681oVrg90
--HG--
extra : rebase_source : 97ca47cd9d0997f69cff62b9201e514ab57d713d
The search feature in the Late Writes section does not work, and a message claiming "Sorry there's no data available in "Late Writes" hindered the view of the data. I added the late-writes-section to the search blacklist.
MozReview-Commit-ID: 4Fqfh9zhzJZ
--HG--
extra : rebase_source : 35428e159c025b029dd2c7716d679ee1825d5b95
The search feature in the Browser Hangs section does not work, and a message claiming "Sorry there's no data available in "Browser Hangs" hindered the view of the data. I added the chrome-hangs-section to the search blacklist.
MozReview-Commit-ID: JJ4eb1fSOfg
--HG--
extra : rebase_source : 671fa5553516ce4b82ae2893e041839c1af27ae9
In RTL locales, the about:telemetry page opened a JSON viewer window because hgram.buckets.reverse()
was being called in RTL mode. Since a refactor tracked in bug 1122480, histograms no longer have a 'buckets' field.
Removing the call to hgram.buckets fixed this bug.
Currently if a subsection (for the environment section) is included in the hash
on load the page breaks, because urlStateRestore ends up calling showSubSection
with no element, which then throws. Move the urlStateRestore call after the
update.
Also guard against showSubSection receiving an empty argument.
MozReview-Commit-ID: 2bYrEQlHlqN
--HG--
extra : rebase_source : 478a4436f842cb9dc6979c0604b18289bbc5ea71
Implementation of the search terms in the url fragment was done as concisely as possible(considering the various conditions required, with the underscore when other hash terms are present). To implement search through hashes in URL, the function urlStateRestore() was changed. To make the changes more aesthetic, another function urlSectionRestore() performs the tasks earlier performed by urlStateRestore(), and urlStateRestore() now implements the search parsing and a call to urlSectionRestore().
MozReview-Commit-ID: 9vgjNUpJkQG
--HG--
extra : rebase_source : c2cdb79e74faffa50bfd6636f0877f541f4f6ddf
We were reusing "all sections" in more than one way, which isn't a globally-
permissable language use. Embedding the substring directly takes care of it
while at the same time embedding it within its context.
MozReview-Commit-ID: CTQhFWEajRo
--HG--
extra : rebase_source : 03b79c5bb19ad690b4ccba27c96bcc6a9f7f17a7
We were reusing "all sections" in more than one way, which isn't a globally-
permissable language use. Embedding the substring directly takes care of it
while at the same time embedding it within its context.
MozReview-Commit-ID: CTQhFWEajRo
--HG--
extra : rebase_source : 4a4e25137086f112eeae8152b4867553e372ce03
Search would leave text in the input field when switching categories,
show a 'No search results' message on load, and show a 'No search results'
message in sections without search inputs.
Tidy those cases away.
MozReview-Commit-ID: BbkgIjq8fYD
--HG--
extra : rebase_source : 0ce7a88f05a8919275e46f8d1c44df33fd83b135
Search would leave text in the input field when switching categories,
show a 'No search results' message on load, and show a 'No search results'
message in sections without search inputs.
Tidy those cases away.
MozReview-Commit-ID: BbkgIjq8fYD
--HG--
extra : rebase_source : 3d1b02d6c29096c42cdcce795689214b44b8cf00
Acceptably-structured pings should render fine in about:telemetry and not
trigger the panic mode of "Just show them the JSON!" that happens when an
exception is thrown.
Two things caught here:
1: Environment section without addon subsection
2: subsection searches
MozReview-Commit-ID: 3Z0hud23XuD
--HG--
extra : rebase_source : 1ac8e8f0cc0c9fa77c9ad2adcd89e3ed31fc124c
Make about:telemetry start page a useful entry point into Telemetry
MozReview-Commit-ID: JIgU3acT1fS
--HG--
extra : rebase_source : 1a9e66fbb31db04b5b131bc7983f546ee5b4fd19
Allow to search for the section's name and fix useless margin in search.
MozReview-Commit-ID: HwCXq0tUct5
--HG--
extra : rebase_source : 09b0bf51bcc2aca875539834f2893d78bd51e564
Also keep the search state when changing ping.
MozReview-Commit-ID: 9M2hz7ttl8e
--HG--
extra : rebase_source : b1807a91390e248b696543f1541520bc23f9a392
Fix the placeholder text for the search on the home.
MozReview-Commit-ID: 9YSrB3FdFCL
--HG--
extra : rebase_source : 34a04957521ee9d6445801ee1e76d88300ab1347
Fix ping selector popup is sometimes hard to dismiss.
MozReview-Commit-ID: KEFcmq6cvRA
--HG--
extra : rebase_source : e2a6b13bd7f355aa88e47c50347d03aee5f0fa57
Clicking on a subsection then clicking on a section now change the
title.
MozReview-Commit-ID: AmdO0DTRstr
--HG--
extra : rebase_source : f0d2b53643add4612de9233142e9144d583f70c6
Add a triangle next to the ping selection button that emphasize the
to the current ping selection popup state.
MozReview-Commit-ID: GOzv01S0i9h
--HG--
rename : browser/themes/shared/icons/arrow-dropdown-12.svg => toolkit/themes/shared/icons/arrow-dropdown-12.svg
rename : browser/themes/shared/icons/arrow-dropdown-16.svg => toolkit/themes/shared/icons/arrow-dropdown-16.svg
extra : rebase_source : 738649d1ab12e7e65df2530864bd833545b57fe5
When switching to a ping that hasn't data for the current section go to
home section.
MozReview-Commit-ID: 2zTZUiyHe0M
--HG--
extra : rebase_source : 2abe235c99cf2b0b6579c9fbac940b5bc8a0a532
Prepare the code for the search on the home page. This will allow to
display only the div with the "data" class and not have cluttered
results.
MozReview-Commit-ID: 5CtMPrLGJT7
--HG--
extra : rebase_source : a00acb809df8eb6e52eec69417a4bfd2face8fb6
Show all subsection after comming back from another section.
MozReview-Commit-ID: I02cR2IaBrm
--HG--
extra : rebase_source : 37ec844a62e862aa918e5e8d2d8687337cacf816
Add a triangle next to the ping selection button that emphasize the
to the current ping selection popup state.
MozReview-Commit-ID: GOzv01S0i9h
--HG--
rename : browser/themes/shared/icons/arrow-dropdown-12.svg => toolkit/themes/shared/icons/arrow-dropdown-12.svg
rename : browser/themes/shared/icons/arrow-dropdown-16.svg => toolkit/themes/shared/icons/arrow-dropdown-16.svg
extra : rebase_source : d94fe7aa872cd6912263179cac1004b335c0973a
Add a raw payload section when looking at a non main ping.
MozReview-Commit-ID: 2dU8apRfzLP
--HG--
extra : rebase_source : 473ef7167c98a93a121d003d1c3a3e0404621cb6
Allow to open the full ping data in the firefox json viewer.
MozReview-Commit-ID: C8rqxmY3qtT
--HG--
extra : rebase_source : 8cf91dfd51961c196facda5405a4c4884baaa529
Show the ping selector popup next to its toggle button in
about:telemetry.
Underline the fact that no archived pings are available.
MozReview-Commit-ID: CwSLOvuhXFn
--HG--
extra : rebase_source : 200b81af3abfea98beffa2c8c0460027a9c58f73
Fixes that about:telemetry only shows events if there are any present in processes.parent.
For some reason switching the processes in the events section also triggers HistogramSection.render(), which breaks when there are no histograms recorded in the selected process.
This patch fixes it to make things work.
--HG--
extra : rebase_source : e7a4cd1d823571a060a4d6293800b0900a68ddd4
Fix "has-data" for all section that uses the process select.
Display no histograms when the current process hasn't any data and not
the parent ones.
MozReview-Commit-ID: 4tY1C2aNR6J
--HG--
extra : rebase_source : cc45b01084f0e2f53f9a313c2f67ef3bc167e825
Also :
* fix the blacklist of section of the search
* Cleanup the html code so that it takes less lines
MozReview-Commit-ID: DITHGIqj6LE
--HG--
extra : rebase_source : 87f76d9b027f263970a0e5cb6f687290d5cbf004
Use window.location.hash to save the current section displayed
Filter the elements displayed after reload or a section change
Also save the state when switching between process
MozReview-Commit-ID: GYQEtS0As0k
--HG--
extra : rebase_source : f3bce2bb41dc92da2ef3cfef42d68beac12650a1
Remove the code related to expanding sections since it's not relevant
anymore.
MozReview-Commit-ID: 3Uav9S2Kj2U
--HG--
extra : rebase_source : b39971a675d3e04b0ccc8c1623f71cb8f1f465d7
We don't need the statebox that were designed for the old
about:telemetry anymore.
MozReview-Commit-ID: LL6nzjKalE1
--HG--
extra : rebase_source : 5a78bf293d8986cc8c8ecfd6adae263fe0c6a1f1
Provide a translation of "current".
Prevent issue with the order of the word by adding another string when
we display the current ping.
MozReview-Commit-ID: AOHXGrlm2Dt
--HG--
extra : rebase_source : a2a6822b9fb562670ffdf00bbf20659123cff622
Remove the quote form the js file and add it to the string file.
MozReview-Commit-ID: JGgywPJ755J
--HG--
extra : rebase_source : df683a5be4be6d3f0d0494960bbc28cdd6620060
Add its own strings to the value of extendedTelemetryEnabled so that it
is independent of of telemetryEnabled.
MozReview-Commit-ID: 8p35LuWbiDw
--HG--
extra : rebase_source : 13b2df492cb4490c59da25cf7c8698e79aefcd91
Divide the current height by two to improve the readability.
Change the colors so that they match the firefox color palette.
Also prevent the label of histogram's bar to overlap.
MozReview-Commit-ID: 5FLgFXk94ng
--HG--
extra : rebase_source : e090b4c5ae787b51c2b1b054e6f7b99d00bc2311
Divide the current height by two to improve the readability.
Change the colors so that they match the firefox color palette.
Also prevent the label of histogram's bar to overlap.
MozReview-Commit-ID: 5FLgFXk94ng
--HG--
extra : rebase_source : 59374f2bd4a6c95744409c6278f7e5efcb50ea02
Introducing a destructuring assignement in the Bug 1378759 caused the
search throw an exception. The code was tested only in certain
circumstances where the bug wasn't triggered.
MozReview-Commit-ID: EWkKJhxMIuy
--HG--
extra : rebase_source : 6b892d1362e4c5956a0f888d93611a89c64d4e0c
Display the entire ping instead of just the payload
MozReview-Commit-ID: JnNk2AjvTvC
--HG--
extra : rebase_source : f5f5eb329f4eafb5762fa12fa9a1724d9a730790
Also better integrate the process selector to the new design.
MozReview-Commit-ID: 8YV6dYPFZvA
--HG--
extra : rebase_source : 4a25bda87a9b2ad5f4fc7054070b1f7f101a47bd
Use a select with 3 optgroup (Today, Yesterday, Older) to sort ping.
MozReview-Commit-ID: 4Imw0cI3zxk
--HG--
extra : rebase_source : b4a877cf757491283d7f5f5dbe1202a6ab4f96b0
Allow to display subsection in the sidebar. The user can now select only
one subsection to be displayed.
Also remove unused strings.
MozReview-Commit-ID: HGFyssfZhfE
--HG--
extra : rebase_source : 53dd23d0af51eb8b4dc9b6c07ae4b778a4472b33
Allow about:telemetry design to be consistent with others about:* pages.
MozReview-Commit-ID: FG7tAmWcg9
--HG--
extra : rebase_source : 75aa02a9960f8d0153f20b075eabfbc12d01fc49
