Commit graph

4939 commits

Author SHA1 Message Date
Tim Nguyen
059c4f1854 Bug 1583696 - Remove XUL grid from toolkit/components/prompts/content/tabprompts.jsm. r=MattN,marionette-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D61442
2020-04-23 09:48:17 +00:00
Andreea Pavel
b9c773a74f Backed out changeset 2f06fd7ef8b6 (bug 1583696) for failing test_bug619644.html on a CLOSED TREE 2020-04-23 05:16:18 +03:00
Tim Nguyen
09f305d392 Bug 1583696 - Remove XUL grid from toolkit/components/prompts/content/tabprompts.jsm. r=MattN,marionette-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D61442
2020-04-22 23:46:35 +00:00
Dão Gottwald
cc338e2e6d Bug 1631696 - Disable the stop/reload animation during startup, restoring pre-bug 1629953 behavior. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D71952
2020-04-22 18:32:45 +00:00
Gijs Kruitbosch
b14bbb1d75 Bug 1627685 - do not wipe out widths if the search bar only overflows temporarily, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D71343
2020-04-22 09:18:49 +00:00
Gijs Kruitbosch
1c0a1c9f3e Bug 1631358 - remove traces of CPOWs from browser/, testing/ and toolkit/, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D71510
2020-04-21 14:05:35 +00:00
Marco Bonardo
45a8a38b0b Bug 1080682 - Use the Public Suffix List to distinguish foo.bar searches in URIFixup (and consequently the Address Bar). r=Gijs,dao
Use the PSL list to evaluate whether user typed strings in urlbar are valid URLs.
Cleanup the URIFixupInfo.fixupChangedProtocol property to be set appropriately.
Auto-correct the most common suffix typos for com, net, org.

Stop using URIFixup to trim urls when the urlbar value is set, instead always trim,
then untrim on focus if the trimmed string would cause, on navigation, a search
instead of a visit. This saves us from doing the URIfixup work on page load and
tab switch, running it only when strictly necessary.

Fix the "Did you mean to go to" prompt to show a protocol, avoiding the
confusing (but funny) "did you mean to go to 'space'" prompts.

Differential Revision: https://phabricator.services.mozilla.com/D68796
2020-04-20 12:39:08 +00:00
Neil Deakin
c7e68f61b7 Bug 1614750, convert translation bar to use JSWindowActor, r=florian
Differential Revision: https://phabricator.services.mozilla.com/D67535
2020-04-18 12:15:10 +00:00
pbz
3623dafadb Bug 1615588 - TabModalPrompt(Box): Added tab level system prompts. r=MattN
This patch updates the prompt code in browser.js and the tabprompts.jsm module
to support the two new prompt types: tab and content
- Updated TabModalPromptBox to support both prompt types
- Updated TabModalPrompt styles for tab prompt type

Differential Revision: https://phabricator.services.mozilla.com/D67134
2020-04-16 14:44:02 +00:00
Marco Bonardo
fb0662edda Bug 1628906 - First search in a tab from location bar could trigger an "Invalid URL" error page. r=Gijs,nika,mattwoodrow
Before 1496578, URIFixup::keywordToURI used to do a synchronous IPC call to be
able to access search engines from the content process. Consumers of URIFixup
didn't care. Bug 1496578 moved the IPC messaging to the callers, in particular
nsDocShell, but assumed nsDocShellLoadState wasn't loading from content.
It looks like in some cases it does, so this adds another sync IPC call for
GetFixupURIInfo.
The total numer of sync IPCs should not change from before Bug 1496578, URIFIxup
was just doing it internally, while now it happens at the call point.
Note the long term plan would be for these docshell objects callers to just
handle URIs, while the UI code should do fixup.
Bug 1375244 tracks the removal of these sync IPC messages.

Differential Revision: https://phabricator.services.mozilla.com/D70607

--HG--
extra : moz-landing-system : lando
2020-04-15 22:39:38 +00:00
Christoph Kerschbaumer
7e43ad336f Bug 1621987: Implement Sec-Fetch-User. r=baku,edgar,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69392

--HG--
extra : moz-landing-system : lando
2020-04-16 08:04:26 +00:00
Dão Gottwald
483b6d0917 Bug 1629953 - Use prefers-reduced-motion media query for the stop/reload button animation. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D70899

--HG--
extra : moz-landing-system : lando
2020-04-15 08:48:08 +00:00
Mihai Alexandru Michis
72126bcffd Backed out changeset c522095c6db2 (bug 1629953) for causing failures in browser_aboutStopReload.js
CLOSED TREE
2020-04-15 01:57:31 +03:00
Dão Gottwald
ec2c37d516 Bug 1629953 - Use prefers-reduced-motion media query for the stop/reload button animation. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D70899

--HG--
extra : moz-landing-system : lando
2020-04-14 17:33:13 +00:00
Dão Gottwald
f49f6b2f27 Bug 1628731 - Reinstate shouldRemoveFocusedAttribute hack. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D70852

--HG--
extra : moz-landing-system : lando
2020-04-14 16:18:01 +00:00
Csoregi Natalia
954b969608 Backed out 5 changesets (bug 1615588) for browser-chrome failures e.g. browser_beforeunload_duplicate_dialogs.js. CLOSED TREE
Backed out changeset 751cca7566a8 (bug 1615588)
Backed out changeset 474aca043834 (bug 1615588)
Backed out changeset 7839b95ef76c (bug 1615588)
Backed out changeset 32bb87f48b13 (bug 1615588)
Backed out changeset 264e642042b1 (bug 1615588)

--HG--
extra : rebase_source : 41ed149c97382bc1cf823abc56811b382cae0207
2020-04-10 21:19:15 +03:00
pbz
5ef7a7ac78 Bug 1615588 - TabModalPrompt(Box): Added tab level system prompts. r=MattN
This patch updates the prompt code in browser.js and the tabprompts.jsm module
to support the two new prompt types: tab and content
- Updated TabModalPromptBox to support both prompt types
- Updated TabModalPrompt styles for tab prompt type

Differential Revision: https://phabricator.services.mozilla.com/D67134

--HG--
extra : moz-landing-system : lando
2020-04-10 16:44:57 +00:00
William Durand
b90b5b3778 Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69831

--HG--
extra : moz-landing-system : lando
2020-04-08 14:18:53 +00:00
Dão Gottwald
3b8b1171af Bug 1627969 - Remove the megabar pref. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D70023

--HG--
extra : moz-landing-system : lando
2020-04-08 19:04:24 +00:00
Nika Layzell
f036c4e342 Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:47 +00:00
Nika Layzell
b99cf8f798 Bug 1616353 - Part 7.4: Pass nsOpenWindowInfo through tabbrowser, r=Gijs
The interface changes which browser.js and tabbrowser.js are being updated for
are performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67053

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:37 +00:00
Nika Layzell
98528edbf2 Bug 1616353 - Part 6.2: Remove setOriginAttributesBeforeLoading API, r=smaug
This API is no longer possible to implement, as it will always try to set the
OriginAttributes on a content BrowsingContext after it has been attached, and JS
can never observe a detached BrowsingContext.

Users of this API are instead changed to perform assertions that
originAttributes have already been set correctly.

Differential Revision: https://phabricator.services.mozilla.com/D67046

--HG--
extra : moz-landing-system : lando
2020-04-07 21:39:14 +00:00
Cosmin Sabou
aefb5f9c88 Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp.
Backed out changeset 3a43210e4900 (bug 1616353)
Backed out changeset cb77e9149cf8 (bug 1616353)
Backed out changeset 3aacc7cfe33f (bug 1616353)
Backed out changeset c026b06063a5 (bug 1616353)
Backed out changeset 580e790c5d17 (bug 1616353)
Backed out changeset 6f09bc1c476d (bug 1616353)
Backed out changeset 6955906262c0 (bug 1616353)
Backed out changeset a7700472807a (bug 1616353)
Backed out changeset a4735096e01b (bug 1616353)
Backed out changeset bd1706c57d91 (bug 1616353)
Backed out changeset 363c13296fda (bug 1616353)
Backed out changeset e414df387524 (bug 1616353)
Backed out changeset 765d3364cca0 (bug 1616353)
Backed out changeset 8a13355b4ac4 (bug 1616353)
Backed out changeset ada17fb8fca7 (bug 1616353)
Backed out changeset 6b6b99af186d (bug 1616353)
Backed out changeset ea966e78b296 (bug 1616353)
Backed out changeset cb88e0bbb3b9 (bug 1616353)
Backed out changeset f89a89015114 (bug 1616353)
Backed out changeset ae6058552969 (bug 1616353)
Backed out changeset f42bb5b48c1b (bug 1616353)
Backed out changeset 1ab9d22c73bb (bug 1616353)
Backed out changeset 2692c2c1396b (bug 1616353)
Backed out changeset 11a279c8da08 (bug 1616353)
2020-04-06 20:03:02 +03:00
Nika Layzell
60b5a34a33 Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058

--HG--
extra : moz-landing-system : lando
2020-04-06 14:30:22 +00:00
Nika Layzell
7be2efaa78 Bug 1616353 - Part 7.4: Pass nsOpenWindowInfo through tabbrowser, r=Gijs
The interface changes which browser.js and tabbrowser.js are being updated for
are performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67053

--HG--
extra : moz-landing-system : lando
2020-04-06 14:30:07 +00:00
Nika Layzell
f0e314fa2a Bug 1616353 - Part 6.2: Remove setOriginAttributesBeforeLoading API, r=smaug
This API is no longer possible to implement, as it will always try to set the
OriginAttributes on a content BrowsingContext after it has been attached, and JS
can never observe a detached BrowsingContext.

Users of this API are instead changed to perform assertions that
originAttributes have already been set correctly.

Differential Revision: https://phabricator.services.mozilla.com/D67046

--HG--
extra : moz-landing-system : lando
2020-04-06 14:29:50 +00:00
Mark Banner
bb413bca06 Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D69235

--HG--
extra : moz-landing-system : lando
2020-04-03 11:36:35 +00:00
Dorel Luca
af82b27122 Backed out 2 changesets (bug 1590803) for browser-chrome failures in browser/browser_placeholder.js. CLOSED TREE
Backed out changeset 6256694a9047 (bug 1590803)
Backed out changeset efd1d1868d70 (bug 1590803)

--HG--
extra : histedit_source : 0dfcd9580b8b8a2274402ba9f32f43a07b7854dd
2020-04-02 18:39:32 +03:00
Mark Banner
b85978d734 Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey
Depends on D69233

Differential Revision: https://phabricator.services.mozilla.com/D69235

--HG--
extra : moz-landing-system : lando
2020-04-02 14:31:45 +00:00
Zibi Braniecki
44bbaba5c4 Bug 1602808 - Revert Window Title to use DTD. r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68661

--HG--
extra : moz-landing-system : lando
2020-04-01 18:44:03 +00:00
Dão Gottwald
9569fc3fef Bug 1626265 - Don't hide the status panel while a link's context menu is open. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69182

--HG--
extra : moz-landing-system : lando
2020-04-01 11:06:31 +00:00
Narcis Beleuzu
7fba7adfcd Backed out changeset 16d82f57e0fb (bug 1602808) for bc failures on browser_privatebrowsing_windowtitle.js . CLOSED TREE 2020-04-01 10:24:08 +03:00
Zibi Braniecki
329298b6fc Bug 1602808 - Revert Window Title to use DTD. r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68661

--HG--
extra : moz-landing-system : lando
2020-03-31 23:52:03 +00:00
Gijs Kruitbosch
ab9fa951ca Bug 1616639 - revert url bar and search bar width when removing the search bar from the navbar, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D64140

--HG--
extra : moz-landing-system : lando
2020-03-31 17:25:50 +00:00
Harry Twyford
70b99b17f1 Bug 1623978 - Disable Search Tips on secondary location changes. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D68067

--HG--
extra : moz-landing-system : lando
2020-03-31 13:56:34 +00:00
prathiksha
75c7060274 Bug 1303775 - Fix race conditions prevalent with closing captive portal tabs that re-direct to the canonicalURL after successful login/abort. r=johannh,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D65554

--HG--
extra : moz-landing-system : lando
2020-03-26 19:04:59 +00:00
Stefan Hindli
bcca559238 Backed out changeset 6b86d0dfff95 (bug 1303775) for causing perma bc failures in browser/base/content/test/captivePortal/browser_CaptivePortalWatcher.js CLOSED TREE 2020-03-26 15:52:02 +02:00
prathiksha
743ccb63ac Bug 1303775 - Fix race conditions prevalent with closing captive portal tabs that re-direct to the canonicalURL after successful login/abort. r=johannh,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D65554

--HG--
extra : moz-landing-system : lando
2020-03-26 12:43:11 +00:00
Dão Gottwald
80fb089287 Bug 1623673 - Make gKeywordURIFixup a good browser.js citizen. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D67508

--HG--
extra : moz-landing-system : lando
2020-03-20 07:45:26 +00:00
Andrea Marchesini
1e01916653 Bug 1531289 - target=_blank with a download should close the download tab, r=nika,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D66454

--HG--
extra : moz-landing-system : lando
2020-03-19 13:03:14 +00:00
meenohara
812500d8dc Bug 1567827 Get rid of security.insecure_password.ui.enabled r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D67178

--HG--
extra : moz-landing-system : lando
2020-03-19 11:28:36 +00:00
Masatoshi Kimura
3df19bc1d4 Bug 1623222 - Remove the charset parameter from nsITextToSubURI::UnEscapeURIForUI. r=hsivonen
Only 3 callers are using a non-UTF-8 charset as the first parameter.
* MediaDocument.cpp: This does not make sense because the "filename" part of
  URLs will always be encoded with UTF-8.
* nsContextMenu.js: This is wrong because "mailto:" URLs don't care about the
  document charset.
* Finder.jsm: This caused bug 1623222.

Differential Revision: https://phabricator.services.mozilla.com/D67386

--HG--
extra : moz-landing-system : lando
2020-03-19 10:45:28 +00:00
Sam Foster
08d2b6aa6d Bug 1618696 - Prevent overlapping show/hide of the ConfirmationHint. r=MattN
* Track and clear a timerID for the ConfirmationHint to avoid callbacks from one show() call interfering with a subsequent call.
* Tighten up waiting for and verifying the confirmation hint in browser_doorhanger_generated_password.js
* Pass in the correct browser when retrieving the anchorNode for the confirmation hint.

Differential Revision: https://phabricator.services.mozilla.com/D67398

--HG--
extra : moz-landing-system : lando
2020-03-18 23:05:57 +00:00
Sydney
01e6267b90 Bug 1587496 - Update nsIBrowserHandler users in browser.js to use new BrowserHandler lazy getter. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D67027

--HG--
extra : moz-landing-system : lando
2020-03-18 19:31:54 +00:00
Coroiu Cristina
0c837bbcd0 Backed out changeset 0453b0a0c49d (bug 1531289) for browser-chrome failures at uriloader/exthandler/tests/mochitest/browser_auto_close_window.js on a CLOSED TREE 2020-03-18 15:55:43 +02:00
Andrea Marchesini
c486efbb58 Bug 1531289 - target=_blank with a download should close the download tab, r=nika,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D66454

--HG--
extra : moz-landing-system : lando
2020-03-18 12:08:24 +00:00
Dão Gottwald
976a235654 Bug 1610479 - Remove UrlbarInput's dependency on focusAndSelectUrlBar. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D66954

--HG--
extra : moz-landing-system : lando
2020-03-16 15:53:32 +00:00
Marco Bonardo
2dc20c6432 Bug 1621328 - Move CreateExposableURI into nsIOService. r=Gijs,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D66269

--HG--
extra : moz-landing-system : lando
2020-03-13 12:44:36 +00:00
Ed Lee
acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
Dão Gottwald
7ba24289ce Bug 1539838 - Move SetPageProxyState into UrlbarInput. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D66288

--HG--
extra : moz-landing-system : lando
2020-03-12 18:15:58 +00:00