Commit graph

325 commits

Author SHA1 Message Date
Sammy Khamis
d4fd43d015 Bug 1900131: Fix FxA toolbar telemetry bug r=markh
Differential Revision: https://phabricator.services.mozilla.com/D212332
2024-06-06 19:49:05 +00:00
Mark Hammond
d2a5247348 Bug 1895521 - fix fxa telemetry in the main browser UI. r=skhamis
browser-sync.js has got a bit disorganized over time. This patch tries to consolidate
all checks for which part of the UI is being interacted with and ensures both client
and server telemetry agree on the interaction, and as a part of this, ensures that
interactions with the fxa-toolbar item and the app menu are reported correctly.

Differential Revision: https://phabricator.services.mozilla.com/D209696
2024-05-23 19:54:46 +00:00
Aron Cseh
550fec1f60 Backed out changeset 4db006d78935 (bug 1895521) for causing mochitest failures on browser_synced_tabs_menu.js CLOSED TREE 2024-05-21 23:25:04 +03:00
Mark Hammond
39334eb179 Bug 1895521 - fix fxa telemetry in the main browser UI. r=skhamis
browser-sync.js has got a bit disorganized over time. This patch tries to consolidate
all checks for which part of the UI is being interacted with and ensures both client
and server telemetry agree on the interaction, and as a part of this, ensures that
interactions with the fxa-toolbar item and the app menu are reported correctly.

Differential Revision: https://phabricator.services.mozilla.com/D209696
2024-05-21 19:20:40 +00:00
Tarik Eshaq
612f797c4f Bug 1887739: Removes force_auth fxa path and uses connect path instead.r=markh,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D208783
2024-05-17 18:00:06 +00:00
Leeya
ff029afb05 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-08 14:33:17 +00:00
Stanca Serban
15a89ebab2 Backed out changeset ede7a0b15af0 (bug 1742889) for causing node tests failures. CLOSED TREE 2024-05-03 23:12:24 +03:00
Leeya
88daa6a600 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-03 19:05:59 +00:00
Mark Hammond
47869da1f5 Bug 1893657 - Inactive tabs from other devices show in a panel subview. r=skhamis,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D208750
2024-05-02 19:08:20 +00:00
Sammy Khamis
126216a59b Bug 1885645: Update FxA sign in menu r=markh,teshaq,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D208249
2024-05-02 14:22:16 +00:00
dschomburg
e63de59f5c Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Gijs Kruitbosch
5838e6c66d Bug 1890718 - move send tab event handlers to not use inline event attributes, r=sync-reviewers,lina
This also reorganizes some duplicated handlers a little and fixes an eslint warning for lexical declarations inside case blocks.

Differential Revision: https://phabricator.services.mozilla.com/D207878
2024-04-22 13:07:24 +00:00
Gijs Kruitbosch
889a1d2763 Bug 1890718 - move mouseover sync panel handlers away from inline handlers, r=sync-reviewers,lina
Differential Revision: https://phabricator.services.mozilla.com/D207877
2024-04-22 13:07:23 +00:00
Sammy Khamis
2cc00a036d Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 20:13:16 +00:00
Cristian Tuns
b9af4e8715 Backed out changeset ab9a461da1ee (bug 1885064) for causing xpcshell failures in test_commands_closetab.js CLOSED TREE 2024-04-19 15:45:22 -04:00
Sammy Khamis
2e05624dda Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 18:44:43 +00:00
Gijs Kruitbosch
484fe1f9b4 Bug 1890718 - remove sync/fxa pane inline command listeners, r=sync-reviewers,lina
This also tidies up some variable naming (we were passing 'panel's that were not, in fact, panels)
and removes some methods that we no longer call.

Bug 1690131 removed the last call to 'showRemoteTabsFromFxaMenu', bug 1562006 removed the last
call to 'showSidebarFromFxaMenu', AFAICT.

Differential Revision: https://phabricator.services.mozilla.com/D207452
2024-04-15 23:23:52 +00:00
Dave Townsend
95ccf713ef Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao
Differential Revision: https://phabricator.services.mozilla.com/D202949
2024-03-19 14:59:20 +00:00
Sammy Khamis
d29c2f92eb Bug 1882888: Sync and save data btn should go directly to fxa sign in r=markh
Differential Revision: https://phabricator.services.mozilla.com/D203204
2024-03-01 18:40:22 +00:00
Sammy Khamis
aa561a6d76 Bug 1880556: Add toggles for FxA products r=sync-reviewers,markh
Differential Revision: https://phabricator.services.mozilla.com/D202365
2024-02-22 19:32:34 +00:00
Sammy Khamis
767e490281 Bug 1879610: Update PXI panel link entrypoints r=markh
Differential Revision: https://phabricator.services.mozilla.com/D201272
2024-02-15 19:43:02 +00:00
Sammy Khamis
beec2617d5 Bug 1879211: Move PXI toolbar strings into localization tree r=markh,flod
Differential Revision: https://phabricator.services.mozilla.com/D201025
2024-02-13 18:42:17 +00:00
Sammy Khamis
c6e02198a0 Bug 1878808: Update FxA toolbar button link r=markh
Differential Revision: https://phabricator.services.mozilla.com/D201017
2024-02-08 19:26:52 +00:00
Mark Hammond
3633298f55 Bug 1878310 - remote tabs marked as hidden are hidden in the synced tabs menu by default. r=sclements,skhamis,fluent-reviewers,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200450
2024-02-06 18:53:06 +00:00
Sammy Khamis
271e91a86d Bug 1873766: Fix VPN icon in light mode r=teshaq,desktop-theme-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D198442
2024-01-12 23:32:16 +00:00
Norisz Fay
8383930ba3 Backed out changeset 4bb3bb7ae82a (bug 1873766) for causing bc failures on browser_sync.js CLOSED TREE 2024-01-13 00:21:19 +02:00
Sammy Khamis
1d13a81056 Bug 1873766: Fix VPN icon in light mode r=teshaq,desktop-theme-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D198442
2024-01-12 19:43:01 +00:00
Sammy Khamis
aaff664247 Bug 1867098: FxA PXI Toolbar experiment r=teshaq,desktop-theme-reviewers,flod,dao
Differential Revision: https://phabricator.services.mozilla.com/D194916
2023-12-13 22:08:33 +00:00
Stanca Serban
8bd13999c2 Backed out changeset 2499ef5644ea (bug 1867098) as requested for causing Bug 1869728. 2023-12-13 16:21:31 +02:00
Sammy Khamis
dc6400347b Bug 1867098: FxA PXI Toolbar experiment r=teshaq,desktop-theme-reviewers,flod,dao
Differential Revision: https://phabricator.services.mozilla.com/D194916
2023-12-11 21:53:53 +00:00
Tarik Eshaq
4574d82b32 Bug 1855513: Move in-browser verification to open web content. r=markh,fluent-reviewers,settings-reviewers,Gijs,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D193678
2023-11-22 17:58:18 +00:00
dschomburg
e764a37738 Bug 1853815 - Remove "Firefox account" branding from FxA app menu. r=flod,fluent-reviewers
This replaces the term Firefox account with Account in FxA's app menu.
This replaces the term Firefox account with your account in FxA's sign out pop up.

Differential Revision: https://phabricator.services.mozilla.com/D188615
2023-09-20 06:23:35 +00:00
Itiel
cf26dda371 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Iulian Moraru
1a03d0ff0d Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
d6ff8a9975 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
Mark Hammond
5ff695c8b3 Bug 1710338 - Prefer the FxA displayName over the email address in the app menu. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D180437
2023-06-12 13:10:00 +00:00
Eemeli Aro
849756d484 Bug 1448444 - Drop signInToSync.description string as unused. r=markh,sync-reviewers
This was only used to format the tooltip of the "Sync now" button in the Firefox Accounts app menu pane when the UI's state was such that the whole pane would not be displayed.

Differential Revision: https://phabricator.services.mozilla.com/D178804
2023-05-29 15:24:38 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Iulian Moraru
170aaf5bb7 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
076aaf6671 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-05-18 17:19:45 +00:00
Sammy Khamis
7548571739 Bug 1824216: Always show sync settings if sync is enabled r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176960
2023-05-18 02:26:23 +00:00
Eemeli Aro
4014fa31de Bug 1831851 - Migrate accounts.properties strings used by browser-sync.js to Fluent. r=sync-reviewers,fluent-reviewers,flod,markh
Differential Revision: https://phabricator.services.mozilla.com/D177601
2023-05-11 06:27:41 +00:00
Eemeli Aro
6eb17d551a Bug 1832179 - Convert sendTabsToDevice.label string to Fluent. r=sync-reviewers,fluent-reviewers,flod,markh
The l10n migration shows a diff, as the singular form of the en-US source string is more appropriately categorized as `1` rather than `one` due to its lack of a `{ $tabCount }` reference.

Differential Revision: https://phabricator.services.mozilla.com/D177612
2023-05-10 18:35:53 +00:00
Francesco Lodolo (:flod)
01af1e915d Bug 1826755 - Move Firefox account Fluent term to toolkit, r=fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,mconley,sclements,sgalich,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D175097
2023-04-12 15:51:42 +00:00
Barret Rennie
a85bf46599 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D172850
2023-03-30 20:51:58 +00:00
Mike Conley
0a3f191850 Bug 1818570 - Fix entrypoint for FxA toolbarbutton and include experiment / variation slugs when opening FxA page. r=Mardak,markh
Differential Revision: https://phabricator.services.mozilla.com/D170790
2023-02-24 22:04:03 +00:00
Mark Hammond
42a8237945 Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D170186
2023-02-22 03:58:11 +00:00
Norisz Fay
a7ceb10f1f Backed out changeset d82c03e04249 (bug 1359861) for causing xpcshell failure on test_BrowserUtils.js CLOSED TREE 2023-02-22 00:05:07 +02:00
Mark Hammond
f48ea32bf5 Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D170186
2023-02-21 21:04:10 +00:00
Mark Banner
7a655466af Bug 1817183 - Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D170062
2023-02-17 16:34:43 +00:00