If there is at least one record for expected I/O, but all of them have
`ignoreIfUnused: true`, and no I/O is reported, then the tests should
succeed (they are all unused and thus ignored). There's a check which
expects to see I/O markers in that case, so this patch conditionally
skips it. (Also: fix some pre-existing typos pointed out in review.)
Differential Revision: https://phabricator.services.mozilla.com/D212632
In bug 1804140, we shipped SHIP everywhere on desktop. Unfortunately, we
never removed the now-dead code from SessionStore.
This patch removes the easy to identify SessionStore code for non-SHIP,
now that it is a fully unsupported configuration.
Differential Revision: https://phabricator.services.mozilla.com/D205479
In bug 1804140, we shipped SHIP everywhere on desktop. Unfortunately, we
never removed the now-dead code from SessionStore.
This patch removes the easy to identify SessionStore code for non-SHIP,
now that it is a fully unsupported configuration.
Differential Revision: https://phabricator.services.mozilla.com/D205479
When I rewrote nsMenuPopupFrame, I made sure percentage sizes worked so
that we could do stuff like this.
This removes some complex code, and improves the behavior on platforms
where screen sizes might not be 100% reliable.
Differential Revision: https://phabricator.services.mozilla.com/D204754
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
the component pref gets flipped off during use
Differential Revision: https://phabricator.services.mozilla.com/D196888
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
the component pref gets flipped off during use
Differential Revision: https://phabricator.services.mozilla.com/D196888
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
the component pref gets flipped off during use
Differential Revision: https://phabricator.services.mozilla.com/D196888
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
the component pref gets flipped off during use
Differential Revision: https://phabricator.services.mozilla.com/D196888
This moves handling of the preferences and log value setting into ConsoleInstance, which is where the preferences
are received. It also makes ConsoleInstance add a listener on the preferences service so that updates are triggered.
The functionality is already covered by dom/console/tests/test_jsm.xhtml
Differential Revision: https://phabricator.services.mozilla.com/D199657
If this test fails (`shouldPass` is false at the end), and
`MOZ_UPLOAD_DIR` is unset (typically the case when running locally), the
test raises an exception about using `PathUtils.join` with an empty path.
This is harmless (the test was already failing) but slightly confusing.
Differential Revision: https://phabricator.services.mozilla.com/D199166
See also bug 1840515. Normally a content process will open the omnijar
files during startup, but when the fork server is used, this is done
once in the fork server and then inherited by child processes.
Differential Revision: https://phabricator.services.mozilla.com/D199165
If this test fails (`shouldPass` is false at the end), and
`MOZ_UPLOAD_DIR` is unset (typically the case when running locally), the
test raises an exception about using `PathUtils.join` with an empty path.
This is harmless (the test was already failing) but slightly confusing.
Differential Revision: https://phabricator.services.mozilla.com/D199166
See also bug 1840515. Normally a content process will open the omnijar
files during startup, but when the fork server is used, this is done
once in the fork server and then inherited by child processes.
Differential Revision: https://phabricator.services.mozilla.com/D199165
What's going on is that we get a focus change, but we also get the
expected "reload button flickers" failure in performance_windowopen.js
Due to that expected change, the isLikelyFocusChange logic fails.
Filtering out expected changes before calling filter() is one way to fix
this. An alternative would be to relax isLikelyFocusChange somehow,
which to me seems undesirable...
Differential Revision: https://phabricator.services.mozilla.com/D197274
